RE: [PATCH v2] app/test-crypto-perf: add throughput OOP decryption

[Suanming Mou <suanmingm@nvidia.com>]

Hi Akhil,

As we mentioned the application in another thread, do you know if we can take the patch for now?

BR,
Suanming

> -----Original Message-----
> From: Suanming Mou
> Sent: Monday, April 1, 2024 8:30 AM
> To: Suanming Mou <suanmingm@nvidia.com>; Power, Ciara
> <ciara.power@intel.com>; gakhil@marvell.com
> Cc: dev@dpdk.org
> Subject: RE: [PATCH v2] app/test-crypto-perf: add throughput OOP decryption
> 
> Hi guys,
> 
> Just want to make sure if anything still need to be checked with that patch?
> 
> > -----Original Message-----
> > From: Suanming Mou <suanmingm@nvidia.com>
> > Sent: Wednesday, March 20, 2024 8:15 AM
> > To: Power, Ciara <ciara.power@intel.com>; gakhil@marvell.com
> > Cc: dev@dpdk.org
> > Subject: RE: [PATCH v2] app/test-crypto-perf: add throughput OOP
> > decryption
> > >
> > > Not totally following some of this, why do we only want to add this
> > > for OOP mode?
> > >
> > > For example an inplace command I can use before this patch but not after:
> > > ./build/app/dpdk-test-crypto-perf -l 2,3 -- --ptest throughput
> > > --optype aead -- aead-algo aes-gcm --aead-op decrypt --devtype
> > > crypto_qat --aead-key-sz 16
> > >
> > > I get an error;
> > > USER1: Only out-of-place is allowed in throughput decryption.
> > > USER1: Checking one or more user options failed
> > >
> > > Do we want to always force the user to use OOP + test vector file
> > > for these throughput decryption tests?
> > > Or should we just add a warning that the throughput may not be
> > > reflecting the "success" verify path in PMD if using inplace and the dummy
> data.
> > >
> > > I am not sure.
> > > If we do want to add the limitation on the throughput tests, these
> > > changes I think are ok for that.
> >
> > Yes, think about that, in throughput mode, we will not fill the test
> > data time to time, otherwise the testing is useless.
> > So that means the test data should not be overwritten, otherwise
> > decryption will be with invalid data after the first round of
> > decryption. Since the 1st round decryption overwritten the data to the
> > original buf. In that case, test decryption throughput in non-oop mode is
> meaningless.
> > That's the reason we add that limit to avoid the invalid data issue.
> >
> >