From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 920ED43CFA; Tue, 19 Mar 2024 10:06:06 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 811D940A79; Tue, 19 Mar 2024 10:06:06 +0100 (CET) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2090.outbound.protection.outlook.com [40.107.101.90]) by mails.dpdk.org (Postfix) with ESMTP id 9F78E40298 for ; Tue, 19 Mar 2024 10:06:05 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KGQJO5xbdM+fD78yjWBu8zFaHHzETjUgqUOvGbccgAG5rY7REMrASfcztCQCz9hdT2ErzDZWi55qriPflXy0evdyP0BH2YRvhUciMZSNXXw5EcR+LsHQ0ipqmL9UuMxSoS0GGZb//IPW9SQsAYKiyAsiEMJXCsfqeZVGpTfHaio0I3uIAX39+/RBa9B729XPEtueRXmRs21hOn3m2mLSaVIr1e053NwemkrirHZTSCtIsIZH5uG2Txm5ACerGsTk1J1muVSFpgqMJfyjRBWXBLAn0Ql09gLcEzRmkz0SHJwr7GM95NLhkCvxk2TsctOqasXrLXe62jtzv/95SAtqKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=G06ANIqeLPTHDBmeWTfRTOpZfaEbBDLMP5HPZpLGazw=; b=ZMeM/3o5s9u4IMlsQbzmDFFkJ+1sriPIEfE22tdIflJmZUn6W8ppehkXWm3tSKPHiGQSsGPbgzTe4I8DuceEdcrueAHGofHG2OORVnta+MMZBCO8v2V+QM56OJk5AfHEAwi601OcRmYSv557Yrvmmnf4RI/VRb/UIzGLhiJQVazI+/cT1ZhnKzOMVJBS7WQqev5aoRMMlk+RzCIT6iqnAwRfp8Zz/u7SUOrHaf78ZKRquojWYn0b8muYgR0JpR8CXcAZIlGm8dusSoabQxUw+6JMreG8/ugpmVB244v9efBl/vQERUIiDirk18w/9YiPJk292L0Qng44BZadRtLgzw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G06ANIqeLPTHDBmeWTfRTOpZfaEbBDLMP5HPZpLGazw=; b=b4GEXnrBEGFcmL+YBe+q3OiGSXLEcqQaNajEH0Jfm1riZlpunY6xm1A1nswqyiARwnt7JLZf5hTmVm3gZLLftb8GcKBkVf2enPLPtijI/ts6BXECr8QfhUO6jzPh0SITMbDEH6EXHviqrEk0rIlS8UZBPw4CnaqoV3oWSMtN6HpskRRUM0r0v3A2/Yhu/thrdtskdxOZMLd7kRcdM6CF8atNNbqgEJqpjib78ou35bILZjEqoKpNZfQe8vIYW3ZK8IoUov03qaCnCLLHYgiOiAph4FNNJfr3GacYvmmzW188qmRbXYF9mr9gvAfWLVRC+6oVJsVTtho3g/EQxwpXIg== Received: from CO6PR12MB5396.namprd12.prod.outlook.com (2603:10b6:303:139::8) by LV3PR12MB9331.namprd12.prod.outlook.com (2603:10b6:408:219::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.26; Tue, 19 Mar 2024 09:06:01 +0000 Received: from CO6PR12MB5396.namprd12.prod.outlook.com ([fe80::8911:190e:1f1b:9d96]) by CO6PR12MB5396.namprd12.prod.outlook.com ([fe80::8911:190e:1f1b:9d96%5]) with mapi id 15.20.7386.025; Tue, 19 Mar 2024 09:06:01 +0000 From: Suanming Mou To: Akhil Goyal , Anoob Joseph , "ciara.power@intel.com" CC: "dev@dpdk.org" Subject: RE: [EXT] [PATCH] app/test-crypto-perf: add throughput OOP decryption Thread-Topic: [EXT] [PATCH] app/test-crypto-perf: add throughput OOP decryption Thread-Index: AQHaP741fQ9w9f68TEG7BEM2I7WNn7E3/9sAgAbByvCAAGxGgIAACv5g Date: Tue, 19 Mar 2024 09:06:01 +0000 Message-ID: References: <20240105100104.908543-1-suanmingm@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR12MB5396:EE_|LV3PR12MB9331:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qdJ18uHVHOtG+izGoIp6yh4wNjB0xjguhr0dUFmiqXhPmA3+EVrmuzmziPklnOJvuT407ZhvSLMT5dk8D8LIsjHMOT/TQ46Q31ISrl2R3Ui8nX2xOi/YNs3DQNSVD807MSFM+hCMguWM0oYvRkmTH2rKc+HwS2Kn/DRg4yMfcY/ILXA5mePajDE52WX1Jz73+2GDjCCJIQqlBs5oSRdRG+cBSN2cxPuD/bkgSSXSIRm8ghdTlLSe7w6GuGQN7X37w0w/9hN/EJy/PnADyWcswCJjnKEY5frAoGTdUObh7BMD8i/pOEIGChxMQ53ccuDW47jAceSZC+VLfEKmORpxC5Y6p0D+L3fON/ulgsDpPKnYRLzoFYj3eyA4anwToQh9QQrjUCd3vp/5FUScwRhQte1A3tX4ElorvGZ2vK7/Grsit++Or0BeE0g1ny0PWJzngQJhKg0XTYwAr58w8WhYHuiv5E5idwcQWr+NNCARFZTMVmwxo4zmttN7IwgGSVlfUQZtL9P3mJnB1XUFi8ZYj3agMoIWOBaFMzX5YCOGn31tJSQPCaJwAZtKQWLSXa/XJ3joDms+0ztRw6uW37Z2xHnGfpgiAcF+pWwS28QFObSNrVDJPrSdi+Gd78qknzvW2erlzug6Awc9cJdOuI5DdPOSe5KxYVvVdEuHC75RIPk= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR12MB5396.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366007)(376005)(1800799015); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?URdFLcKAVOJXP7r6F6lovqaLalxr35wAcbg1VlGMTxE3/KO/MX89FbI8XUgq?= =?us-ascii?Q?EMVD2TgyLWqMke5ij3zJRzp4ejxUFrVOsP4MaBOdtsKUm1K2A5fbnjx0MGLe?= =?us-ascii?Q?j7DOf1ue+MsFFGgGE7bvYzBTff6tdoN7QnKZjtuLS9betKeu4YX22bX+wFE7?= =?us-ascii?Q?QhsoMo3uJxePg3dkAF9P8SYqRBp9OeqeFdLRotWueyy48R2dXYd1Cp1S5Auj?= =?us-ascii?Q?jvP7qIPSvhGcXd0sMkK/vyzaw7yxfqOvcydCrRrvfNZRbcVBkgvGBbuOyo8o?= =?us-ascii?Q?28gZwezqLdhxjDYe1KmwH7tNwKS9oXpWeJ7r05P+/JV24Vbm5EYDVT1yty/j?= =?us-ascii?Q?NFbhfxvrshEEaziZJYbKGeStLi3g4VcJPizw7UM8FEmp+YPxnVKriYxDLf6o?= =?us-ascii?Q?oJckk2x64z+3gyGgvtAwx7YX6zRxGjJafjltzNJmQrK3xUhY4tzCUN+yfx7c?= =?us-ascii?Q?CigrZEzehZX+OtcJk7xJfAW0TUQHWEXtMBIu4syVukiQYiSnnPvqea8Jwj0B?= =?us-ascii?Q?7sdN2Aac5PmTt7gyN5LgKIlSNt9MThH1N3ZX74IoGsWOw5sBRha1tpDagGLV?= =?us-ascii?Q?o+o1fCJZsJ1bHVVhIOIenwz1uUQmKJL9rRgj/B4GsBPsKmdQyB3acnIBlqDf?= =?us-ascii?Q?P5uUlNMRu96E+5IusrjGe3VLj0BgBdtK773JqGYUXtteQTnIf4K3VQifO3rg?= =?us-ascii?Q?yHzg5XbdjyO9Ni2UViTNkdkpP9PopZxEdzlCi0aGVDA6KGq3bDWn6OHTKIsq?= =?us-ascii?Q?T+OqBaYFsz49llyT2cyYvapXbk2zd+iF5Y4+lNgjg7iMsfuxZlvQSmq0Fx+W?= =?us-ascii?Q?6aJG9HFJ2IlYyH3WuR5SPYVF5k831NZX1urbgkPfrGyHK4it3V+RioJJ3VJz?= =?us-ascii?Q?IKxJzArUei3Wnc/s381uDM29uQ/HEeF7cyBYoVaaZ//8hjiiAlpu9TXTPZo5?= =?us-ascii?Q?5TaESU+1B6cDewmc0ycygGmDW2yssU63mi9HTTO3HYzckWh1GELPXbjI+kCM?= =?us-ascii?Q?CX1qMuRmuui5V8xGelVUOK6ZwhSdPCJ9atsZHYymz/ROKC/CFHqxC/ZUCo/Y?= =?us-ascii?Q?Swvu7QP1nyIcPCGujE8U3f9XC2ZPdIh99BEPG1sob216zZwPYuExa0NxdCVu?= =?us-ascii?Q?m2AmR07EbjQjfnIcPLmSJshBQExHJEM6BIhYAY2+xVGThpHiw8bTSC+3v0A8?= =?us-ascii?Q?Fs7XAj3y4o8fyZo6LSNnm7Bi7VnKmoXR0i/aVPU6N4Czgo5F9gWeiQNP/6Vp?= =?us-ascii?Q?/H7Ty/zxNQ7JK58vPFkhqGNnO6aOv69DRRUTVIQxYG5SQP+KuOwYfSaz+2wj?= =?us-ascii?Q?7nGImXbcARUSnF/aK1Xjm5PurRiwBAdIAjFzj0b77gGePiT3rZmCln0+tT0e?= =?us-ascii?Q?sKfpntgYeRbDEcVy9NfWREJbr6p11o+9DgyuuwTf/0OrQDvCGl/GmwhWuVpJ?= =?us-ascii?Q?nYS24W0i4bX+Sfn5C2HKfaR68Yc/klFjqMhL19wtW0FgFnLBFzxiRW3TCNzU?= =?us-ascii?Q?7UZ2KADixyWbktd8Ays73QxgGIV1IN8TZmNz6nEqYuEzrlGUY6aTvcxT7G/m?= =?us-ascii?Q?0X/SVyd1dEMTXW50xMaMXh7y9pmPkzIXDlUXeRA9?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5396.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 47296509-c3bc-4df2-ecc9-08dc47f3cc7d X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Mar 2024 09:06:01.3135 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bMokV91nmMQx0q7oo8PtTVrtw1Lj7AIPSUL5agmwDmbFd7GCyfe0WMANb4ziuHe4MLOvUxunVTlWhLbruEV1wg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR12MB9331 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Akhil Goyal > Sent: Tuesday, March 19, 2024 4:23 PM > To: Suanming Mou ; Anoob Joseph > ; ciara.power@intel.com > Cc: dev@dpdk.org > Subject: RE: [EXT] [PATCH] app/test-crypto-perf: add throughput OOP decry= ption >=20 > > > > + if (options->test =3D=3D CPERF_TEST_TYPE_THROUGHPUT && > > > > + (options->aead_op =3D=3D RTE_CRYPTO_AEAD_OP_DECRYPT || > > > > + options->cipher_op =3D=3D RTE_CRYPTO_CIPHER_OP_DECRYPT) && > > > > + !options->out_of_place) { > > > > + RTE_LOG(ERR, USER1, "Only out-of-place is allowed in > > > > throughput decryption.\n"); > > > > + return -EINVAL; > > > > + } > > > > > > This check is blocking cipher_only decryption which should pass > > > irrespective of inplace/oop and Data correct/incorrect. > > > > Sorry, in that case I will remove "options->cipher_op =3D=3D > > RTE_CRYPTO_CIPHER_OP_DECRYPT" and only kept " options->aead_op =3D=3D > > RTE_CRYPTO_AEAD_OP_DECRYPT ", what do you think? >=20 > I would suggest to check for "auth_op =3D=3D RTE_CRYPTO_AUTH_OP_VERIFY" > Instead of cipher_op. I'm not sure. Since in AEAD OP, auth_op will always be RTE_CRYPTO_AUTH_OP_V= ERIFY, in that case even in place encrypt will be rejected. If the combination here is too complicated, what about just remove that lim= its and let user to decide? If the input is not correct, PMD will reject it= as well. >=20 > Ciara, What do you suggest? You were also seeing some issues in this patc= h.