From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BCA8DA0542; Tue, 5 Jul 2022 18:12:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 950B54021D; Tue, 5 Jul 2022 18:12:14 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 8D4E4400D7 for ; Tue, 5 Jul 2022 18:12:13 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 265APgio018087; Tue, 5 Jul 2022 09:12:10 -0700 Received: from nam02-sn1-obe.outbound.protection.outlook.com (mail-sn1anam02lp2048.outbound.protection.outlook.com [104.47.57.48]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3h2nhnt001-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 05 Jul 2022 09:12:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QRFhQYA790Hg7cPhqZ7qTpKr0ifJYGOciF9BrZ5GqqHA2mp5HCZQ+yM45O4CN7/0uON/71zhlCBZES71OqDGtcrBW508qtG6Kwk+znwWmPnb6M/yKlsZ4kNwUKYW+lHs3EJPL19GNKT7Jy+HuQKm4MNRgdG7A8XrrMA8XZlyfUB0YIhDf9hpx6Lcc9Q1H6SP1+0ov3elAfD1lWHvSsSHoDhPHLEzeeAtnqvtqocGIBKcUNhJD0UceyB+TJDZYvczjwLXE7LTJZuXGuO7i1PaCqQlTFE/b+05kLdTsAmzqH0S6N2wa2vLxZD1CMC4ZHNMY/5T0UF8u0ZeyttAnFh1mQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Xml58FI1IvZgygd0n9mWaoIS1Z3tkDgGIvcAfWGbrYU=; b=KCu6WIkQaIMpWNeytzDOa/LY5BhtzTQ8/70/XJRLS8IuxDwYaKFOPK8LlnzFBH4RRrkdDNmqLk0RHvEzJ+wqCrL79mt0G5SvQZSRguwzn/au0H9upebGrddwT+4QBpHJZm6lL86OC8k+4i5vrK5d1GCSuo4dElTEGnTccqF6c2aqKXWzeOG6T68an+yIiNKrL/rgGGTYcoq07RpkVA+dkbzlFHNSuWmALsch9UN57Y3qzGYYkMfXwQfzDKdrTiXI/o63BZySHVStxvI/ANmQKcvbBygrg1p5Y/OzqwXkYppyEzGdGem1CjT3DY3UPYkOYADSO2mr/AvbBjh1PcCPzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xml58FI1IvZgygd0n9mWaoIS1Z3tkDgGIvcAfWGbrYU=; b=ZXO2X0g3gTqiE/QXM1GTZGkCUBm9AyMmOhDcM/gFxjdvNRLlhYeo+HtSdZJICBx8pIjnHazvcZih0uqRTThuBU7hcatAUCVkPMmIMGMk0NeJjhl2P+rWgrx/FAJ7KTOIvb31TSAnqEDnQmmtRjYeCbmYND1zTC7GVc+usV8cLIc= Received: from CO6PR18MB3844.namprd18.prod.outlook.com (2603:10b6:5:340::7) by SN4PR18MB4885.namprd18.prod.outlook.com (2603:10b6:806:210::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21; Tue, 5 Jul 2022 16:12:00 +0000 Received: from CO6PR18MB3844.namprd18.prod.outlook.com ([fe80::c800:c01f:1cac:d1b3]) by CO6PR18MB3844.namprd18.prod.outlook.com ([fe80::c800:c01f:1cac:d1b3%4]) with mapi id 15.20.5395.021; Tue, 5 Jul 2022 16:11:59 +0000 From: Rahul Bhansali To: Thomas Monjalon CC: "dev@dpdk.org" , David Christensen , Ruifeng Wang , Bruce Richardson , Konstantin Ananyev , Jerin Jacob Kollanukkaran , Akhil Goyal Subject: RE: [EXT] Re: [PATCH v3 1/2] examples/l3fwd: common packet group functionality Thread-Topic: [EXT] Re: [PATCH v3 1/2] examples/l3fwd: common packet group functionality Thread-Index: AQHYhuUCxxBePGbHmkWmIuRKqfUkZK1uXGAAgAGpHkA= Date: Tue, 5 Jul 2022 16:11:59 +0000 Message-ID: References: <20220524095717.3875284-1-rbhansali@marvell.com> <20220623093816.254830-1-rbhansali@marvell.com> <3162621.Bm8zEkEi59@thomas> In-Reply-To: <3162621.Bm8zEkEi59@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c9ac225c-89d0-46e6-2243-08da5ea11728 x-ms-traffictypediagnostic: SN4PR18MB4885:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: LD5bGS0Wkz8+eDXZDTwoDwW3rBf+kMeJo7SD6WoHkBj4k4MO/6b0/W8A6qnD6PcRfbioMOsElkEu2H8u/Dg/NPtrrGnmoZDHZp59KGDnKzx5vQ2P1tFQ2PqEf8s8j0HAAI9caULr3TclGXV3DYhpSkvcSKHlvseYDsGDo2gQOsRWw+ysUiZ+/GGixj2+yFg7fn8CLCPmiH7BFpp7fH1550BSLLBds49dQuHLmpoNJusKtHTUDq0XWpdPe+ronk2SRKsMQ9wIir6Sq6whxfXp7wb/EdtyYsnxQ8dkD7vbYm6DVOlrhC6aaC04JM3UUMJlPYTWz7h4UznEYVNR96dJj76BFbyvajPDN6UNNwhxkMerhB0JgKFX/Dx6qZudi+MhiBX5OdLTZ0nWnS9N3Hxa7chG9SNkLHujC5TM63IfgPOftA6ireV1CYevR7Jg/l+2SzmiDzFlDEvS6RUldkjuXbNT5OCOHHPQMaKGj5C1k1S/aP/aAF+gpfFKyBFOXpYivcRlOP8MqtB8F8nvGOqTYpoATo+VCcWd4kP+1V4SUQmq/FKRAEg7KTfW83qPSmXX69Ty8UfQRIvR0dBritkpCIVhu83L/6ZAvbXuC+3SaWAekZfVT3z2vumsEZpp0C+QJojmTMatfkDeFR2349KSf3How14XNEuN6NhrfSEo572bSaVgj3ANG7O+jr+AXasBXpuwmB0Z0/Dm/qRcZUD0wLIz+nPqDkZ9/zw4N3NamvU5tRztXW/Aj8k6xvSxhlAG64jsW5FZ8TsLftnzHl3NBjiiKqRPVuBlwxlKwYXFp+kRdnDELvdClvVWqPEXyjFd x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB3844.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(366004)(396003)(346002)(39860400002)(376002)(136003)(186003)(6916009)(55016003)(66476007)(66556008)(54906003)(76116006)(64756008)(66446008)(66946007)(4326008)(8676002)(9686003)(53546011)(71200400001)(26005)(83380400001)(6506007)(107886003)(55236004)(7696005)(52536014)(38100700002)(86362001)(2906002)(41300700001)(8936002)(316002)(122000001)(5660300002)(478600001)(33656002)(38070700005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?NTkrAHZhuHt2w1yx6AnHoZjcQ6D0dcmdi2zfKbkvhhFo660MYFm6sPAC7sEw?= =?us-ascii?Q?CW/9IAdZWUqkvNrukqns7L+IqDFdEJFfq5ILZg4BF2xTfAEE/LNnegF44VsD?= =?us-ascii?Q?3sXNds1D1hIWBZZID1Wk4Ed6vsbReg3s0Ci/4SZHLHYa3XM5bdVr2lNzHzlz?= =?us-ascii?Q?fZ5MYudN8SYZ2oMjjUFnRs0vOV9RMBv9ni8OLCF1BvMZ0jUURHtGzxQR+rV1?= =?us-ascii?Q?ZTmRXNh/IXgstluAL6E6PBemloCWKIh1GSp/H77QWvjfYFbrZVsZwlr7ue0n?= =?us-ascii?Q?PsMeBJ3VeaaIQq1FIO4O3Wfoj2TfUNpOw7G0pvvlmrkOEtb89tkVp8j58zYB?= =?us-ascii?Q?tfq60c0mmqKNZrUmmB1oUzyClMHlx66lkYlrXYlNV7mZUsnS8JE2V3hJczCC?= =?us-ascii?Q?5IfQxI4EXJqftb1YWYbTZIxKR8kYj44kw6SRdoXDXBnLmlMpsgw94nxN9TSr?= =?us-ascii?Q?1SpvXtNg41Dho/iQfq21KQm0SblcxZ8RYms310es3sQK9t1r6oI9mi8UnYvt?= =?us-ascii?Q?BqcnkBT+oWqNpRMNISX0nbNZcdQNdHBOv+EGFcRaymjowzsl8fhBIUy46Qga?= =?us-ascii?Q?GL+HasaDgm+TbhIwEp3SIlnDzbd4mmdm4RujSHtxr61GIzLCEgu80XRgWraP?= =?us-ascii?Q?12mAweJny99SrW0LKnULfMQS5qJmYPYskL4dJ72ci10RFU7y2yNsquGnud9s?= =?us-ascii?Q?D5LWPTD/T5rZhSNMyL+UTqOVqCHBZf/RBd9VXZyQ+KgZyOshYw4S8Nd+7g2/?= =?us-ascii?Q?A/Q5imDqrcXiFhX+HUB+F/LHCPRNA0h0y2HjNkcAMyUIssRDVtgKnzoJqNbm?= =?us-ascii?Q?DqMhzpVVlqKIdLs7bSJ7jbXkyq1p6sRAyNA2LHkbW2sxgMndehDu2q5+uafP?= =?us-ascii?Q?LnndGNT37K8bW8H+VIpjXZ1sazk65b3YbxEKGVpuMkVlhbHphrM5B3k6dBAJ?= =?us-ascii?Q?PY+AwUQ25w9QozutVDvQSWBFDZAekbH5xbLxtgHqz+R1k1wytvg0d+cUSmHk?= =?us-ascii?Q?JHkZ4q4AedgL1pqbOR/2H7yocpOcy1KR854sJzEFZjX1bfuHBfYLbtt1pS+4?= =?us-ascii?Q?g8VNqbKFQotbk1Sp8N/8w9jOawLPjfoY6r3NE/qMxL7ftB63lGEOgJ1yf2xb?= =?us-ascii?Q?y7auNDuoIe0iUoj7gtAtrixjcug+amEkfyOXNltuB48jl6KAYWka1Yp2ib0x?= =?us-ascii?Q?HLgcdS6KXw61FxcQFYErv9JGytwOkjimQEedKT9xxLby2cuDAyHSjcrmFOzd?= =?us-ascii?Q?CpNp/HSGHFYnqqHNOzClPsvZXPq1sMp6cpv9m+9xbWeTWJ8tvHpm7uVA3jBx?= =?us-ascii?Q?iOLcJrlNNCCzs2Hc0Zysyark5nGmxmWA+S77wvi87ghx9hcsVPqBzq9AH+xi?= =?us-ascii?Q?zc6ntM1aD3re88Eca051d+PCfY4mWQk0+yfBHPM8byarIfXllAtPfHlpXPwd?= =?us-ascii?Q?jcsDVYN2gnFNJIpA+pCuDLrHcARjjtIH/kX3ftlXHedEqwrQdVEtx4Wxu+vT?= =?us-ascii?Q?BlvLp8nu6CgO7G/WzUaXogLTobJq5TUft5p1hSfm+BQdtGad8zKBhFYa11+j?= =?us-ascii?Q?fjgLWvdVU0CobLYyO6bWn5FbCNmA1vqEybUS36BO?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB3844.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c9ac225c-89d0-46e6-2243-08da5ea11728 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jul 2022 16:11:59.7128 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ZIi0H5e7d3xGrNWCfp8nADeveCAxXusNSiL/PdFnPNlpkGLLQpSoj5DiF70V0yu6uzIo39xe9yWxmOCM3EBebA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR18MB4885 X-Proofpoint-ORIG-GUID: 8ZGFmHlVVUvrVLfL5Egu6vyx6RZwrHoa X-Proofpoint-GUID: 8ZGFmHlVVUvrVLfL5Egu6vyx6RZwrHoa X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-05_13,2022-06-28_01,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Thomas Monjalon > Sent: Monday, July 4, 2022 8:18 PM > To: Rahul Bhansali > Cc: dev@dpdk.org; David Christensen ; Ruifeng Wan= g > ; Bruce Richardson ; > Konstantin Ananyev ; Jerin Jacob > Kollanukkaran ; Akhil Goyal > Subject: [EXT] Re: [PATCH v3 1/2] examples/l3fwd: common packet group > functionality >=20 > External Email >=20 > ---------------------------------------------------------------------- > 23/06/2022 11:38, Rahul Bhansali: > > +#ifndef _PORT_GROUP_H_ > > +#define _PORT_GROUP_H_ >=20 > No need of underscores at begin and end. >=20 > > + > > +#include "pkt_group.h" > > + > > +/* > > + * Group consecutive packets with the same destination port in bursts = of 4. > > + * Suppose we have array of destination ports: > > + * dst_port[] =3D {a, b, c, d,, e, ... } > > + * dp1 should contain: , dp2: . > > + * We doing 4 comparisons at once and the result is 4 bit mask. > > + * This mask is used as an index into prebuild array of pnum values. > > + */ >=20 > This explanation is not clear to me. >=20 > > +static inline uint16_t * > > +port_groupx4(uint16_t pn[FWDSTEP + 1], uint16_t *lp, >=20 > array parameter is not standard, you should make it a simple pointer >=20 > > + __vector unsigned short dp1, > > + __vector unsigned short dp2) >=20 >=20 > longer parameter names would help >=20 > [...] > > --- a/examples/l3fwd/Makefile > > +++ b/examples/l3fwd/Makefile > > +INCLUDES =3D-I../common > > PC_FILE :=3D $(shell $(PKGCONF) --path libdpdk 2>/dev/null) CFLAGS += =3D > > -O3 $(shell $(PKGCONF) --cflags libdpdk) # Added for > > 'rte_eth_link_to_str()' > > @@ -38,10 +39,10 @@ endif > > endif > > > > build/$(APP)-shared: $(SRCS-y) Makefile $(PC_FILE) | build > > - $(CC) $(CFLAGS) $(SRCS-y) -o $@ $(LDFLAGS) $(LDFLAGS_SHARED) > > + $(CC) $(CFLAGS) $(SRCS-y) $(INCLUDES) -o $@ $(LDFLAGS) > > +$(LDFLAGS_SHARED) > > > > build/$(APP)-static: $(SRCS-y) Makefile $(PC_FILE) | build > > - $(CC) $(CFLAGS) $(SRCS-y) -o $@ $(LDFLAGS) $(LDFLAGS_STATIC) > > + $(CC) $(CFLAGS) $(SRCS-y) $(INCLUDES) -o $@ $(LDFLAGS) > > +$(LDFLAGS_STATIC) >=20 > No need to introduce INCLUDES, you can expand CFLAGS. >=20 > I will fix this last one while pulling. > Please work on better names and explanations for an EAL integration. >=20 Ack, will make changes for an EAL integration. >=20