DPDK patches and discussions
 help / color / mirror / Atom feed
From: Sunil Kumar Kori <skori@marvell.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Jie Hai <haijie1@huawei.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [EXTERNAL] Re: [PATCH 1/2] net: fix offset calculation for GENEVE packet
Date: Wed, 21 May 2025 04:57:29 +0000	[thread overview]
Message-ID: <CO6PR18MB3860093067F7BFA7C59E16FCB49EA@CO6PR18MB3860.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20250520142137.366c8235@hermes.local>

> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Wednesday, May 21, 2025 2:52 AM
> To: Sunil Kumar Kori <skori@marvell.com>
> Cc: Jie Hai <haijie1@huawei.com>; dev@dpdk.org
> Subject: [EXTERNAL] Re: [PATCH 1/2] net: fix offset calculation for GENEVE
> packet
> 
> On Mon, 19 May 2025 21: 36: 55 +0530 <skori@ marvell. com> wrote: > From: Sunil
> Kumar Kori <skori@ marvell. com> > > While parsing packet headers, offset must
> be added to get next > header but for geneve header parsing offset
> 
> On Mon, 19 May 2025 21:36:55 +0530
> <skori@marvell.com> wrote:
> 
> > From: Sunil Kumar Kori <skori@marvell.com>
> >
> > While parsing packet headers, offset must be added to get next header
> > but for geneve header parsing offset is overwritten.
> > Also inner_l2_len is not set in case of geneve packets.
> >
> > Fixes: 64ed7f854cf4 ("net: add tunnel packet type parsing")
> >
> > Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
> 
> Looks good, but why reorder the assignment to *off ?
> 
> Could just be:
> 
No specific reason. It can be kept as it is. I will fix in next version.

      reply	other threads:[~2025-05-21  4:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-19 16:06 skori
2025-05-19 16:06 ` [PATCH 2/2] app/testpmd: clear stale internal len information skori
2025-05-20 21:17   ` Stephen Hemminger
2025-05-21  5:01     ` [EXTERNAL] " Sunil Kumar Kori
2025-05-21  5:11   ` [PATCH v2 1/2] net: fix offset calculation for GENEVE packet skori
2025-05-21  5:11     ` [PATCH v2 2/2] app/testpmd: clear stale internal len information skori
2025-05-21  9:33     ` [PATCH v2 1/2] net: fix offset calculation for GENEVE packet huangdengdui
2025-05-22  6:12       ` [EXTERNAL] " Sunil Kumar Kori
2025-05-23  1:29     ` huangdengdui
2025-05-20 21:21 ` [PATCH " Stephen Hemminger
2025-05-21  4:57   ` Sunil Kumar Kori [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CO6PR18MB3860093067F7BFA7C59E16FCB49EA@CO6PR18MB3860.namprd18.prod.outlook.com \
    --to=skori@marvell.com \
    --cc=dev@dpdk.org \
    --cc=haijie1@huawei.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).