From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D3E4DA0543; Thu, 22 Sep 2022 13:18:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B57AF40156; Thu, 22 Sep 2022 13:18:14 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id C3404400D7; Thu, 22 Sep 2022 13:18:12 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 28M9GZHk024144; Thu, 22 Sep 2022 04:18:12 -0700 Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2108.outbound.protection.outlook.com [104.47.58.108]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3jrmx58bnv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 22 Sep 2022 04:18:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S7PfU3tLdhw1fIHMXngKVTBKZx9VhfN3rrspF8W6VZcitRCjuXITr/DBXYauq23xOpafHjpvfJ7IBY0B0y2tKpGCo8L+eyjzqra+d7oCGA89CLrQwwa1ekcUZOjmOZhrzvNtVmEY6p/5uGY9Qz9v52ecEn2X16Mrk0rj+lVjYM11CaeUZV13q972DRnriJ52Kk6Er60JnmDwQSlvOw0bZcRtZhR+jMna3tlqmVpOLIMZAe9jIPFIg9uBO0m4Ho459Zk+00nSkdEk9d/cW9z1wKkdboAYT/VKVmXXooQo8FGmzd1snLVUEnfchzlWB+o75u3Jdi7B8B0/QsivA83t4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pNLMc0Gc2fY6WarSOl3lj7X8gghHUONkJmjCPrwt0x4=; b=U1p8halZvBhdOAWdCdcOuQoq8AJxWX6TdoXrFUDfnZ2CAPPYkPa118yRnHCbQaPNpcSE38H1H43XJwGoQF1iNDPBRDUZo5+HsZc68yqcMxS14UhULEljUcRl7PAsgFxS7UmWAFszwJQmNVkK8HO9GlibkDvghbWgbqdMz9e1FiGPGGk4X+jjU9Zam77yfxdRa799qpqPGkUgjrD5xecG1tO9wBWME46IzgUJSwT0RZNUMMRs7nDhYbnJVT1m84t0tNewFWw8gsN7xry5RInHxgZ6q90AL6ayNddkMOhy1OwMRuuoR/DYm5JDILnn7zkvNg9Okdu5RTtBLBdH027OqQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pNLMc0Gc2fY6WarSOl3lj7X8gghHUONkJmjCPrwt0x4=; b=oYLM+AxX/7Pyjf35rUaG0/InASNLCFvyxFzhUj1vWCOpX8PtLqNKR0w1XlR6uc8s37cVk1vmZCepgPwAfFeKoxxoWnc2Wp0At1j1GFnohH08HY/tFq3chCQ19NaAaZ0ccd9Rq2c+5mmZOrryjvWIkjVO1qjEJQ2DiNbg9OjAGic= Received: from CO6PR18MB3860.namprd18.prod.outlook.com (2603:10b6:5:34d::12) by CH0PR18MB4291.namprd18.prod.outlook.com (2603:10b6:610:bb::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.19; Thu, 22 Sep 2022 11:18:05 +0000 Received: from CO6PR18MB3860.namprd18.prod.outlook.com ([fe80::90e5:b580:882e:96bc]) by CO6PR18MB3860.namprd18.prod.outlook.com ([fe80::90e5:b580:882e:96bc%5]) with mapi id 15.20.5654.016; Thu, 22 Sep 2022 11:18:05 +0000 From: Sunil Kumar Kori To: David Marchand , "dev@dpdk.org" CC: "stable@dpdk.org" , Jerin Jacob Kollanukkaran Subject: RE: [EXT] [PATCH 4/8] trace: fix dynamically enabling trace points Thread-Topic: [EXT] [PATCH 4/8] trace: fix dynamically enabling trace points Thread-Index: AQHYzbJPN60Ls9oAPE+5VCRgtHOPSK3rSa4w Date: Thu, 22 Sep 2022 11:18:05 +0000 Message-ID: References: <20220921120359.2201131-1-david.marchand@redhat.com> <20220921120359.2201131-5-david.marchand@redhat.com> In-Reply-To: <20220921120359.2201131-5-david.marchand@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-dg-rorf: true x-dg-ref: =?us-ascii?Q?PG1ldGE+PGF0IG5tPSJib2R5LnR4dCIgcD0iYzpcdXNlcnNcc2tvcmlcYXBw?= =?us-ascii?Q?ZGF0YVxyb2FtaW5nXDA5ZDg0OWI2LTMyZDMtNGE0MC04NWVlLTZiODRiYTI5?= =?us-ascii?Q?ZTM1Ylxtc2dzXG1zZy0zNzUyYjRiOC0zYTY4LTExZWQtYjZiZC05NGU2Zjc5?= =?us-ascii?Q?MjY4OTBcYW1lLXRlc3RcMzc1MmI0YjktM2E2OC0xMWVkLWI2YmQtOTRlNmY3?= =?us-ascii?Q?OTI2ODkwYm9keS50eHQiIHN6PSI1MTcyIiB0PSIxMzMwODMxOTA4MTM1OTU5?= =?us-ascii?Q?MTQiIGg9IkwxYUE4cm5ZdWx0WlF6UHNwUXdibVRBK3JwRT0iIGlkPSIiIGJs?= =?us-ascii?Q?PSIwIiBibz0iMSIgY2k9ImNBQUFBRVJIVTFSU1JVRk5DZ1VBQVA0RkFBQUtH?= =?us-ascii?Q?UVg2ZE03WUFldk5lUWJqTHd1SjY4MTVCdU12QzRrSkFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFIQUFBQUNPQlFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFF?= =?us-ascii?Q?QUFRQUJBQUFBNlBxZWxBQUFBQUFBQUFBQUFBQUFBSjRBQUFCaEFHUUFaQUJ5?= =?us-ascii?Q?QUdVQWN3QnpBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUVB?= =?us-ascii?Q?QUFBQUFBQUFBZ0FBQUFBQW5nQUFBR01BZFFCekFIUUFid0J0QUY4QWNBQmxB?= =?us-ascii?Q?SElBY3dCdkFHNEFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQWdBQUFBQUFBQUFBQUFBQUFRQUFBQUFBQUFBQ0FBQUFB?= =?us-ascii?Q?QUNlQUFBQVl3QjFBSE1BZEFCdkFHMEFYd0J3QUdnQWJ3QnVBR1VBYmdCMUFH?= =?us-ascii?Q?MEFZZ0JsQUhJQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFCQUFBQUFBQUFBQUlBQUFBQUFKNEFBQUJqQUhVQWN3?= =?us-ascii?Q?QjBBRzhBYlFCZkFITUFjd0J1QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-refone: =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBRUFBQUFBQUFBQUFnQUFBQUFBbmdBQUFHUUFi?= =?us-ascii?Q?QUJ3QUY4QWN3QnJBSGtBY0FCbEFGOEFZd0JvQUdFQWRBQmZBRzBBWlFCekFI?= =?us-ascii?Q?TUFZUUJuQUdVQVh3QjJBREFBTWdBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQVFBQUFBQUFBQUFDQUFBQUFBQ2VBQUFBWkFCc0FIQUFYd0J6QUd3QVlR?= =?us-ascii?Q?QmpBR3NBWHdCakFHZ0FZUUIwQUY4QWJRQmxBSE1BY3dCaEFHY0FaUUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUJBQUFBQUFBQUFB?= =?us-ascii?Q?SUFBQUFBQUo0QUFBQmtBR3dBY0FCZkFIUUFaUUJoQUcwQWN3QmZBRzhBYmdC?= =?us-ascii?Q?bEFHUUFjZ0JwQUhZQVpRQmZBR1lBYVFCc0FHVUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFFQUFBQUFBQUFBQWdBQUFBQUFuZ0FBQUdV?= =?us-ascii?Q?QWJRQmhBR2tBYkFCZkFHRUFaQUJrQUhJQVpRQnpBSE1BQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUJ3QUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBUUFBQUFBQUFBQUNBQUFBQUFDZUFBQUFiUUJoQUhJQWRnQmxBR3dB?= =?us-ascii?Q?YkFCZkFIUUFaUUJ5QUcwQWFRQnVBSFVBY3dBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-reftwo: QUFBQUFBQUFBQkFBQUFBQUFBQUFJQUFBQUFBQT09Ii8+PC9tZXRhPg== x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR18MB3860:EE_|CH0PR18MB4291:EE_ x-ms-office365-filtering-correlation-id: 668740a3-bb59-46b7-e372-08da9c8c1eb7 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wfEtoOqVqR4z3uGd+GhQmQaTgkkp2d8YrRPtUnvennQUkCuRhPTDFRKoD5aZRHWsj4agsouZSpjFBroAumfmOc6qAQrap9nnrHlBokk8vsz36q3L7Mg4epKjMMvjxjBbBm0fPKK69BhZZ5G2EsJUzLfJdK01liyM68/XtcdA5dSKYqYn85oTfDt9Ac5xTEkOwUYsvNxofzOagmz+3XT+r+x3UYOu12LUKSSMh+KMwOuSzWePw9/n6/98koXqOmYbsiiPHTfViFQiTnuN6xIEx4CXB6ZtIPz+vBx2OrvJWrrJHG/2aBXacANad/YLJRovmpYEwry6dYTvee/Kg080UrdbcA9JLuiqRnKdeq+NZhSl/lQtLFACs67WKPHLTh+AubaH/LidS9Fgx4xjm3b48/6WPhtE3Ayz3lKG3nwkXefm6t4ARMLKv0UGrtmjCvOt0+psQA6M86WWZAJyRBRNbTTspqp9ZZdUiEEFNIWMjJOlDBBSGdqOkbbq1h2kZRnaRPmQoGwO+U3MZZSfhUeZ9HMuqf5fMdYdBOQbjh268qkgPN5saIzxK2vvKxR8xZO9nMSAOBIxUkj5wSd5u3Rj/WunTFlvJ0Bvtk+eYHIsJj+4uWJRAlyjuh3FQdbqWONXj4b+jfVNrCPOOLu67CUopMh/5x78OzV0RHITl21wGxasnPTeWUXqzSMIxkpxJZ38MDayYeN+SPTKUyr2jzR+BRNnTE/Zl4fLcpgvxKSGyZqE6913dDVrnm6cWYVNs4qTdSM3caRyyarnb6HRLZKhug== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB3860.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(376002)(346002)(366004)(396003)(39860400002)(136003)(451199015)(38100700002)(122000001)(66899012)(2906002)(478600001)(107886003)(41300700001)(4326008)(76116006)(71200400001)(52536014)(86362001)(38070700005)(5660300002)(53546011)(6506007)(54906003)(110136005)(55016003)(316002)(186003)(8676002)(66946007)(66446008)(64756008)(66476007)(66556008)(83380400001)(26005)(9686003)(33656002)(7696005)(8936002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?83puvUT6149ekfd+q3nDX2/mjdKygprIs0xC1TTf7soVp5/84Vamcl5z/67Q?= =?us-ascii?Q?WJUUbuNanMq3yGPAX0bTHGAFV8yWR/so0ahhHUkKE1zxMQDHVXiTricNlLUh?= =?us-ascii?Q?TqGY4csDhj1hry50pNGV/KyPW7C7n0OeFnnxNrAtt23i1mdXtxhUa90Aci14?= =?us-ascii?Q?JyQqXdPPhXAJARawr9OuSufKujQl1Q6VZZ8gfAMgCrFt8tNKZDk+9Y1zADhg?= =?us-ascii?Q?Am5kM7JPFv/v/Eusz8/9CzYPA5/K2XbcnsmKqPiLX2RUtTJRM7gNx4StbfbU?= =?us-ascii?Q?ZeA0LCgh/jgYi2BJtS8x6J+PvWDIGkWf2Jucw42Nw2dNLDQDfVZQVr/OJ3Ii?= =?us-ascii?Q?LfVmsVZBGXorqatC5fw3Bh5MLo6egK+mIIJAXo72RF63GucUlexDeqefqMVn?= =?us-ascii?Q?zz/RHRiXVjIIpO/XprzZ0705wU/NKSyX5HlKw8IiIVbHek4rxvECy47ZYsEp?= =?us-ascii?Q?gDhmUwcnsuWZ2dbc2p4WOyLKek76VzBxw+M8ZsQEbspD8bHg8ymyJWVGI/5B?= =?us-ascii?Q?LXTwAtZq141/DKlolMW3jLfcF1sQ0XhuSKxDEWtQzUswrw+ercVom3hS3i1+?= =?us-ascii?Q?zbRwUePGu3IyO1hhWX24WVjWinfs2Ml1XeVnDWpt/CxlieZVAqTf5WsCuRE0?= =?us-ascii?Q?KN+JFGSJlg9iKxI3S5VpcUzNZkGMWFiNp/pMiGlZhfvFK+bnIQxoIRV1bUru?= =?us-ascii?Q?eQY2xQtnydcq8YgITIcjmIgOJfG+YWskD0YL4/RxfchYNnMxHP4FfgV44XPp?= =?us-ascii?Q?LHbmjyjh5zEB5nvzlQOkaNJJE0GmBtcD/5bMieoaauvqNboZIVsIeFl91seU?= =?us-ascii?Q?iRdaFRD6JL8uvr/2rNcVfEUToUhEZv4de22TLIiG23JbOBLsFi5itwLZ+2VE?= =?us-ascii?Q?WpVN2LVmNy0cpurkanTee3JXIk8uuWqJiiJq0OCYDkDSBERhJoQzTyxUfLvz?= =?us-ascii?Q?aW10xR3piwjRKpvhju5zAY9YRqAm6jDYpHu2ot20VHQrZcyDwSjo+Kx+5ynS?= =?us-ascii?Q?z6iJyryILrQkdWwNV9gWN2RRYUUp9jGAvomQIrt13vQc8BWFFmdwGBByWIEG?= =?us-ascii?Q?Mp33s9Q0pPgqFDFPGaff2BHP1ttMpSn8PELNKmUyYJudGiRS5jKioAybjBB7?= =?us-ascii?Q?JHs/dWM/nIRV9uIncmcAaPsA+wY0BmJkqal3xnW+lNBqgLM0/8c2j+zjsi7d?= =?us-ascii?Q?cg5qW8afbv9gProUyQ8MeC2FN6ZDPMutHscSph1mky/Xxxzw66acNJjNoD1h?= =?us-ascii?Q?xFaLMii894XyJCyyIRDQrAhfM79ZkmzSe3qt5SR5J13vVtN2LV+yzrBRKCnJ?= =?us-ascii?Q?Yo2Dm3Rrt1ztZhZgR2d9nMLpunSl4Jv1bHGWuqMT921CMym72FY4JeVWet8x?= =?us-ascii?Q?suDexNTIwk0xSQ5jUNP27w0kOlQp+MW9fYf6S4BEejQqBJDXv5IVaTpIEau+?= =?us-ascii?Q?UvXo4PHuDkUgcg4r3ntCF0VcQYtloUXylfCXc7k54cMVI9ctTZ/oVJzGCBag?= =?us-ascii?Q?sMs6rY50hPwPyEkW11kOp8YbIHqtC+gCDz9KCFuUM35+tVg/SF1k5PqzZp2L?= =?us-ascii?Q?EqNsv94FC67yHgBgNJlfVLudgw3y7iiyIYp6ALRk?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB3860.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 668740a3-bb59-46b7-e372-08da9c8c1eb7 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Sep 2022 11:18:05.0912 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cs8/ob+QHsf3pKi1qfsuts7QQdX0XUBWCzzW93w630he5p94LZM/KK/5s3cnV77ysiU1Hi+9GDMdSfDhK89szQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR18MB4291 X-Proofpoint-GUID: RV9te8dNlEs6J5mQdc3fHk6mZJo-Au9P X-Proofpoint-ORIG-GUID: RV9te8dNlEs6J5mQdc3fHk6mZJo-Au9P X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-09-22_07,2022-09-22_01,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: David Marchand > Sent: Wednesday, September 21, 2022 5:34 PM > To: dev@dpdk.org > Cc: stable@dpdk.org; Jerin Jacob Kollanukkaran ; Suni= l > Kumar Kori > Subject: [EXT] [PATCH 4/8] trace: fix dynamically enabling trace points >=20 > External Email >=20 > ---------------------------------------------------------------------- > Enabling trace points at runtime was not working if no trace point had be= en > enabled first at rte_eal_init() time. The reason was that trace.args refl= ected > the arguments passed to --trace=3D EAL option. >=20 > To fix this: > - the trace subsystem initialisation is updated: trace directory > creation is deferred to when traces are dumped (to avoid creating > directories that may not be used), > - per lcore memory allocation still relies on rte_trace_is_enabled() but > this helper now tracks if any trace point is enabled. The > documentation is updated accordingly, > - cleanup helpers must always be called in rte_eal_cleanup() since some > trace points might have been enabled and disabled in the lifetime of > the DPDK application, >=20 > With this fix, we can update the unit test and check that a trace point c= allback > is invoked when expected. >=20 > Note: > - the 'trace' global variable might be shadowed with the argument > passed to the functions dealing with trace point handles. > 'tp' has been used for referring to trace_point object. > Prefer 't' for referring to handles, >=20 > Fixes: 84c4fae4628f ("trace: implement operation APIs") > Cc: stable@dpdk.org >=20 > Signed-off-by: David Marchand > --- > app/test/test_trace.c | 20 ++++++++++ > app/test/test_trace.h | 2 + > doc/guides/prog_guide/trace_lib.rst | 14 +++++-- > lib/eal/common/eal_common_trace.c | 53 ++++++++++--------------- > lib/eal/common/eal_common_trace_utils.c | 17 +++++++- > lib/eal/common/eal_trace.h | 3 +- > 6 files changed, 70 insertions(+), 39 deletions(-) >=20 >=20 [snipped] > int > -rte_trace_point_disable(rte_trace_point_t *trace) > +rte_trace_point_disable(rte_trace_point_t *t) > { > - if (trace_point_is_invalid(trace)) > + uint64_t prev; > + > + if (trace_point_is_invalid(t)) > return -ERANGE; >=20 > - __atomic_and_fetch(trace, ~__RTE_TRACE_FIELD_ENABLE_MASK, > - __ATOMIC_RELEASE); > + prev =3D __atomic_fetch_and(t, ~__RTE_TRACE_FIELD_ENABLE_MASK, > __ATOMIC_RELEASE); > + if ((prev & __RTE_TRACE_FIELD_ENABLE_MASK) !=3D 0) > + __atomic_sub_fetch(&trace.status, 1, __ATOMIC_RELEASE); > return 0; > } >=20 IMO, above change should go as a separate commit as it just replaces the va= riable name. > @@ -413,9 +407,6 @@ trace_mem_free(void) > struct trace *trace =3D trace_obj_get(); > uint32_t count; >=20 > - if (!rte_trace_is_enabled()) > - return; > - > rte_spinlock_lock(&trace->lock); > for (count =3D 0; count < trace->nb_trace_mem_list; count++) { > trace_mem_per_thread_free_unlocked(&trace- > >lcore_meta[count]); > diff --git a/lib/eal/common/eal_common_trace_utils.c > b/lib/eal/common/eal_common_trace_utils.c > index 2b55dbec65..6340caabbf 100644 > --- a/lib/eal/common/eal_common_trace_utils.c > +++ b/lib/eal/common/eal_common_trace_utils.c > @@ -314,14 +314,18 @@ trace_dir_default_path_get(char *dir_path) > return 0; > } >=20 > -int > +static int > trace_mkdir(void) > { > struct trace *trace =3D trace_obj_get(); > char session[TRACE_DIR_STR_LEN]; > + static bool already_done; > char *dir_path; > int rc; >=20 > + if (already_done) > + return 0; > + > if (!trace->dir_offset) { > dir_path =3D calloc(1, sizeof(trace->dir)); > if (dir_path =3D=3D NULL) { > @@ -364,7 +368,8 @@ trace_mkdir(void) > return -rte_errno; > } >=20 > - RTE_LOG(INFO, EAL, "Trace dir: %s\n", trace->dir); > + RTE_LOG(DEBUG, EAL, "Trace dir: %s\n", trace->dir); > + already_done =3D true; I request you to keep it as INFO only. If a user enables traces, then it wi= ll give information directly about the directory without running in debug m= ode.=20 > return 0; > } >=20 > @@ -375,6 +380,10 @@ trace_meta_save(struct trace *trace) > FILE *f; > int rc; >=20 > + rc =3D trace_mkdir(); > + if (rc < 0) > + return rc; > + Trace directory is being created here and in trace_mem_save() function alon= g with the logic to handle whether it is already done or not. Instead can't it be called in rte_trace_save() directly. That will suffice = the intention, I believe. > rc =3D snprintf(file_name, PATH_MAX, "%s/metadata", trace->dir); > if (rc < 0) > return rc; > @@ -406,6 +415,10 @@ trace_mem_save(struct trace *trace, struct > __rte_trace_header *hdr, > FILE *f; > int rc; >=20 > + rc =3D trace_mkdir(); > + if (rc < 0) > + return rc; > + > rc =3D snprintf(file_name, PATH_MAX, "%s/channel0_%d", trace->dir, > cnt); > if (rc < 0) > return rc; > -- [snipped] > 2.37.3