From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 44FC6A0547; Wed, 12 Oct 2022 11:24:02 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2B8EE42D6E; Wed, 12 Oct 2022 11:24:02 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 2969442B6D; Wed, 12 Oct 2022 11:24:01 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29C8en5f010955; Wed, 12 Oct 2022 02:24:00 -0700 Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2104.outbound.protection.outlook.com [104.47.70.104]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3k5t92r4h8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 12 Oct 2022 02:24:00 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NesCfOURfeHa+esEAOjAh/lbRNzJp+l/+12GolxaTNZs6lw3UYqCFOXlREahlhGEzCI4G5J+KWC7/Hf+7gXlr21AX6PdxjsCNXY07lS778lQP39U069NxBTJZ3jTPY2FqmZ1251GsslC69cODEjyof2v3KFgsxk6RFqfhFp/0n7dmShEpzX17U+VQ+MmNdOTKny0I+6Mt48Vsi9Lka6TvDAoKgbMjKOEiJ0i0Mu8dxErjYoDt4EYq+HZZUDg9bybs8nXogy+jxMe61exV6w6NDoShwMUJN4Tl1qQyi8ZGc3dWxzZsgC9QlV/wXfUyszsvDxi5rme4HBRu+YbvBZfVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BlI+aWbfXq3AtAJ11macvJJ57xRjVnOsd6Z/r96pzdo=; b=FMspjoE2MGEl1HV6q8a97TLBzxGHycqFMME8O+FIsMOqBGFj29vXCcrMBKVsGHnhIYpdEtM7wUlNaKGYZPDz5ApRfI8VPQU9PsGXXN+oLzwwLheMHp/cXVRrsYMAcSDU1tr58v/mx4Q7MiCw7uKMaxtbDAAdPXDaPYULCEYULt5ZevS+CpFOz19w05Ti3Tx8zL9hhRu2Cc8Kvi6Km2bNH9T3mftJvY3/xsE4PyXLieRdMkcCDPnLIJFAhDD8v3dsRRxguxF614joF2DgLP+vuuXguB1BEeTt8fcmgcZ0brkp41S0xKV9GE8COI7GvjKXV1kB18BUlz1VVtBuu3XccQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BlI+aWbfXq3AtAJ11macvJJ57xRjVnOsd6Z/r96pzdo=; b=aMSnj26YuWjX8J0NeFkEmq+71kn7chpkQWM3u+XG7GEl7+mFJWTO+ugJW94tDWdm24788YI0gI4tBQ+Gw0k95vK7Fvn9jvCNzlZOQ9soHj9OzlAI89v81D8vcGXXu0pSslWPIpGUkYBO1rPAjQmPDOf2ydjxuF53CXfz10h2Uzs= Received: from CO6PR18MB3860.namprd18.prod.outlook.com (2603:10b6:5:34d::12) by SA0PR18MB5253.namprd18.prod.outlook.com (2603:10b6:806:1bd::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Wed, 12 Oct 2022 09:23:58 +0000 Received: from CO6PR18MB3860.namprd18.prod.outlook.com ([fe80::50c6:106e:b9d9:4436]) by CO6PR18MB3860.namprd18.prod.outlook.com ([fe80::50c6:106e:b9d9:4436%7]) with mapi id 15.20.5676.044; Wed, 12 Oct 2022 09:23:58 +0000 From: Sunil Kumar Kori To: David Marchand , "dev@dpdk.org" CC: "skori@mavell.com" , Jerin Jacob Kollanukkaran , "stable@dpdk.org" Subject: RE: [EXT] [PATCH v2 5/9] trace: fix dynamically enabling trace points Thread-Topic: [EXT] [PATCH v2 5/9] trace: fix dynamically enabling trace points Thread-Index: AQHY19X40jrjxbtWfU+NUz0UdAuW5q4KiBCg Date: Wed, 12 Oct 2022 09:23:58 +0000 Message-ID: References: <20220921120359.2201131-1-david.marchand@redhat.com> <20221004094418.196544-1-david.marchand@redhat.com> <20221004094418.196544-6-david.marchand@redhat.com> In-Reply-To: <20221004094418.196544-6-david.marchand@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-dg-rorf: true x-dg-ref: =?us-ascii?Q?PG1ldGE+PGF0IG5tPSJib2R5LnR4dCIgcD0iYzpcdXNlcnNcc2tvcmlcYXBw?= =?us-ascii?Q?ZGF0YVxyb2FtaW5nXDA5ZDg0OWI2LTMyZDMtNGE0MC04NWVlLTZiODRiYTI5?= =?us-ascii?Q?ZTM1Ylxtc2dzXG1zZy05NzU5YmQ3ZC00YTBmLTExZWQtYjZiZS05NGU2Zjc5?= =?us-ascii?Q?MjY4OTBcYW1lLXRlc3RcOTc1OWJkN2YtNGEwZi0xMWVkLWI2YmUtOTRlNmY3?= =?us-ascii?Q?OTI2ODkwYm9keS50eHQiIHN6PSIzNjczIiB0PSIxMzMxMDA0MDIzNTI3NjY4?= =?us-ascii?Q?NjgiIGg9IlN1UzNGZWQ4YWJqQUZVWGJ1SzJOeDFhYmRNcz0iIGlkPSIiIGJs?= =?us-ascii?Q?PSIwIiBibz0iMSIgY2k9ImNBQUFBRVJIVTFSU1JVRk5DZ1VBQVA0RkFBQ1V2?= =?us-ascii?Q?N0paSE43WUFSQytuNmUzVHNYQUVMNmZwN2RPeGNBSkFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFIQUFBQUNPQlFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFF?= =?us-ascii?Q?QUFRQUJBQUFBNlBxZWxBQUFBQUFBQUFBQUFBQUFBSjRBQUFCaEFHUUFaQUJ5?= =?us-ascii?Q?QUdVQWN3QnpBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUVB?= =?us-ascii?Q?QUFBQUFBQUFBZ0FBQUFBQW5nQUFBR01BZFFCekFIUUFid0J0QUY4QWNBQmxB?= =?us-ascii?Q?SElBY3dCdkFHNEFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQWdBQUFBQUFBQUFBQUFBQUFRQUFBQUFBQUFBQ0FBQUFB?= =?us-ascii?Q?QUNlQUFBQVl3QjFBSE1BZEFCdkFHMEFYd0J3QUdnQWJ3QnVBR1VBYmdCMUFH?= =?us-ascii?Q?MEFZZ0JsQUhJQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFCQUFBQUFBQUFBQUlBQUFBQUFKNEFBQUJqQUhVQWN3?= =?us-ascii?Q?QjBBRzhBYlFCZkFITUFjd0J1QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-refone: =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBRUFBQUFBQUFBQUFnQUFBQUFBbmdBQUFHUUFi?= =?us-ascii?Q?QUJ3QUY4QWN3QnJBSGtBY0FCbEFGOEFZd0JvQUdFQWRBQmZBRzBBWlFCekFI?= =?us-ascii?Q?TUFZUUJuQUdVQVh3QjJBREFBTWdBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQVFBQUFBQUFBQUFDQUFBQUFBQ2VBQUFBWkFCc0FIQUFYd0J6QUd3QVlR?= =?us-ascii?Q?QmpBR3NBWHdCakFHZ0FZUUIwQUY4QWJRQmxBSE1BY3dCaEFHY0FaUUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUJBQUFBQUFBQUFB?= =?us-ascii?Q?SUFBQUFBQUo0QUFBQmtBR3dBY0FCZkFIUUFaUUJoQUcwQWN3QmZBRzhBYmdC?= =?us-ascii?Q?bEFHUUFjZ0JwQUhZQVpRQmZBR1lBYVFCc0FHVUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFFQUFBQUFBQUFBQWdBQUFBQUFuZ0FBQUdV?= =?us-ascii?Q?QWJRQmhBR2tBYkFCZkFHRUFaQUJrQUhJQVpRQnpBSE1BQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUNBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBUUFBQUFBQUFBQUNBQUFBQUFDZUFBQUFiUUJoQUhJQWRnQmxBR3dB?= =?us-ascii?Q?YkFCZkFIUUFaUUJ5QUcwQWFRQnVBSFVBY3dBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-reftwo: QUFBQUFBQUFBQkFBQUFBQUFBQUFJQUFBQUFBQT09Ii8+PC9tZXRhPg== x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR18MB3860:EE_|SA0PR18MB5253:EE_ x-ms-office365-filtering-correlation-id: 0cfd0da3-cac4-4dbb-f782-08daac337e06 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: kWVWXWvci8p8Yaudn1bpD+t0TUZel+OS/WARiiKT0G51rKRIFabwfuWUKHq6pdjInxA5l0HvONPHJIzejZ+9jENMi/hlVK09XdcLKGODRBM3liVyO6GkwhAZxZLkG2RTfkicP1SdzZSiCcaaYyZWbmjBYJzUePKHt4Gmz6+ebr1x3RrKR+FG9+Cy7/Q95IgqGNRbaOOu8horvCg75xQYHryfG1T13TeQL9WuBnV1C/TuUNo5/OIkmzUr0w/dV7oGhEa2txv+yRTI3ij90KO23TqCy5iDMAEkMY3tdPBZUXaGH0efAqosW6a87N1EWaT2eOl2ifUAPQhrhgpD9Oc619i+fipqAF/G9RxqZA0dILnzOO+9B4qK2vXQ1U4vpx1I3SlLJGXy4HL9tcUqkdPs7K1JxdU9fCtOjjmVRbeZ4G6o1U0uLWEio3T9+yu/GP2u+eKUhbqJvu/vcVwkXHG9EatX2SPp+74fj3xJ05XxyxoA85kw/5OCZ/mFJnOgOAlIXT4rgYZ7et9jsnOpyBZ5LUU3IQtEZ3tG137BJMCX7/ExcoQ6FyXdILh2bNQSUFP9amfeOM8kgbdoA2l8QAOTmX6xAEHoy52cKteMFiBE7Se5fz/+esqxDTXOqLdbJZU0YLPj17Alt1l+/pqvQMk9TR+tybobp5c1fZOmaduXjN8+L8veW5z25BWeQvzkF5u6AR0fSAAJ/7J+LWV58rOfgpJsObg9Ma07xlOcRviIjX2Ce4NXE9x6bH61Qf3BFA8l/K00VvKayXVfyemqSapl9g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB3860.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(346002)(39860400002)(136003)(366004)(396003)(376002)(451199015)(8936002)(86362001)(55016003)(122000001)(71200400001)(478600001)(5660300002)(54906003)(7696005)(6506007)(53546011)(52536014)(2906002)(83380400001)(38070700005)(41300700001)(316002)(8676002)(64756008)(4326008)(110136005)(76116006)(33656002)(38100700002)(66556008)(66476007)(66446008)(66946007)(186003)(66899015)(26005)(9686003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?eAGd4kmP+PSIK3QJSpXZd6/oil/cVJYE4+tFusYp3ZRzs1dTSxNbVSa7naEY?= =?us-ascii?Q?P24ElPu/xAI/DkAHqaF7kJVykMpghPUW1VigXerUaT4c4rp5pvz3DDZ5AaFM?= =?us-ascii?Q?jT1HLvaboxOWMm9u3t7oK4RQ9YoD6ujpXg8Dfcy79FCt0MFTds1WAIrL9x+0?= =?us-ascii?Q?jjK/zG6+BQ4EZD8C882nqEKgAxluLNIod8Qkoo5d/F/ewX9kIi/IUeBBaFGA?= =?us-ascii?Q?4qOznACRe+0Yx36k/jUYNBTRrTD8JyoJjszQEVL5OBtEGq/ROuJzG/xetshN?= =?us-ascii?Q?S6d9giHNo6lcIZLbK8gB24TBQEUybPxP8lEqiFnm+9yiK/egX8ADpr4A6Mce?= =?us-ascii?Q?mU76pKuJhhF4YbeYYGHYDsdgnQyyqJSIWdL532W+UdU23+83FMd3QKMuEKQE?= =?us-ascii?Q?i71IgUmY+W2g5ObytmrAT+10b5Sw8jSrT0h0zUnKQ2JfTm2zCgNtjMzVnqtW?= =?us-ascii?Q?BWOvpNuLYGHkeMwChUXUeSUnY+o93FqpvdEV2D5cSAdI5Ais3XnJJFUuuasC?= =?us-ascii?Q?P5d8qbJBTtCKnhhHt2cAc7BeidIJVewM/jNqTbrLk2wK/qcjHjLLPjUC1MDr?= =?us-ascii?Q?UNNvVIaEVv3nOzobRPtTgYbiXJ4hV7ZybNiUgBTYtaPO+6B9AtkPutzcJvEV?= =?us-ascii?Q?5Miu2jXqduT+L7ZUP4wP8r4TXa8f9sjlbtdggLgfeFkgCyUskgfuv3XHWHCB?= =?us-ascii?Q?eVwL9r1Chj4PGDtaIzowBMVWtfuzo16UwyTsKYIyL45ZXKJwyKy8/YgKDa5L?= =?us-ascii?Q?wuhVDyT/DgFCThilvGv4ZhLQ7e0XAxYy+jLAIgxW7IgXHLlcoW/M/sXS2gJq?= =?us-ascii?Q?ZSXRrBkhlEYRXzNC8zOTz96P27ck8t6pueQba8eYrE7dR7EN2m+3jwjYV4Hi?= =?us-ascii?Q?4uYb1uyv36yzCp/cNrsbP1rMHZs+E/UihOF/DYJWQ/r5n/ZoKS/B0hTkIQhH?= =?us-ascii?Q?f1qWCuDzNyJjhfNdsGGLQPngLT8nHOe2TmAncFVCJY+b/5G8K7OKgyTw7+ZS?= =?us-ascii?Q?LEgAB3ahXd8jvHqUvdYocJWULgMqWF2lLiuOisLmZE5XVpD2i3zE6MPHhctQ?= =?us-ascii?Q?s8KfZKV2xk+DiFGijj63GD3FF6fZuk4W5w/7MnpT0Wlfw4tTVqURatmOwSZL?= =?us-ascii?Q?vj/JvJJBtOGvequO26waAmAXWfRKa+9i4Tz7HRA4XBWMY/86p2qDxmIwOxGA?= =?us-ascii?Q?v8TEaMQvUI2V8rahawBF7ajTZhnCrNViFSBNa8R7HNlDH8dReN1+563gp1wC?= =?us-ascii?Q?1zRbYt6dFws9XotM5DEf4lgLO5Rc6UzEGWM1D4FEITEoW7In++5uGI1bHV9O?= =?us-ascii?Q?/9HzbKXuU2cYdpXfI+FcKKL/b01DAzYKDrcrZ9h2ddHB0KEQnEiTcLqfGaj1?= =?us-ascii?Q?5QkgqUzn+ytK5lqgSIv2WYupKnMU9LrhuzlyMpi5PPm8R44yUP+o5BwD+riH?= =?us-ascii?Q?6121Q3N1ebnzVDtUSwbFAxx5PSya7m/+zBHL2O3c636vSUI4MIMLf1EQyZF9?= =?us-ascii?Q?+gDDp/ZiZp4yxDRtsQ1uqBkaPGzjXpR8mBYb/krifA3feHoxPc/cDNo7CY/W?= =?us-ascii?Q?5CnjZg2kRwaAIECVhRDL9W8b/VKfC53vjExYVq1W?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB3860.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0cfd0da3-cac4-4dbb-f782-08daac337e06 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2022 09:23:58.3728 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LqbC+6+Lp3eglYfrphwpaZy1VQKzDPjY1TMZuvlnYwh86n3zaybk1kk0GuUrkE8+QUbBrKr3xmiA7uPZswLB6w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR18MB5253 X-Proofpoint-GUID: 8d1ET1kM-7nn2_apnmB-RfKiOXfYxSKb X-Proofpoint-ORIG-GUID: 8d1ET1kM-7nn2_apnmB-RfKiOXfYxSKb X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-10-12_04,2022-10-11_02,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: David Marchand > Sent: Tuesday, October 4, 2022 3:14 PM > To: dev@dpdk.org > Cc: skori@mavell.com; Jerin Jacob Kollanukkaran ; > stable@dpdk.org; Sunil Kumar Kori > Subject: [EXT] [PATCH v2 5/9] trace: fix dynamically enabling trace point= s >=20 > External Email >=20 > ---------------------------------------------------------------------- > Enabling trace points at runtime was not working if no trace point had be= en > enabled first at rte_eal_init() time. The reason was that trace.args refl= ected > the arguments passed to --trace=3D EAL option. >=20 > To fix this: > - the trace subsystem initialisation is updated: trace directory > creation is deferred to when traces are dumped (to avoid creating > directories that may not be used), > - per lcore memory allocation still relies on rte_trace_is_enabled() but > this helper now tracks if any trace point is enabled. The > documentation is updated accordingly, > - cleanup helpers must always be called in rte_eal_cleanup() since some > trace points might have been enabled and disabled in the lifetime of > the DPDK application, >=20 > With this fix, we can update the unit test and check that a trace point c= allback > is invoked when expected. >=20 > Note: > - the 'trace' global variable might be shadowed with the argument > passed to the functions dealing with trace point handles. > 'tp' has been used for referring to trace_point object. > Prefer 't' for referring to handles, >=20 > Fixes: 84c4fae4628f ("trace: implement operation APIs") > Cc: stable@dpdk.org >=20 > Signed-off-by: David Marchand > --- > Changes since v1: > - restored level to INFO for trace directory log message, > - moved trace_mkdir() to rte_trace_save, >=20 > --- > app/test/test_trace.c | 20 ++++++++++ > app/test/test_trace.h | 2 + > doc/guides/prog_guide/trace_lib.rst | 14 +++++-- > lib/eal/common/eal_common_trace.c | 53 ++++++++++--------------- > lib/eal/common/eal_common_trace_utils.c | 11 ++++- > lib/eal/common/eal_trace.h | 3 +- > 6 files changed, 65 insertions(+), 38 deletions(-) >=20 [snip] > diff --git a/lib/eal/common/eal_common_trace_utils.c > b/lib/eal/common/eal_common_trace_utils.c > index 2b55dbec65..7bf1c05e12 100644 > --- a/lib/eal/common/eal_common_trace_utils.c > +++ b/lib/eal/common/eal_common_trace_utils.c > @@ -314,14 +314,18 @@ trace_dir_default_path_get(char *dir_path) > return 0; > } >=20 > -int > +static int > trace_mkdir(void) > { > struct trace *trace =3D trace_obj_get(); > char session[TRACE_DIR_STR_LEN]; > + static bool already_done; > char *dir_path; > int rc; >=20 > + if (already_done) > + return 0; > + As trace_mkdir() call is being moved to rte_trace_save() so there won't be = another context which will be invoking trace_mkdir(). So is this logic still needed here ? > if (!trace->dir_offset) { > dir_path =3D calloc(1, sizeof(trace->dir)); > if (dir_path =3D=3D NULL) { > @@ -365,6 +369,7 @@ trace_mkdir(void) > } >=20 > RTE_LOG(INFO, EAL, "Trace dir: %s\n", trace->dir); > + already_done =3D true; > return 0; > } >=20 > @@ -434,6 +439,10 @@ rte_trace_save(void) > if (trace->nb_trace_mem_list =3D=3D 0) > return rc; >=20 > + rc =3D trace_mkdir(); > + if (rc < 0) > + return rc; > + > rc =3D trace_meta_save(trace); > if (rc) > return rc; [snip] > 2.37.3