From: Sunil Kumar Kori <skori@marvell.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Aman Singh <aman.deep.singh@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [EXTERNAL] Re: [PATCH 2/2] app/testpmd: clear stale internal len information
Date: Wed, 21 May 2025 05:01:57 +0000 [thread overview]
Message-ID: <CO6PR18MB386027DB3D4E6D472E32FB03B49EA@CO6PR18MB3860.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20250520141711.0b9d481f@hermes.local>
> On Mon, 19 May 2025 21:36:56 +0530
> <skori@marvell.com> wrote:
>
> > From: Sunil Kumar Kori <skori@marvell.com>
> >
> > hdr_lens is used to maintain header lengths after parsing packets.
> > When port receives different type of packets (say first is VXLAN
> > packet and second is GRE packet).
> >
> > For first packet, L2/L3/L4 lengths are set for inner and outer header
> > alongwith tunnel_len.
> >
> > Now for second packet, tunnel_len is added more than its size it
> > contains stale value which further leads to wrong header pointers.
> >
> > Hence clearing stale information before processing each packet.
> >
> > Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
>
> The initialization of hdr_lens then becomes redundant.
>
> Maybe better to just move it into the loop.
>
Yes, that will not make any difference. I will fix in next version.
next prev parent reply other threads:[~2025-05-21 5:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-19 16:06 [PATCH 1/2] net: fix offset calculation for GENEVE packet skori
2025-05-19 16:06 ` [PATCH 2/2] app/testpmd: clear stale internal len information skori
2025-05-20 21:17 ` Stephen Hemminger
2025-05-21 5:01 ` Sunil Kumar Kori [this message]
2025-05-21 5:11 ` [PATCH v2 1/2] net: fix offset calculation for GENEVE packet skori
2025-05-21 5:11 ` [PATCH v2 2/2] app/testpmd: clear stale internal len information skori
2025-05-21 9:33 ` [PATCH v2 1/2] net: fix offset calculation for GENEVE packet huangdengdui
2025-05-20 21:21 ` [PATCH " Stephen Hemminger
2025-05-21 4:57 ` [EXTERNAL] " Sunil Kumar Kori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO6PR18MB386027DB3D4E6D472E32FB03B49EA@CO6PR18MB3860.namprd18.prod.outlook.com \
--to=skori@marvell.com \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).