From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CCEFFA0C58; Tue, 30 Nov 2021 08:17:01 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B6E354068F; Tue, 30 Nov 2021 08:17:01 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 2B4F04068B for ; Tue, 30 Nov 2021 08:17:00 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1AU6xLnG004069 for ; Mon, 29 Nov 2021 23:16:58 -0800 Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2173.outbound.protection.outlook.com [104.47.58.173]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3cnf5x026b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 29 Nov 2021 23:16:58 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H0u15SFrCj14X33eiD9sei3f8sCP70EQqpncd6rieq7mi45eyTA/qomXsYBifrXT/zbubvJD8hsjjjH2mg9lynbqz2VUwTEu30AY2wmg0VZAiot+8SFbhbVH0zyZ74VKbrI8egTNSuBU2m0MdX3ycVWGpBucFgo5NNvj6WhCMc2vEd/wia3oVzHa78F2Lv2yIMhXjiN8Kufnp7mgZIu0Bg6+1HgMBKwdiCncNhAAYTH18Djz55hbfZjeOaESjUA3Ls1q9zeaq1xW6Ltw+yCVdn+XtyWpalRxo9oAR6GkOnt+ycyKUb8PkLbMw0B3j+HRNj9O5Jebc5GkDbSj5RziGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=woTpomjQQGuahStA4MzfPaVU8Pd+9XP4gD3dAx3mQIo=; b=akRzhnN3+xOGwVRZNWooc+o7WrhMDgo5JD9bwlJao8DfkJa9nCozZtzZEKXhGPzGUaGh98ZxfshFmBqrT/ElqNPpcoMTr5z3ttO7hZebI0EyvKFLerHMBYfwOn4d06RMFEacAr7uqb1SPL0j7RduzCM544Z66iI0z1niWlUycx1NQ3Bdr8e8Xf53jSXsoG5lIDIQXonjb6FVYxu46kL21Q88ny7vTa2X7kI7aIarYWVgJ34InoELmTw/JMAVINvLlDlWEguprW97oiNuH2n/mXdT2oOl1zJSoPL+xUuEVW57lHN8YpuSjuM+piPa640JmKdKogN00cFEDB3pE3AdXg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=woTpomjQQGuahStA4MzfPaVU8Pd+9XP4gD3dAx3mQIo=; b=jJjXIqECvinxqxqRhBQX53NZehRowSIlxbW+ChgmwfzCH7Msf71EV4CygNixv5KHBsgtb00qyTxUWcgnv9wxU7mOnD422o/DYtNoc7OIhHkGmSDdOGhQXmPmLJbbjfFEGvZoICmnNHBq4JHwH+T4tWOAg0479HuVfoofJj7kbM4= Received: from CO6PR18MB3860.namprd18.prod.outlook.com (2603:10b6:5:34d::12) by MW3PR18MB3561.namprd18.prod.outlook.com (2603:10b6:303:2e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.24; Tue, 30 Nov 2021 07:16:50 +0000 Received: from CO6PR18MB3860.namprd18.prod.outlook.com ([fe80::dc37:87a0:2de1:ffa0]) by CO6PR18MB3860.namprd18.prod.outlook.com ([fe80::dc37:87a0:2de1:ffa0%5]) with mapi id 15.20.4755.011; Tue, 30 Nov 2021 07:16:50 +0000 From: Sunil Kumar Kori To: Rakesh Kudurumalla , Nithin Kumar Dabilpuram , Kiran Kumar Kokkilagadda , Satha Koteswara Rao Kottidi CC: "dev@dpdk.org" , Rakesh Kudurumalla Subject: RE: [PATCH 1/2] net/cnxk: update meter bpf ID in rq Thread-Topic: [PATCH 1/2] net/cnxk: update meter bpf ID in rq Thread-Index: AQHX5bVsqRaHwKhj4kW1yG3zJEgeBKwbqQMw Date: Tue, 30 Nov 2021 07:16:50 +0000 Message-ID: References: <20211130064147.1023321-1-rkudurumalla@marvell.com> In-Reply-To: <20211130064147.1023321-1-rkudurumalla@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0d190156-d4a6-4a92-1055-08d9b3d16128 x-ms-traffictypediagnostic: MW3PR18MB3561: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2803; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: x4W8ohqCfIe8iLqr7F7xyJbVZm/iXRJqjRt+gW74EZ8ue/hml5/tFRARD1tNTv6DlFjuZJRl8yw7vJx1PajQcH7YPyc7f+WWyuyy1n72UnJ4KCfZy98cBUtaumAjbxBWlv//W+fI5FnwaOuq+hjKNmgOaKBoj/vcR3j30UmybUhqHwHF2cT5LbNr+bF+Fob+qqF6xzzwfPPaTHI8RFg+qc3PYO+NmQ+QZH+jRtl0AxHlK54kLUtLQ90tXjtHiQnw6g5NkL/sOVk9TMytYNEQ3ajMxTQkXzQH1y0wBNu4WqUPcXD4dYaMRxENV1shMcDVnh8hgAfJpak92SjJkP0xDzzQdkWiQglcOIXDYCbi0i+Q9ipxv95+MfaAwgA6gybfuZUFsBrEaLwodidb+IiWIWw1mupKiuTSWWd3C6fQNXfrUt5O7shc5GGcLrbkVmSiS/6gZ0gBPea6QDa9djlfHWIDwgI6ORj8DD7LLejyRkd7jSg1rJFgWhVL95HJzCRBx1SJhuqdYZoejd1vjkUZy6f0H8xV1khPikrLT8FnauWToRAQyAbA5mxV5KFvIfGxXHXHK74V+qoaFZBss+HhofLfy1yjY9398HyX8ieQQgkbMiqUwNoEYE5PVCnt9dqI/aEjcDjY5IIaJSs7I+GfXuQESWvQ7wdsM+FgHrc3TAOLwbslwZC8ipytqcB8zexzwkJgwmvVq3aKIJiN6umB0A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB3860.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(7696005)(8676002)(66556008)(5660300002)(86362001)(122000001)(66946007)(66446008)(71200400001)(38100700002)(66476007)(64756008)(2906002)(6506007)(8936002)(52536014)(4326008)(26005)(508600001)(33656002)(110136005)(9686003)(316002)(15650500001)(107886003)(54906003)(55016003)(76116006)(6636002)(83380400001)(186003)(38070700005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?PRln6rRLt2EX/X9/MrEEpwwkDOIx1ObvJHXUJL+HloMjQHT++8GKTa6DEunz?= =?us-ascii?Q?hAAGtZmMJzgVk9mWN5yAB02jnjsIa7f9Tj9iKBAEYeXU27cgIrsWSae4Oe7f?= =?us-ascii?Q?i4MiRGpuGi712neAyoAZaGr9TG19SCriSPRtpwzoMwixxImx04hqKLYRtGil?= =?us-ascii?Q?tnwpA9kMO0NllPs3wmfU+KSjaG8MukXv0y+Ot08HZSpiAntbNihEA+nKoc1d?= =?us-ascii?Q?KN3vl/k0X1tuQ1rwYD8ZgA2AB4BHJM03JEq5OV7TO8zblhGArOR+7z03iF8d?= =?us-ascii?Q?EaIj+SawHnIi4J28MuF6Nbup+7RLKp2TXWKiBCtwIsRTIssYPafyazHlI3f4?= =?us-ascii?Q?uy/GF5eqFTYjwvv8HPZnoVOVDsxXcgkQqZFZSGpMr8wJEMpJyOvtuiw39jpN?= =?us-ascii?Q?WQuWcdUA5AH9iPxxmiVLGPCAPp0lq3Rzw73BB++9T479AeJeoX6fCEFsGrcz?= =?us-ascii?Q?77J3FC5SPRavd1yFEAD2o74i5Xfbwx+rizomI48Fgme6/qcrDJukp1x1cIm+?= =?us-ascii?Q?Bs1kZYUVXpV2dWBD8qee7uQyGUOnquXJmfAvYZP/XIxGrbOb+po2+Oj07xDi?= =?us-ascii?Q?qyRIx5Oh/MEREWO03bjZJkr5r9+MpeCc39z2loZlu/7a9S3b5mFfhgsBxQAu?= =?us-ascii?Q?47bQhmC1Ny569s3gJNAVPi/B133YCy7IS96iSkk+iyTUVezXKJ6b43kHHDsK?= =?us-ascii?Q?YFx4otoFqI7J936gOjTVtguRSRnEA9gGcuP0xaaZjWhjLe2iljZze6daoQIa?= =?us-ascii?Q?nQIiG0N6elVugN1LhsvVdqH/vI4qUpPdUqk96iDnoDtCaLMM6auGxM/ClNv3?= =?us-ascii?Q?KqXyycIfDTFvBfx6CV0H1iMF2Op4WCX+QnQ30Wl5V5E57acUbuVI7MMSNUZf?= =?us-ascii?Q?e4LfOkMNwew4Dco7/dZq7pMIEkkiX/j7DSXqtYJ/OzFNEfumzqi253zfQSo+?= =?us-ascii?Q?CVbUn51Uc8cFRa4k0IqGhRHUprDOlbdz6cCjFoAvE8hytmezpgpk+632WlbL?= =?us-ascii?Q?vjGcUo8r7+VPC4j2EQfn0yJRhHfwerS3OthP8yG5mUlTO9mD0+4FXhGpLWS9?= =?us-ascii?Q?nw/StVmjhIDr2+bGQ/C/kUBG5GijgdYKPMIPLw6P7DtwY42yeqoDn3EKtpPp?= =?us-ascii?Q?vPjrpPAnI/cquPH48E3LvOlnnVlQj3wHXr/BLE2Ov4vDy8A8toZjge6eg7Dt?= =?us-ascii?Q?YI83vKnfb/H4HNfhrtjsBFdaP6gwau0kgJy6KEnTguLug14AfQwf5ebs+np8?= =?us-ascii?Q?my0wITzRuwwp6QO0rdo0tUOpwBsY6mlcx4rrxRJPuNm5M1Fvg2gk7aheYXcE?= =?us-ascii?Q?jxg/tmYDSt5NYKw9K2S7H4wUZ0RMiedcStSJhGfO4P5SzFKqO0jf54Wmd4td?= =?us-ascii?Q?WuOJntxWz3tRFae0GOY17AW6sIIgRqDB7ht2mV5kDUIZuCCzxNpndJYJl7BS?= =?us-ascii?Q?wjej4GIy610PEUkyAO/Y+rU/SLZzvh3t4G6mBtaXJfM7Vhj/ureI0WR9TSSY?= =?us-ascii?Q?krOo/lnAKNk4f+ecYhuwZMVPT3HqUo/IH6n5gYLK8g9uhq2ej253L5djQLNg?= =?us-ascii?Q?yisZTpTap9q9QN5zPy+fE1KC71qJLnVuTrCcn+5ufjZCg/e+0OlSW/PjzRw6?= =?us-ascii?Q?kw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB3860.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0d190156-d4a6-4a92-1055-08d9b3d16128 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Nov 2021 07:16:50.7644 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GDtbDHswE1wrD1aFGQLJ+oAus20m4ZMBfr6I7n6AezQrrMPWNRDt6uSFr9iyyXlCqRnXMrZuJPA2ZEGVkIm57Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR18MB3561 X-Proofpoint-GUID: nuOJhFBbG5Al94vgXT3h8Qki16BiAMzQ X-Proofpoint-ORIG-GUID: nuOJhFBbG5Al94vgXT3h8Qki16BiAMzQ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-11-30_05,2021-11-28_01,2020-04-07_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org >-----Original Message----- >From: Rakesh Kudurumalla >Sent: Tuesday, November 30, 2021 12:12 PM >To: Nithin Kumar Dabilpuram ; Kiran Kumar >Kokkilagadda ; Sunil Kumar Kori >; Satha Koteswara Rao Kottidi > >Cc: dev@dpdk.org; Rakesh Kudurumalla >Subject: [PATCH 1/2] net/cnxk: update meter bpf ID in rq > >Patch updates configured meter bpf is in rq context during meter creation > >Signed-off-by: Rakesh Kudurumalla >--- > drivers/net/cnxk/cn10k_rte_flow.c | 9 ++++----- >drivers/net/cnxk/cnxk_ethdev_mtr.c | 25 ++++++++++++++++++------- > 2 files changed, 22 insertions(+), 12 deletions(-) > >diff --git a/drivers/net/cnxk/cn10k_rte_flow.c >b/drivers/net/cnxk/cn10k_rte_flow.c >index b830abe63e..402bb1c72f 100644 >--- a/drivers/net/cnxk/cn10k_rte_flow.c >+++ b/drivers/net/cnxk/cn10k_rte_flow.c >@@ -36,20 +36,20 @@ cn10k_mtr_configure(struct rte_eth_dev *eth_dev, > for (i =3D 0; actions[i].type !=3D RTE_FLOW_ACTION_TYPE_END; i++) { > if (actions[i].type =3D=3D RTE_FLOW_ACTION_TYPE_METER) { > mtr_conf =3D (const struct rte_flow_action_meter >- *)(actions->conf); >+ *)(actions[i].conf); > mtr_id =3D mtr_conf->mtr_id; > is_mtr_act =3D true; > } > if (actions[i].type =3D=3D RTE_FLOW_ACTION_TYPE_QUEUE) { > q_conf =3D (const struct rte_flow_action_queue >- *)(actions->conf); >+ *)(actions[i].conf); > if (is_mtr_act) > nix_mtr_rq_update(eth_dev, mtr_id, 1, > &q_conf->index); > } > if (actions[i].type =3D=3D RTE_FLOW_ACTION_TYPE_RSS) { > rss_conf =3D (const struct rte_flow_action_rss >- *)(actions->conf); >+ *)(actions[i].conf); > if (is_mtr_act) > nix_mtr_rq_update(eth_dev, mtr_id, > rss_conf->queue_num, >@@ -98,7 +98,7 @@ cn10k_rss_action_validate(struct rte_eth_dev *eth_dev, > return -EINVAL; > } > >- if (eth_dev->data->dev_conf.rxmode.mq_mode !=3D >RTE_ETH_MQ_RX_RSS) { >+ if (eth_dev->data->dev_conf.rxmode.mq_mode !=3D ETH_MQ_RX_RSS) { > plt_err("multi-queue mode is disabled"); > return -ENOTSUP; > } >@@ -171,7 +171,6 @@ cn10k_flow_create(struct rte_eth_dev *eth_dev, const >struct rte_flow_attr *attr, > return NULL; > } > } >- > for (i =3D 0; actions[i].type !=3D RTE_FLOW_ACTION_TYPE_END; i++) { > if (actions[i].type =3D=3D RTE_FLOW_ACTION_TYPE_METER) { > mtr =3D (const struct rte_flow_action_meter *)actions[i] >diff --git a/drivers/net/cnxk/cnxk_ethdev_mtr.c >b/drivers/net/cnxk/cnxk_ethdev_mtr.c >index 39d8563826..a36fcb8aaf 100644 >--- a/drivers/net/cnxk/cnxk_ethdev_mtr.c >+++ b/drivers/net/cnxk/cnxk_ethdev_mtr.c >@@ -35,7 +35,6 @@ static struct rte_mtr_capabilities mtr_capa =3D { > .chaining_n_mtrs_per_flow_max =3D NIX_MTR_COUNT_PER_FLOW, > .chaining_use_prev_mtr_color_supported =3D true, > .chaining_use_prev_mtr_color_enforced =3D true, >- .meter_rate_max =3D NIX_BPF_RATE_MAX / 8, /* Bytes per second */ > .color_aware_srtcm_rfc2697_supported =3D true, > .color_aware_trtcm_rfc2698_supported =3D true, > .color_aware_trtcm_rfc4115_supported =3D true, @@ -180,20 +179,20 >@@ cnxk_nix_mtr_capabilities_get(struct rte_eth_dev *dev, > struct rte_mtr_capabilities *capa, > struct rte_mtr_error *error) > { >- struct cnxk_eth_dev *eth_dev =3D cnxk_eth_pmd_priv(dev); >- uint16_t count[ROC_NIX_BPF_LEVEL_MAX] =3D {0}; > uint8_t lvl_mask =3D ROC_NIX_BPF_LEVEL_F_LEAF | >ROC_NIX_BPF_LEVEL_F_MID | > ROC_NIX_BPF_LEVEL_F_TOP; >+ struct cnxk_eth_dev *eth_dev =3D cnxk_eth_pmd_priv(dev); >+ uint16_t count[ROC_NIX_BPF_LEVEL_MAX] =3D {0}; > struct roc_nix *nix =3D ð_dev->nix; >- int rc; >- int i; >+ uint32_t time_unit; >+ int rc, i; > > RTE_SET_USED(dev); > > if (!capa) > return -rte_mtr_error_set(error, EINVAL, >- RTE_MTR_ERROR_TYPE_MTR_PARAMS, NULL, >- "NULL input parameter"); >+ >RTE_MTR_ERROR_TYPE_MTR_PARAMS, NULL, >+ "NULL input parameter"); > > rc =3D roc_nix_bpf_count_get(nix, lvl_mask, count); > if (rc) >@@ -207,6 +206,15 @@ cnxk_nix_mtr_capabilities_get(struct rte_eth_dev >*dev, > mtr_capa.meter_trtcm_rfc4115_n_max =3D mtr_capa.n_max; > mtr_capa.meter_policy_n_max =3D mtr_capa.n_max; > >+ rc =3D roc_nix_bpf_timeunit_get(nix, &time_unit); >+ if (rc) >+ return rc; >+ >+ mtr_capa.meter_rate_max =3D >+ NIX_BPF_RATE(time_unit, NIX_BPF_MAX_RATE_EXPONENT, >+ NIX_BPF_MAX_RATE_MANTISSA, 0) / >+ 8; >+ > *capa =3D mtr_capa; > return 0; > } >@@ -304,6 +312,9 @@ cnxk_nix_mtr_policy_validate(struct rte_eth_dev >*dev, > if (action->type =3D=3D >RTE_FLOW_ACTION_TYPE_DROP) > supported[i] =3D true; > >+ if (action->type =3D=3D >RTE_FLOW_ACTION_TYPE_VOID) >+ supported[i] =3D true; >+ > if (!supported[i]) { > sprintf(message, > "%s action is not valid", >-- >2.25.1 Acked-by: Sunil Kumar Kori