From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D5B1C43691; Wed, 6 Dec 2023 17:19:29 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7BAE74029C; Wed, 6 Dec 2023 17:19:29 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 1F6A04021E for ; Wed, 6 Dec 2023 17:19:27 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3B6EtlPI022748; Wed, 6 Dec 2023 08:19:27 -0800 Received: from nam02-dm3-obe.outbound.protection.outlook.com (mail-dm3nam02lp2040.outbound.protection.outlook.com [104.47.56.40]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3utu530agg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 06 Dec 2023 08:19:27 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WyfQ2gRsScqhnT1WyAsVCu9YyfFKOPBesTjBPYbzjswfEarRPs7tVzJrJiVbqnpQtsWddNENIXj7rvKDjjDBbq9GZEFHubIEh3VlQlnXIISH4gNPjOvRED07if1Zlkoxh2YwCCtTZyE93WpI+ZOrDylynGIksx+D2FcGZOolZpVmukCGMUMygFvRSSioG4L8sBGbmHhEgco1YC/sWoBnO9pxqdqEGhnRCMZWtFx8DslZLkQIY5jA1UvlJR2i7RljK/9YOKLRyCIJ34pIe9eGDqzqPS2Fpaj2gYfsYfu0UzZrcm82PcV8y20CsGaDo1YlqLkelUTmGsW1iWv1qc525g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TE3cwpczUWgmh1yejj3vijOHVgbKQAFw7ld0SvTqk8c=; b=Jy67QMiFTDBWeXmIAl+pxq6mGp7T0MO0oDAtZDiTaP1mm3U7YIW4yEtzKM76Puo7eF470rjIPLg1tP9dRUHv4n7bHsXSYn98n/yex2iyal46WKHorO3xuL8i06UcN96YERoWrSiZlMtj5ifTajS0c+bRy6EbGoKZrEqRifagau3onRmJIFmBippGKjPoDIub3M5heN0rI2Be9ZAReey1SbtNXY+6DMQl3sVl9SkvyJIvIhqAUpjYHoKch4P8iHIFyvJ0vTuW+vINcwKJVRbG+Q+hXXq3aW/RI5w5F7nrtTvpEI6TTsxEp43EfsEWLBUbthjJN7CIfdDFE6+z+D7sNQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TE3cwpczUWgmh1yejj3vijOHVgbKQAFw7ld0SvTqk8c=; b=G6T3roPnLYvvNBYH71pKVg2T/tDsG2Yi5rePWXdMMd6Ixhufwnsc8WpQP0zQEGU3aB2TUBT1z/j63YHXrGUGsM1ebQPkAbRzakYcHLBnOddivCe7hOGv0DwGZEBZoAbCUoZ3J/I9uhXjj9wUdmOsF+0h5GYFK9DRtXev+r+4ua4= Received: from CO6PR18MB3860.namprd18.prod.outlook.com (2603:10b6:5:34d::12) by PH0PR18MB3989.namprd18.prod.outlook.com (2603:10b6:510:20::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.25; Wed, 6 Dec 2023 16:19:24 +0000 Received: from CO6PR18MB3860.namprd18.prod.outlook.com ([fe80::102c:7050:7665:d46f]) by CO6PR18MB3860.namprd18.prod.outlook.com ([fe80::102c:7050:7665:d46f%3]) with mapi id 15.20.7068.025; Wed, 6 Dec 2023 16:19:24 +0000 From: Sunil Kumar Kori To: Bruce Richardson CC: "dev@dpdk.org" , "david.marchand@redhat.com" Subject: RE: [EXT] [PATCH 1/3] buildtools/dpdk-cmdline-gen: support optional parameters Thread-Topic: [EXT] [PATCH 1/3] buildtools/dpdk-cmdline-gen: support optional parameters Thread-Index: AQHaJ4qFvq/G/B+APES9WkbWdPtfz7Cb2XUAgABoHgCAACvwYA== Date: Wed, 6 Dec 2023 16:19:24 +0000 Message-ID: References: <20231205145109.1000464-1-bruce.richardson@intel.com> <20231205145109.1000464-2-bruce.richardson@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-dg-rorf: true x-dg-ref: =?us-ascii?Q?PG1ldGE+PGF0IG5tPSJib2R5LnR4dCIgcD0iYzpcdXNlcnNcc2tvcmlcYXBw?= =?us-ascii?Q?ZGF0YVxyb2FtaW5nXDA5ZDg0OWI2LTMyZDMtNGE0MC04NWVlLTZiODRiYTI5?= =?us-ascii?Q?ZTM1Ylxtc2dzXG1zZy0zNjUzNDI3OS05NDUzLTExZWUtYjZkOS0zY2UxYTE0?= =?us-ascii?Q?ZTkzZDBcYW1lLXRlc3RcMzY1MzQyN2EtOTQ1My0xMWVlLWI2ZDktM2NlMWEx?= =?us-ascii?Q?NGU5M2QwYm9keS50eHQiIHN6PSI4MTEyIiB0PSIxMzM0NjM1MzE2MjIwMjIy?= =?us-ascii?Q?NzAiIGg9InRobldhT0g2UldxejlxaGFHZEVrRk92V0k3Zz0iIGlkPSIiIGJs?= =?us-ascii?Q?PSIwIiBibz0iMSIgY2k9ImNBQUFBRVJIVTFSU1JVRk5DZ1VBQUJnV0FBQit2?= =?us-ascii?Q?TXo0WHlqYUFlb01OTGwyVkZ3WTZndzB1WFpVWEJnWkFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFIQUFBQUJ1RHdBQTNnOEFBRG9HQUFBQUFBQUFBQUFBQUFF?= =?us-ascii?Q?QUFRRUJBQUFBOVJlbkx3Q0FBUUFBQUFBQUFBQUFBSjRBQUFCaEFHUUFaQUJ5?= =?us-ascii?Q?QUdVQWN3QnpBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUVB?= =?us-ascii?Q?QUFBQUFBQUFBZ0FBQUFBQW5nQUFBR01BZFFCekFIUUFid0J0QUY4QWNBQmxB?= =?us-ascii?Q?SElBY3dCdkFHNEFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQXdBQUFBQUFBQUFBQUFBQUFRQUFBQUFBQUFBQ0FBQUFB?= =?us-ascii?Q?QUNlQUFBQVl3QjFBSE1BZEFCdkFHMEFYd0J3QUdnQWJ3QnVBR1VBYmdCMUFH?= =?us-ascii?Q?MEFZZ0JsQUhJQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFCQUFBQUFBQUFBQUlBQUFBQUFKNEFBQUJqQUhVQWN3?= =?us-ascii?Q?QjBBRzhBYlFCZkFITUFjd0J1QUY4QVpBQmhBSE1BYUFCZkFIWUFNQUF5QUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-refone: =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBRUFBQUFBQUFBQUFnQUFBQUFBbmdBQUFHTUFk?= =?us-ascii?Q?UUJ6QUhRQWJ3QnRBRjhBY3dCekFHNEFYd0JyQUdVQWVRQjNBRzhBY2dCa0FI?= =?us-ascii?Q?TUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQVFBQUFBQUFBQUFDQUFBQUFBQ2VBQUFBWXdCMUFITUFkQUJ2QUcwQVh3?= =?us-ascii?Q?QnpBSE1BYmdCZkFHNEFid0JrQUdVQWJBQnBBRzBBYVFCMEFHVUFjZ0JmQUhZ?= =?us-ascii?Q?QU1BQXlBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUJBQUFBQUFBQUFB?= =?us-ascii?Q?SUFBQUFBQUo0QUFBQmpBSFVBY3dCMEFHOEFiUUJmQUhNQWN3QnVBRjhBY3dC?= =?us-ascii?Q?d0FHRUFZd0JsQUY4QWRnQXdBRElBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFFQUFBQUFBQUFBQWdBQUFBQUFuZ0FBQUdR?= =?us-ascii?Q?QWJBQndBRjhBY3dCckFIa0FjQUJsQUY4QVl3Qm9BR0VBZEFCZkFHMEFaUUJ6?= =?us-ascii?Q?QUhNQVlRQm5BR1VBWHdCMkFEQUFNZ0FBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBUUFBQUFBQUFBQUNBQUFBQUFDZUFBQUFaQUJzQUhBQVh3QnpBR3dB?= =?us-ascii?Q?WVFCakFHc0FYd0JqQUdnQVlRQjBBRjhBYlFCbEFITUFjd0JoQUdjQVpRQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-reftwo: =?us-ascii?Q?QUFBQUFBQUFBQkFBQUFBQUFBQUFJQUFBQUFBSjRBQUFCa0FHd0FjQUJmQUhR?= =?us-ascii?Q?QVpRQmhBRzBBY3dCZkFHOEFiZ0JsQUdRQWNnQnBBSFlBWlFCZkFHWUFhUUJz?= =?us-ascii?Q?QUdVQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUVBQUFB?= =?us-ascii?Q?QUFBQUFBZ0FBQUFBQW5nQUFBR1VBYlFCaEFHa0FiQUJmQUdFQVpBQmtBSElB?= =?us-ascii?Q?WlFCekFITUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQ2dBQUFBQUFBQUFBQUFBQUFRQUFBQUFBQUFBQ0FBQUFBQUNl?= =?us-ascii?Q?QUFBQWJRQmhBSElBZGdCbEFHd0FYd0J3QUhJQWJ3QnFBR1VBWXdCMEFGOEFi?= =?us-ascii?Q?Z0JoQUcwQVpRQnpBRjhBWXdCdkFHNEFaZ0JwQUdRQVpRQnVBSFFBYVFCaEFH?= =?us-ascii?Q?d0FYd0JoQUd3QWJ3QnVBR1VBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFCQUFBQUFBQUFBQUlBQUFBQUFKNEFBQUJ0QUdFQWNnQjJB?= =?us-ascii?Q?R1VBYkFCZkFIQUFjZ0J2QUdvQVpRQmpBSFFBWHdCdUFHRUFiUUJsQUhNQVh3?= =?us-ascii?Q?QnlBR1VBY3dCMEFISUFhUUJqQUhRQVpRQmtBRjhBWVFCc0FHOEFiZ0JsQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBRUFB?= =?us-ascii?Q?QUFBQUFBQUFnQUFBQUFBbmdBQUFHMEFZUUJ5QUhZQVpRQnNBRjhBY0FCeUFH?= =?us-ascii?Q?OEFhZ0JsQUdNQWRBQmZBRzRBWVFCdEFHVUFjd0JmQUhJQVpRQnpBSFFBY2dC?= =?us-ascii?Q?cEFHTUFkQUJsQUdRQVh3Qm9BR1VBZUFCakFHOEFaQUJsQUhNQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQVFBQUFBQUFBQUFDQUFBQUFB?= =?us-ascii?Q?Q2VBQUFBYlFCaEFISUFkZ0JsQUd3QWJBQmZBR0VBY2dCdEFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-refthree: =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUJBQUFBQUFBQUFBSUFB?= =?us-ascii?Q?QUFBQUo0QUFBQnRBR0VBY2dCMkFHVUFiQUJzQUY4QVp3QnZBRzhBWndCc0FH?= =?us-ascii?Q?VUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFFQUFBQUFBQUFBQWdBQUFBQUFuZ0FBQUcwQVlR?= =?us-ascii?Q?QnlBSFlBWlFCc0FHd0FYd0J3QUhJQWJ3QnFBR1VBWXdCMEFGOEFZd0J2QUdR?= =?us-ascii?Q?QVpRQnpBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBUUFBQUFBQUFBQUNBQUFBQUFDZUFBQUFiUUJoQUhJQWRnQmxBR3dBYkFC?= =?us-ascii?Q?ZkFIQUFjZ0J2QUdvQVpRQmpBSFFBWHdCakFHOEFaQUJsQUhNQVh3QmtBR2tB?= =?us-ascii?Q?WXdCMEFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQkFBQUFBQUFBQUFJ?= =?us-ascii?Q?QUFBQUFBSjRBQUFCdEFHRUFjZ0IyQUdVQWJBQnNBRjhBY0FCeUFHOEFhZ0Js?= =?us-ascii?Q?QUdNQWRBQmZBRzRBWVFCdEFHVUFjd0JmQUdNQWJ3QnVBR1lBYVFCa0FHVUFi?= =?us-ascii?Q?Z0IwQUdrQVlRQnNBRjhBYlFCaEFISUFkZ0JsQUd3QWJBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUVBQUFBQUFBQUFBZ0FBQUFBQW5nQUFBRzBB?= =?us-ascii?Q?WVFCeUFIWUFaUUJzQUd3QVh3QndBSElBYndCcUFHVUFZd0IwQUY4QWJnQmhB?= =?us-ascii?Q?RzBBWlFCekFGOEFZd0J2QUc0QVpnQnBBR1FBWlFCdUFIUUFhUUJoQUd3QVh3?= =?us-ascii?Q?QnRBR0VBY2dCMkFHVUFiQUJzQUY4QWJ3QnlBRjhBWVFCeUFHMEFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-reffour: =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFRQUFBQUFBQUFBQ0FBQUFBQUNlQUFB?= =?us-ascii?Q?QWJRQmhBSElBZGdCbEFHd0FiQUJmQUhBQWNnQnZBR29BWlFCakFIUUFYd0J1?= =?us-ascii?Q?QUdFQWJRQmxBSE1BWHdCakFHOEFiZ0JtQUdrQVpBQmxBRzRBZEFCcEFHRUFi?= =?us-ascii?Q?QUJmQUcwQVlRQnlBSFlBWlFCc0FHd0FYd0J2QUhJQVh3Qm5BRzhBYndCbkFH?= =?us-ascii?Q?d0FaUUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFCQUFBQUFBQUFBQUlBQUFBQUFKNEFBQUJ0QUdFQWNnQjJBR1VB?= =?us-ascii?Q?YkFCc0FGOEFjQUJ5QUc4QWFnQmxBR01BZEFCZkFHNEFZUUJ0QUdVQWN3QmZB?= =?us-ascii?Q?SElBWlFCekFIUUFjZ0JwQUdNQWRBQmxBR1FBWHdCdEFHRUFjZ0IyQUdVQWJB?= =?us-ascii?Q?QnNBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBRUFBQUFB?= =?us-ascii?Q?QUFBQUFnQUFBQUFBbmdBQUFHMEFZUUJ5QUhZQVpRQnNBR3dBWHdCd0FISUFi?= =?us-ascii?Q?d0JxQUdVQVl3QjBBRjhBYmdCaEFHMEFaUUJ6QUY4QWNnQmxBSE1BZEFCeUFH?= =?us-ascii?Q?a0FZd0IwQUdVQVpBQmZBRzBBWVFCeUFIWUFaUUJzQUd3QVh3QnZBSElBWHdC?= =?us-ascii?Q?aEFISUFiUUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQVFBQUFBQUFBQUFDQUFBQUFBQ2VB?= =?us-ascii?Q?QUFBYlFCaEFISUFkZ0JsQUd3QWJBQmZBSFFBWlFCeUFHMEFhUUJ1QUhVQWN3?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUJBQUFBQUFBQUFBSUFBQUFBQUo0QUFBQnRBR0VBY2dCMkFH?= =?us-ascii?Q?VUFiQUJzQUY4QWR3QnZBSElBWkFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFFQUFB?= =?us-ascii?Q?QUFBQUFBQWdBQUFBQUFPZ1lBQUFBQUFBQUlBQUFBQUFBQUFBZ0FBQUFBQUFB?= =?us-ascii?Q?QUNBQUFBQUFBQUFBYUJnQUFHUUFBQUJnQUFB?= x-dg-reffive: =?us-ascii?Q?QUFBQUFBWVFCa0FHUUFjZ0JsQUhNQWN3QUFBQ1FBQUFBREFBQUFZd0IxQUhN?= =?us-ascii?Q?QWRBQnZBRzBBWHdCd0FHVUFjZ0J6QUc4QWJnQUFBQzRBQUFBQUFBQUFZd0Ix?= =?us-ascii?Q?QUhNQWRBQnZBRzBBWHdCd0FHZ0Fid0J1QUdVQWJnQjFBRzBBWWdCbEFISUFB?= =?us-ascii?Q?QUF3QUFBQUFBQUFBR01BZFFCekFIUUFid0J0QUY4QWN3QnpBRzRBWHdCa0FH?= =?us-ascii?Q?RUFjd0JvQUY4QWRnQXdBRElBQUFBd0FBQUFBQUFBQUdNQWRRQnpBSFFBYndC?= =?us-ascii?Q?dEFGOEFjd0J6QUc0QVh3QnJBR1VBZVFCM0FHOEFjZ0JrQUhNQUFBQStBQUFB?= =?us-ascii?Q?QUFBQUFHTUFkUUJ6QUhRQWJ3QnRBRjhBY3dCekFHNEFYd0J1QUc4QVpBQmxB?= =?us-ascii?Q?R3dBYVFCdEFHa0FkQUJsQUhJQVh3QjJBREFBTWdBQUFESUFBQUFBQUFBQVl3?= =?us-ascii?Q?QjFBSE1BZEFCdkFHMEFYd0J6QUhNQWJnQmZBSE1BY0FCaEFHTUFaUUJmQUhZ?= =?us-ascii?Q?QU1BQXlBQUFBUGdBQUFBQUFBQUJrQUd3QWNBQmZBSE1BYXdCNUFIQUFaUUJm?= =?us-ascii?Q?QUdNQWFBQmhBSFFBWHdCdEFHVUFjd0J6QUdFQVp3QmxBRjhBZGdBd0FESUFB?= =?us-ascii?Q?QUEyQUFBQUFBQUFBR1FBYkFCd0FGOEFjd0JzQUdFQVl3QnJBRjhBWXdCb0FH?= =?us-ascii?Q?RUFkQUJmQUcwQVpRQnpBSE1BWVFCbkFHVUFBQUE0QUFBQUFBQUFBR1FBYkFC?= =?us-ascii?Q?d0FGOEFkQUJsQUdFQWJRQnpBRjhBYndCdUFHVUFaQUJ5QUdrQWRnQmxBRjhB?= =?us-ascii?Q?WmdCcEFHd0FaUUFBQUNRQUFBQUtBQUFBWlFCdEFHRUFhUUJzQUY4QVlRQmtB?= =?us-ascii?Q?R1FBY2dCbEFITUFjd0FBQUZnQUFBQUFBQUFBYlFCaEFISUFkZ0JsQUd3QVh3?= =?us-ascii?Q?QndBSElBYndCcUFHVUFZd0IwQUY4QWJnQmhBRzBBWlFCekFGOEFZd0J2QUc0?= =?us-ascii?Q?QVpnQnBBR1FBWlFCdUFIUUFhUUJoQUd3QVh3QmhBR3dBYndCdUFHVUFBQUJV?= =?us-ascii?Q?QUFBQUFBQUFBRzBBWVFCeUFIWUFaUUJzQUY4QWNBQnlBRzhBYWdCbEFHTUFk?= =?us-ascii?Q?QUJmQUc0QVlRQnRBR1VBY3dCZkFISUFaUUJ6QUhRQWNnQnBBR01BZEFCbEFH?= =?us-ascii?Q?UUFYd0JoQUd3QWJ3QnVBR1VBQUFCYUFBQUFBQUFBQUcwQVlRQnlBSFlBWlFC?= =?us-ascii?Q?c0FGOEFjQUJ5QUc4QWFnQmxBR01BZEFCZkFHNEFZUUJ0QUdVQWN3QmZBSElB?= =?us-ascii?Q?WlFCekFIUUFjZ0JwQUdNQWRBQmxBR1FBWHdCb0FHVUFlQUJqQUc4QVpBQmxB?= =?us-ascii?Q?SE1BQUFBZ0FBQUFBQUFBQUcwQVlRQnlBSFlBWlFCc0FHd0FYd0JoQUhJQWJR?= =?us-ascii?Q?QUFBQ1lBQUFBQUFBQUFiUUJoQUhJQWRnQmxBR3dBYkFCZkFHY0Fid0J2QUdj?= =?us-ascii?Q?QWJBQmxBQUFBTkFBQUFBQUFBQUJ0QUdFQWNn?= x-dg-refsix: =?us-ascii?Q?QjJBR1VBYkFCc0FGOEFjQUJ5QUc4QWFnQmxBR01BZEFCZkFHTUFid0JrQUdV?= =?us-ascii?Q?QWN3QUFBRDRBQUFBQUFBQUFiUUJoQUhJQWRnQmxBR3dBYkFCZkFIQUFjZ0J2?= =?us-ascii?Q?QUdvQVpRQmpBSFFBWHdCakFHOEFaQUJsQUhNQVh3QmtBR2tBWXdCMEFBQUFY?= =?us-ascii?Q?Z0FBQUFBQUFBQnRBR0VBY2dCMkFHVUFiQUJzQUY4QWNBQnlBRzhBYWdCbEFH?= =?us-ascii?Q?TUFkQUJmQUc0QVlRQnRBR1VBY3dCZkFHTUFid0J1QUdZQWFRQmtBR1VBYmdC?= =?us-ascii?Q?MEFHa0FZUUJzQUY4QWJRQmhBSElBZGdCbEFHd0FiQUFBQUd3QUFBQUFBQUFB?= =?us-ascii?Q?YlFCaEFISUFkZ0JsQUd3QWJBQmZBSEFBY2dCdkFHb0FaUUJqQUhRQVh3QnVB?= =?us-ascii?Q?R0VBYlFCbEFITUFYd0JqQUc4QWJnQm1BR2tBWkFCbEFHNEFkQUJwQUdFQWJB?= =?us-ascii?Q?QmZBRzBBWVFCeUFIWUFaUUJzQUd3QVh3QnZBSElBWHdCaEFISUFiUUFBQUhJ?= =?us-ascii?Q?QUFBQUFBQUFBYlFCaEFISUFkZ0JsQUd3QWJBQmZBSEFBY2dCdkFHb0FaUUJq?= =?us-ascii?Q?QUhRQVh3QnVBR0VBYlFCbEFITUFYd0JqQUc4QWJnQm1BR2tBWkFCbEFHNEFk?= =?us-ascii?Q?QUJwQUdFQWJBQmZBRzBBWVFCeUFIWUFaUUJzQUd3QVh3QnZBSElBWHdCbkFH?= =?us-ascii?Q?OEFid0JuQUd3QVpRQUFBRm9BQUFBQUFBQUFiUUJoQUhJQWRnQmxBR3dBYkFC?= =?us-ascii?Q?ZkFIQUFjZ0J2QUdvQVpRQmpBSFFBWHdCdUFHRUFiUUJsQUhNQVh3QnlBR1VB?= =?us-ascii?Q?Y3dCMEFISUFhUUJqQUhRQVpRQmtBRjhBYlFCaEFISUFkZ0JsQUd3QWJBQUFB?= =?us-ascii?Q?R2dBQUFBQUFBQUFiUUJoQUhJQWRnQmxBR3dBYkFCZkFIQUFjZ0J2QUdvQVpR?= =?us-ascii?Q?QmpBSFFBWHdCdUFHRUFiUUJsQUhNQVh3QnlBR1VBY3dCMEFISUFhUUJqQUhR?= =?us-ascii?Q?QVpRQmtBRjhBYlFCaEFISUFkZ0JsQUd3QWJBQmZBRzhBY2dCZkFHRUFjZ0J0?= =?us-ascii?Q?QUFBQUtnQUFBQUFBQUFCdEFHRUFjZ0IyQUdVQWJBQnNBRjhBZEFCbEFISUFi?= =?us-ascii?Q?UUJwQUc0QWRRQnpBQUFBSWdBQUFBQUFBQUJ0QUdFQWNnQjJBR1VBYkFCc0FG?= =?us-ascii?Q?OEFkd0J2QUhJQVpBQUFBQT09Ii8+PC9tZXRhPg=3D=3D?= x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR18MB3860:EE_|PH0PR18MB3989:EE_ x-ms-office365-filtering-correlation-id: 74f87682-5e28-4249-d544-08dbf6771cd3 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3DtAVcDEEEglvpeZzUzBS7f5PQxveG1mMY9yNGNBdOr4l7HxWDcyxOxqgF//s2VbmJ6irf/RpFbzk6ztk6mB2s7tVCwgTD0WYTuhEo0Xkc35yx7KRQYtmM0hBHL+kZs4tJRbjBgWWyq8K9KGvw9USQqt/RG3d/WbZtteHL+M0tu4XFinWTwguGQQS6AESrpCNwVe6GB+78eyCJmHCVxblgSXEy/cZMWJtAvpzkGmze+fa2scrGKDRjpNyTgcFlnTxzQlN1AdTLSPO1JmWfa7rFDXbdujMe98UXvoqLvkdCtyNOt/V9SkUi3yYsY+TlE89BA3uyKNkEAqXd0NKsXuUMhANzitUOb4EW9R6UFN/JVZBqoY6NMY82Wc4ACueqon0Umx6dF5XsUmR0zJ4mPnEcsjykBygOSE2Heo0SkuKLG0JJPpZaQzYLWMyhGN2JPreuLIUOAjGGqEGj+eUnDK83GX0YyXD2m9SYH0rhdmnXyGKCgrXMIEZNxYc1YVsuSv8d5ZThIrx3jsGORKjrOpgnqzO6lkIcZwtgCQIacWKLUpaccmVLLkuAJIo19tiswDH4FW3kwXRNKfUhM8jemMTaXGLhHS0AL5myjku8hzpVbVkmm3maEMYj6UkftTLh2Vz/Ounvg7F4zHyV9tzA8sOIXsOaAvpus1P7jPDAxy+D0= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB3860.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(376002)(346002)(39860400002)(136003)(396003)(230173577357003)(230922051799003)(230273577357003)(64100799003)(1800799012)(186009)(451199024)(122000001)(38100700002)(41300700001)(86362001)(55016003)(33656002)(83380400001)(7696005)(9686003)(38070700009)(53546011)(71200400001)(6506007)(2906002)(8936002)(8676002)(478600001)(316002)(54906003)(52536014)(26005)(76116006)(4326008)(5660300002)(66946007)(66446008)(66556008)(64756008)(6916009)(66476007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?v4/TyHXr26tOEKNoMvG8y/QBc0tgcgj4IxLXyRLIkMi5qXN1zYGO20Jown9U?= =?us-ascii?Q?7ULFOgqTsuLstnyYd13DBQFPWbLKTG7Xbkw/1eQb1fh7Do/V7fG5pBa7SDJT?= =?us-ascii?Q?7vQ10JwQ/ouOcpjdTa/G3caYgfIFFm7YEngg/6eN2d7vEghfkAZ/YhBP80x1?= =?us-ascii?Q?2/T5R/D1oFwhlVCrE8TZ1zcrMHJ6qBHp8r8prQ6bQfbMhrMrBWRVyWBdn+gL?= =?us-ascii?Q?9PD6j+VMKioN0HiQMTkqUpY8/Szc/568ZA1QhDzo3eBqMKWY2io2wXIGbCaR?= =?us-ascii?Q?y1KGDtvfmqEbrGHrH0RupXP+Gqenv02/uCiSTZn6QvHQn8a41GS0kbrDrNmz?= =?us-ascii?Q?i2JaBUe+jkYi8U0jkwVZJv7j5jvG8OKyZaRhUjumdDbI+gOOCFb67bbApCoE?= =?us-ascii?Q?k15qPDzDBP6AUqDObyBz+D7kLTV8S7SrGxYY8bXD0urasDSMYDBzYVSRy7Q8?= =?us-ascii?Q?dv1aAo7/1MeN3rtLc3dIp/v6g2o05il5MUH3O3gzHUqykyUdZksnowPTCxKM?= =?us-ascii?Q?RQkLMT+wzfQyAEhU/CGygTyOiiLoM7ou6Y16rPzjfnBHHgCOpXGJPvy9YvhB?= =?us-ascii?Q?ExkL20tYFIpE1mYvauxAO6I9zqrgTKSnkuVofVcx8xmnGp+wcP9vylDCwOKh?= =?us-ascii?Q?bgfflAJx13skSZmzCsZpYEJeOHoMK5ZdD67to5cmII/0iCoq9m8F//J+7hp1?= =?us-ascii?Q?CauPloxLoG7+rwk6cd8e89FDHya9MZt4Ccq07rlvpGIpFssvt4ykLPb59IdY?= =?us-ascii?Q?L+kLjRSho8EMJ1WklH2RZR7kBDQcI3MNVcnVHRRI6z6yrTB0IU8cbzYhAelZ?= =?us-ascii?Q?1Z4LGWTUOjvzvkLsywQXkS66s9t25iemoXe7Drygz1oakhwf+UjIbX0Eu7qx?= =?us-ascii?Q?EVILUMnvKI6QX78HdWsmtcaJvIeUT4aSi97JfdKeoTvXuuHygY5miE+r/N2g?= =?us-ascii?Q?WdopC7no89vM7dFgdVELpdEaGsb/3gQFxiqsV3bxKJDesNr+W4WT3Z78xBRf?= =?us-ascii?Q?yf4A/i+sb5yuW8lf+SHsJkZkeAlXT5EYW3/gSA4XTDmFwIlu5w6bx4VSdVVx?= =?us-ascii?Q?nrtDp+1q61KOFGiXLE9lL4sO9TuJ87ag9wZ1zQ9cs+tOtSi9FJz1V7YppA1q?= =?us-ascii?Q?hhE7YVPQoYoCRfxkpEBc0hS2oNRumQWu9CQX9MBgqc+nlAGyBInnBwNWUglf?= =?us-ascii?Q?v+2KOlABhT39UBP7HtHb/AxCD3Mr8PDJXwEP1kF6IEnbCnUQ0fq7mP9T8voA?= =?us-ascii?Q?kLe3v1KjT/OLQLAwCAfiyYMESMBgKvoI9ZWzu/SEM4OgHPEQj+mDmYDd/eLQ?= =?us-ascii?Q?qtFOw7MFxQyplVWnuzZ5fanexaz+COrsiBAjFcyDNlnriHOxlRQtVrdzcakX?= =?us-ascii?Q?7wwgLF9a76l3r3mfoexd6V97KEpeZeH2nwzCH8rQQsTAMKBn+7U7dAutcC0Z?= =?us-ascii?Q?fTtDH1N1VmIapwG1UWqiwClC8/Cjwif8h2gOh8ttJdvokorhSR8wf3setPNL?= =?us-ascii?Q?hOVJ2SQ3pwfNcQO7na8222d0QnzNUtbN0y7QUjBD3L41+AQoFZudgiyx7SZ8?= =?us-ascii?Q?WuRvBlNUsaD/ftaxk4k=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB3860.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 74f87682-5e28-4249-d544-08dbf6771cd3 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Dec 2023 16:19:24.7764 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: c5aSUTSLcS6GDfoYBgmxHsrgWcXlkXwP9Mz3g1761Dr9/h9RmMxulHsb6mkfsqNbFylYJSAL05X/DUZ7WcWNFg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR18MB3989 X-Proofpoint-ORIG-GUID: f2GgBgtmXy9NqhYWD220uIaLyD3wLLAc X-Proofpoint-GUID: f2GgBgtmXy9NqhYWD220uIaLyD3wLLAc X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-06_14,2023-12-06_01,2023-05-22_02 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Bruce Richardson > Sent: Wednesday, December 6, 2023 7:00 PM > To: Sunil Kumar Kori > Cc: dev@dpdk.org; david.marchand@redhat.com > Subject: Re: [EXT] [PATCH 1/3] buildtools/dpdk-cmdline-gen: support > optional parameters >=20 > On Wed, Dec 06, 2023 at 07:23:51AM +0000, Sunil Kumar Kori wrote: > > > -----Original Message----- > > > From: Bruce Richardson > > > Sent: Tuesday, December 5, 2023 8:21 PM > > > To: dev@dpdk.org > > > Cc: Sunil Kumar Kori ; > david.marchand@redhat.com; > > > Bruce Richardson > > > Subject: [EXT] [PATCH 1/3] buildtools/dpdk-cmdline-gen: support > > > optional parameters > > > > > > External Email > > > > > > -------------------------------------------------------------------- > > > -- Sometimes a user may want to have a command which takes an > > > optional parameter. For commands with an optional constant string, > > > this is no issue, as it can be configured as two separate commands, > > > e.g. > > > > > > start > > > start tx_first. > > > > > > However, if we want to have a variable parameter on the command, we > > > hit issues, because variable tokens do not form part of the > > > generated command names used for function and result-struct naming. > > > To avoid duplicate name issues, we add a special syntax to allow the > > > user to indicate that a particular variable parameter should be > > > included in the name. Any leading variable names starting with a > > > "__" will be included in command naming. > > > > > > This then allows us to have: > > > > > > start > > > start tx_first > > > start tx_first __n > > > > > > without hitting any naming conflicts. > > > > > It's a good option provided to user to choose name as per the need. I h= ave > another thought that how about providing flexibility to skip a token too = along > with implemented support. > > Consider following example: > > 1. ethdev dev mtu size > > 2. ethdev dev promiscuous <(on,off)>enable > > > > So tokens and functions should be as cmd_ethdev_mtu_parsed() and > cmd_ethdev_ promiscuous_parsed(). > > Here token dev should be skipped. If it make sense, then > please add this support too. > > > It does and at the same time it doesn't. :-) >=20 > I understand how what you suggest would indeed lead to better function > names. However, given that these are functions for cmdline, and unlikely = to > be ever called from regular code, how much does the function name > matter, so long as it doesn't conflict with anything else? It was the avo= iding > name conflicts, more so than having better names, was the driving force f= or > this patch. >=20 > In the case you describe, if we take this patch, we can change "dev" to > "__dev" to give you the functions: cmd_ethdev_dev_mtu_parsed() and > cmd_ethdev_dev_promiscuous_parsed(). The extra "dev" is a little untidy, > but then again if app isn't ever calling this directly, does it really ma= tter? >=20 > If we do want to have precise control over what the functions are called, > rather than adding in lots of different tweak rules, I would instead look= to > see if there is some syntax we could use to specify directly the name to = be > used for the function and result structs. However, right now, I'd rather = not > implement this, as I'm not sure how to do so in a clean way. >=20 Agreed that functions are not going to be called from application directly. I mentioned this requirement as in name cmd_ethdev_dev_promiscuous_parsed() "ethdev" is enough to describe it's role. Unnecessarily "dev" is added. In future, If you get time to look into and it improves something then plea= se have a look. Rest looks okay. So giving ack.=20 Acked-by: Sunil Kumar Kori > /Bruce