RE: [EXTERNAL] Re: [PATCH v2 1/2] net: fix offset calculation for GENEVE packet

[Sunil Kumar Kori <skori@marvell.com>]

> > diff --git a/lib/net/rte_net.c b/lib/net/rte_net.c index
> > be24690fdf..1264f33d61 100644
> > --- a/lib/net/rte_net.c
> > +++ b/lib/net/rte_net.c
> > @@ -251,7 +251,8 @@ ptype_tunnel_with_udp(uint16_t *proto, const struct
> rte_mbuf *m,
> >  		if (unlikely(gnh == NULL))
> >  			return 0;
> >  		geneve_len = sizeof(*gnh) + gnh->opt_len * 4;
> > -		*off = geneve_len;
> > +		*off += geneve_len;
> > +		hdr_lens->inner_l2_len = sizeof(struct rte_udp_hdr) + geneve_len;
> 
> The l2_len in mbuf is also calculated from the outer L4 header, so it is calculated
> in the same way here.
> However, this is easy to be misunderstood, can we add a note to inner_l2_len as
> follows?
> 
> struct rte_net_hdr_lens {
> 	uint8_t l2_len;
> 	/* Outer_L4_len + ... + inner L2_len for tunneling pkt. */
> 	uint8_t inner_l2_len;
> 	uint16_t l3_len;
> 	uint16_t inner_l3_len;
> 	uint16_t tunnel_len;
> 	uint8_t l4_len;
> 	uint8_t inner_l4_len;
> };
> 
IMO, adding documentation should not be an issue and if you feel then please add into your mentioned series.
Other than this, if you find this patch okay then please ack.