RE: [EXTERNAL] Re: [PATCH v2 1/2] ethdev: remove unnecessary type conversion

[Sunil Kumar Kori <skori@marvell.com>]

[-- Attachment #1: Type: text/plain, Size: 5619 bytes --]

Hi Stephen,

I will take care of it and resubmit.

Thanks
Sunil Kumar Kori

From: Stephen Hemminger <stephen@networkplumber.org>
Sent: Tuesday, July 29, 2025 9:59 AM
To: Sunil Kumar Kori <skori@marvell.com>
Cc: Shepard Siegel <shepard.siegel@atomicrules.com>; Ed Czeck <ed.czeck@atomicrules.com>; John Miller <john.miller@atomicrules.com>; Igor Russkikh <irusskikh@marvell.com>; Ajit Khaparde <ajit.khaparde@broadcom.com>; Somnath Kotur <somnath.kotur@broadcom.com>; Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>; Kiran Kumar Kokkilagadda <kirankumark@marvell.com>; Satha Koteswara Rao Kottidi <skoteshwar@marvell.com>; Harman Kalra <hkalra@marvell.com>; Hemant Agrawal <hemant.agrawal@nxp.com>; Sachin Saxena <sachin.saxena@nxp.com>; John Daley <johndale@cisco.com>; Hyong Youb Kim <hyonkim@cisco.com>; Jie Hai <haijie1@huawei.com>; Ian Stokes <ian.stokes@intel.com>; Bruce Richardson <bruce.richardson@intel.com>; Vladimir Medvedkin <vladimir.medvedkin@intel.com>; Anatoly Burakov <anatoly.burakov@intel.com>; Dariusz Sosnowski <dsosnowski@nvidia.com>; Viacheslav Ovsiienko <viacheslavo@nvidia.com>; Bing Zhao <bingz@nvidia.com>; Ori Kam <orika@nvidia.com>; Suanming Mou <suanmingm@nvidia.com>; Matan Azrad <matan@nvidia.com>; Long Li <longli@microsoft.com>; Wei Hu <weh@microsoft.com>; Chaoyong He <chaoyong.he@corigine.com>; Jiawen Wu <jiawenwu@trustnetic.com>; Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>; Jerin Jacob <jerinj@marvell.com>; Maciej Czekaj [C] <mczekaj@marvell.com>; Jian Wang <jianwang@trustnetic.com>; Maxime Coquelin <maxime.coquelin@redhat.com>; Chenbo Xia <chenbox@nvidia.com>; Jochen Behrens <jochen.behrens@broadcom.com>; Thomas Monjalon <thomas@monjalon.net>; Ferruh Yigit <ferruh.yigit@amd.com>; dev@dpdk.org
Subject: [EXTERNAL] Re: [PATCH v2 1/2] ethdev: remove unnecessary type conversion

On Mon, 12 May 2025 20: 37: 19 +0530 <skori@ marvell. com> wrote: > From: Sunil Kumar Kori <skori@ marvell. com> > > As rte_eth_rx_queue_count() returns signed value to represent > the error cases but internally invoked callback
ZjQcmQRYFpfptBannerStart
Prioritize security for external emails:
Confirm sender and content safety before clicking links or opening attachments
    Report Suspicious  <https://us-phishalarm-ewt.proofpoint.com/EWT/v1/CRVmXkqW!tO3Z1f8UAnU6tQ_8mZxaDpsd9S1Slu0Hp4J3JKyA7OZCT6lylV5T0yFk--SXWH2bVATYaqk7jqFo_2iyTw$>   ‌
ZjQcmQRYFpfptBannerEnd

On Mon, 12 May 2025 20:37:19 +0530

<skori@marvell.com<mailto:skori@marvell.com>> wrote:



> From: Sunil Kumar Kori <skori@marvell.com<mailto:skori@marvell.com>>

>

> As rte_eth_rx_queue_count() returns signed value to represent

> the error cases but internally invoked callback is returning

> unsigned value. Hence unnecessary type conversion is done.

>

> To avoid this typecasting from signed to unsigned, fixed

> return type of callback functions.

>

> Signed-off-by: Sunil Kumar Kori <skori@marvell.com<mailto:skori@marvell.com>>

> ---

>  drivers/net/ark/ark_ethdev_rx.c        | 2 +-

>  drivers/net/ark/ark_ethdev_rx.h        | 2 +-

>  drivers/net/atlantic/atl_ethdev.h      | 2 +-

>  drivers/net/atlantic/atl_rxtx.c        | 2 +-

>  drivers/net/bnxt/bnxt_ethdev.c         | 2 +-

>  drivers/net/cnxk/cnxk_ethdev.h         | 2 +-

>  drivers/net/cnxk/cnxk_ethdev_ops.c     | 2 +-

>  drivers/net/dpaa/dpaa_ethdev.c         | 2 +-

>  drivers/net/dpaa2/dpaa2_ethdev.c       | 2 +-

>  drivers/net/enic/enic_ethdev.c         | 2 +-

>  drivers/net/hns3/hns3_rxtx.c           | 2 +-

>  drivers/net/hns3/hns3_rxtx.h           | 2 +-

>  drivers/net/intel/e1000/e1000_ethdev.h | 4 ++--

>  drivers/net/intel/e1000/em_rxtx.c      | 2 +-

>  drivers/net/intel/e1000/igb_rxtx.c     | 2 +-

>  drivers/net/intel/e1000/igc_txrx.c     | 2 +-

>  drivers/net/intel/e1000/igc_txrx.h     | 2 +-

>  drivers/net/intel/fm10k/fm10k.h        | 2 +-

>  drivers/net/intel/fm10k/fm10k_rxtx.c   | 2 +-

>  drivers/net/intel/i40e/i40e_rxtx.c     | 2 +-

>  drivers/net/intel/i40e/i40e_rxtx.h     | 2 +-

>  drivers/net/intel/iavf/iavf_rxtx.c     | 2 +-

>  drivers/net/intel/iavf/iavf_rxtx.h     | 2 +-

>  drivers/net/intel/ice/ice_rxtx.c       | 2 +-

>  drivers/net/intel/ice/ice_rxtx.h       | 2 +-

>  drivers/net/intel/ixgbe/ixgbe_ethdev.h | 2 +-

>  drivers/net/intel/ixgbe/ixgbe_rxtx.c   | 2 +-

>  drivers/net/mlx5/mlx5_rx.c             | 4 ++--

>  drivers/net/mlx5/mlx5_rx.h             | 2 +-

>  drivers/net/netvsc/hn_rxtx.c           | 2 +-

>  drivers/net/netvsc/hn_var.h            | 2 +-

>  drivers/net/nfp/nfp_rxtx.c             | 2 +-

>  drivers/net/nfp/nfp_rxtx.h             | 2 +-

>  drivers/net/ngbe/ngbe_ethdev.h         | 2 +-

>  drivers/net/ngbe/ngbe_rxtx.c           | 2 +-

>  drivers/net/sfc/sfc_ethdev.c           | 2 +-

>  drivers/net/thunderx/nicvf_rxtx.c      | 2 +-

>  drivers/net/thunderx/nicvf_rxtx.h      | 2 +-

>  drivers/net/txgbe/txgbe_ethdev.h       | 2 +-

>  drivers/net/txgbe/txgbe_rxtx.c         | 2 +-

>  drivers/net/vhost/rte_eth_vhost.c      | 2 +-

>  drivers/net/vmxnet3/vmxnet3_ethdev.h   | 2 +-

>  drivers/net/vmxnet3/vmxnet3_rxtx.c     | 2 +-

>  lib/ethdev/rte_ethdev.h                | 2 +-

>  lib/ethdev/rte_ethdev_core.h           | 2 +-

>  45 files changed, 47 insertions(+), 47 deletions(-)



Was going to apply this for 25.11 (next-net).

But the Intel drivers got rearranged and no longer applies.

Would prefer that you rebase and resubmit, instead of me trying to patch a patch for this.

[-- Attachment #2: Type: text/html, Size: 20552 bytes --]