From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4825FA0C52; Wed, 24 Nov 2021 12:16:17 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 103BE41160; Wed, 24 Nov 2021 12:16:17 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 238604115F for ; Wed, 24 Nov 2021 12:16:16 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1AO2UeHS007517; Wed, 24 Nov 2021 03:16:15 -0800 Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2101.outbound.protection.outlook.com [104.47.58.101]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3ch9tt2gks-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 24 Nov 2021 03:16:15 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cTr27Kzzu6QqTGBFK1E+yMJ2BpZ1vqg2Ak3AOquYDXgJb3Q+vi7K4zy3LtnRE52JI119hyDUQX5yK5fZzGZmuLpuqVqLJZxOuZWAzaiejvM0CqmOoTBLbWzSXgZJw2xC4CBOKxNPJn2dfar1O5ACNs5Z7bX/yGNF2btTNscxyOWNEsUJryxDy5H8C7tPvukOKR4mfX9ycQwTvZWwoGl4P1x7JSJMGQ+1ZZ17mPSCuOVNoYiC2euSWEUTWytDr6B+6dMveHy/KV51h1+N8+ut1zbnTv+0esZXkj1GrGCvHbcWSQwVY9S8y5MHKume/R50g7gJjC3mFvTAVUGTXMl+SQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nvuAA14ATU/Sm/wGKB/v+ZUK4I4f+Bq3d9vxZmSv+vc=; b=lhcch0uQzGX+a2o/D2gCjCwd1iFnzudhbmsnVjI6FN6Q1cp0rDR/+GpdYS934aZ8M9p/FoaaL981xJwzLL90gZqmlYwmij2Zw5FVU3rwaC3XXAW+VAd7fGDm+rRjwRP44IVkByg0JuaSmgpvCwWfEvRODeJvrIVKTblbG5JVYFH6bhocLMhfCLV71hbXKqB2WaCdo32uFnB43oO3KBImPS80Ich0yVyBXrcExKJd5ETypvyg+mv++a3Axz+M2AYIzNubbwKlr6geksmdzptIV88vIe9GmU95oGbuJE7YC+1dBwSkXnFnxRsdOOoB0P7RoCUbOBH120iHbSxI12ue1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nvuAA14ATU/Sm/wGKB/v+ZUK4I4f+Bq3d9vxZmSv+vc=; b=Nq/w0WJmR/cSEWExYnawGIIxZeito/n9Fx0ih948rB7DkMdq/r6jEw9qqECn1MKW6usL+ULCBoQyYi5k9M8PuwNlNkNn9FdVwYFdepJpHisholBXl1UI3BP9lc4y1Hwzip2W60xB2xX5L3j7sxlpIM7cJe11VRlI/YJm0FTsd6w= Received: from CO6PR18MB3860.namprd18.prod.outlook.com (2603:10b6:5:34d::12) by CO6PR18MB3907.namprd18.prod.outlook.com (2603:10b6:5:345::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.19; Wed, 24 Nov 2021 11:16:13 +0000 Received: from CO6PR18MB3860.namprd18.prod.outlook.com ([fe80::dc37:87a0:2de1:ffa0]) by CO6PR18MB3860.namprd18.prod.outlook.com ([fe80::dc37:87a0:2de1:ffa0%5]) with mapi id 15.20.4713.027; Wed, 24 Nov 2021 11:16:13 +0000 From: Sunil Kumar Kori To: Thomas Monjalon CC: Jerin Jacob Kollanukkaran , "nikhil.rao@intel.com" , Pavan Nikhilesh Bhagavatula , "hemant.agrawal@nxp.com" , "nipun.gupta@nxp.com" , "harry.van.haaren@intel.com" , "mattias.ronnblom@ericsson.com" , "liang.j.ma@intel.com" , "dev@dpdk.org" Subject: RE: [EXT] Re: [PATCH v8 10/10] devtools: check event device doc tables Thread-Topic: [EXT] Re: [PATCH v8 10/10] devtools: check event device doc tables Thread-Index: AQHX4FpvfOAyedFBwE+wqPzraLZfzawSghAAgAAFnTA= Date: Wed, 24 Nov 2021 11:16:12 +0000 Message-ID: References: <20211122075414.1834651-1-skori@marvell.com> <20211123110743.2002557-1-skori@marvell.com> <20211123110743.2002557-10-skori@marvell.com> <3741160.x2eqROFiRU@thomas> In-Reply-To: <3741160.x2eqROFiRU@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 69b5f70b-b0df-459a-b3cf-08d9af3bd32a x-ms-traffictypediagnostic: CO6PR18MB3907: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1169; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Vp+Tn2NQuR60UsvmiLXG0Zj5lsIZPAgeKyC2tUMN9c7GZC31hxLuouTqBB68ix77B3LApzV4F1zIwR/n2ZovjRoH9Qdv5ku4GwhROfjRg9+eSaj95fNHx8llX2ZuFOLFryXH4VKv7vr3AvgLVYIwIYRDThPeCZ+Z/pN3mWadl+/844xDeHTQD9FgawYiTtd8yG5ITWGIBteAr4zAfVR/vy7jvDdCqsAITgefhNhfD10CgpArTDXS8xxQWekuSxxZ8PKYcxtrT9Qh9/fT8DZFm3BTXeqCRCjm0JwpkIK41hSV5Bya/q0meJoDbslGTEKK/mJ6yFav8HFZ+SyFiIUv2SIJU3dMq7XQfFfCwCq1pid4SQLTK3+/Rlhi+AFDb8TZi+rY7dv3y9EL9Zkuv8L7GNOHYdjG3uduNIH8HfFhXC8r6RfqClxVhgo5W6GCiQrNI5yhDAytBS6lpJoRFg433sGIxNxXMeXSFbUifna1kE7M25g8iBy+Dl2VNKVrouddSbDO2ogTKrkGh8LqXMVAjYu+mFu9GMKZfhcE8NBojW9DPwvKNpUGVvtogY3cO+5Sb0z7WoS3nfIOV/w/IW6ttbNqlkP98zNOTrlG3+1/hCB+gi/8ml6vXz81PfFWKJktRKcA2dOc7y/58crC/VZlHTbAUASn19sx9WvlzLyOcWH60UAvkSBaEjVAyoixa2X9w2zK0PKf0QFELsf3KThYgQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB3860.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(64756008)(54906003)(122000001)(38100700002)(66556008)(66476007)(66446008)(38070700005)(26005)(71200400001)(66946007)(52536014)(9686003)(83380400001)(55016003)(76116006)(4326008)(2906002)(8936002)(33656002)(508600001)(186003)(6916009)(316002)(86362001)(7696005)(5660300002)(8676002)(6506007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?UAwtzgguHnh29E4LgVwWM+GNEbdLxLLWvLcx2b0Lfa4+qxBZfKfhsZRDH03D?= =?us-ascii?Q?atw+p+Gg8Ld7bq/D45xSdyJSRzYH3P6gUdGjRX4ZlS63TYIRKyh5FK1p8cd8?= =?us-ascii?Q?bA+m9yhDBd/s7WeRoNPRalYehOTJgVPlQmTuzV6XThjCRssylfCS3LKKbMvh?= =?us-ascii?Q?EbeY3uloEyYgSISjxo4VJmgNYOyQ2eLkQfrevHvJ5emjVDkkqFNVuhDX4qNj?= =?us-ascii?Q?rb7/eLp/oy8K6jseMCBfUwBYlw9p+4FpmFQNCMgBjvREkXG/pZacZ+CqmP1J?= =?us-ascii?Q?5ge6LgodM89mxQjmBhYVYz0zFTBq91bvrRW97zz1enQJpX5iKBzW/ZIaUpG+?= =?us-ascii?Q?jaT1D5Z6beDS498t/gm8ivtZAv/Bv1ba79uwflARpK5ovpJO7uUQPys8YFUf?= =?us-ascii?Q?XDD1w7q8YdcEpsQqGG6u02DVgAaQOnNhyzoOQkSgN4uXLq8I/YOlZ1ucy80C?= =?us-ascii?Q?mPLPllMk10HLMv+cca7FGzvKHPtVV2Zhxk25+xs6U4GfNSFuUPynrfF7qr5X?= =?us-ascii?Q?nB7Ki1CbVDoc5jnhVJ07DgXIzxwOmhX2ssBlU49N0lswWWQHzDnleFfXL0KY?= =?us-ascii?Q?cOLDdNhn5hm5oMh9ixqPNzEQTuM34E/3GnuzMTP7Z0/QX7F0OgWoNUSey0Et?= =?us-ascii?Q?om3+Y6fg//BJtX4QfzZ05sHydmPF6lYvyXP41QsrT3oDvfEYuOmERmlzZ6xP?= =?us-ascii?Q?km+5ndDqbt3AfZn855vUH7+StMGLg457PtKqM+RiAILCIgOhWqN1gCo+kAE+?= =?us-ascii?Q?01IvZPRHqTNSMiC8pS5PQUQqsxLvQ1ECF3oPb9Cyj+aVZqryFEzKSMArP+86?= =?us-ascii?Q?bJ5GEvQW04QchrI74v9p2Atn66whfQXqnc/5weoNsYHfix9O5cBQXPV96n3o?= =?us-ascii?Q?VRArQF/lfaz6n/NvlzYzSReFKfpCKDvfZmuL/28NhFjF4W9lAi5FVyUingDB?= =?us-ascii?Q?Mlq/d6SAO8e6Xr37TmqZO16KQT9/QdzM4hzdKFKWtF9bGovND6YVqpavNV4A?= =?us-ascii?Q?bm+gnVQEWXr4Y80z7Mq1f8JxKwzpBQ8uQmuG/mGWPenM/0wKPuSY0iYPhtP4?= =?us-ascii?Q?MYj86SHfrani4zgin/DQXD8Bz0NiJDBwYqME5c6uZnEZlbzraVnQ5h3u54Lb?= =?us-ascii?Q?La8VRq1BgEl4HYFnFLbxCHk2SHzpincKrgkuII1OgbZZ06po0L3+NcS7667q?= =?us-ascii?Q?oIP+1rl/VsgtPqy4yJvhDMxCdT+g8urV6tSyxwNrUqXQpbb8WK1cwi+mGz8Q?= =?us-ascii?Q?p88SKJdALyBugMzERc5RLc73DrsX2WzFlPgl8Zb5rHdbMix4b3HPhL8BCFZS?= =?us-ascii?Q?7NVD+oCO8XjQ+W8cML3QNpILpcUAe8mA9w6nLPwkOwiBSZNFVSZ1glB0j1hz?= =?us-ascii?Q?sB3PJOI+Z7DOLWaGEqHOYF7dGr8KIDbci+DMEs3H58DcqFnTB1hzLHRjKCBq?= =?us-ascii?Q?YoT55l5urkz/oSDq/pd/aUIa8O3Htkjrf309ZaAwDywyBOUUZDr6kWH7F43p?= =?us-ascii?Q?MVm6dyR+EiEGsE/KLro4f4Az77GtCqF+Sy7gmFxTLY7cXKVZIwgP05T8wdmL?= =?us-ascii?Q?GD8V2m8E4GR9QJjcIhgRRN0EDVrDo6jS2V3tIfl13CAmQG6qPOpCUW8zbYnY?= =?us-ascii?Q?0g=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB3860.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 69b5f70b-b0df-459a-b3cf-08d9af3bd32a X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Nov 2021 11:16:12.8436 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9MQcRFe+oeH73PNwMtAq62gHayqjTjoUyBxJdMVxHcABtcQkhLsD4Hlt8mpnZOwr9ZK6/BCcEZQ6ZxOTk1PqWg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR18MB3907 X-Proofpoint-ORIG-GUID: qVdLRfXWbt2EYEPnEqE4NODDuQQMisuc X-Proofpoint-GUID: qVdLRfXWbt2EYEPnEqE4NODDuQQMisuc X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-11-24_04,2021-11-24_01,2020-04-07_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Thomas, It will take some time to handle all the comments for this patch. So I woul= d request you to defer this patch for next release and take other patches i= n series.=20 Also I will send one patch to add feature matrix for dlb2 platform and fix = minor review comments given by You.=20 Regards Sunil Kumar Kori >-----Original Message----- >From: Thomas Monjalon >Sent: Wednesday, November 24, 2021 4:23 PM >To: Sunil Kumar Kori >Cc: Jerin Jacob Kollanukkaran ; nikhil.rao@intel.com; >Pavan Nikhilesh Bhagavatula ; >hemant.agrawal@nxp.com; nipun.gupta@nxp.com; >harry.van.haaren@intel.com; mattias.ronnblom@ericsson.com; >liang.j.ma@intel.com; dev@dpdk.org >Subject: [EXT] Re: [PATCH v8 10/10] devtools: check event device doc table= s > >External Email > >---------------------------------------------------------------------- >23/11/2021 12:07, skori@marvell.com: >> --- a/devtools/check-doc-vs-code.sh >> +++ b/devtools/check-doc-vs-code.sh >> +all_event_drivers() >> +{ >> + find $rootdir/drivers/event -mindepth 1 -maxdepth 1 -type d | >> + sed 's,.*/,,' | >> + sort >> +} >> + >> +check_event_dev() # >> +{ >> + code=3D$rootdir/drivers/event/$1 >> + doc=3D$rootdir/doc/guides/eventdevs/features/$1.ini >> + [ -d $code ] || return 0 >> + [ -f $doc ] || return 0 >> + report=3D$($selfdir/parse-event-support.sh $code $doc) >> + if [ -n "$report" ]; then >> + error "doc out of sync for $1" >> + echo "$report" | sed 's,^,\t,' >> + fi >> +} > >These 2 functions are mostly copy/paste of rte_flow functions. >Given there will be more in future, I would prefer code being factorized. > >> if [ -z "$trusted_commit" ]; then >> # check all >> for driver in $(all_net_drivers); do >> check_rte_flow $driver >> done >> + > >I would remove this blank line. > >> + for driver in $(all_event_drivers); do >> + check_event_dev $driver >> + done >> exit $result >> fi >[...] >> +if has_code_change 'RTE_EVENT_DEV_CAP_*' || >> + has_code_change 'RTE_EVENT_ETH_RX_ADAPTER_CAP_*' || >> + has_code_change 'RTE_EVENT_ETH_TX_ADAPTER_CAP_*' || >> + has_code_change 'RTE_EVENT_CRYPTO_ADAPTER_CAP_*' || >> + has_code_change 'RTE_EVENT_TIMER_ADAPTER_CAP_*' || > >Can it be a single query? > >> + has_file_change 'doc/guides/eventdevs/features'; then >> + for driver in $(all_event_drivers); do > >No need to check all drivers. >For rte_flow, only changed drivers are checked. > >> + check_event_dev $driver >> + done >> +fi >[...] >> +# generate INI section >> +list() # <pattern> <extra_patterns> { >> + echo "[$1]" >> + word0=3D$(git grep -who "$2[[:alnum:]_]*" $dir) >> + word1=3D$(echo "$3") > >Why echo? > >> + words=3D"$word0""$word1" > >Why so many quotes? > >> + echo "$words" | sort -u | >> + awk 'sub(/'$2'/, "") {printf "%-20s =3D Y\n", tolower($0)}' >> +} >[...] >> +event_dev_rx_adptr_support() >> +{ >> + title=3D"Eth Rx adapter Features" >> + pattern=3D$(echo "RTE_EVENT_ETH_RX_ADAPTER_CAP_" | >> + awk '{print toupper($0)}') >> + check_rx_adptr_sw_capa || >extra=3D'RTE_EVENT_ETH_RX_ADAPTER_CAP_OVERRIDE_FLOW_ID >> + > RTE_EVENT_ETH_RX_ADAPTER_CAP_MULTI_EVENTQ >> + > RTE_EVENT_ETH_RX_ADAPTER_CAP_EVENT_VECTOR' > >Why having extra parameter, instead of updating the pattern? >By the way, the pattern RTE_EVENT_ETH_RX_ADAPTER_CAP_ already include >all of this. > >> + list "$title" "$pattern" "$extra" >> +} >[...] >> +# compare with reference input >> +event_dev_sched_compare() >> +{ >> + section=3D"Scheduling Features]" >> + { >> + event_dev_sched_support >> + sed -n "/$section/,/]/p" "$ref" | sed '/^$/d' >> + } | >> + sed '/]/d' | # ignore section title >> + sed 's, *=3D.*,,' | # ignore value (better in doc than generated one) >> + sort | uniq -u | # show differences >> + sed "s,^,Scheduling Features ," # prefix with category name } >> + >> +event_dev_rx_adptr_compare() >> +{ >> + section=3D"Eth Rx adapter Features]" >> + { >> + event_dev_rx_adptr_support >> + sed -n "/$section/,/]/p" "$ref" | sed '/^$/d' >> + } | >> + sed '/]/d' | # ignore section title >> + sed 's, *=3D.*,,' | # ignore value (better in doc than generated one) >> + sort | uniq -u | # show differences >> + sed "s,^,Eth Rx adapter Features ," # prefix with category name } >> + >> +event_dev_tx_adptr_compare() >> +{ >> + section=3D"Eth Tx adapter Features]" >> + { >> + event_dev_tx_adptr_support >> + sed -n "/$section/,/]/p" "$ref" | sed '/^$/d' >> + } | >> + sed '/]/d' | # ignore section title >> + sed 's, *=3D.*,,' | # ignore value (better in doc than generated one) >> + sort | uniq -u | # show differences >> + sed "s,^,Eth Tx adapter Features ," # prefix with category name } >> + >> +event_dev_crypto_adptr_compare() >> +{ >> + section=3D"Crypto adapter Features]" >> + { >> + event_dev_crypto_adptr_support >> + sed -n "/$section/,/]/p" "$ref" | sed '/^$/d' >> + } | >> + sed '/]/d' | # ignore section title >> + sed 's, *=3D.*,,' | # ignore value (better in doc than generated one) >> + sort | uniq -u | # show differences >> + sed "s,^,Crypto adapter Features ," # prefix with category name } >> + >> +event_dev_timer_adptr_compare() >> +{ >> + section=3D"Timer adapter Features]" >> + { >> + event_dev_timer_adptr_support >> + sed -n "/$section/,/]/p" "$ref" | sed '/^$/d' >> + } | >> + sed '/]/d' | # ignore section title >> + sed 's, *=3D.*,,' | # ignore value (better in doc than generated one) >> + sort | uniq -u | # show differences >> + sed "s,^,Timer adapter Features ," # prefix with category name } > >I think these functions can be factorized. >