From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 02B02A0C4D; Wed, 6 Oct 2021 19:34:36 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E205240696; Wed, 6 Oct 2021 19:34:35 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id F1D0F40685 for ; Wed, 6 Oct 2021 19:34:34 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1969kcP7007628; Wed, 6 Oct 2021 10:34:32 -0700 Received: from nam04-dm6-obe.outbound.protection.outlook.com (mail-dm6nam08lp2043.outbound.protection.outlook.com [104.47.73.43]) by mx0b-0016f401.pphosted.com with ESMTP id 3bh9fd1w27-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 06 Oct 2021 10:34:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BaNmY4/8zKKqMFKuytIQGyQYQumKBpurX3SfEzM0Vd8zWc/UgzG/l41/nQ65Q+3TkNvvZL+pZ1JHdKotNW5uXWVFOzmZdL3xxJS33hMYHfY5GNYf2mJMpt0nTgBxEuaaBJTvtzjOs3uh22KYkvlmYjB3/ECZRsTadNNIRBfjrJZ8AorIlNXclcErdv/p3pKwKoDyD9rs6ac+cXPUuP9fd2MUNy2Xsay606m+MFWHswXs0FS0Sbzkmki60BDMWL18DalGRfH/ZcgvUthTbleTcfD4J9Yb7O1tq6r/eQ/hnOYKng0YQX4IwH2cEkz1pqZGHx2BAXpOVLAO3yaJHP+6Mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w97/hbHLrCelQBdQ1jjpocVncZ0LJTqrfFqVoGAxRPo=; b=hpZ9tXh8SiTA6qBKk+h9TWBQOtGcQBC4E+6MlxM38pw2IiMOUL0N4+YhrpXyUChrrv+m2Gd/ByMxp1MHW+NOQC1U+MaqnEbqpg9kPkUTHEmPgQ9X+Ws54IouFFuvIePzS9in4E2lgtwhv1h4l4VJfBqdytDHGRq4O/IoLo8d9aXbCua64ACVjbhSqBAuovIFdQcM4kqxGodUqN+tVpiZFQkPAkY1KrLRns6ib3pLx6d+O4to6NNPaa1ctVPgfKHMorFSaewD9oIR6qgOUOIQAL/F9X57jLvo0krjNVzrLKx2HwdkQ8AIpvxf9MfjgP1Y9DZ5JXfPjg1KneNUUtCZ7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w97/hbHLrCelQBdQ1jjpocVncZ0LJTqrfFqVoGAxRPo=; b=N23n/g8kh2OxfXG4WRGMpZ1+PGYnk1MYZt4jiiqVhh+uMEB8QcLuSQ9Opt+YxhpmwhHlgL4Ee4EHLDWFBpYMManWjXY4z2qOawOMxs56Ja4cSQbtE4Sb6rrtxQJ7QDF0B6JsUDs+vC4AONYAeItytyFWHab6UJ48kUXqHnVu1Ds= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by CO1PR18MB4826.namprd18.prod.outlook.com (2603:10b6:303:ed::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.15; Wed, 6 Oct 2021 17:34:30 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::c41e:707:3f91:71b8]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::c41e:707:3f91:71b8%6]) with mapi id 15.20.4566.023; Wed, 6 Oct 2021 17:34:30 +0000 From: Akhil Goyal To: "Power, Ciara" , "dev@dpdk.org" CC: "Zhang, Roy Fan" , "Bronowski, PiotrX" , Thomas Monjalon , "De Lara Guarch, Pablo" , Ray Kinsella Thread-Topic: [EXT] [PATCH v3 01/10] drivers/crypto: introduce IPsec-mb framework Thread-Index: AQHXtU9kTphNsT52okqrso6s4y6LQqvF/gAQgAAp1QCAAB3+0A== Date: Wed, 6 Oct 2021 17:34:30 +0000 Message-ID: References: <20210727083832.291687-1-roy.fan.zhang@intel.com> <20210929163035.608387-1-ciara.power@intel.com> <20210929163035.608387-2-ciara.power@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 84ef92c1-d4fc-4d34-fc32-08d988ef8dda x-ms-traffictypediagnostic: CO1PR18MB4826: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: d7Pt2YyJHI0NZAJEKJmZrsovzU0HTpRaXGI1mhVFyROWo8wv4sdPfvXbENn3TC2HOI19VseZtIscSXM3LY5jEJ3ijWTb+AEZ01UxqOis18YjWytTXzRluNTlN5BGJOn4hUZDs5eyOQVx/03/IWiLgqMqdTlO8Fw9reLxVFqxVqyWwpt7ZZkF0UMU/jVkUsPc1Kfo8pHA23kyxPV+n1bN47/lVngUG5djPefuI8QuWKeQZbgFcIE5O0a0abhfgVRs0/NduhhVyzqDuSf1+GAmIstyw50lnhH+vs04N7EgBMsIdOWUaCdCe1qmgdmfJohm3F2kDJgFCaL4CsOzbkT+RHjBURE3W/2VGN4baQMstzjDXHEAYb3xxu8fjmosAuCHLDukiB5MWbKoarBKk2pgcyZOaf+ly2OHqC83m/ANzfOH8Ul19dHn2iNmqaiUvkeUVLln1YAqAgR8RjzHG+EKPw+ypqehotg2jtBgdLtnvy2Mh5zY/tuSIzhzIfyNCXqjf3JMPBa+pHZPv3mWGVczXhUNBCZAOI9B5miZ2eMNCv+HUdjCegjXRvQgnD5Vwa9B4X/MdOmqPkU3viKDwhR6zzVh+0M+0ejeIBOLGlPQKW7NIQWL4H3ctyFLqk6Rp5HfNJ7O5EIGCTTZcoqJ5Q0LUWI+mADfHYwqfI6eDQzGVMv8bkQpmjQDlSQQCQfPophxzJJ7LQxNFMPZEH3n/ORH/w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(38100700002)(5660300002)(122000001)(83380400001)(55236004)(71200400001)(4326008)(6506007)(2906002)(316002)(54906003)(66946007)(86362001)(186003)(8936002)(66476007)(52536014)(38070700005)(76116006)(64756008)(8676002)(26005)(508600001)(7696005)(110136005)(9686003)(66446008)(33656002)(55016002)(66556008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?34vf5ED8Z5VoGyvdPFtzDhlBXh9C76faD3PxDwvgkfxE6r32vLLuNM6/Ce0z?= =?us-ascii?Q?dBaz/Mq+xDDPCOahiWcYEKptQVRj+E9w782NPVSPJUQS3akzADn9ng++y2VC?= =?us-ascii?Q?1Peen44xbSIcr8NB1JNxCHTQXZ03SHwiisHTL1ayumoElzbI0RmmHS04LIfR?= =?us-ascii?Q?MzMolkbZMnIl0HAxZPlEUl1VHXq/ppulRXy66gH8V54+CQZDR1w4BM6qNYi7?= =?us-ascii?Q?qbviHmaz/VE762SgXw7Kbggz/fE+GDTXlGZ/JUDiJDfe5Xdilp8FCdFa3muh?= =?us-ascii?Q?oNkF/nFYj8lZiXhYz0tzTVLZ8NmZvAoO1vTGwjdC0lD8XDB96bzdZPIPGdnj?= =?us-ascii?Q?jJEiSQEQeDXqfUHtJ9vCdVwXJK3Qqd546AXroN9Zrl0CqjAXUB0B6JJQ+Xhs?= =?us-ascii?Q?Z30ltaD3VbenPDFoCDteOQlzyhbdJ4QB1ZjBCmNns5DfEXeltmQQkRzj9wpf?= =?us-ascii?Q?ZVDv6kgul/DI6Zcxx9l+4t7k2eqOEyPcqGeAePAbUMV2/sd8IRwqY2V51Hff?= =?us-ascii?Q?Zx6HIjOlInACXE7AKLjI+0bZWXG7RIr5wxoSDCcqWutyYy7ztrkwFOczpTnw?= =?us-ascii?Q?sd7Z8gPxO7mDOcFX8oIHjq0xGL1rfZQuxsUVNdjM/cQitHfEga1duzhZyBhv?= =?us-ascii?Q?xQYloruL/HiKmXMfSYYJvkjz8Vk3XDidTs+IDM/BWJlcuN2RUhLtsLBGZ9ZO?= =?us-ascii?Q?az0SJEhP7CVTKiqIZWpxzSqaBFtwWAG/RgScPaL9iNCbtJUN+2gA/JoqbcFn?= =?us-ascii?Q?Wzv9WsBGQWLfSQNY47LBWG99UxgcksXSgNLW/ijUHTiZGqRO4dBvtqmGCXhZ?= =?us-ascii?Q?2pHjAjLX0NxpWoqG742LlZKz6Aub+U6AchLQqcNJfrdREJjSnKZyBYVonvAj?= =?us-ascii?Q?1ILlobxPmicVVjvHG93n8yyIdkNGvlPnhyLMgB6PYOZPXWWVgNjeLoCxBasT?= =?us-ascii?Q?7FirNfiruv6fW40tsve1+ErAO6RYHBJYN1Pq1L6Lqxny3KPSUp6tXQ7iFNJL?= =?us-ascii?Q?CRyjdl7e2cWyoYDh56L9fqKwOTB3RHJ9G9Q1cYaTRaaAWDjnbK/Jt+z47EhT?= =?us-ascii?Q?zHzdcejwhTUo5Zyw5t+RP/1e0P4wqpL1uMqedDikx6dTxL3+aceuhJtBmIHH?= =?us-ascii?Q?5c64tMOO27a2JjCE4qy9ndRoTh/GkMarz8d5PzmFjgk7QhvWYGZ0mtx5UArJ?= =?us-ascii?Q?WgO0VWV4D4mHXcQb67RGiXsY2voxLX+4SmjayaZJGf0s0bvF2+uKn5T5ZKJT?= =?us-ascii?Q?cJoMlkL8KBNX+0CQnhXPYrkxCC76U9lbjuL70rWE9m+PeYz14xVcblMJpUoR?= =?us-ascii?Q?1mxTYhoJlClrHq9azPJS+Gqy?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 84ef92c1-d4fc-4d34-fc32-08d988ef8dda X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Oct 2021 17:34:30.6682 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: S+0y6c7+pDxAhvNdSkurSuh+seec0/KXM1usWjo3xGF10YlxWCdLg/cN6j6DtjWwx+3bYqBKycdqJv2SJty2Eg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR18MB4826 X-Proofpoint-GUID: O1q773Y32L2Gdcd0YoBqXM4lXHNZsn5h X-Proofpoint-ORIG-GUID: O1q773Y32L2Gdcd0YoBqXM4lXHNZsn5h X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-10-06_04,2021-10-06_01,2020-04-07_01 Subject: Re: [dpdk-dev] [EXT] [PATCH v3 01/10] drivers/crypto: introduce IPsec-mb framework X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Hi Akhil, >=20 > >> From: Fan Zhang > >> > >> This patch introduces the new framework to share common code > between > >> the SW crypto PMDs that depend on the intel-ipsec-mb library. > >> This change helps to reduce future effort on the code maintenance and > >> feature updates. > >> > >> The PMDs that will be added to this framework in subsequent patches > are: > >> - AESNI MB > >> - AESNI GCM > >> - KASUMI > >> - SNOW3G > >> - ZUC > >> > >> The use of these PMDs will not change, they will still be supported > >> for x86, and will use the same EAL args as before. > >> > >> The minimum required version for the intel-ipsec-mb library is now v1.= 0. > >> > >> Signed-off-by: Fan Zhang > >> Signed-off-by: Ciara Power > >> > >> --- > >> v3: > >> - Updated intel-ipsec-mb macros. > >> - Added use of auto init function for IMB_MGR. > >> - Added detail to commit log. > >> v2: > >> - Added qp NULL check in get stats function. > >> - Added maintainers file entry. > >> - Replaced strlcpy with rte_strlcpy. > >> --- > >> MAINTAINERS | 4 + > >> drivers/crypto/ipsec_mb/meson.build | 27 ++ > >> drivers/crypto/ipsec_mb/rte_ipsec_mb_pmd.c | 169 ++++++++++ > >> .../crypto/ipsec_mb/rte_ipsec_mb_pmd_ops.c | 291 > ++++++++++++++++++ > >> .../ipsec_mb/rte_ipsec_mb_pmd_private.h | 275 +++++++++++++++++ > >> drivers/crypto/ipsec_mb/version.map | 3 + > >> drivers/crypto/meson.build | 1 + > >> 7 files changed, 770 insertions(+) > >> create mode 100644 drivers/crypto/ipsec_mb/meson.build > >> create mode 100644 drivers/crypto/ipsec_mb/rte_ipsec_mb_pmd.c > >> create mode 100644 drivers/crypto/ipsec_mb/rte_ipsec_mb_pmd_ops.c > >> create mode 100644 > drivers/crypto/ipsec_mb/rte_ipsec_mb_pmd_private.h > >> create mode 100644 drivers/crypto/ipsec_mb/version.map > >> > >> diff --git a/MAINTAINERS b/MAINTAINERS index 1e0d303394..f1aaf7d408 > >> 100644 > >> --- a/MAINTAINERS > >> +++ b/MAINTAINERS > >> @@ -1065,6 +1065,10 @@ F: drivers/common/qat/ > >> F: doc/guides/cryptodevs/qat.rst > >> F: doc/guides/cryptodevs/features/qat.ini > >> > >> +IPsec MB > > > >Not sure if the name ipsec_mb is appropriate for a crypto PMD which also > >support algos which are not specified for IPsec like ZUC/SNOW/KASUMI. > >Moreover, this is a crypto PMD and not IPsec PMD. > > > > >> +/** Get device statistics */ > >> +void > >> +ipsec_mb_pmd_stats_get(struct rte_cryptodev *dev, > >> + struct rte_cryptodev_stats *stats) > > > >I believe 1 instance of the ipsec_mb PMD will support only one kind of > >operation(aesni_mb/aesni_gcm/zuc/snow/kasumi). > >This cannot be changed during the lifetime of the process. Right? > > > >=20 > Yes - please treat the ipsec_mb_pmd.c/pmd_ops.c as the shared code base > for these existing SW crypto PMDs based on intel-ipsec-mb library. There = is > no new PMD called ipsec_mb as such. >=20 > Maybe to make it less misleading we could rename the file names like so: > Ipsec_mb_pmd.c -> ipsec_mb_private.c > And similar change for ipsec_mb_pmd_ops.c and ipsec_mb_pmd_private.h > What do you think? >=20 Ok that would be better.