From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 622DCA0503; Fri, 20 May 2022 09:30:23 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2115C427ED; Fri, 20 May 2022 09:30:23 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 9B21640222 for ; Fri, 20 May 2022 09:30:21 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24K5osku028893; Fri, 20 May 2022 00:30:20 -0700 Received: from nam04-dm6-obe.outbound.protection.outlook.com (mail-dm6nam08lp2042.outbound.protection.outlook.com [104.47.73.42]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3g50as9cux-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 20 May 2022 00:30:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I8ZnKTcTX0GRIbgNJaadgkxalZIK925l0sMsQ0E41h+b7zLd2SepE1P83nrQBFgtF8DQalkb9NVpVOpwVFeFEHuT2yE4ZVU4sBt/bVPSK0qbzSIiqVXiAlebVHgIaj3caI4gsw/yZqTD3ZpZk2VmUdIJ4ohLc7BmoizB5IfSlTGFNxkfZpOy7SS3eOCWvIh+9QCfc/1nvzBR1BRlt7q7lKWs0YeK2TbgXfcUqYJPPijA3G5GjqYLtVJUK/Ny2yskf/n+Cg54VwxBhvL2ke+v5DCsFlfIZKW0ArQQss20rIx63lFDBjSp6nmidquGzIF2yaMVL2eeliP27hdawvJ/3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dNp4RTdSDqEK5SSPneinUpoeUd8UYGukquyFRpdF2E4=; b=N4Ir2TYchUT7ZUj3Kusj06TAoHiwGcdWkvf59/dZeJoqEzeyxBHWKtH3t1w/CQkDVa9NLfPsmF/liU2Nh56ZcHRP17BAGqxlpZ1JN1Ac6Vu7tlUbZth/TApu/qNNOlCs/PGiWTYdufezN9f1cOvjfYfPK3Fn5tdMeAgLWY/wEH14sDdCu6SeUEmrIjqhlWRXzyErRLrW7iMxxeBHuHEOngpw7URZVpLBZnW3fEDPWDgmwOGm1CRIo8VDHRHcAxakobZrDjH/k+HqsgntjjZbX/IRiuvzMu6a4pNRDtQTKMKrz1jbFACaiu3OHdSl0A1OYQvXEOhW3ta+SqwWIzOW2Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dNp4RTdSDqEK5SSPneinUpoeUd8UYGukquyFRpdF2E4=; b=QgmhrGcGAgiyiuItjUrjO18rzzmF0oKcegxJPKJQi+QXhNfYGxIjaAc4kW5pMdIdMDeKlaRq3QFOvOW+TAfYG+VZACWfLIgrMvSkcV+hTRnJbpl4T04mnTHEVzmLFXNlzds4XxxVVe3BCHNJXyMdx1xejSg3giqQJNizXwromaM= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by MN2PR18MB3607.namprd18.prod.outlook.com (2603:10b6:208:269::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.17; Fri, 20 May 2022 07:30:18 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::1d4a:ca8b:611a:9cf6]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::1d4a:ca8b:611a:9cf6%5]) with mapi id 15.20.5273.018; Fri, 20 May 2022 07:30:18 +0000 From: Akhil Goyal To: Arek Kusztal , "dev@dpdk.org" CC: Anoob Joseph , "roy.fan.zhang@intel.com" Subject: RE: [EXT] [PATCH 00/40] cryptodev: rsa, dh, ecdh changes Thread-Topic: [EXT] [PATCH 00/40] cryptodev: rsa, dh, ecdh changes Thread-Index: AQHYbBeUC/khZ7+0HkucfkvuhM52aa0nXnpA Date: Fri, 20 May 2022 07:30:18 +0000 Message-ID: References: <20220520055445.40063-1-arkadiuszx.kusztal@intel.com> In-Reply-To: <20220520055445.40063-1-arkadiuszx.kusztal@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 920a6793-387c-452e-4b0e-08da3a329732 x-ms-traffictypediagnostic: MN2PR18MB3607:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mkil6nyp0UmpZRZiDDS6E3oTP3H0CNWuEKmRtMToQSoP+JBQlMJMoDhSInS+lXeyP7PFslwjEwBcznk3klxIUfTvSN1D3Zbii/NDz46c01RQzzldykYK0yDixlrqy5M7+2MqlCxtGn6xxBnBp2U53OuFV8yZy6e3Q655l6ZfpXQF0Eru0z+V0OOSvB1tN7fRKly0sNx/gZDVuYm6uApKZ/ah258MrAPAtn65gff8ypa9QY0N7LkEVo5JHDoatHU9io4FwaUPa53FtzCjKxMQ2hDFD2OJwq6xzmomx8HfOjJHYzLUrHb8DXXCNOKNrchZh400c4o62zymdydYVHLvtqKqoaL9tibsAU+CrTzy+FFDUARZWq868rdQM/EDY/31BIsbW5dvjs/1yy8RN4QC4IUN94tYco6n453L/EJZyjyZhmQvLbyr/6tEee97X9G1UWf9IKaSMrpwTzm40FwHfpf3/IMr9+5YHkVpXhoZyB/ODRmRKQAqbg6dc4/siBKTutcOwSn9JnquSqZyV5a2jTAKzOeA2nqeU5KNN74FAf7DmvO7FGBb7GQ+pUv60gqaFztymK+aerRSRnZU9F5ggRLQCYRYPrHJoCiP0iqzOYHb3VxTetNy4Sa4YbP+Q75G9UA0CNPpzSliw2PR2okVJ+K/jdau/bkEfkR42Kf5yFGOKTPirdN+/i+869bBQ3skRXMXBCOrLeq/LuwGAt2GNg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(55016003)(86362001)(52536014)(71200400001)(33656002)(508600001)(7696005)(54906003)(8676002)(76116006)(64756008)(66446008)(66476007)(66556008)(8936002)(66946007)(4326008)(110136005)(316002)(2906002)(83380400001)(38100700002)(38070700005)(186003)(122000001)(5660300002)(26005)(55236004)(6506007)(9686003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?P32gNkl02tlly9MsfRGZdpkroGP9JDLhub23M+yye37qc8K2tdDW88OGjhi2?= =?us-ascii?Q?kPYct6A7lJuh4AR1MvuPHmvFgaN7GG8u3gDcI+llFL1xZE0TFQdM2UkO95OY?= =?us-ascii?Q?v3wayE0xirb8GffJS2uqIxcLGLEX4SO1JmFLWRwu8ICdi/fY6MOMmHLUZ7Yp?= =?us-ascii?Q?K/zYdZM0kkduFs0aXJst7rhRenxW8vrwm2A+/4aGbE0kXqWIOsATQrzojX22?= =?us-ascii?Q?9yc5B50ddbY3qHK5ylJ7+c6GZWWkw1ogizTXggHu+Oy2zjUo5ye4l9SYABbO?= =?us-ascii?Q?6Oj3yVwDKlkEJYBjSYrVPbXHyN14C9VyfGLBuciLioua+Ci007ScbsN/D+tQ?= =?us-ascii?Q?albvIKNFpJMjGhY+nJ4cyBpqokac5D2Lj5Bn/dwOCkNfewUal2lquQ51plWw?= =?us-ascii?Q?Pub+mC2qMgBrP4Ychudp5yZzO9aRIvd0ZDHTeGW3zlHNDfEJmp33hjKI73v3?= =?us-ascii?Q?7cadWNlOfyihxTsh6qNy5jvrjgrObHonYI3ZijS0ZQfRv9fdw5QgVUSTuLyT?= =?us-ascii?Q?INJ+W5jY9iOdc2i6lZsd7qrQRmtzPfmaTOvjTWSQLALy/oWCYBF2Yrq60r4E?= =?us-ascii?Q?qxBg08z4ffBPBACWxmVDrnR0yC/16M+GM0D31dRuM5z83kPS2RYk/bWJdX7s?= =?us-ascii?Q?wrk3ixO5CgflWlfBUA6uEnKhW//Bl6T/LTDh9aZcMfzHzXAUF58iuERsvity?= =?us-ascii?Q?39/ISgKdOV3ue76//+OwtXblnW22o/v4EwWDqI/6BSVxr4Z9XsifkGqs7F+d?= =?us-ascii?Q?EkQ8q9xfMH4wvW9yQHw88NfL6PSmRXdsPDS8WRlY0ZN8givLxNFnlXM1di8a?= =?us-ascii?Q?MQIPzqpcqMwO/bLgUVS6Rr319QorTd38qPKobfX+v8SNG2wljEXAqYVl5xGE?= =?us-ascii?Q?KlO75gc+Swpcky7wMcn8mkeyrXu1oryW8xBu5GIq1ka7n5cQ6hxqxwtbt791?= =?us-ascii?Q?AF7keB1nmiUfmlsAGt6u6d0OyBVeZZhq083xjfVbeG8Uv1p5Q5fnfGUmxjSB?= =?us-ascii?Q?S4tVyIE5fIvlwhLckI88aIPF6YRCjyNKJkQwVELDBccbpdUX7n5FeGA9Wt5J?= =?us-ascii?Q?Nj22T3E5GrU7IN5XzPS9+vuNjtLwAUS0nKceQTqrVYSEdY52a2a7JuONmo/r?= =?us-ascii?Q?10Z3yGWZwSalw7nozOXdzQYBK0T/7dAUM8WnqNLGnQXptJpc91O/lcoDD7gF?= =?us-ascii?Q?g7JjXJuArrkP2aFLCg2QelIO+Ue7hv10g9sWDaXyVoBi3MBAp26yd9I2kfqB?= =?us-ascii?Q?wFvT2wvl48/nrIDzr4wOlUyxeXciMhNxWGQfL5DNB50tVTOx6qilcTTEC5hv?= =?us-ascii?Q?U3ZRY75kouirDfBSeCNJj8tG+p9wPN1Us9yO0SIhElNOdD5wELeUjgh6XRq9?= =?us-ascii?Q?7wwPIvl6nQU/WnfejjCaG+lV2pHO7SPNYfKZBzwKHmNfiGO1A8fpjTYmEv/I?= =?us-ascii?Q?7LlbgHNJLAMiPbQr7ajCSRGJ5dKbNx07fI9m41Rn+kCqn+0NQ6T511fAeLkB?= =?us-ascii?Q?hdIbbzPZC2+qgIH5y5+CfGc9+oSHootLfxQQE++eFdJJaEDPGw/5o2tz3ZJZ?= =?us-ascii?Q?VhNDqPjy7OAdmGIhXFjoRF9mU5+TQok2ESuFYcRCSjZQ4XbKS6LSP6nE4P0T?= =?us-ascii?Q?jDa0fJz9VQ5g/le06EeQk+qcwbDMr84rEkXiDPHxV9BaAj/9UTMhO8hrf73n?= =?us-ascii?Q?0BaghCk16SF242qQUnFqSAPs7sPgdFNvNSNHiD1wGMolBR2fF73jHmwDZP7s?= =?us-ascii?Q?catFhMeT8Q=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 920a6793-387c-452e-4b0e-08da3a329732 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 May 2022 07:30:18.5153 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PyL7r9beekPmOFOxvshHyVsSmaGjm3wxLOGXWNSfRRQOAOlwsnLrHz2GE+bKr3VoyvQpqerb3TMowJxvuzBRMg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB3607 X-Proofpoint-ORIG-GUID: Xcsq341QyKcdcJbPBA6pSWNhPJofX_Rp X-Proofpoint-GUID: Xcsq341QyKcdcJbPBA6pSWNhPJofX_Rp X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-20_02,2022-05-19_03,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > This patchset introduces some of changes discussed on mailing list > for 22.07 release in cryptodev asym. >=20 > Key changes: >=20 > - It fixes API for RSA (expescially signature paddings) > - Adds Elliptic-Curve Diffie-Hellman > - Removes LIST_END enumerators (ABI issue - supressed asym_xform) > - Adds Eliiptic-Curve point verification (DH verification - but will be u= sed only for > EC) > - Adds RSA missing padding fields. > - Adds asym op flags > - Fixes many API comments (like EC curves) >=20 > Commits are grouped by functionality, and mostly independent. Please ensure all commits compile individually. Also mark previous versions in patchworks as superseded. >=20 > Arek Kusztal (40): > cryptodev: redefine ec group enum > cryptodev: remove list end enumerators > test/crypto: remove list end enumerators > cryptodev: reduce number of comments in asym xform > test/crypto: removed asym xform none > cryptodev: separate key exchange operation enum > crypto/openssl: separate key exchange operation enum > test/crypto: separate key exchange operation enum > cryptodev: remove unnecessary zero assignement > cryptodev: remove comment about using ephemeral key in dsa > cryptodev: remove asym crypto next xform > crypto/openssl: remove asym crypto next xform > test/crypto: remove asym crypto next xform > app/test-crypto-perf: remove asym crypto next xform > app/test-eventdev: remove asym crypto next xform > cryptodev: move dh type from xform to dh op > crypto/openssl: move dh type from xform to dh op > test/crypto: move dh type from xform to dh op > cryptodev: changed order of dh fields > cryptodev: add elliptic curve diffie hellman > cryptodev: add public key verify option > cryptodev: move RSA padding into separate struct > crypto/qat: move RSA padding into separate struct > crypto/openssl: move RSA padding into separate struct > crypto/octeontx: move RSA padding into separate struct > crypto/cnxk: move RSA padding into separate struct > common/cpt: move RSA padding into separate struct > test/crypto: move RSA padding into separate struct > cryptodev: add salt length and optional label > cryptodev: reduce rsa struct to only necessary fields > crypto/qat: reduce rsa struct to only necessary fields > crypto/openssl: reduce rsa struct to only necessary fields > crypto/octeontx: reduce rsa struct to only necessary fields > crypto/cnxk: reduce rsa struct to only necessary fields > common/cpt: reduce rsa struct to only necessary fields > test/crypto: reduce rsa struct to only necessary fields > cryptodev: add asym op flags > cryptodev: clarify usage of private key in dh > crypto/openssl: generate dh private key > test/crypto: added test for dh priv key generation >=20 > app/test-crypto-perf/cperf_ops.c | 1 - > app/test-eventdev/test_perf_common.c | 1 - > app/test/test_cryptodev_asym.c | 117 +++++---- > app/test/test_cryptodev_dh_test_vectors.h | 1 - > app/test/test_cryptodev_dsa_test_vectors.h | 1 - > app/test/test_cryptodev_mod_test_vectors.h | 2 - > app/test/test_cryptodev_rsa_test_vectors.h | 2 - > app/test/test_event_crypto_adapter.c | 4 - > devtools/libabigail.abignore | 2 + > drivers/common/cpt/cpt_ucode_asym.h | 12 +- > drivers/crypto/cnxk/cnxk_ae.h | 44 ++-- > drivers/crypto/octeontx/otx_cryptodev_ops.c | 26 +- > drivers/crypto/openssl/rte_openssl_pmd.c | 47 ++-- > drivers/crypto/openssl/rte_openssl_pmd_ops.c | 33 +-- > drivers/crypto/qat/qat_asym.c | 28 +-- > lib/cryptodev/rte_crypto_asym.h | 342 ++++++++++++++++-----= ------ > lib/cryptodev/rte_cryptodev.c | 15 +- > 17 files changed, 358 insertions(+), 320 deletions(-) >=20 > -- > 2.13.6