From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5152BA054D; Thu, 26 May 2022 13:02:17 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3508B40151; Thu, 26 May 2022 13:02:17 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 1C74A40150 for ; Thu, 26 May 2022 13:02:15 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24Q9AURH023391; Thu, 26 May 2022 04:02:14 -0700 Received: from nam04-dm6-obe.outbound.protection.outlook.com (mail-dm6nam08lp2044.outbound.protection.outlook.com [104.47.73.44]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3g93ty8d7m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 26 May 2022 04:02:13 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FzNhax5trLOm1g+hsHn0X2f+S4rA+T8RLyTMrXOd67L1sye2GFPgbo6L5mskQRCqSi0VTsZ8Z19CJX99D/xWtAtqzX7cvwXI5LChEkfS/9Nw5chfiSuqnmPhX3pWYrE9bDBQOfRj/dBbEcJHNWaZQum728VCVyKU70/YVGuBmSKqypcoc3Y7PxRHtoZ8duLENo/9g5AlRA+oB9F5oNDgnFqDDJXG9YBZ0N+M9eXwodIgXOAlfPDwbwn90e7a8pBapTTAvTvrILyowWyGtZUv4Sgb6FcwmxeIxKlZVPTNmPXHOhPr0OG1jLOXauERHf1HL1CDdVnV212Eq2Du44aqQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z5FFeBvYmHL0mvta4yQ2aar80PPR7bXOK1cuiGa1GO0=; b=W8czHvuxo4+HBHUpqirNLlydeOgRiP8vix3dptaDDhAYQggAJD+JwFBtGOtKyntxdhylAlH69vC3D1HnmJHxrxq7vOtfQWK90XheHTo7B9gXkV+nrUHn+dJ0GnFgUfXmCoauXW/TJDFzDvaj6A8JLMaLYATb4nhJLncapfej0MMyteKVjfSpOMm+udZyI0FSb0kWDPqYrU5yvOfOP/4BGcLTS57QVEXcyRorCYOe1/wEWFExiEykIRH+Lsd1pLJOApZzeDgLrncpgLjy+4CtVm+rOpwYGoVtdUnNOm7PzXzsj3+QZRWGTxhwETy+ewLYe+KO35RLw1pSsvD8dLrd6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z5FFeBvYmHL0mvta4yQ2aar80PPR7bXOK1cuiGa1GO0=; b=leVUFoFjeT0zo4S+7urcZce2/W9Uu2FSTHmyqaXvP10W+K3J6yAnJkY1V21NU1D/Fj9TtqJrH3XL2QLtsUC0iKbjkPjPYFkdTurYeXpWg9u6hyq+OUIJfs8IyQCeaZCPnVt80Rl4UW0KCwauTraHJ4NBP63DCVDcElNszPA+2zk= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by SA1PR18MB4726.namprd18.prod.outlook.com (2603:10b6:806:1d9::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Thu, 26 May 2022 11:02:11 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::f154:453d:893:f6ce]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::f154:453d:893:f6ce%7]) with mapi id 15.20.5293.013; Thu, 26 May 2022 11:02:11 +0000 From: Akhil Goyal To: Arek Kusztal , "dev@dpdk.org" CC: "roy.fan.zhang@intel.com" Subject: RE: [EXT] [PATCH v2 04/14] cryptodev: remove comment about using ephemeral key in dsa Thread-Topic: [EXT] [PATCH v2 04/14] cryptodev: remove comment about using ephemeral key in dsa Thread-Index: AQHYcFl5kq2qKHRUIkSWpwGufYqw1q0w/v9g Date: Thu, 26 May 2022 11:02:11 +0000 Message-ID: References: <20220525155324.9288-1-arkadiuszx.kusztal@intel.com> <20220525155324.9288-5-arkadiuszx.kusztal@intel.com> In-Reply-To: <20220525155324.9288-5-arkadiuszx.kusztal@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f8377bd0-a1ec-46a2-e834-08da3f072f40 x-ms-traffictypediagnostic: SA1PR18MB4726:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: r+FSHAtEAXprpesA6FTR74NRdZIBE2f9MccpQZV04KOr2rm5t7weLxytYQFrVipHdDJmUrM8c+qToHdHrdSDSxCPq9M3DKt+RlhNpVgGbvjX7Erd5dn5Ag7nIgH0otM3VQlfE+PuE9QqvIengEkVBejaN++JvQFtyK++B6JAXPYoLu3MD6B1Lk4UobW180KO84qh2Iti6yk3IoRVMFA1JgrZALYRamF28V3NMUQSS8Q826KwJlgAWBdBjP5LcyTSXR6lGOR1oHKRrzJKQR/Lg69o9UOGL+0V3cADgQQzrd3/Uw1ml0tCiEhCUVMuVmrTFnCNgq73hf4mD4I2BRt2lRoOdgF6hNolBjPyhEDF3pbALJz2l4TECKbbmn9ZE58YdyFhifxfwSpZFj8jenniG0EEJw+LC4it4mOpzQQPZ7zS4XIgc9xK50CfHdc00KLz58KnjjksFPdLy470IdV3B07YkL/Iv1zvPJ/t/L++L3jHAYfSpibEIs3TY8w7dVWmSJj0+VnJTNN1mvnzxjIjET15CMu3OY6I2wVqHpQiEBb0HppjXXBUKeweDJeKgifABY+lh3BthanyxU+ODSMJW2qIELanVxZ2nUkVyD8DpnIPq/lZFHt0gG15+D2OG3c8zxTvc61iK28q4eDIik0g/CaGzR0TkahAKfbqp+hZLKWvIc46CICxOT5sNx0vuEij05yVyvZghcDQTossmfiasA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(186003)(2906002)(55016003)(26005)(5660300002)(33656002)(9686003)(38100700002)(38070700005)(122000001)(71200400001)(6506007)(86362001)(55236004)(52536014)(53546011)(8936002)(110136005)(76116006)(316002)(4326008)(508600001)(83380400001)(7696005)(8676002)(64756008)(66476007)(66556008)(66446008)(66946007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?NzbrVISpbkDOaMmPfPBeXTIcwxI4wLEtvl/z3UmZ/g0P5XSCEnzK6SiC5huF?= =?us-ascii?Q?PCMd7BZx63tGrMh8rsdbBGiqKWc6IBr3339x3KmjrPohZ6HQXULxiwnxpOFO?= =?us-ascii?Q?b4MytSze0cuww/eHd+bFt555CrEocGqOsWUm++jVfpL5rElfR8Lt4z2nvPlQ?= =?us-ascii?Q?f4UeWAt3LNRmV7gOYS/SfRcXL5SlnPS46mqHZuj3YgoyZsfpucxJOS/AVMkk?= =?us-ascii?Q?bF5NSJsr6Ky5GielerhrXHh2BmgT8pP2fNeFk4GkrlPYHKNXXfWyzYU//Mhj?= =?us-ascii?Q?UYC7wwOOmxrF/WsE+c6CFYAWXVe3zwq0WvSG5Ib/ag4/RdpGx1BDRwa5HRfU?= =?us-ascii?Q?WGtMvyiROdzXSEYMt+HulXvNOw9nrYrewf76AGM+JsI66+pBFQVhT3XsIPrD?= =?us-ascii?Q?JDE84dvKZ2sO+uGQrV2bXd62EiMkAB1+mIme9jjuNfoGhZ5m4h91x18NbYgK?= =?us-ascii?Q?Sg6TQkNPxtdn8kVCfi78hVk5B3/LDb2VO7ZGX5qq2rz3631GxZDx7jidH98l?= =?us-ascii?Q?zHKze52fDrvaa8qRg9KOIaFS0iZNerfdUhGwFFin5SK/j0EUwOPNJslzwsX8?= =?us-ascii?Q?8Hf3gp2AQ7OWippNkGmRBRz3ZtIIGGGS5O2Yggm5dRmWpDefIGTqk8VvQ+V8?= =?us-ascii?Q?gyyBOEZ3ENRJclgb5ufN+9Svx2vyvhOwJ5xuUpXxKL1zvR1wXAYbk5Qop9ao?= =?us-ascii?Q?LIUSaPZJ2cT9tn5Ezqu9l6urnIVjwY320oqOFTw0C6DfVVnVSfHCkpHYI56k?= =?us-ascii?Q?BBHA6+VXjS0mUXMKpJi1XQJn36mYoB3EPj0OSuCSS5t7zivHqLulNRgTBF8a?= =?us-ascii?Q?hC8sBJqEJe+sLV2TfAbPb3YosjWHHA2JndrwLxQRPO8l9dIyEy1d46BykQmY?= =?us-ascii?Q?4Ftc3y5sFzAXaKld650Tf4XG2euUIpv7kaeCsOT0HXebj6sbZtToILrDtkEq?= =?us-ascii?Q?61Nt2c+Bmpx+go6ZwX/GgLAjtBImd/qAn5X6iV0E4ZaM/PIoT+/x41iEr5u1?= =?us-ascii?Q?/EAHvxOVZVErTP0RvTrYrmOYfrLaAZRY4W9aQr9YFaSbhzZ1eTQEFqkc50fF?= =?us-ascii?Q?quHzdwfB6phdg3cOTRv/bv+ygKeqGTinswsWVpmB3MMYDacXFMMrt0geiiOJ?= =?us-ascii?Q?MJpylyvLzTPkdZ3yz/GAkQ+vnrldiyELNiIF8HO9OdR//8xyhAejaIP7Euvn?= =?us-ascii?Q?K/GmvCnbZMnGFjdjvPPKbQV9n9c4wsW9dybpN0HyK+Sh2jzB62DmYBGpOJ81?= =?us-ascii?Q?jEV4rufHOkqr0ucdZUmcMefeecELnA0PAMEHU4x/6QQa+eXWNLZIHISh+iMX?= =?us-ascii?Q?N9u6UUugG55ROLobBgt2VNV9vnB/2Oh3E9k4rlpy+4wXfmcUpGHDcFZsa5PS?= =?us-ascii?Q?9lS2iYhir884yoUmopob3e77VcbGZR8hYsHXJni/DBcQgttbrmp1O5GHvuSG?= =?us-ascii?Q?/8O1kM3owJWf6cqjLjnkUCR/ODFNIDby5YUt/T80Fd2+KDuWyxsgmAQYRHUO?= =?us-ascii?Q?7Kkb0En40xrAb8DIqeiI4GrVO0UR/lzMqOR+vCHUU4aLTivf1lumh8ZrQ6eT?= =?us-ascii?Q?3/9cLVwKq5jZGnlufR3+WQc/AjRIfhQgTK9rLLPVRUTSvKcdDgDXF+KhKK25?= =?us-ascii?Q?EqkcG4xhgkAqb4ep0atlDiA354YoJkRR2ZxQPuhnorj1PrpVoEjRUXTYfax7?= =?us-ascii?Q?4qej+GYfN6dne6O/X5CC6S2LqW4NqcrC+tR+3aZvGIFC+iWvIWx26fsSmbLD?= =?us-ascii?Q?Lxo3n8N6sQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f8377bd0-a1ec-46a2-e834-08da3f072f40 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 May 2022 11:02:11.6137 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: TrYNW2JhpTch+joiCyHFtPomOfngEPiZw+ABVf/vBtTa+yOpdFRlHZWKA8dYXStyXdlRORKLzNTZTmnwpCbVIQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR18MB4726 X-Proofpoint-GUID: 6CKO3JwaGqWby64C-icZCLH65vQRQ9xN X-Proofpoint-ORIG-GUID: 6CKO3JwaGqWby64C-icZCLH65vQRQ9xN X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-26_03,2022-05-25_02,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Arek Kusztal > Sent: Wednesday, May 25, 2022 9:23 PM > To: dev@dpdk.org > Cc: Akhil Goyal ; roy.fan.zhang@intel.com; Arek Kuszt= al > > Subject: [EXT] [PATCH v2 04/14] cryptodev: remove comment about using > ephemeral key in dsa >=20 > External Email >=20 > ---------------------------------------------------------------------- > - Removed comment that stated dsa can be used with Diffie > Hellman ephemeral key. > DH and DSA integration allowed to use ephemeral keys for > random integer but not for private keys. >=20 > Signed-off-by: Arek Kusztal > --- > lib/cryptodev/rte_crypto_asym.h | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) >=20 > diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_a= sym.h > index 2b427afa3f..ef8686fda8 100644 > --- a/lib/cryptodev/rte_crypto_asym.h > +++ b/lib/cryptodev/rte_crypto_asym.h > @@ -270,13 +270,7 @@ struct rte_crypto_dsa_xform { > rte_crypto_uint g; > /**< Generator of the subgroup */ > rte_crypto_uint x; > - /**< x: Private key of the signer in octet-string network > - * byte order format. > - * Used when app has pre-defined private key. > - * Valid only when xform chain is DSA ONLY. > - * if xform chain is DH private key generate + DSA, then DSA sign > - * compute will use internally generated key. > - */ > + /**< x: Private key of the signer */ > }; Acked-by: Akhil Goyal