From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 949B7A0543; Thu, 22 Sep 2022 17:37:39 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2632740156; Thu, 22 Sep 2022 17:37:39 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id B9BB0400D7 for ; Thu, 22 Sep 2022 17:37:37 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 28M72ngZ032741; Thu, 22 Sep 2022 08:37:37 -0700 Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2103.outbound.protection.outlook.com [104.47.58.103]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3jr1qmnq1c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 22 Sep 2022 08:37:36 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vi6nlaGpJ7jHfTtg+1apLr9Xpfj9S5l7xYhw2brOwQWMmBLe2ZSa0VEzPRtD2n/nyUjTohWWQDwiMmKJZ3tf0XbCCJGgJbQOrtLK1agXJ5CXP/XGRwLktwOocrRX65J48D2YIYymiRMxU0Fia8oO6NbGndvTeD9Q8/dUC+VhG3/nc4JNc7pJXCypFyXLgnRXbK/PX2fcyRCBg99iJy/uQUW27XephgrY2VoIEv6eL6rf/LKphonp95BPIR7tvTbv/iOjbsByWCsvTLebDZHmKrQEG1TVxLitdmLMa0Knf8X5Hu0JC6Im219dSOJx4jYx/M52RkuiSaLAGSlfz2Mutw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NPR0hQ0S+bwjrOC15UMzoOcX1ytpFAfqIQAct6sale4=; b=TvOZs5moL9oZzgF/aeyNIIzRX+PtZRuuLu5Mv+e/kqH2VFBt3tP6yHKeYWINDL1Hps61m53gEKS1RpJ/faXR9vfTUiXlAKQXkX4YiyIyEvuoHLSydDeb+q7431e6MQn/3g5V+MGws8+2HG8oN3g+peQNgf/SlrvdMyerz+LCST8RAppJ5HczbrjGFJEc5VBtFGj3i1OZ1b8ta6/3mbCds+A5TDEP9MRelT9WSeKX9cYIuEI2ssW4ymDExzOOgT1hJx50c5ZI+Uy3miGyyfyOSnaSnppl4+SjLDtN9Fpmjf7bbJNvJ3f6JT610ltg48SFHDU5m46s5IZYrLkUxYi65A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NPR0hQ0S+bwjrOC15UMzoOcX1ytpFAfqIQAct6sale4=; b=I0rweoSdQtvGXnzJcFEh6AXI1fMjpsO96CU2fpXvgC8qIAlURTv/YlFmzL5uvf7xs8QSSNRoT47tH9TdxmiR6J1gHLktkVooAxfWteutCVwO1NQloNxOJRTfPhu+cEC7MXu839BoSM1h3AN1aHNlU1ecjAxuJQDbuLEGuNy4P5E= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by CO3PR18MB4864.namprd18.prod.outlook.com (2603:10b6:303:165::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18; Thu, 22 Sep 2022 15:37:35 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::7cea:d050:5433:8c74]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::7cea:d050:5433:8c74%7]) with mapi id 15.20.5654.019; Thu, 22 Sep 2022 15:37:34 +0000 From: Akhil Goyal To: Akhil Goyal , "dev@dpdk.org" , Qiming Yang , Wenjun Wu , Jiawen Wu , Jian Wang , "hemant.agrawal@nxp.com" , "konstantin.v.ananyev@yandex.ru" CC: "thomas@monjalon.net" , "david.marchand@redhat.com" , Vamsi Krishna Attunuru , "ferruh.yigit@xilinx.com" , "andrew.rybchenko@oktetlabs.ru" , "yisen.zhuang@huawei.com" , Igor Russkikh , Jerin Jacob Kollanukkaran , Ankur Dwivedi Subject: RE: [PATCH 2/3] security: support MACsec Thread-Topic: [PATCH 2/3] security: support MACsec Thread-Index: AQHYsA4zaInDS8iPpEGx5CI2RgW+ya3r0Hcg Date: Thu, 22 Sep 2022 15:37:34 +0000 Message-ID: References: <20220814184620.512343-1-gakhil@marvell.com> <20220814184620.512343-3-gakhil@marvell.com> In-Reply-To: <20220814184620.512343-3-gakhil@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR18MB4484:EE_|CO3PR18MB4864:EE_ x-ms-office365-filtering-correlation-id: 3aef2dc6-6b81-4d27-de43-08da9cb05f09 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KLU7VYAktEK3Psgixw4lukj1jniq7tajKloqwa0fSfDCd1FFItKtT4OLIcH0llCJpsKwCE81E2Izw7R/Zlqw5wWMqwfMO6+5pj/+U3hkAFXdwREiZncBqCbXGvW7DNsAzEGhcTir0ZZEba9MLhCylM3FR+fAEeH7tYRrEIzGoPmqD7h5WaY2Yo8GxintiDMYfN2oY6uUwStPygEw30waoP9PxWEfOdzKzYcyw8MFQb8pv6mFXJHKWeYwsSA/Et22XShNvrqo7D+Dj1N+XHURH4S3lUjXfotqQuXa0znWfv/zbpFy/j/T20W0dM6FsARkvCWOCXqwaG+gZ6PYddqM4u3qBR22tyd5tCsB3zlfTgGu6DTdHGXFRd57Be4VPgLE/k6Hjt64nAh2AuXn/FPnPWoyq+OPO+G5/ZQ+iuLEzcy/+rujDrXfh7w2YVauI8jMXxUAXgka9dT3G4xoQUKLPq0yfNo1fENVtMEoMo9FXChBY4a9NciqJ8BldhJVoVvbtg4YlYZCiX/n/4FF5zSN62id+yDNXpo3JRarO0R6e7psQjPRTXBCa/WHZ2X35G/n9Rt15ReuRzz8Nh5Ya5t1ZRr1/fqYeRVGlMprNbanO8IHOHHalCIlQQwrdhiw7yorcdEIH7mPB8NxOd09gHe1gN15niVy1+tQ11HuQNYnR9aEznlwYT4qf0zuwonNkv+LJucIMs+WfQ2HmFjBgkmn7TDiWgHCOxymR0vJ3LxfGl+Fg8zDB68ixCu/tcobcPGPXUK2tOuvwfFSFMi0K8i26w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(376002)(346002)(366004)(396003)(136003)(451199015)(122000001)(38100700002)(316002)(110136005)(55016003)(54906003)(52536014)(8936002)(7696005)(55236004)(6506007)(83380400001)(86362001)(5660300002)(7416002)(26005)(33656002)(107886003)(66476007)(9686003)(4326008)(186003)(41300700001)(66446008)(76116006)(64756008)(66946007)(8676002)(66556008)(38070700005)(15650500001)(71200400001)(2906002)(478600001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?GzPn7hQEg6SsFtHefwlC5Q5AIhTwYUD8gFZP7P27KMiR0t+nr2ekR8MFNFwf?= =?us-ascii?Q?h/Y7vZXEzZOyg+9918PeKdCfn5Wr6FtiuUY6xcpdkAvW4kdqEvpP3tztN+Hr?= =?us-ascii?Q?AeYJ0qnDo3OkCCjYvh84jXxa0cQIsp0EEU+JcDQd82WOXcxBJObarwTskp/S?= =?us-ascii?Q?wp0nugytF8jnzC9shoa7Cg3RNH2xjOuDWv73RMQ01pqoO444HqOFCS7jZh4v?= =?us-ascii?Q?U6yv6lwUvTEGpHIAxCUiRNdGStjoGzU3SKwajVYvIyV9IgPawVIqc9EIxFlH?= =?us-ascii?Q?4mCKqkJNdH09hMebXL8BFAM3byXEmQYR0daS5om2ZXtzaMUfLjgS+INMiea9?= =?us-ascii?Q?uZQUrH8oBrPwQbAf/PbhO4RapOEB22TBo3qcY3fxq7d/S+9bFtSO8nUHP3O4?= =?us-ascii?Q?7UBZGwnZNaPZUdFd/YqTEQK7tvBPzhUhtKKg9jqvbT2wrGHoP5TqcXTy0Y9/?= =?us-ascii?Q?Rsp59Hz0MWiS3blE8iT6oFANzwHqPTOAd7ixWYY+n/Vu87oy/Ssz/5NOKUEv?= =?us-ascii?Q?R+lD0wosQEluIRXGm0lh/vn0a4f8jbWDjme6odWyZey5BXYeh3zZ6n9Tokb8?= =?us-ascii?Q?nInkVN8RAMlz6CVix1+RaJAJ7Dd2LthqeJKYFU3aI+OKjgH8mve1NK8k5cqt?= =?us-ascii?Q?egzHqFNMf9qWpuOkAanbMqdZ50ajMis4tLnwOHKtu6tr6J/cEGjHh1AM0NVO?= =?us-ascii?Q?ldTwiiqRUz8IA5RVNCIbQamkn1lX0WcQbTYXgKQS3nHlCeO6dF5zuUMa6S2q?= =?us-ascii?Q?vkxXOpWZrpr5LLmmzEBb7m64mjG1Mw5hB3ckWGQqp5hkLImXoFdcSgd+8LkA?= =?us-ascii?Q?YiUP3nt9G/uGPPzwB1hElSeyrkKsEXbPWUBO5Lg/VYuo+YOFDnF8xjDZYYL0?= =?us-ascii?Q?cNrNgWJz9mXlQ3qYwCgjLx2qOQoce7wkq/9QnJnQBy7PszVT1x5TyuSctY0I?= =?us-ascii?Q?eP2++lBtzqewdb83k61ml3LBhpebPtivDHVVAnX3tCet5BnS5sYs812SGm/w?= =?us-ascii?Q?gxwaIo4FphjVEXHmAsYfUqcNSCklkPDhTTXjxbpFBHZGN3PxjYb7XcQrd+cr?= =?us-ascii?Q?252i1Q9PinrplDejrlHFLwisprTziBCopem1Lmz8UuK5XUZChorwzxJxiqtJ?= =?us-ascii?Q?PfDH/huZIMsgyOnQPToHbCgDRUR31F4qd0F+88X4oW3PZxAGzKBPRx0cxAh+?= =?us-ascii?Q?+ucBwQ0kyEmnaJnUTYtJzE16979cpEihzOUwOXyqQxQdHebJwHBuPL48gghA?= =?us-ascii?Q?KbXqZLCiMIlw6vk7oyZLgDdXf7trUcty2BmlrQNF4Q+A1o+ciBswQXWR0bof?= =?us-ascii?Q?ra8fN9NHRGkXkKYTuoVmpz5URVmqVycJWRYoXrPJMrqvfdZFVc6dERNl6K3n?= =?us-ascii?Q?gu6+2LAfkKg+V3uHg/xefYGRWdp+de2YpP+WIfkJLu8lRxqKi4I3PsRcRGq8?= =?us-ascii?Q?1ZhebqQEIvTZx5H/VeTYK/oPnVe31DMRdXa9rMirOX4oQCZYpd06FWaQKm17?= =?us-ascii?Q?J/dTmQZNmvVq2u6DcZbuaeP8VzOTSer+9ek2FMx3fZOAOrpjECqxsXDMMwR+?= =?us-ascii?Q?TN1lwhJzjI5qugqRvLB85Snz9OwOzbTsZPbPbhOr?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3aef2dc6-6b81-4d27-de43-08da9cb05f09 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Sep 2022 15:37:34.8693 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: c5qrQm3N7g89MhnGYEtl0g3vgJzATge4TsfgMN/FWBKWpYIHJP5aHtaokte51DIAaeCnwvE/oDmPaX4crwBdWg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO3PR18MB4864 X-Proofpoint-GUID: ndKB1TgIEINMkTbkbVvpOFzLodba-CIg X-Proofpoint-ORIG-GUID: ndKB1TgIEINMkTbkbVvpOFzLodba-CIg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-09-22_08,2022-09-22_01,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi txgbe/ixgbe maintainers, I see that MACsec is supported by ixgbe and txgbe PMDs. Could you please review this patch? Regards, Akhil > Subject: [PATCH 2/3] security: support MACsec >=20 > Added support for MACsec in rte_security for offloading > MACsec Protocol operation to inline NIC device or a crypto device. >=20 > To support MACsec we cannot just make one security session and > send with the packet to process it. MACsec specifications suggest, > it has 3 different entities - SECY Entity, SC(secure channel) and > SA(security association). And same SA can be used by multiple SCs and > similarly many SECY can have same SCs. Hence, in order to support this > many to one relationships between all entities, 2 new APIs are created - > rte_security_macsec_sc_create and rte_security_macsec_sa_create. > Flow of execution of the APIs would be as > - rte_security_macsec_sa_create > - rte_security_macsec_sc_create > - rte_security_session_create(for secy) > And in case of inline protocol processing rte_flow can be created with > rte_security action. A new flow item will be added for MACsec header. > New APIs are also created for getting SC and SA stats. >=20 > Signed-off-by: Akhil Goyal > ---