DPDK patches and discussions
 help / color / mirror / Atom feed
From: Akhil Goyal <gakhil@marvell.com>
To: lhx <li.hanxiao@zte.com.cn>, "dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [EXTERNAL] [PATCH] zsda:introduce zsda drivers and examples
Date: Tue, 2 Jul 2024 13:11:36 +0000	[thread overview]
Message-ID: <CO6PR18MB44840D86BCE2B8301EDB7514D8DC2@CO6PR18MB4484.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20240701082751.3479106-1-li.hanxiao@zte.com.cn>

>  create mode 100644 examples/zsda/Makefile
>  create mode 100644 examples/zsda/commands.c
>  create mode 100644 examples/zsda/meson.build
>  create mode 100644 examples/zsda/test.c
>  create mode 100644 examples/zsda/test.h
>  create mode 100644 examples/zsda/test_zsda.c
>  create mode 100644 examples/zsda/test_zsda.h
>  create mode 100644 examples/zsda/test_zsda_compressdev.c
>  create mode 100644 examples/zsda/test_zsda_compressdev.h
>  create mode 100644 examples/zsda/test_zsda_cryptodev.c
>  create mode 100644 examples/zsda/test_zsda_cryptodev.h
>  create mode 100644 examples/zsda/test_zsda_cryptodev_aes_test_vectors.h
>  create mode 100644 examples/zsda/test_zsda_cryptodev_data.h
>  create mode 100644 examples/zsda/test_zsda_cryptodev_hash_test_vectors.h

Along with the comments from David, one more high level comment.

Why do you need to have a separate example application?
Can you align with app/test/test_cryptodev.c and app/test/test_compressdev.c?

      parent reply	other threads:[~2024-07-02 13:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-01  8:27 lhx
2024-07-02  8:52 ` David Marchand
2024-07-02 13:11 ` Akhil Goyal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CO6PR18MB44840D86BCE2B8301EDB7514D8DC2@CO6PR18MB4484.namprd18.prod.outlook.com \
    --to=gakhil@marvell.com \
    --cc=dev@dpdk.org \
    --cc=li.hanxiao@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).