From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F1EF442B3A; Thu, 18 May 2023 14:06:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D7CAC40E25; Thu, 18 May 2023 14:06:16 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 45A8E4014F for ; Thu, 18 May 2023 14:06:15 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 34I967ZM024737; Thu, 18 May 2023 05:06:14 -0700 Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2107.outbound.protection.outlook.com [104.47.58.107]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3qmyexbx6u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 18 May 2023 05:06:13 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fo6XYnCNgabb2I6Lp9ytG4xP4RL0qVeparsCD5e2RSpYzmXFHtLm/CEAUETEIPNt6D2pQSA9bNUZ7mzLb1PPTp/k4kcwmZdPoYm1VtWCTrNDgy+YmnGWrH3xMO3tNdmVabn+JMshBSsTEIi6wA4cOAnzru1y4vy2H1zrLeu0jjUm6EoIEjXMsS4+ndntnkKIfesnFMBH3VEzyn2BBTmM+MRwq3UMCsUe4S49Y0KECEXskXPrMmn+hu5C9cDxksYToxxdXGFvN5T/QbTXzkYaCTT7i9wp9cxrGOj4AFah8lNHZzmb8Pw2mzAmP0ToRjtYZ5Be12yeqeFzDSbcifRUig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rBTEiRp/obaRlCFDB6w6VCX+7kMJdghf+n/YnEHDts8=; b=KbkPBoaLJBd95mlIqR3oZ9rqc9Ytcn4+/iIqn4j2cb4ykxypoofh+0H4gDCdzAoQ8GpCt7utwqntgNfF4XnY+4DlH6NebatJv5ShiZ/aUVW0qm7tdj1Q3zcshdgw9OCtexNgBX4y7XEbDf6LgLTyD1aH3PlvUS3WM/1qVSkmGBtzsV5644Rz3DJIy3nMKKALMCIHa5BCNqdSxMYVMgjGC+oFpSbWUL0z5fXKOyp/pUhGtarwylPluDZ1H+kfpK1ZgBZ7ePKZHzpvDSXAaJ6gPKEhgHZTgWQmqbyBJAgyNsZvKE/Tl3+ubXoqumVhfMmRHayikg2MNG3gBpHJDJAhgA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rBTEiRp/obaRlCFDB6w6VCX+7kMJdghf+n/YnEHDts8=; b=XnXP0Iw7GA9unWr81QspLTjzYRoPoxoz3hC6rzoBz/tvUU+Xz3zvD5M820f+as450qKd36TH07R1afeGKzdqjpBKC9Q0K2zilFNaNwfvF2yECF0wx/Ey7EU/l3nApDEUavvfz3sBjFIttYpeS+8rTywHy+WaE6DnuvylyiySv80= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by DM4PR18MB4270.namprd18.prod.outlook.com (2603:10b6:5:395::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.19; Thu, 18 May 2023 12:06:10 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::831b:85d2:9a45:8489]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::831b:85d2:9a45:8489%6]) with mapi id 15.20.6411.019; Thu, 18 May 2023 12:06:09 +0000 From: Akhil Goyal To: Anoob Joseph , Thomas Monjalon , Jerin Jacob Kollanukkaran , Konstantin Ananyev , Bernard Iremonger CC: Hemant Agrawal , =?iso-8859-1?Q?Mattias_R=F6nnblom?= , Kiran Kumar Kokkilagadda , Volodymyr Fialko , "dev@dpdk.org" , Olivier Matz Subject: RE: [PATCH v2 09/22] app/test: add lib pdcp tests Thread-Topic: [PATCH v2 09/22] app/test: add lib pdcp tests Thread-Index: AQHZbvkOXNgVhPuK50eErA5+HpB37q9fzGdggABOJICAAACkwA== Date: Thu, 18 May 2023 12:06:09 +0000 Message-ID: References: <20221222092522.1628-1-anoobj@marvell.com> <20230414174512.642-1-anoobj@marvell.com> <20230414174512.642-10-anoobj@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-dg-rorf: true x-dg-ref: =?iso-8859-1?Q?PG1ldGE+PGF0IG5tPSJib2R5LnR4dCIgcD0iYzpcdXNlcnNcZ2FraGlsXG?= =?iso-8859-1?Q?FwcGRhdGFccm9hbWluZ1wwOWQ4NDliNi0zMmQzLTRhNDAtODVlZS02Yjg0?= =?iso-8859-1?Q?YmEyOWUzNWJcbXNnc1xtc2ctNWQ1NzRlZDctZjU3NC0xMWVkLWEwOTMtOT?= =?iso-8859-1?Q?RlNmY3NjYxOTA3XGFtZS10ZXN0XDVkNTc0ZWQ4LWY1NzQtMTFlZC1hMDkz?= =?iso-8859-1?Q?LTk0ZTZmNzY2MTkwN2JvZHkudHh0IiBzej0iNTg1NyIgdD0iMTMzMjg4OD?= =?iso-8859-1?Q?UxNjY0MjQ4MDg3IiBoPSJDNldEa1Q0UXZIWHZFNGJYa3VIMzV3emd5blk9?= =?iso-8859-1?Q?IiBpZD0iIiBibD0iMCIgYm89IjEiIGNpPSJjQUFBQUVSSFUxUlNSVUZOQ2?= =?iso-8859-1?Q?dVQUFNZ01BQUFYbmZjZmdZblpBV2ZEZG9sd09vNlJaOE4yaVhBNmpwRVVB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBSEFBQUFCWURBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBRUFBUUVCQUFBQTQrVXREQUNBQVFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUo0QUFBQmhBR1FBWkFCeUFHVUFjd0J6QUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFFQUFBQUFBQUFBQWdBQUFBQUFuZ0FBQU?= =?iso-8859-1?Q?dNQWRRQnpBSFFBYndCdEFGOEFjQUJsQUhJQWN3QnZBRzRBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBUUFBQUFBQUFBQUNBQUFBQUFDZUFBQUFZd0IxQUhN?= =?iso-8859-1?Q?QWRBQnZBRzBBWHdCd0FHZ0Fid0J1QUdVQWJnQjFBRzBBWWdCbEFISUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQkFBQUFBQUFBQUFJQUFBQUFBSjRBQUFCakFIVUFjd0IwQUc4QW?= =?iso-8859-1?Q?JRQmZBSE1BY3dCdUFGOEFaQUJoQUhNQWFBQmZBSFlBTUFBeUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-refone: =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUVBQUFBQUFBQUFBZ0FBQUFBQW5nQU?= =?iso-8859-1?Q?FBR01BZFFCekFIUUFid0J0QUY4QWN3QnpBRzRBWHdCckFHVUFlUUIzQUc4?= =?iso-8859-1?Q?QWNnQmtBSE1BQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFRQUFBQUFBQUFBQ0FBQUFBQUNlQUFBQVl3QjFB?= =?iso-8859-1?Q?SE1BZEFCdkFHMEFYd0J6QUhNQWJnQmZBRzRBYndCa0FHVUFiQUJwQUcwQW?= =?iso-8859-1?Q?FRQjBBR1VBY2dCZkFIWUFNQUF5QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFCQUFBQUFBQUFBQUlBQUFBQUFKNEFBQUJqQUhVQWN3QjBBRz?= =?iso-8859-1?Q?hBYlFCZkFITUFjd0J1QUY4QWN3QndBR0VBWXdCbEFGOEFkZ0F3QURJQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBRUFBQUFBQUFBQUFnQUFBQUFBbmdBQUFHUUFiQUJ3QUY4QWN3QnJBSGtB?= =?iso-8859-1?Q?Y0FCbEFGOEFZd0JvQUdFQWRBQmZBRzBBWlFCekFITUFZUUJuQUdVQVh3Qj?= =?iso-8859-1?Q?JBREFBTWdBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQVFBQUFB?= =?iso-8859-1?Q?QUFBQUFDQUFBQUFBQ2VBQUFBWkFCc0FIQUFYd0J6QUd3QVlRQmpBR3NBWH?= =?iso-8859-1?Q?dCakFHZ0FZUUIwQUY4QWJRQmxBSE1BY3dCaEFHY0FaUUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-reftwo: =?iso-8859-1?Q?QUFBQUFBQUFBQUJBQUFBQUFBQUFBSUFBQUFBQUo0QUFBQmtBR3dBY0FCZk?= =?iso-8859-1?Q?FIUUFaUUJoQUcwQWN3QmZBRzhBYmdCbEFHUUFjZ0JwQUhZQVpRQmZBR1lB?= =?iso-8859-1?Q?YVFCc0FHVUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFFQUFBQUFBQUFBQWdBQUFBQUFuZ0FBQUdVQWJRQmhBR2tBYkFCZkFH?= =?iso-8859-1?Q?RUFaQUJrQUhJQVpRQnpBSE1BQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBUUFB?= =?iso-8859-1?Q?QUFBQUFBQUNBQUFBQUFDZUFBQUFiUUJoQUhJQWRnQmxBR3dBWHdCd0FISU?= =?iso-8859-1?Q?Fid0JxQUdVQVl3QjBBRjhBYmdCaEFHMEFaUUJ6QUY4QWNnQmxBSE1BZEFC?= =?iso-8859-1?Q?eUFHa0FZd0IwQUdVQVpBQmZBR0VBYkFCdkFHNEFaUUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQkFBQUFBQUFBQU?= =?iso-8859-1?Q?FJQUFBQUFBSjRBQUFCdEFHRUFjZ0IyQUdVQWJBQmZBSEFBY2dCdkFHb0Fa?= =?iso-8859-1?Q?UUJqQUhRQVh3QnVBR0VBYlFCbEFITUFYd0J5QUdVQWN3QjBBSElBYVFCak?= =?iso-8859-1?Q?FIUUFaUUJrQUY4QWFBQmxBSGdBWXdCdkFHUUFaUUJ6QUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUVBQUFBQUFBQUFBZ0FBQUFB?= =?iso-8859-1?Q?QW5nQUFBRzBBWVFCeUFIWUFaUUJzQUd3QVh3QmhBSElBYlFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFRQUFBQUFBQUFBQ0FBQUFBQUNlQUFBQW?= =?iso-8859-1?Q?JRQmhBSElBZGdCbEFHd0FiQUJmQUhBQWNnQnZBR29BWlFCakFIUUFYd0Jq?= =?iso-8859-1?Q?QUc4QVpBQmxBSE1BQUFBQUFBQUFB?= x-dg-refthree: =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFCQUFBQUFBQU?= =?iso-8859-1?Q?FBQUlBQUFBQUFKNEFBQUJ0QUdFQWNnQjJBR1VBYkFCc0FGOEFjQUJ5QUc4?= =?iso-8859-1?Q?QWFnQmxBR01BZEFCZkFHTUFid0JrQUdVQWN3QmZBR1FBYVFCakFIUUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBRUFBQUFBQUFBQUFnQUFB?= =?iso-8859-1?Q?QUFBbmdBQUFHMEFZUUJ5QUhZQVpRQnNBR3dBWHdCd0FISUFid0JxQUdVQV?= =?iso-8859-1?Q?l3QjBBRjhBYmdCaEFHMEFaUUJ6QUY4QWNnQmxBSE1BZEFCeUFHa0FZd0Iw?= =?iso-8859-1?Q?QUdVQVpBQmZBRzBBWVFCeUFIWUFaUUJzQUd3QUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQVFBQUFBQUFBQUFDQUFBQUFBQ2VBQU?= =?iso-8859-1?Q?FBYlFCaEFISUFkZ0JsQUd3QWJBQmZBSEFBY2dCdkFHb0FaUUJqQUhRQVh3?= =?iso-8859-1?Q?QnVBR0VBYlFCbEFITUFYd0J5QUdVQWN3QjBBSElBYVFCakFIUUFaUUJrQU?= =?iso-8859-1?Q?Y4QWJRQmhBSElBZGdCbEFHd0FiQUJmQUc4QWNnQmZBR0VBY2dCdEFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUJBQUFBQUFBQUFBSUFBQUFBQUo0QUFBQnRBR0VB?= =?iso-8859-1?Q?Y2dCMkFHVUFiQUJzQUY4QWRBQmxBSElBYlFCcEFHNEFkUUJ6QUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFFQUFBQUFBQUFBQWdBQUFBQUFuZ0FBQUcwQVlRQnlBSFlBWl?= =?iso-8859-1?Q?FCc0FHd0FYd0IzQUc4QWNnQmtBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-reffour: QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBUUFBQUFBQUFBQUNBQUFBQUFBPSIvPjwvbWV0YT4= x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR18MB4484:EE_|DM4PR18MB4270:EE_ x-ms-office365-filtering-correlation-id: 372f9ec0-c49f-4f6e-c59f-08db57984473 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: shcP+A2ktH8nsXxs6W5OpzEKO8tvb9B9xQ0ndgPMnvidx6TDjYTml4+Xy5IFzdx3tgkjKSNy5srw09MleymjCSvNwlgcNcvtnbYaDaVHkZcJxFNA19H+fF7IpcpSY9km85BT78gcAQ9Ga2wHHj6ZNF73vXM4Tmsgi2WAPSIuP9vhBH0Yd3GeOTkJs7owk3dWq6LYEi/9Cksl6/YOH7H243VBAVgwb/kGpyuTFbnDa8tYhvBNi90vGH9bddFRAuZOGDaZAVqv6zPyGp7sJv8rPWZA2J3OTEqmgVtAJKKaffIsbAdMzSm7ozIJ04P41ddcDg/aX/WPWuY6o2XztBtSwCBwUdUx9OPsGQIVu9lnsj+WjnIQT85IG//+jimlaF+UU2g3G8dsXAaiWeh6WJc/V6n7dfyi/s0IbYPBXb7mIbp9kaSxbXNppduGUpYDsn14P7FzjGlLAh+PaaQ0m8l+/48Ghkg6uBuoh417yOKwHQ/yvg166TMBhAiDhbjXe0uNZ0NWXixclkPJ4Tl89jjFxRNMGhr4WzTI8gV75BA1KTS6pF+sUXiLiUPvgjL/DdX7cPgU75r+PLqIozafHyHMc6nekl4zg72RUOQ0f/cxj7aXMgKd+6RMTLm7CA0JjuoV x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(136003)(39860400002)(346002)(376002)(366004)(451199021)(316002)(2906002)(478600001)(52536014)(41300700001)(8936002)(4326008)(8676002)(54906003)(110136005)(71200400001)(64756008)(66476007)(66446008)(66556008)(76116006)(66946007)(5660300002)(7696005)(55236004)(9686003)(6506007)(26005)(38100700002)(186003)(55016003)(122000001)(83380400001)(38070700005)(86362001)(33656002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?b6ZLrM9Xm+UDQpuyumui1F2Ga3yVAIKD7IbRWAe4WBUhPFm8CfTMk+NH2n?= =?iso-8859-1?Q?tiPYxknFcNX+XHjVR7nJ9R7elDIwHae4APiT9nmEviZl6APw3lUnrlGH9b?= =?iso-8859-1?Q?5P4jfMOlaFtazRRFUXLJGaamG8X0z0r8ctzggx+Vhilqy2aMk9qLGRIJQs?= =?iso-8859-1?Q?rjc3+rpwLqtnjKOwT4t/poZmwIsdZxOIu//fB8e/juxPSFv14gfSDDKXuu?= =?iso-8859-1?Q?p69TT37G1WGP+KUsausll1LDOEJLpCxZ0SbjsCi7DkGukim/Tc3DuedA88?= =?iso-8859-1?Q?nNl9zzLFxhckJ1H+KoAkwuP8+yqwyH+mieBBIvHMSSZLpI/Jg+tUHvpEC/?= =?iso-8859-1?Q?bHcp5D2O/iisbppuHRFjXfEW4NXxgW1qFQaKuXS1Nh8C1P6kfdYdYWBNU9?= =?iso-8859-1?Q?RCGSfEzfzlKLgEmY7W72vcgVUOk7+svclyhoGINsBCZAm+6N/a89G+oxvB?= =?iso-8859-1?Q?6NQUlyEFTSL0kTFAjy0cYjCmHjrePczkKjTZmQ5OwaJKdYdRMKs1WuAG4b?= =?iso-8859-1?Q?pGz0kKqimxcFy2XYsUiaowm5SoZfY1JDoS96AbAk6T+UPv7/ImIXQ87KFQ?= =?iso-8859-1?Q?PXxEO7YMa/NVwbXT/fe8M53NwZMTLO/bMS0cyV7FMylWbOz6WRv7fUOFyV?= =?iso-8859-1?Q?7TWHMC9thrnOXGrsFs5PCFyfKXxToV/rC6ySSIB+ypLvhZDnyvFZ3V9Oiu?= =?iso-8859-1?Q?vfFiQPkIVrSkrQSw8RR7KZM0hSmDOKn+bTKU8+JiMVuj6rucj5Jk5vuA5n?= =?iso-8859-1?Q?GPLLrunQjFZSpPQQxigU5A+jkZGjpDsSkL9bVr2BxdSay9xvY0OBfmnNfy?= =?iso-8859-1?Q?qHpf9TFIpFaVf0+kgonuuaOeEtRGLLfGV+WSDm55t/I29SKfenmoIg1O0Z?= =?iso-8859-1?Q?h9g4Q+FwL+muH0Dm6WkMa5aw8wBVTFtP4jgkmK7BgKNn0i0zkIUf1OS1p9?= =?iso-8859-1?Q?TTz25fhncCA/cbHADdRwugt5oXA5IvSuz+P2KH91JFK9zsnRKzw2IETyGi?= =?iso-8859-1?Q?qjrIr1+IWfpJXU2SuSWrOrWum2UyvWi2ljm1nrlsj8rcYCpestyFRd3EbA?= =?iso-8859-1?Q?/Doej6qKnA4mqGeRGptnWJZKUb/54qgA1bzRwZ0ckFMpyLfIiR7S8ThQ5W?= =?iso-8859-1?Q?8T7weGyKPJEZEh4vZz8nMcASMbcBa9pg5xi6PwH5m9DwFzxYMnTwAyjRjP?= =?iso-8859-1?Q?BZGL0ms5nqYOTuYmTIfbkzpQ3Bi1igcAeDfrNBSa66scZvdHPW1XieBxRM?= =?iso-8859-1?Q?vbW5MNHTDUuBwp5sSXHlDPA0C4RzAC+Fq8yqbuP/S3oPhXiqRSxO5cQkbj?= =?iso-8859-1?Q?iQYf26xE0+lizLI8b/qKfNowxErqAAsnN/wSLokX4dpuyanP0Hpo6aMT1h?= =?iso-8859-1?Q?mmlPNz6nA+IkAz28ek1rzViXXizdOXCcj3Cs+7Vnfp5G4y1Dy3PryKD9dg?= =?iso-8859-1?Q?fqavANFONAft1UuJ75gFS181m+5KIvXM1RBUacaMtytWm764JddDmyvDKJ?= =?iso-8859-1?Q?e+awpBTi0qb8DbwM6XmAfZDQvKkbdjfWhxfORhUeU3w9ZbciROFvw51Exq?= =?iso-8859-1?Q?xBQDQZ+OxTz82ZmglLi3xLOXwO6BydhqDpKB1lhpGBg504VgmJIxY854ky?= =?iso-8859-1?Q?4fi/tsFD1XZQUshaN6S4qLw36HXmTM2wVC?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 372f9ec0-c49f-4f6e-c59f-08db57984473 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 May 2023 12:06:09.7682 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WdmCcnGZEDz8WtGiYzp/vHR/MZFM6+3Pz47kU6+YY65PTpL6WSt74d1Nr/XOvk8OXnCbR2HZQtki3h9vZfTpvA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR18MB4270 X-Proofpoint-GUID: 2GzlCJ-KZSR8Tqy9K58zWuWvKzJfdnW8 X-Proofpoint-ORIG-GUID: 2GzlCJ-KZSR8Tqy9K58zWuWvKzJfdnW8 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-05-18_09,2023-05-17_02,2023-02-09_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > > diff --git a/app/test/meson.build b/app/test/meson.build index > > > 52d9088578..0f658aa2ab 100644 > > > --- a/app/test/meson.build > > > +++ b/app/test/meson.build > > > @@ -96,6 +96,7 @@ test_sources =3D files( > > > 'test_meter.c', > > > 'test_mcslock.c', > > > 'test_mp_secondary.c', > > > + 'test_pdcp.c', > > > 'test_per_lcore.c', > > > 'test_pflock.c', > > > 'test_pmd_perf.c', > > > diff --git a/app/test/test_cryptodev.h b/app/test/test_cryptodev.h > > > index abd795f54a..89057dba22 100644 > > > --- a/app/test/test_cryptodev.h > > > +++ b/app/test/test_cryptodev.h > > > @@ -4,6 +4,9 @@ > > > #ifndef TEST_CRYPTODEV_H_ > > > #define TEST_CRYPTODEV_H_ > > > > > > +#include > > > +#include > > > + > > > > Can we remove these includes from here and add in test_pdcp.c directly? >=20 > [Anoob] Why? 'test_cryptodev.h' already has many references to rte_crypto= dev > symbols. Not including the dependencies is not correct. >=20 In that case, it can be a separate patch. But not in this patch. > > > > > > > + if (conf->is_integrity_protected) { > > > + if (conf->entity.pdcp_xfrm.pkt_dir =3D=3D > > > RTE_SECURITY_PDCP_UPLINK) { > > > + conf->entity.crypto_xfrm =3D &conf->a_xfrm; > > > + > > > + a_xfrm.auth.op =3D > > RTE_CRYPTO_AUTH_OP_GENERATE; > > > + a_xfrm.next =3D &conf->c_xfrm; > > > + > > > + c_xfrm.cipher.op =3D > > > RTE_CRYPTO_CIPHER_OP_ENCRYPT; > > > + c_xfrm.next =3D NULL; > > > + } else { > > > + conf->entity.crypto_xfrm =3D &conf->c_xfrm; > > > + > > > + c_xfrm.cipher.op =3D > > > RTE_CRYPTO_CIPHER_OP_DECRYPT; > > > + c_xfrm.next =3D &conf->a_xfrm; > > > + > > > + a_xfrm.auth.op =3D RTE_CRYPTO_AUTH_OP_VERIFY; > > > + a_xfrm.next =3D NULL; > > > + } > > > + } else { > > > + conf->entity.crypto_xfrm =3D &conf->c_xfrm; > > > + c_xfrm.next =3D NULL; > > > + > > > + if (conf->entity.pdcp_xfrm.pkt_dir =3D=3D > > > RTE_SECURITY_PDCP_UPLINK) > > > + c_xfrm.cipher.op =3D > > > RTE_CRYPTO_CIPHER_OP_ENCRYPT; > > > + else > > > + c_xfrm.cipher.op =3D > > > RTE_CRYPTO_CIPHER_OP_DECRYPT; > > > + } > > > + /* Update xforms to match PDCP requirements */ > > > + > > > + if ((c_xfrm.cipher.algo =3D=3D RTE_CRYPTO_CIPHER_AES_CTR) || > > > + (c_xfrm.cipher.algo =3D=3D RTE_CRYPTO_CIPHER_ZUC_EEA3 || > > > + (c_xfrm.cipher.algo =3D=3D RTE_CRYPTO_CIPHER_SNOW3G_UEA2))) > > > + c_xfrm.cipher.iv.length =3D 16; > > > + else > > > + c_xfrm.cipher.iv.length =3D 0; > > > + > > > + if (conf->is_integrity_protected) { > > > + if (a_xfrm.auth.algo =3D=3D RTE_CRYPTO_AUTH_NULL) > > > + a_xfrm.auth.digest_length =3D 0; > > > + else > > > + a_xfrm.auth.digest_length =3D 4; > > > > This if-else is not needed. If is_integrity_protected, digest_length sh= ould > > always be 4. >=20 > [Anoob] I had explained this in v1 patch set. Will try again. >=20 > In PDCP, with AUTH_NULL it is expected to have 4 bytes of zeroized digest= . >=20 > With AUTH_NULL, it is lib PDCP which would add zeroized digest. No PMD > currently supported in DPDK supports non-zero digest with AUTH-NULL. Also= , it > is not specified what is the digest added in case of AUTH-NULL. In auth_xform, digest_length is the expected length of digest coming out of= crypto device. Now if the device is expected to support PDCP, and we are reusing the crypt= o APIs, We can specify the digest length required for NULL auth. The PMDs capability can be updated accordingly. You can add a comment in the rte_crypto_auth_xform specifically for NULL au= th for PDCP case. The reason, I am insisting on this is, for the user, while configuring auth= _xform, it is setting digest length as 0 and when the packet is received the packet= length is increased by digest. This will create confusion. And it will also help in identifying the case of no integrity and null inte= grity. >=20 > > Also define a macro for MAC-I len. It is being used at multiple places. > > Similarly for IV length macro can be defined. > > >=20 > [Anoob] Agreed. You want me to introduce RTE_PDCP_MAC_I_LEN or > something local would do? I am ok either way. Having defined in library would be better, to be used i= n lib and PMD as well. >=20 > > > + > > > + if ((a_xfrm.auth.algo =3D=3D RTE_CRYPTO_AUTH_ZUC_EIA3) || > > > + (a_xfrm.auth.algo =3D=3D > > RTE_CRYPTO_AUTH_SNOW3G_UIA2)) > > > + a_xfrm.auth.iv.length =3D 16; > > > + else > > > + a_xfrm.auth.iv.length =3D 0; > > > + } > > > + > > > + conf->c_xfrm =3D c_xfrm; > > > + conf->a_xfrm =3D a_xfrm; > > > + > > > + conf->entity.dev_id =3D (uint8_t)cryptodev_id_get(conf- > > > >is_integrity_protected, > > > + &conf->c_xfrm, &conf->a_xfrm); > > > + > > > + if (pdcp_test_params[index].domain =3D=3D > > > RTE_SECURITY_PDCP_MODE_CONTROL || > > > + pdcp_test_params[index].domain =3D=3D > > > RTE_SECURITY_PDCP_MODE_DATA) { > > > + data =3D pdcp_test_data_in[index]; > > > + hfn =3D pdcp_test_hfn[index] << > > pdcp_test_data_sn_size[index]; > > > + sn =3D pdcp_sn_from_raw_get(data, > > > pdcp_test_data_sn_size[index]); > > > + count =3D hfn | sn; > > > + } > > > > The above logic can go inside lib PDCP as well. > > This is specific to PDCP and not user dependent. > > You can reuse the pdcp_xfrm.hfn as well. > > >=20 > [Anoob] Sorry, what exactly can go into lib PDCP? This snippet is reading= SN used > in a test vector and constructs the count based on SN & HFN value from ve= ctor. This count value is being used to establish entity. I am saying, instead of= taking Count, take sn as input and in the libpdcp combine pdcp_xfrm.hfn and sn as = needed to create count and store in entity_priv. Just wanted to reduce the application headache to make bitshifting and ORin= g to SN.