From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 32045A04A8; Mon, 7 Feb 2022 19:28:13 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E7FB4410F3; Mon, 7 Feb 2022 19:28:12 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id ECBC541104 for ; Mon, 7 Feb 2022 19:28:10 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 217Gj2Bg005200; Mon, 7 Feb 2022 10:28:05 -0800 Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2103.outbound.protection.outlook.com [104.47.55.103]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3e30b0aefv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 07 Feb 2022 10:28:05 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SWgFVAQ+n+/pC4tj1xURraO9DvTWW2Fc4goc0kMZS9c+fmw8Zo9gya0ofdO7qJ7BzBl0t1yalaveh67brL3eSwCaVMJZIUoRi5lNMSZ6eTDmxj/GN5SbV+9p9hWI27NzHqvs+gcURIZLjcedwV7F09qNTmvXqLUUuGOZHodtF50S1+f/RF4x5gj88BqUTV2Zl+kyRcTWq98dzDn16mZvML+eMWBaw3u4GcUacNkJ7itb1Ym8Jg9WlS5hjGuu6NMsgJXDPfIr/8OKxaJf4Npmjf46vg5R5+1++qhSfG8sPvFf7wyGgUAM74zWA0JNJTJN4P4e76fRhJZ/vlAb++6MHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U/lxPnzAwTzmD3tHs/znd2iqpMTkeJ0NEGlCuWhl9IA=; b=F131LsiJkheTPmYfNyQw0fliQtEA1anItdT16RVok/2bZnY1RaP7ms0OMfUS6DnVb6XHo/IT+5Gtv+pe1XmQDWNPihr5s0orrgA/kt0joYrrPF/xuxRuwqJaMyUMcyRX+RBqSXu/QiXrKWTYXyIkwAJgGXNMXQWRMqzb7A5lguccb1yEWaZ77ts2COeJsLUn4/zhb6KOqO4q4WVGM8k0DPC/ySIyFbvA2uXt6/J/oqyEmjPTLZt+4Vc1ozTlC+P8Ew4hPKdCJLEjqe/Q/s8W1BQqGiSeBYxIJ6kI2CMRp2aEcDm2YyPWCaBTMXjB4whFigLXlQvokEZw9cRL31glfg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U/lxPnzAwTzmD3tHs/znd2iqpMTkeJ0NEGlCuWhl9IA=; b=l2/d/WoOnQdorV0AdPgQm997lmYUi4ZNgdzz1q68ps/w1LOofm2pt3UQ5nCJ77L4uTCji0CAywbnPeY7PMFCzQ52znXjEzZtsOOiWPa8FcFgBYQTRg0Wjhb5tvzWmAz8DDMyxPbj7v5Z4rlp/nTAndUxMIF9LizACIKkTkGkmPA= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by MWHPR18MB1421.namprd18.prod.outlook.com (2603:10b6:320:2a::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Mon, 7 Feb 2022 18:28:03 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::9985:c3ca:2f91:7fc]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::9985:c3ca:2f91:7fc%5]) with mapi id 15.20.4951.019; Mon, 7 Feb 2022 18:28:03 +0000 From: Akhil Goyal To: Stephen Hemminger , Ferruh Yigit CC: "dev@dpdk.org" , Anoob Joseph , "matan@nvidia.com" , "konstantin.ananyev@intel.com" , "thomas@monjalon.net" , "andrew.rybchenko@oktetlabs.ru" , "rosen.xu@intel.com" , "olivier.matz@6wind.com" , "david.marchand@redhat.com" , "radu.nicolau@intel.com" , Jerin Jacob Kollanukkaran , "mdr@ashroe.eu" Subject: RE: [EXT] Re: [PATCH v4 2/3] ethdev: add mbuf dynfield for incomplete IP reassembly Thread-Topic: [EXT] Re: [PATCH v4 2/3] ethdev: add mbuf dynfield for incomplete IP reassembly Thread-Index: AQHYGhSD5snN0ffJdEyr+e/sHU+c5KyIWrAAgAABYQCAAAlQAIAABvSw Date: Mon, 7 Feb 2022 18:28:03 +0000 Message-ID: References: <20220130175935.1947730-1-gakhil@marvell.com> <20220204221334.3551574-1-gakhil@marvell.com> <20220204221334.3551574-3-gakhil@marvell.com> <20220207092330.49a0ba8a@hermes.local> <20220207100146.23cb2e93@hermes.local> In-Reply-To: <20220207100146.23cb2e93@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 61edd70a-507e-4197-06f8-08d9ea679409 x-ms-traffictypediagnostic: MWHPR18MB1421:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: tGHGlFX5EDEc3tJjiKQdH67yWxGC7jnRECeloPmudl2jp4PSYybt8HWjb5usZby2ObnB2CXd4pqztM4nOyyGwPTkdAZuqo4VMmPqxVgDmWKeFeyxE6cuuS7LTyy6RMwJimH0zS7frZs2R/IsIUYEGNtutQtrlNphouR4Snor/B3AImM5eJRcgDd4SclKGM3WnPHaaIaVAHE86zHX6pglgIBqvxSlgcRrGhEsd1rdzDH8uM1ZKcRz1Em21objKEA0qLcknatY96Dh/TczhqRnebFGJ0e5D+g+tCgNj7iJqzxhOwOO6oZApzaXuRYPncZE2bh6u9mQ+db12QSnCtvBFboLX1BYj5zbmU0O7MPrZn/9Me4fE/NUEdpUfIR35NvWQuw0zOhpZ1NOBI0Qla3Wtu0vchvg8Zq5VPfWqwLsdT65kbkMxv4BX/iOr6+VeGEyhaPqcfm4BAcLmEgPx4vta/eVJ2M+KroBDzUd1/QcKP7oZ1klsqU7wC0vLkb4QXbEMRakl8W/O83cyORsrtucRsjeWeoP+1pXiuQ5Wp7Fh6rsd94Rs9WkfjVJda1nYkSxg8jtV9iJmkBuBisW9PRfop+Bfobet/GaERtQWwIZaY1jOkDIFSbGV1wOPvbS07xTjHdONwbwMGjtJH/Nn0ffOXfXaFH7IVfdJbd2SvbsVHCfKv9r7RuNPnYADsRTFj88uZ+F2Kt9oeQ/MxUYEPx7eg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(26005)(186003)(6506007)(316002)(55016003)(54906003)(9686003)(71200400001)(2906002)(38100700002)(122000001)(55236004)(7696005)(110136005)(53546011)(4744005)(38070700005)(86362001)(66946007)(33656002)(52536014)(5660300002)(508600001)(76116006)(7416002)(8936002)(4326008)(8676002)(66556008)(66446008)(64756008)(66476007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?BcLRPeTzlg9oHVpa1EevD+t5jkXueJ6gMWWD6z4HlHt0VJUk8XBZxk45vhFb?= =?us-ascii?Q?oMFyyflYk+kbBrBATJrFbNIQHCLBiwxS3BbdJWphMny6EYb4G9Yf+slg4mcz?= =?us-ascii?Q?A0Rb+x6B139cUq1WcLM2VzSrMgEi/5UZ2+XcUhrU2O/bNbA5Psib0eA6ZyyO?= =?us-ascii?Q?Fz+7flk6r/bEB55MWKvH09mtpt+7GLr0tSxV+oasm61AgzeYOxbGzpB59pRI?= =?us-ascii?Q?Bum50fstpSBzbNI2VVcqlB66Wm8a3/RHuiqOZTBh14uDljTELTKaxO9L1y53?= =?us-ascii?Q?kbLj2DUpYOfVzOhkThM9NiWRLXVqCbzHkWt0xde4mDHEj/RDlYHYBF+8Cl9t?= =?us-ascii?Q?Zch3d4fih63AYirDSqtxhYSStB3Vm4mUvYqpZebPJDW0qdrbGfWco9Iof/8v?= =?us-ascii?Q?baFVY+l3f/umXZ5CAyWH+fmj+8YM6UkosL2TfzS5k2HXYwXwrXImiUKeyPKi?= =?us-ascii?Q?7vk6FZ5AEO6G1CwvcEkFjgj5rN0AhHYoAMGV1yFzi7EKtRCkQX/rP+MkYY7a?= =?us-ascii?Q?y8vzw3xPtQrQZDky4oeJRh+aIIYsmJgM6A8/lbcAx0cD7TYLcBF0A0uRLsgP?= =?us-ascii?Q?i8BTf/m0tfCYWILqmxEyVRjezs5hX8EGjKS4KLLsekLZ74Q1eNgVhSftYrVZ?= =?us-ascii?Q?VYjaTWW3eUIj2zEMPzku8UnZXTXcKi58aDolcgi5E19+K3/4apNg1kviLrju?= =?us-ascii?Q?o/vuivsW/xzBz6U23JJcsmMFRjP+gjwPfderWcDxyIbyMNXrIQmcj0EbCTsf?= =?us-ascii?Q?2Fd1Wuv8RVjJOiKKDZO/3JRjwDMm4sM5b0KaeoHCtq0lNhJYKQrAWU5dscfC?= =?us-ascii?Q?OELaUoRSkjCTySA0Sl9ZyRlC+3X/y8eYMtbnCpkQy2pKrqM5RocR7PAfPr+Z?= =?us-ascii?Q?9KZsrsmqbjoIDAsDytamCaVD27MdpiEpzVeU4Prcmucx+yuquJwpwJBF7Xu/?= =?us-ascii?Q?J1C8lpfLSupIDokNNSVXlwpDuxRVyrqXK1NUTL/xGp9Sf/HP6/33ZPTLl4vH?= =?us-ascii?Q?OCVBDt0uP1jlddVHhKhSQKmfbFgXmMEbIqz4ybOMkh3x0ZNLX4kRn9i/Fp4b?= =?us-ascii?Q?5auKLnsZJjzVJevVjAnfbx0Oxx4Rgc1C1Rx4lvw+f4fi1Xa4BvN4UJu6VFf4?= =?us-ascii?Q?8SAeqEZNTnSvvqwtcV8u/pHaZ/tW7irlSsfsxU51la2E7Zq/bjbEIVwqXYKb?= =?us-ascii?Q?xmOj4u888VIYmfeOCXIPCXfQot6oxxh1nHcMXhy84AC7QsRSOwoLNW1stPo4?= =?us-ascii?Q?XvmZsfLFcv+3NY+BcyrnsFvleg66YCTHZPIclpEyxjgpDW1Jiwn/3iPaIO+y?= =?us-ascii?Q?iHBDeGAvL5JVtc7kTPPUyA+EnBXa4Duqw4RJ0UXedYJNKSr6P5hnZ2Oxxxcl?= =?us-ascii?Q?CUz5l/G/Zv+QL6Ikvqqc747kG01aE2vtIypEtWFOXxzo2YLI3rRUn420sbWl?= =?us-ascii?Q?jW7zM0+Evrh3ZKEkbGNCukVYCUqEhSIizhcFnQ2/ARojvhvR0QqE8NVdTMB/?= =?us-ascii?Q?GYEMTta+zCWSlvVUFRvG86uslpz2ePwuDDmqm78rhllrvTch9JoJ1wBrYHLB?= =?us-ascii?Q?AQSrNVMc9g0SVPYcjJMYwMqtntnEgN1qkJVKWR/M7b6b+q6zykNVt0oxn9dT?= =?us-ascii?Q?vjk4WrxS0KQGUfQoE8PatPo=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 61edd70a-507e-4197-06f8-08d9ea679409 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2022 18:28:03.4224 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: q4g/W5svoTxkeu/FFqgE6PX7jQl/Ck7dADtf+sQQSFZOeCH1ue+gj+eeKcuAknGhJV4UQRKD1f1vkWMJIRJN7g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR18MB1421 X-Proofpoint-GUID: e31MKg-n9jkh6O0zV-Pc61WxEP4OEc5x X-Proofpoint-ORIG-GUID: e31MKg-n9jkh6O0zV-Pc61WxEP4OEc5x X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-02-07_06,2022-02-07_02,2021-12-02_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > On Mon, 7 Feb 2022 17:28:26 +0000 > Ferruh Yigit wrote: >=20 > > On 2/7/2022 5:23 PM, Stephen Hemminger wrote: > > > On Sat, 5 Feb 2022 03:43:33 +0530 > > > Akhil Goyal wrote: > > > > > >> +/** > > >> + * @internal > > >> + * Register mbuf dynamic field and flag for IP reassembly incomplet= e > case. > > >> + */ > > >> +__rte_internal > > >> +int > > >> +rte_eth_ip_reass_dynfield_register(int *field_offset, int *flag); > > > > > > Maybe use RTE_INIT() constructor for this? > > > > Dynfiled should be registered only when users asks for the feature. >=20 > right but making the user ask can lead to errors, can it be done implicit= ly > on first use. Registering dynfield is responsibility of PMD when the application asks for= the feature. So how can it lead to errors.