From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1177BA0548; Thu, 11 Nov 2021 12:11:47 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8A0DB410E5; Thu, 11 Nov 2021 12:11:46 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id F0E0A40E2D for ; Thu, 11 Nov 2021 12:11:44 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1AB9WUQ0017058; Thu, 11 Nov 2021 03:11:44 -0800 Received: from nam04-bn8-obe.outbound.protection.outlook.com (mail-bn8nam08lp2041.outbound.protection.outlook.com [104.47.74.41]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3c90mt8dtg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 11 Nov 2021 03:11:44 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R9d3inRVgqM8tBYDRlFQz5Jv5+ladxCKEwqAnf6TH/S1NJiLvo9XhW+dZTc5rcT/jpQgyzShw0/DMXFxZ1iUqHgA79YsKO2tUZ8sBpcOaAPUnZDtL0wQuQnGszi/pQpNEFKnifmrMOtLRNP3val3hL1k3MYR4/nhp206FJMsBiis+nlIGoRKxQ1d741vekNGg7CzT2ntZWgBDHqIsaKmKaLwHBRErCCfzhC/k2iQ5nfyTZV6RLHtCTyb54BX+6/6GRErqkioNVed/yVi04KwXj2yqjb/Iu4R/nnBwxlU4ClQWlhDKWqb/FH4Utz2ZFtg55xEQ55BmUkbas8YBlvLag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lm7pyYIrw2TI5oenuRect5IixCMfrc0fhTg8tB7PMJs=; b=ezqNqF2HZVnmbrDSxZxoIhsU+jnA2RytUNjqDKDp/ooZh+k1WZ6JFXom/VkEZX4cgJICvUnTy9DM7JGYLG/BAABexyPlhxtZqOeO1T8+CBZkKOj0sHgt5aZzeiRC4xfZSoEVuk/mN2hlrmpF4uMzMvg1u9ctl76UioMua/IrwzGEsjc3aMw4VH1RDNuoxrZyDSbz6VjD78h1+FeAwnNLZPCQsgmRwtn7I6DR7B7BQzx/z8WiNzjH4pCkkJ0n0WPhwghO6cP7iXOu+CGpCmIbVdkhE+gjR6TRiyaCJ8SBaDsRQb64lJthwDKw+QwzmOqMLG/X4YpkP38KhFYiCzlIGw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lm7pyYIrw2TI5oenuRect5IixCMfrc0fhTg8tB7PMJs=; b=dmjScPuYnefXhGq7n+QXNIW18g3GW5IKvBZTSwIoxppCCP+QYL2OAGcLQDcxLmiS65t97M11d0jfr6CehSt8YfgbPQ14tqMMaSrdf9iEP99fUf5AEGB0rbbWqpZjvLMu/byvfuLvMOuZoBobGXRzYYbU0FQ175tQtFK4SG8swFQ= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by CO1PR18MB4780.namprd18.prod.outlook.com (2603:10b6:303:ef::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.15; Thu, 11 Nov 2021 11:11:42 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::c41e:707:3f91:71b8]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::c41e:707:3f91:71b8%8]) with mapi id 15.20.4690.015; Thu, 11 Nov 2021 11:11:42 +0000 From: Akhil Goyal To: Raja Zidane , "dev@dpdk.org" CC: Matan Azrad Subject: RE: [EXT] [dpdk-dev] [PATCH V4] crypto/mlx5: support BF2 and ConnectX6-DX devices Thread-Topic: [EXT] [dpdk-dev] [PATCH V4] crypto/mlx5: support BF2 and ConnectX6-DX devices Thread-Index: AQHX1i5wJ3KDKqD5A0Kx87oEKN/q1av+LD5w Date: Thu, 11 Nov 2021 11:11:42 +0000 Message-ID: References: <20211108131858.19986-1-rzidane@nvidia.com> <20211110122748.34138-1-rzidane@nvidia.com> In-Reply-To: <20211110122748.34138-1-rzidane@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a3802a19-3c79-4417-7071-08d9a5040a75 x-ms-traffictypediagnostic: CO1PR18MB4780: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1824; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: RhMsvBj19xaOBDCIx8Mjv4Ux3Vt7Pmj1wCLW8WdIhUuxW4Fg2JVC6PXchgqbyht+xO52LvkVkbN3YbAY3sm93DtMeDkk8XJPylTBX34Pp+bYq6ydxXRlWEX6r3gz9NP5j4jRLYFd4iyy6TtZ6Qi0QG6sVanU4dK9Oc3mIjMJmQzWsLcP9MDR07N2NSC2SpO9agXZcWAWz1/3NmiciNjFfyw2caOKEBntHlnoduCrof2fCHG0l+Ri6QkpwaugItBlabgvkFDEVxvbRPT3xxSOBCxQYIN08JZIb495P4UleFp4L6jIoy4zHiwSgHH79/D6e/Hwi7FpD6cD5ZioJe4eFLE//EyTEXSlR4ZpvWbxcw2LKiW/ZioOc/e9/nljFwhHmnck//WXWelnLuLCplXCiGHtqsUGBRG2aZTMCfBg+9Eeo/8Ca6Y1GW5wk41Wr9yfwOZA2qYYv80z9guekp3jo48im5QalVnb/7IVsGebL9PNBnLnc3Wbejgrrm5wjmlmUpF1+IH5E2fF7s5y1mh7+FWXlSetbG8FfD/OUHGI/iDOWRBI6GAjc/Gvj+hJpR7VjICSzMbAaqaVcD6vhvXlt/Phkm293OOELQiupaUp5Mp+uItPLO6eq1IEvbr49WPP1xQDU1/OSmmqSqv5dHBkzXe53oycmBBfDoiLmvnYEteIY/2b0Q1pESDbvyBTsh/u6m8q104rgaHKzsDXIthpnA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(5660300002)(508600001)(52536014)(33656002)(186003)(7696005)(64756008)(66446008)(66476007)(76116006)(83380400001)(2906002)(86362001)(122000001)(110136005)(66556008)(316002)(8676002)(71200400001)(26005)(9686003)(4326008)(38070700005)(38100700002)(55016002)(55236004)(8936002)(6506007)(66946007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?273uwkTrGbMAUo07M0s8zja/Kiowkko/FgAfaO56IV43YG3kDZAohO3wtxzF?= =?us-ascii?Q?NcSC5gJbd2OAB7LqBKShpTZU1PG8uyfx03EUb9pLPyvrACOkSmw7zmnivgmN?= =?us-ascii?Q?bCaDVjjNCyQyLlFik6AD1reqt6fv8PcaajXsY1ekBVqk0FwdQqL9dESppGjY?= =?us-ascii?Q?dsl1wFu3uD8vQm5YKJGZFhor+8+61OXVDiZGJwKKFUTGBjpmMKzfyqypDA0w?= =?us-ascii?Q?/W+77/eiQXa6wPmupUMYXNG8WdJo4w/7FHQmcHM5y2oA/oG/kqXLoVrJJfg0?= =?us-ascii?Q?8o+MyEADZJk2Wq0Lle4Orny2/0UtYRSFLTOTbp4KY9+l1ARcYaWMEMyJYPcc?= =?us-ascii?Q?NexqHwiw8RnkTOdoCnfDyqxS5YINvpapHx4caKfBExuqbFzIayYmuS9Q7hY2?= =?us-ascii?Q?ohc3AxmtFCswbjWVDXma/vGEoV6XmxJF2LOOSpGUZysNa1cwrcgRbwCM7ydV?= =?us-ascii?Q?oHsc5+WraZHfzNs3HxPjE763m36inptrZ0ZeXVwvDjDg5PTLzCqpujovSvIP?= =?us-ascii?Q?ebObq3x50nfMo16I/MMYR7t1i8YYGPkIadZA/WoeIEQIl19ziDtArQ1SemkU?= =?us-ascii?Q?Odoft00S3i9vod6Oowu5HsKv8zRgQ8uKPuT+zqTvnJNlym0HfPGlGFBFOrIj?= =?us-ascii?Q?rZIdmgXVUeY7LQLXLR/N5IaUXGWrD900FJ4V7M2Rkkwg+Qc/omUkKpMAXYdY?= =?us-ascii?Q?7h3stLdrQzDy3N42DntQ9SAeNOxmOl/7QI9qRRib0/9b7XdEfrntr/1lEvEc?= =?us-ascii?Q?wunkHjb1JxXWaefS1+kaF6WibEGWZZwiB5RX9FjDvVLEg9MywfQ7lOLFI/ys?= =?us-ascii?Q?nPye3KVy2UvYycMvfCGBET8TPZpYSJk8BfJ8aXk8sF6o3lcmGNnUYGLxmfar?= =?us-ascii?Q?ldNLJuCIy0t3xoAz+/aPf3EVb1XJonHbpfb5JOffjwzEGONiPXcOGID1Z801?= =?us-ascii?Q?+YsjtGNtU5X6FZSvssfvB3RV/76iJ8NIfeT2CL+kPXoo8i3AgtxT/Mg4ng5o?= =?us-ascii?Q?5gIz/JLhZevFOlKsfBWUlj+kzCWmEYPfQC2jfbSrXlPhoJR0Fd8+lTStwA3F?= =?us-ascii?Q?QtGY4pf8ZD6FkyXKk+BCV12n5wY1LOon8H6L0RdqFpppZu5/rQSeKtFbA9VP?= =?us-ascii?Q?qYvEfy9ZzMSytzh3uEi4Pl7VOlE+k+Ws+6XOeuhP7CvjLXqgIE6aWvxVZzK2?= =?us-ascii?Q?fNEYa74+I/gbcEn/ufjGcUvSTzOinJYA1Mm0cbRzZIsxRo525ikSvBojPFlr?= =?us-ascii?Q?3EDScF7YeCo19t44ILSAuxBpoOgk/6LXRomhP/32WYFFTqzJ3C7y5L6yW/3k?= =?us-ascii?Q?B23WiTYAqS5Anvc7eKsHxmKPaFE2cRIWDTiSgP4jufQU98cMoMXXLm2ArQYC?= =?us-ascii?Q?wKr4F6XhslaD5AxUMGjh8coUJdichTU9KSfujjcUbLnBej2YWBl+1VMuNEXQ?= =?us-ascii?Q?RmJXk1oOupiWJsajdW3yxPx7euPkWNhvHUBd5n2NSwYSS9BHrc3iUE8Y2wsd?= =?us-ascii?Q?hIMiSMVeCT53QahCVmZ4/kqhZw30tKUzqe0n3b24J6TkMKF9Eh6+7dCjl5SB?= =?us-ascii?Q?war29EALCks4aawW+ox9GL1vpQx/bDFA9P7cUAIwTA03QdajggbljsM5UM8p?= =?us-ascii?Q?brS+pvH6AgKV0S8fQpvuCOc=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a3802a19-3c79-4417-7071-08d9a5040a75 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Nov 2021 11:11:42.1923 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: q/W9B4KQm295/46XUwLyO1sxJvueIS5fle+JMjHYEkEA8zpXKIFKV84BUd5byljyJ6pSkVj4HlXyskERaSbyIA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR18MB4780 X-Proofpoint-ORIG-GUID: dpC6EJjIUBhn8JU3K6WM1TGRgtfqgEqb X-Proofpoint-GUID: dpC6EJjIUBhn8JU3K6WM1TGRgtfqgEqb X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-11-11_03,2021-11-08_02,2020-04-07_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > Starting from FW version xx.32.0108. version, the BlueField2 and ConnextX= 6- > DX > adapters support crypto operations. >=20 > Add them to the supported PCI devices list. >=20 > Signed-off-by: Raja Zidane > Acked-by: Matan Azrad > --- > V2: fixed checkpatch warning. > V3: fixed doc. > V4: fixed commit log. > doc/guides/cryptodevs/mlx5.rst | 11 ++++++++++- > doc/guides/rel_notes/release_21_11.rst | 2 +- > drivers/crypto/mlx5/mlx5_crypto.c | 8 ++++++++ > 3 files changed, 19 insertions(+), 2 deletions(-) >=20 > diff --git a/doc/guides/cryptodevs/mlx5.rst > b/doc/guides/cryptodevs/mlx5.rst > index 9bd8c6fe85..fe18a20717 100644 > --- a/doc/guides/cryptodevs/mlx5.rst > +++ b/doc/guides/cryptodevs/mlx5.rst > @@ -88,6 +88,7 @@ The mlxreg dedicated tool should be used as follows: > should not be specified. >=20 > All the device ports should set it in order to move to operational mod= e. > + For BlueField2, also the internal ports in the ARMs system should be s= et. Rephrase it to For BlueField2, the internal ports in the ARMs system should also be set. >=20 > - Query CRYPTO_OPERATIONAL register to make sure the device is in > Operational > mode. > @@ -141,6 +142,8 @@ Supported NICs > -------------- >=20 > * Mellanox\ |reg| ConnectX\ |reg|-6 200G MCX654106A-HCAT (2x200G) > +* Mellanox\ |reg| BlueField 2 SmartNIC > +* Mellanox\ |reg| ConnectX\ |reg|-6DX >=20 >=20 > Limitations > @@ -155,10 +158,16 @@ Limitations > Prerequisites > ------------- >=20 > +FW Prerequisites > +~~~~~~~~~~~~~~~~ > + > +- xx.31.0328 for ConnectX6. > +- xx.32.0108 for ConnectX6DX and BlueField2. > + > Linux Prerequisites > ~~~~~~~~~~~~~~~~~~~ >=20 > -- Mellanox OFED version: **5.3** > +- Mellanox OFED version: **5.3**. > see :doc:`../../nics/mlx5` guide for more Mellanox OFED details. >=20 > - Compilation can be done also with rdma-core v15+. > diff --git a/doc/guides/rel_notes/release_21_11.rst > b/doc/guides/rel_notes/release_21_11.rst > index 01923e2deb..96d14e01fd 100644 > --- a/doc/guides/rel_notes/release_21_11.rst > +++ b/doc/guides/rel_notes/release_21_11.rst > @@ -291,6 +291,7 @@ New Features > * **Updated Mellanox mlx5 crypto driver.** >=20 > * Added Windows support. > + * Added support for BF2 and CX6DX. You may use Bluefield2 and ConnectX6-DX instead. >=20 > * **Updated NXP dpaa_sec crypto PMD.** >=20 > @@ -416,7 +417,6 @@ New Features > overruns in C/C++ programs, and other similar errors, as well as > printing out detailed debug information whenever an error is detected. >=20 > - Do not remove this line. > Removed Items > ------------- >=20 > diff --git a/drivers/crypto/mlx5/mlx5_crypto.c > b/drivers/crypto/mlx5/mlx5_crypto.c > index 3caa22f35f..47da3d115b 100644 > --- a/drivers/crypto/mlx5/mlx5_crypto.c > +++ b/drivers/crypto/mlx5/mlx5_crypto.c > @@ -994,6 +994,14 @@ static const struct rte_pci_id > mlx5_crypto_pci_id_map[] =3D { > RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX, >=20 > PCI_DEVICE_ID_MELLANOX_CONNECTX6) > }, > + { > + RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX, > + > PCI_DEVICE_ID_MELLANOX_CONNECTX6DX) > + }, > + { > + RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX, > + > PCI_DEVICE_ID_MELLANOX_CONNECTX6DXBF) > + }, > { > .vendor_id =3D 0 > } > -- > 2.17.1