From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1468DA0093; Thu, 13 Jan 2022 14:31:59 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D104742734; Thu, 13 Jan 2022 14:31:58 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id D116040150 for ; Thu, 13 Jan 2022 14:31:56 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 20DABZRK023932; Thu, 13 Jan 2022 05:31:55 -0800 Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2100.outbound.protection.outlook.com [104.47.55.100]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3djhd4rnty-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 13 Jan 2022 05:31:55 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R4LCEKXWCV7kFCyci05lmDgWadysyAV0tWVTbNADPh4H88MW1yJE5lB4lOh7X9P18rRFl01IwBgVesMJE7ZMTtPOg/gB0dQOzQrEMA78k9N9EIXhKXlqCoojUCU6TFCmtwjZmKiZOAJE2v875Y5rCS3xXr8FloTfXUNmrRiCEmMCqGFyDvO7riHz77R7+8W8AqN/I8lKW0taaT3CsXY8HLvjoM9tw/0G2teqBL2rVTtORJ24IHTuJ9OE64S5irX4nJzcxs0FmBGI1tD5WIPdjW+1nIPCf6uAelPQsbC/uZtFvtZeegiJkWIWHECX2TMLSDJLbmUuF4amq0eT8nowuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZLBwS2mAyvZS1ZFB+1QbtOs8rjewjpr5dK0eSg85reA=; b=d0BoeQ5G47Qthzn4znH2pIjyv94mYeqPgFyBbGqJpW4KBm2/28EtreWhIO80dB9mPjFwnicJhUbrEpZ/fqLWL2+oSyJXzxwxkFZ6uRosy29pnQVZ69r6vFvAC2DPsiNQ/6LALD2Y5tHKz3EnSdwUCM5fKp1MI63NVkDOO++2XvIG5vCvP4pc0jEpJS0PwE5ak+LCaZFvETV+mYlvT+46CLe26EAk4HhgnKjF+CH+KtBXA2Y52bmzhb4i6Yn5ha5HXHV3jLgPLnehyYpRhmqnEAsCmhPKjf3xQyN8XPWvDpSi0ofXgqngk7XUgqHGUsMZETMV5T6p0JumIIIXyfXWvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZLBwS2mAyvZS1ZFB+1QbtOs8rjewjpr5dK0eSg85reA=; b=BEHQi6pwG1b2S5GH0jNKtFLkkLrNCSkWYRXiJhZTjAEx2Z14UOEnfJgtCbcqYkRMyLZE8Id6M9MWBUFqgpplcT/6YdrDVIC9iB++GvPtpxnQK0kIdtZolV5DsK7pXZUAaLWzhMH3mCgjaiE+OccwRnMqkfQ6Q0XO8Ye9JDQorJs= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by CY4PR18MB1638.namprd18.prod.outlook.com (2603:10b6:903:145::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.11; Thu, 13 Jan 2022 13:31:51 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::ecd1:2b8:57bd:7780]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::ecd1:2b8:57bd:7780%7]) with mapi id 15.20.4888.011; Thu, 13 Jan 2022 13:31:51 +0000 From: Akhil Goyal To: "Ananyev, Konstantin" , "dev@dpdk.org" CC: Anoob Joseph , "Nicolau, Radu" , "Doherty, Declan" , "hemant.agrawal@nxp.com" , "matan@nvidia.com" , "thomas@monjalon.net" , "Yigit, Ferruh" , "andrew.rybchenko@oktetlabs.ru" , "olivier.matz@6wind.com" , "Xu, Rosen" Subject: RE: [PATCH 2/8] ethdev: add dev op for IP reassembly configuration Thread-Topic: [PATCH 2/8] ethdev: add dev op for IP reassembly configuration Thread-Index: AQHYALPOiP3b/bX9/ESNWXt27mVBoKxeCfCAgAArc8CAAQXIgIAAAJWAgAAGqQCAAACF0IABvJVg Date: Thu, 13 Jan 2022 13:31:51 +0000 Message-ID: References: <20210823100259.1619886-1-gakhil@marvell.com> <20220103150813.1694888-1-gakhil@marvell.com> <20220103150813.1694888-3-gakhil@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 25794f15-b116-4b1c-e59e-08d9d6990ef1 x-ms-traffictypediagnostic: CY4PR18MB1638:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dBBYyCZ5Cjv5L6+0WtQEszvYXjRHRs6Fy9+a6mCVNhBgVN4aMhwWhIeh6zSO9DFq6FZej2qCCMYu0YmwkzuR3QkYdY4/PvUSx0gOaFiDH9J4PYSqzhIo9aSYC3/5a65xVOeZLyVFz2S8vlULpCDR/2/bq7DVm405skXJ4BYt7uw8U6V/1e39yZG6tVLP5tSgreDvg817pr9AO5WZwj5XFmvtVbupHYfCcJyFyiAPqADP9p57201dTXyQExFZQAr8jwNxkqnZxZnmQhJ6qw5TIIPArcka/NTn5OQgdvQhyW6Jo3kyhMUp7a4Ai5LgXD+wRZmc+FLOo7xSRPRr7yoO6XFsiTG/VJWEUfD5adwYG3NsuEkT/ibaBTT0SvmhsDhGkCJ2GJXX8pTjzmVbDBwVfqiWMxxd6jLb0XnUtmQDz9Vws1bT3pzxuD1jWCo7A4QYGJkYcxsH9U/gyW7dy3OfwJOurxxblIQy5rS8nwZGz9O3sRO6pirvXNG4CETZg66GK3MiO69JESkQxrCdkQssadZsRraihhH4qYZQH/nqo65b/EFM+TvVR6+rrNsfMHdlCFCF6wh9OoN8DA+JcWdl7LYLy3BMx1vzeKhjO8FXSu2EmZdkGVsDA1P5rbirfgUPZYGC1eV7Awmou53qo0qhmOe2z7TDrfKd3NoCHjQCyxWIjW5Ha7G2ASv+gbeVZRW6myitCXuOCJejK1kpOI5tFQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(52536014)(6506007)(5660300002)(186003)(55236004)(110136005)(316002)(26005)(55016003)(33656002)(7696005)(8676002)(7416002)(71200400001)(86362001)(122000001)(66446008)(38070700005)(9686003)(64756008)(66556008)(4326008)(54906003)(2906002)(8936002)(76116006)(508600001)(38100700002)(66476007)(66946007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3Hia27Zux/mUZ16oi/Ei9tqsmLA/i4vLO9tvpOvlpwYXXtxByi4+8cQcrWRI?= =?us-ascii?Q?OJo6rlRcjM2XpI5uQs6LWtHMTP4Qr61VsRszGqMe++Z+cKYxUjynC8X17Uti?= =?us-ascii?Q?9cijfVbmkudiTDJTMI0qtMCEvBoYzI2oT4oBK+SaxzBmLMb3oraTx1Y07XH+?= =?us-ascii?Q?QCrxWomtFxpZF9S6MbK8z356yNRaPLWM4M4qgARi5udolY4n04jteZi5NL6Q?= =?us-ascii?Q?2BA8ych6zATNA7TQqaPRHpwGUMsezLz39hocOOAYQ0skJc/O996Wq0LpNqda?= =?us-ascii?Q?tIXzjM23foLFw6pAV7EGowpC5m4bEsfpCeJvO32jM+Q/eCv+Y42Gb+VNviBE?= =?us-ascii?Q?7Q6NkMqz1yIhlcKmCGk+jgzGiwfgSQ0yQ55fgEvOrUokQ3hBsdVfLeT/G+w0?= =?us-ascii?Q?RO57UJsrPebJkphub26rgxDevo//35fxvyZbAEQgEADijvTTpEKnqMeBsEPT?= =?us-ascii?Q?jFsLTx9cNNkS7XTksNgserQ4UUnp1biv/EMCNoWtRGyhQ7n9aBWPtANd4/fa?= =?us-ascii?Q?FVq666K+zWvhNzjoF6I9flp/E6hjCYjUP5AUfe8OTEzavgotij1S2jp/0o9r?= =?us-ascii?Q?EWTIpiUQvs4vb7ybiPdNAHPL4ts/V1kdzpyphhXCX+lJoc+FGPLbx/kq+YFL?= =?us-ascii?Q?Uj9fxIjCj5gRJFmwJg4oaT5ES727sAI2uPqORxZ7zdkeCt8O3QpBzeyFVohi?= =?us-ascii?Q?RcwCbApvhOOgULJuX5Q07Pa4F/WCCFOIlTDUhrYPaL9XM3WWAKyQvvzwI8xd?= =?us-ascii?Q?vVzGm17cT1CmfEJymqIryFjyPMOUI4ysxk+WtylFEU5URgfBdIl/qRvPGD9n?= =?us-ascii?Q?UZTZTEl7u3/ErTn3av7MpnOmtVjwQ1RqY3jt+Mk8riiZfnsbC/mmxve6Ftug?= =?us-ascii?Q?A0YFN/AIL57jWJLPjUwT3/7vWvVtpligYFzs/ugnkFFYi4DpKF8Vx2zcF5Nj?= =?us-ascii?Q?vgDHmiMv7egcMA5pT4uCxjO97dIoR9dMvjkMiBxkrEsq3mwiTGnurL4d4J6A?= =?us-ascii?Q?krGD+2lyth4/khr/XZhEpTlgGQhSTgMMNiI4uPjMZpTW2SRJIaBsPtiHZ+Fq?= =?us-ascii?Q?nuJw/KZCdSyT5Tm1GbVohWU7IQjulfG2TRcLTDf+UqAIaMIayiTXP5aSsA/E?= =?us-ascii?Q?WmLU/t0el1gv+4j/WQjwJ4XYKKRJcbXjLazNs4UTVB21JCUpTBrhhxw0xzyT?= =?us-ascii?Q?S4VdfqpvXng+rerDqqJ0lnXlc0YfWzHwqStRP3kMFrJY2D9YF7NJticVIXKl?= =?us-ascii?Q?cr2xxjSKMUFkS+Zd3y7nRf7f1UdAjeSi46J0a/RwA1OIz7X87ooR4MskwL1L?= =?us-ascii?Q?MUtnT9f9ieoYS2qH8Pf9BBN6jXNxVuTCG/mXFHcVE44nNBXMlAs6r24DFQof?= =?us-ascii?Q?CZIWqdJ3TkCaleoN8owYE7y+SmPOcEczlaZDpGkZa8UhJkjwpzNaEDiXEj3s?= =?us-ascii?Q?olZOecVC64obDPlpA+eO7oJHeqhpSJ+rpjSAu0+crr9rpye3/Mp+jFBlmjLg?= =?us-ascii?Q?F2msybmNSn24UCx2u+sCl+ixn36pKzPF8YznOkwdki4UoESQOvvKf07kF82v?= =?us-ascii?Q?2lhAysnGKxaokEPYLiaOG5fI43hg4mdToGtoXVWc1VA4ugSywKEZH0Hg45T0?= =?us-ascii?Q?hA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 25794f15-b116-4b1c-e59e-08d9d6990ef1 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2022 13:31:51.7304 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 01CTJtVlc8lrw3MRZp9L+gW+3tSeVRCkfVXbBJqnhS5uABt3FQ3F+2UKNkgAv9NF4rQIzFUYCES5piwaiH/ccg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR18MB1638 X-Proofpoint-GUID: c5IA7DKK4wkRje-hqrL42az3SPnfv4fv X-Proofpoint-ORIG-GUID: c5IA7DKK4wkRje-hqrL42az3SPnfv4fv X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-01-13_04,2022-01-13_01,2021-12-02_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Konstantin, > > > > > > Another question - if we have reassembly_conf_set() would it ma= ke > sense > > to > > > > > > have also reassembly_conf_get? > > > > > > So user can retrieve current ip_reassembly config values? > > > > > > > > > > > The set/supported values can be retrieved using rte_eth_dev_info = :: > > > > reass_capa > > > > > > > > Hmm, I thought rte_eth_dev_info :: reass_capa reports > > > > max supported values, not currently set values. > > > > Did I misunderstand something? > > > > > > > Reassembly configuration is expected to be a one-time setting and is = not > > expected > > > to change multiple times in the application. > > > You are correct that rte_eth_dev_info :: reass_capa reports max suppo= rted > > values > > > by the PMD. > > > But if somebody uses the _set API, dev_info values will be overwritte= n. > > > However, a get API can be added, if we have some use case. > > > IMO, we can add it later if it will be required. > > > > Basically you forbid user to reconfigure this feature > > during application life-time? > > That sounds like a really strange approach to me and > > Probably will affect its usability in a negative way. > > Wonder why it has to be that restrictive? > > Also with the model you suggest, what would happen after user will do: > > dev_stop(); dev_configure();? > > Would rte_eth_dev_info :: reass_capa be reset to initial values, > > or user values will be preserved, or ...? > > > I am not restricting the user to not reconfigure the feature. > When dev_configure() is called again after dev_stop(), it will reset the = previously > set values to max ones. > However, if you insist the get API can be added. No strong opinion on tha= t. On another thought, setting dev_info :: reass_capa to a max value and not c= hanging it in reassembly_conf_set() will make more sense. The most common case, would be to get the max values and if they are not go= od Enough for the application, set lesser values using the new API. I do not see a use case to get the current values set. However, it may be u= sed for debugging some driver issue related to these values. But, I believe that can be manag= ed internally in the PMD. Do you suspect any other use case for get API?