From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8A2BEA04FF; Wed, 27 Apr 2022 17:57:34 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7AE86427F6; Wed, 27 Apr 2022 17:57:34 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id BEC6C427F6 for ; Wed, 27 Apr 2022 17:57:32 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 23R8Xoax030652; Wed, 27 Apr 2022 08:57:31 -0700 Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2175.outbound.protection.outlook.com [104.47.56.175]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3fprsquh8x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 27 Apr 2022 08:57:31 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZimNiGPS/vTFUTU3D35nTP8Cu/EkqqLC6OYiKA9C0PYeR2XYmeGpIiBr6WyLiJVhfF3zZYefp097AWvyOcZ+K7UjpPR+BH7DmxPm8dbL5f//4Lq+j+bxnSbtsnynCcH40iLRK1xVTzSOP7CtKn0B2f819alGEcUNz7fVyGdDRYJnUgPXR/k7j4y9nx4tBKWLuiN6KTFTLBW8axgWel/k9mvkTNfo8sShTdx2zKzgV9algCQ/0tWSAeN38TRjnbw0nj8tkqPPr5Zr7mp2+TcK3a+VUozZFocfx+kkWOqIJCjemFB7sd/4D5KVVfzZoZrdsdY25/xMMjXYikATLC6l2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a2PPCDD3iT3UbSYICinDepYjMra4EsgsdoGAV1Jgtk8=; b=d/wtNhumNdLhtFyVlXV0gq85hdhfc85/pfKxOa+SbUh151+DPD0oE+P40TxETtLnpwkCHW+KdFiDJMx0zn1DOEtOHkoHDL0f9JdjuB2YCdbrhVri3pi2LY/jGJoME1Tf9J6YNUNK6Pk0Fif+At+dmjQowq/ZyHlY5jkMMJDWwzjKXp7mtpbI2CrnDYRJzwSKP6TJ9puRybBWCUJpcydmkbsszwtnZ1vT7IPCZ3JzmOmlwCH3dg7pHVV4a3edJX9ig+IiKpbIEsVQxVVTYoU9xxmKc6Z3eBqwfgy7APwfEp6gHAfRfEEtUOh8znEvFXKJ2yToY7FcTNznZn6RLpGdyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a2PPCDD3iT3UbSYICinDepYjMra4EsgsdoGAV1Jgtk8=; b=aEe/IhvFAA1UdFtgIVC3CqeWCcog00BF+9ceUcDE0rRTn1frc/1tH0Za9TL6iLSJ6qw9u/KVAcI301QcWu9pe0yXdCpAhIzL3hrKV6MTYlWhkO6MebC78MQkWu/kloulrgGpCbEqjBPrfSlEfMzwo3WUZ9no2IdLn28iHUtpY8w= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by MW3PR18MB3609.namprd18.prod.outlook.com (2603:10b6:303:59::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Wed, 27 Apr 2022 15:57:30 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::a0df:8676:6ad2:4338]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::a0df:8676:6ad2:4338%6]) with mapi id 15.20.5186.021; Wed, 27 Apr 2022 15:57:30 +0000 From: Akhil Goyal To: Arek Kusztal , "dev@dpdk.org" CC: "roy.fan.zhang@intel.com" Subject: RE: [EXT] [PATCH v4 0/3] cryptodev: move dh type from xform to dh op Thread-Topic: [EXT] [PATCH v4 0/3] cryptodev: move dh type from xform to dh op Thread-Index: AQHYWgqYHf8JXHQRVEWX6DIFrs385q0D6eYw Date: Wed, 27 Apr 2022 15:57:30 +0000 Message-ID: References: <20220427074400.2091-1-arkadiuszx.kusztal@intel.com> In-Reply-To: <20220427074400.2091-1-arkadiuszx.kusztal@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 17dafe4d-be60-4bff-8473-08da2866a249 x-ms-traffictypediagnostic: MW3PR18MB3609:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 23KjkmjHztd58qiSSYHTdlcxFbinDR4liYeIDXqL1baJsbDOo4zC0xHxSHHl+iNF4HR2rlf8dW0Mf5w0ABnHc4wRyGgWl6dcqbMtYK5dJOdHFPNuZm9djEj21S7hx+mKjfuJTQaLQa0acasIqEIk2O7cA9smkrb5LjcyHgYKMwSY9dLYc8Q5g96JUVVELVMqkOUXyrlls5GuNxtBXYes+DIDnzvIi4R76/RRO5YG419DI2SZb7F/as02tREepcD2U2IC5258RdeUAH/2NRHUOtK/iZTv9zYh3pRvqAE3t9IMJlvrgx+JmYiK9n3GirokZ1EOAF64QoUt2XLVBrCUTs3HvTRGBdFAZADIPNV74YmZXkw+33ty0vFtwcLsxZluvrl2SpzHIUf6nsWNjzBnmpnER5+nFrOs++ijxAgPejJstaHMe2QJtI+OB1oZBq4YW+t5A7FokGKpQp6K57ynMee+2W5Xn2eOs9JDfUE3nylv2RjlJFUKmC6yM4kq6VVa6osEfnhp91YQgBu1FRwm4k3J+U18PRR4ccsmg+uH5u5TtDEcIN6qYKKJ/VohnZRR41bfTodBm59ZP2wd3TfdXkajSBcooKRM6jtWH5BkDSRHM+ONRUIEiCEeOA1M4R5ikaYcJXB5iTyCiS0z0N3ms/Rdlkb8tET6BgQcfyEJLHDHYsE7ans1JdAjjiXCsD/DMr5rrYMIiuWRjCIaCSSjjA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(55016003)(76116006)(316002)(5660300002)(66476007)(7696005)(186003)(66946007)(66556008)(33656002)(2906002)(52536014)(4326008)(83380400001)(8676002)(66446008)(64756008)(8936002)(110136005)(86362001)(71200400001)(508600001)(38100700002)(38070700005)(26005)(55236004)(9686003)(122000001)(6506007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?q4AmWKnatIhLZ/CXUK3Z6QJqJ9C/+I3IiYsmOr3GUBE8d1HeXxWQqYh+PLh6?= =?us-ascii?Q?OFKlySNrwg7G2GqYnKNyAyeaV0q2b1ur/7gR9ZSmhuXTrY6sFEOLNa+qfUQx?= =?us-ascii?Q?8u2Yc+23/TRRaGy6W8dIvdyzxZUwfsncid6Z/mgN1UY0v5lfOfm/U1tokOT+?= =?us-ascii?Q?PF8bd6ZZdVnVRCOZHgELQLJRJPqlGa5GXbyNAlxlfT3jhLWYHFVxWoiVJaDB?= =?us-ascii?Q?iIAcqzCAYOz9V+GwjadV48EMnBl139VwzDffWH4mVMotF4GN+xacvdemWTKD?= =?us-ascii?Q?3DCbSgUG3Zm9gX5EyxNWiEwFOym+267mqfaIm8XP6tb5jYCRvlHxnt4GfBM+?= =?us-ascii?Q?tIKtFscxWzKBUTBl1YApjaWU2N0CyYidLSRUEbflVbD36RyEC+EzqHP1+Gd8?= =?us-ascii?Q?qwJxSB8Yxv+H6+59sIVfhMB2/RD6dfFIU8YIIRO2yLLsw9D37iJeWQPSOc5w?= =?us-ascii?Q?1UOKLWEP+g1+oxCm5M7t20YX4FSMCOgCGs+Mz9o9NP3fbIDgyNpburwe6iBq?= =?us-ascii?Q?546HPnPEba+ePbfF/i5gaI7DFOfp0IaxZ8MU3pddPFI16CycugAjk6l1+Iyn?= =?us-ascii?Q?pcfdM3wAf/nCoCuEOk47VOTULV7KH8ZP4lY37XBDou3bUMsp6tClJI+gNs4n?= =?us-ascii?Q?Vkf6W+ayJBsUMmqlALfyqyX1TM+KDaym0NvNobWk3ht86pDMzhuH4mwrXt0q?= =?us-ascii?Q?AAhGVFrxjZUhxD1FwnYScvvpn75rCgBvGJJMC3eYDZ75vKXhsKD31hpKH+2x?= =?us-ascii?Q?CUQBW5sPIpaSewTadwmLyjFGRvqn3yeXe2PUpDZsF+xqzBJ/sKjx0vl3tnuM?= =?us-ascii?Q?QKsqxpKqrUMsYmvuV69VYpHChvkohIo0xRJxVU/zg4uE8O88PezxZ5ZlDal8?= =?us-ascii?Q?+yycJnVtvtStjjmV59rIof+xFjkhxdBk7vDxolVDG0FxcBILlOHjUG83q4Ue?= =?us-ascii?Q?zHPUTMWmdTY+qFTMCcsfuKZVkTduGk63OKzHbjraLuyvANBTRUyrDEmJkf8I?= =?us-ascii?Q?PiE2UbUofDzKHZ8S3nsB1KqA3Gpf/HTFHHlOz6JqSNYAPWLRLoKaDkkLUc7h?= =?us-ascii?Q?YqCHhYe+eVC5g3B7bo+PXAHsmzXc0Fdcsc+cBIBvetS4C4WDDH0fzw5jPMW4?= =?us-ascii?Q?oGK1xqRiJ+WGWajPrzD0AuW0h0fdEKASeQKVOkYMVdZ0yje2QrGGYFipWQLK?= =?us-ascii?Q?3SzYwP4EsmINMDL2cjkbexok0ypyFOiHhIXsaN3xj3hfKVXVpNY6GczIT/a0?= =?us-ascii?Q?pPk1xak9esx4iRTlnwuuHtTexCk1HXehQnzr9mmC8PIVVcKMUmA6MfEij1YW?= =?us-ascii?Q?6hBTuFVBZgROYp13HhC9EDg6y4+7vKqGAqUioXQSIl3Ly2TiyktUiLxYRsAO?= =?us-ascii?Q?ntNYrVnwkMlOC8laf65/V6qStyDEQlKwmhTyhNZ2Sdr72mWWiDcI91OlhLet?= =?us-ascii?Q?YJBt12213WKvrqLUnC2p4cJ3ow3zPa7op07QCtetcTeo8cKwurTtPZqfxuc9?= =?us-ascii?Q?aLVwQw5bhKJBaNkTTBxRQM/8UuL4eA/woZB2i6VZKoA0ufvz4yGjIJHZWmWA?= =?us-ascii?Q?m93zFV9Fu11CjWiv273t5V6KXko40cXM2MCnp5nj77RMOX6vtgMf23IjBiRU?= =?us-ascii?Q?po2Z/QO9Ir0Egc6aUAZgnqCVENd8WWJtiM3NB+D6U82hIbV90eVGWz302+CT?= =?us-ascii?Q?/5rFIB2TZ4UGQzKU41rsZuBHjR0jZJYN12FlHSa0Hil74KyOtn5gFmIvZJri?= =?us-ascii?Q?jPSJc6PnaA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 17dafe4d-be60-4bff-8473-08da2866a249 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2022 15:57:30.0380 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3g9VeMeXSQwjVxu7OQdFpTQIxDSHLoh17DNXAjh0NEs57dkTJH2QFYDddbwzQByC/PlKHG2XvriWguq5nH8WRQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR18MB3609 X-Proofpoint-ORIG-GUID: uaCKn8vq8mM0T1-u5zpGBVkMjXplU9Er X-Proofpoint-GUID: uaCKn8vq8mM0T1-u5zpGBVkMjXplU9Er X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-04-27_04,2022-04-27_01,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Arek, > Operation type (PUBLIC_KEY_GENERATION, SHARED_SECRET) should > be free to choose for any operation. One xform/session should > be enough to perform both DH operations, if op_type would be xform > member, session would have to be to be created twice for the same > group. Similar problem would be observed in sessionless case. > Additionally, it will help extend DH to support Elliptic Curves. >=20 rte_crypto_asym_op_type is moved to rte_crypto_dh_op_param. But why not move to rte_crypto_asym_op? I see that in other ops also, Op_type is there, we can move that out. Right? Also, I see one more potential issue. There is a union of various ops in rte_crypto_asym_op, but how will=20 User identify which one to use. There should be a union to identify which=20 Struct to choose from. > v4: > - changed op_type coment > - added openssl fix >=20 > Arek Kusztal (3): > cryptodev: move dh type from xform to dh op > crypto/openssl: move dh type from xform to dh op > test/crypto: move dh type from xform to dh op >=20 > app/test/test_cryptodev_asym.c | 11 +++--- > drivers/crypto/openssl/rte_openssl_pmd.c | 54 ++--------------------= ------ > drivers/crypto/openssl/rte_openssl_pmd_ops.c | 26 -------------- > lib/cryptodev/rte_crypto_asym.h | 14 ++++---- > 4 files changed, 16 insertions(+), 89 deletions(-) >=20 > -- > 2.13.6