From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EC4A1A0C4B; Thu, 14 Oct 2021 20:57:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9021440041; Thu, 14 Oct 2021 20:57:14 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 37B1A4003C for ; Thu, 14 Oct 2021 20:57:13 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19EDCrW8017005; Thu, 14 Oct 2021 11:57:08 -0700 Received: from nam02-dm3-obe.outbound.protection.outlook.com (mail-dm3nam07lp2045.outbound.protection.outlook.com [104.47.56.45]) by mx0b-0016f401.pphosted.com with ESMTP id 3bpjk1ad9w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 14 Oct 2021 11:57:07 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VD86iZJWfIwdZf1va2khdHx/okugsiiGQ5KQ0laWqRD0kn6g161stuSqA9sJUbLmTjcl3j/XZjUTpb0KlQWynJTUnpprcjSF1unION9ZPhyh2673jU8oVuMTxFTRQ3zjVXjNWWxuytgL9tquq8Mhh0SX1dF86UQvrhE8nynOva5OOci2kId78+L+XaEd8aXe7yaUg7EH/9A1wrMGD3SAnbIQBF51cAzloeoB+GUF+LRuFtNaKA2dPvdbCLZ+QqENTZi7oI2RPJYJCKVSiuC8dW3FqIPYEyyH4LfT+xmBRkWuYA1hWLKrnQllApDKthNAWDVaQLQ6wmx855DCwiiUnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IydSiNUEdia1u29jDhJdlLLU5fQl7dFShZ0YxGL1PAI=; b=YQxUBD/Uigc6WLs912qUtjcEUVLYPymUTB6aiX6ioX+dB856jhGtTbuWBmg3fO/rN71Ar6R7OssSXmW3dSKovRZXhFFgJW4p1sfnul9f7DNbuIYP25ircupS5t8FarnGpSm+VcBqEStd3kLykgIU07s0So4Bu87qRRrBPbBwjsUEEccteuD5h7SU0KuaTjCXagCAFq7Dp3qD7rcLykXBZzwemJkg0IAOV/J9Y7KSZf0/18uoLTEE1vrZl+Oi64zygrBUNobinQh3/gAhXibYd1LNQrRlTBa2bm6CXBdxmSSDYrhlJmEKUbKHvXR2QaOyVWKIip6sjHjxQjJNq0ZHfw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IydSiNUEdia1u29jDhJdlLLU5fQl7dFShZ0YxGL1PAI=; b=cQ3P7DZ9DI/xQri9Yj75gQCfmOW1idyVCVKpibfKhvfC4AemWuw+SRKG2pYy1B480rDJlZc/aYqyRv+EVPnizPw9Oqnr2UcJ3nEJrV0dCM38SS8GbHEWIPPwgz1iRcw5+GOKe0NWrR8q84tOEmJfsgkxd++oj5VA+FgKd/K68xg= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by CO6PR18MB4497.namprd18.prod.outlook.com (2603:10b6:5:355::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Thu, 14 Oct 2021 18:57:03 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::c41e:707:3f91:71b8]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::c41e:707:3f91:71b8%8]) with mapi id 15.20.4608.016; Thu, 14 Oct 2021 18:57:03 +0000 From: Akhil Goyal To: "Zhang, Roy Fan" , "dev@dpdk.org" CC: "thomas@monjalon.net" , "david.marchand@redhat.com" , "hemant.agrawal@nxp.com" , Anoob Joseph , "De Lara Guarch, Pablo" , "Trahe, Fiona" , "Doherty, Declan" , "matan@nvidia.com" , "g.singh@nxp.com" , "jianjay.zhou@huawei.com" , "asomalap@amd.com" , "ruifeng.wang@arm.com" , "Ananyev, Konstantin" , "Nicolau, Radu" , "ajit.khaparde@broadcom.com" , Nagadheeraj Rottela , Ankur Dwivedi , "Power, Ciara" , "Wang, Haiyue" , "jiawenwu@trustnetic.com" , "jianwang@trustnetic.com" Thread-Topic: [PATCH v2 0/7] crypto/security session framework rework Thread-Index: AQHXwGetv1shlNanEkaGEWDxUt04X6vSX5xQgABbf4CAABT+AIAACUMg Date: Thu, 14 Oct 2021 18:57:03 +0000 Message-ID: References: <20210930145014.2476799-1-gakhil@marvell.com> <20211013192222.1582631-1-gakhil@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ba8a22ba-269f-49df-097d-08d98f446938 x-ms-traffictypediagnostic: CO6PR18MB4497: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:236; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fxJOU5KCALwH7boEAEmfPzXIjtcWY1QJdJywvDgg2ZoPvNhVtEBqrfZ39EswMpeyhEDDX2WQS8IO4jNNTP6Rp71X4SD77fCf24ytcFDacjJ1r1iVQnphjUJ+Uqxkh8v0FwlBNcJ0bHkhh/YXyJ0eYSobMhDMN4QNza5PDZ2wAfrjyzNU3pAVVYuCa4ekPotW1Zw37CAuXiilWn1vZoWm6B4kup8Sa8WXZpvS9HPJJKvHdZDfacpQRBQs26GPpvX3WRfD2vuF/IyAd0pkdQ5m67BUWVoWfVlC/I22O4wzb468ICSw+5HUMmpOJCxUGBPPJM/h1kgftZr9fO1U0fRk4a2u4/6n4J9E3PRApy+ARPL8Xfpvo7D2QVeVbMUzG2RmpMZPetdRtVx05+fmjfU6hop8VXpmGm/2cWJn5lVLwjA9j5sOSl53vKO80Q5wcJdLD6iKTwReieTo/T1tyRY0ztMthtM46fTQvZnft9Ris6YHT1rUqDQyGrsSqnR0JRbenyu8E5z0K8HeEqmi9nqfilRwkADsh6oS6Z4np+QJjNUCAsALltiW6xSDqzIc+v5NAMyb0q3oGdBYBuWBxriIhGkLm6VgqrQH1JwP81qhpdZCTmRc3B4OQ668SVI/9fmRXFuX8V5H7Q2j3Hk9t/Ueah31w1GIxCr06KNhrOpk1bI5OW/GU/eQE2q94JLwFlSDu5NuuvR9TpDZwBTA7dZDWw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(66946007)(38100700002)(83380400001)(15650500001)(316002)(8936002)(122000001)(66556008)(2906002)(508600001)(110136005)(54906003)(76116006)(9686003)(7416002)(4326008)(186003)(66476007)(55236004)(5660300002)(33656002)(38070700005)(52536014)(26005)(2940100002)(71200400001)(7696005)(64756008)(55016002)(86362001)(6506007)(8676002)(66446008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?KKM5mEjY0+I6EYhKihx916teeIhAw+/HkXeTmlnQgdYcJ9E47wk07l9/shyj?= =?us-ascii?Q?cB27GJk1hRoDB901rbgHA2OsrKNvuP1D5CJ/h5MK3XMSP9II0vwEXg22G+md?= =?us-ascii?Q?tOcLk2yxA/DzCeQeoPpHGO8gmW6xf9qwsQ3VxwbVupKcVlGcFzcofCh8c0SG?= =?us-ascii?Q?8uce36Nq7YzDOeNKnQDxkV6Aow2N2kSb5cbDfm9pANRt9XMqZG5hk6TeYJCg?= =?us-ascii?Q?PXsRG463DDUl8wNDxz+xqerf+iATJ486EmyX0jX/OTgxVq3VpUjKeuNg76vG?= =?us-ascii?Q?/E5JkE7N+hojqJGWL/dHfJVJIogv7mOMghcwd3drp8EOblc3EjS0+wLkR5wY?= =?us-ascii?Q?61k8Qlk2W5BFLhDYglRX6qKjs5CaYkzJSFEZl3tVA0XHEigX86CCz7m110Ua?= =?us-ascii?Q?4ssPYF1QXDNeVMX7evRGFNvWBGKGm1KGLmVjoeZyRGa0ts+gdKTfZDYPgMBV?= =?us-ascii?Q?/HqUakVasdMuq7BUAMuoXVlLB7AfgirzNM7b1cH5Z8KJQp1bq7339RxlNN1z?= =?us-ascii?Q?QK6U1TGWFypSna5INnf+WSuhLiQB21u+hZYmUgL2lTSdea3zHOZJcqr0rh1x?= =?us-ascii?Q?oJn11geFTMlCPTRSyLsgU5yOEoSQUIHonDWhBw3IVxDdDTsy1rp4MegLvwVu?= =?us-ascii?Q?N6/yisljH2xdgy/DVnSqXl2mCKsdPWvs2UngQW4S2t4Wp5fbDsbbzoc9d8f0?= =?us-ascii?Q?1kKleWkJNEuoKwnkc3Sj4j7LY2Ymmr137Csax/3AGdjz3DFjiHG3USnf9t20?= =?us-ascii?Q?QHOlehEZ3TYKHitFJCFNes79D+UK5vfpj3gZTUw+pCZeUbfcfAqwPykhmUDv?= =?us-ascii?Q?0eula97jB3nNYLuUnb2VdSCvvis34kIsOVno7t5LY3n6AWxYL3/2gNmMIVox?= =?us-ascii?Q?8scWklXDyU13Euiyz7X7nEUBWWhG82WL/cJV6F9s3SfGnxesm7XjdcsE3/CY?= =?us-ascii?Q?j6qfjE1vbLvCzvosJNX/HfPSlfMO2/b9P0tBSp191+C/GO/hXR8XKzEVDYpi?= =?us-ascii?Q?WT+aRqE6AEEX3oknTz2jk2/RQsO2AvDsVVk6jKfqb/D1+nTr7rJfh5UEiH5h?= =?us-ascii?Q?oqneYP+qS71eVLKi54qXLG2lQjohiM2ZpVZy2rnjJ2IaJjmVliyuZHokoCZL?= =?us-ascii?Q?e3f5DIFF+O+sTjtTyERjSYIezd+hieo61uUzQVwHBKazgpmwihMJ2CBd2aw8?= =?us-ascii?Q?FbFIElog463AKNj2IM/JrVwQDtEx56J4lwHjAaJyKLmScRxCRyK6XxiUQxR3?= =?us-ascii?Q?/udhWI82I4fTKtHAwuqgr5/AqJkwkXW0IfYAoKIwtsElwrvtprTXO7fz1hUe?= =?us-ascii?Q?unIkE/dIpR68DxqOsRufelE7?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ba8a22ba-269f-49df-097d-08d98f446938 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Oct 2021 18:57:03.3144 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yVVd8suGyBAbjuo6a31vct7oGsGu0QZWPmj1TDGq8SYti0101WKhLm4/lhU/8uvyYOw6VSnobqZazp60eom7Gw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR18MB4497 X-Proofpoint-ORIG-GUID: Y0S7n-qAueTVoXeF-C3WR5JDUc3blIcx X-Proofpoint-GUID: Y0S7n-qAueTVoXeF-C3WR5JDUc3blIcx X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-10-14_10,2021-10-14_02,2020-04-07_01 Subject: Re: [dpdk-dev] [PATCH v2 0/7] crypto/security session framework rework X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Fan, Check for below QAT fix also=20 > > > > Unfortunately the patches still cause seg-fault at QAT and SW PMDs. > > > > - for qat it fails at rte_security_ops->session_size_get not implemente= d. And for this one diff --git a/drivers/crypto/qat/qat_sym_pmd.c b/drivers/crypto/qat/qat_sym_= pmd.c index efda921c05..96cd9d2eee 100644 --- a/drivers/crypto/qat/qat_sym_pmd.c +++ b/drivers/crypto/qat/qat_sym_pmd.c @@ -306,6 +306,7 @@ static struct rte_security_ops security_qat_ops =3D { .session_create =3D qat_security_session_create, .session_update =3D NULL, + .session_get_size =3D qat_security_session_get_size, .session_stats_get =3D NULL, .session_destroy =3D qat_security_session_destroy, .set_pkt_metadata =3D NULL, diff --git a/drivers/crypto/qat/qat_sym_session.c b/drivers/crypto/qat/qat_= sym_session.c index ef92f22c1a..41b5542343 100644 --- a/drivers/crypto/qat/qat_sym_session.c +++ b/drivers/crypto/qat/qat_sym_session.c @@ -2297,4 +2297,10 @@ qat_security_session_destroy(void *dev __rte_unused,= void *sess_priv) } return 0; } + +static unsigned int +qat_security_session_get_size(void *device __rte_unused) +{ + return sizeof(struct qat_sym_session); +} #endif > > - for sw pmds the queue pair's session private mempools are not set. > > > Can you check if below change works for Kasumi. I will replicate for othe= rs. >=20 > diff --git a/drivers/crypto/kasumi/kasumi_pmd_private.h > b/drivers/crypto/kasumi/kasumi_pmd_private.h > index abedcd616d..fe0e78e516 100644 > --- a/drivers/crypto/kasumi/kasumi_pmd_private.h > +++ b/drivers/crypto/kasumi/kasumi_pmd_private.h > @@ -38,8 +38,6 @@ struct kasumi_qp { > /**< Ring for placing processed ops */ > struct rte_mempool *sess_mp; > /**< Session Mempool */ > - struct rte_mempool *sess_mp_priv; > - /**< Session Private Data Mempool */ > struct rte_cryptodev_stats qp_stats; > /**< Queue pair statistics */ > uint8_t temp_digest[KASUMI_DIGEST_LENGTH]; > diff --git a/drivers/crypto/kasumi/rte_kasumi_pmd.c > b/drivers/crypto/kasumi/rte_kasumi_pmd.c > index d6f927417a..1fc59c8b8a 100644 > --- a/drivers/crypto/kasumi/rte_kasumi_pmd.c > +++ b/drivers/crypto/kasumi/rte_kasumi_pmd.c > @@ -139,27 +139,24 @@ kasumi_get_session(struct kasumi_qp *qp, struct > rte_crypto_op *op) > op->sym->session, > cryptodev_driver_id); > } else { > - void *_sess =3D NULL; > - void *_sess_private_data =3D NULL; > + struct rte_cryptodev_sym_session *_sess =3D NULL; >=20 > - if (rte_mempool_get(qp->sess_mp, (void **)&_sess)) > + /* Create temporary session */ > + _sess =3D rte_cryptodev_sym_session_create(qp->sess_mp); > + if (_sess =3D=3D NULL) > return NULL; >=20 > - if (rte_mempool_get(qp->sess_mp_priv, > - (void **)&_sess_private_data)) > - return NULL; > - > - sess =3D (struct kasumi_session *)_sess_private_data; > - > + _sess->sess_data[cryptodev_driver_id].data =3D > + (void *)((uint8_t *)_sess + > + rte_cryptodev_sym_get_header_session_size= () + > + (cryptodev_driver_id * _sess->priv_sz)); > + sess =3D _sess->sess_data[cryptodev_driver_id].data; > if (unlikely(kasumi_set_session_parameters(qp->mgr, sess, > op->sym->xform) !=3D 0)) { > rte_mempool_put(qp->sess_mp, _sess); > - rte_mempool_put(qp->sess_mp_priv, _sess_private_d= ata); > sess =3D NULL; > } > op->sym->session =3D (struct rte_cryptodev_sym_session *)= _sess; > - set_sym_session_private_data(op->sym->session, > - cryptodev_driver_id, _sess_private_data); > } >=20 > if (unlikely(sess =3D=3D NULL)) > @@ -327,7 +324,6 @@ process_ops(struct rte_crypto_op **ops, struct > kasumi_session *session, > memset(ops[i]->sym->session, 0, > rte_cryptodev_sym_get_existing_header_session_siz= e( > ops[i]->sym->session)); > - rte_mempool_put(qp->sess_mp_priv, session); > rte_mempool_put(qp->sess_mp, ops[i]->sym->session= ); > ops[i]->sym->session =3D NULL; > }