From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 259E6A0548; Wed, 25 May 2022 08:00:22 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F40D4400EF; Wed, 25 May 2022 08:00:21 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 1ADDD400D6 for ; Wed, 25 May 2022 08:00:20 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24P4h2Am021764; Tue, 24 May 2022 23:00:19 -0700 Received: from nam02-dm3-obe.outbound.protection.outlook.com (mail-dm3nam07lp2044.outbound.protection.outlook.com [104.47.56.44]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3g93u2jdw5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 24 May 2022 23:00:19 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JQ7T9DGVc457RGlDNkczbCkfGy1ngBho2q9yift15r++89x9WM5Wi51BKvl3iAE9ceavvcQ/9Gx75eXVbtPLhfZJ3Kld4rizyWCz9oPPJ3+N5YZECeLKzqgySsM5Of9y3JF4/clQlg1dABPrArjBlW/sjaEpAbkJ0JcvUbEenC3qHwvVqaDgLgfy5ZTJ2Fceg2x4Gy2oFU7mAhNhJWlPlqh+YRWkPpogVugvfYOMk78jyviyjf1oYWmDpZnPYWCSkia7pTtF7d3lwT0y8RMsr+AyM1mPwleGhb4ase7T3SyJlZTuedQaMbPCmXi2r/sEkh4uAoEcx18simF9mD3V0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rOMx9G86IuJuQe1+WUY5UZ+Xr86tr1BIjgeCm6t9CQU=; b=DpGX3d5dJnSfqkZ3NqTt3MH51PwG65AIx2aPFNnHE4R/6vXP60L489dPCvsONE1dr96k8ZvlMwZKbj71WK+0o3ofHmJoN6z3nec9/xekvHgB5jC5Xo3ZqduHCwfawJcY58LnKoxd+B2HKgRKlk6toDIj8dwl+vtQVdfdQAgnTwpLXz/3PjwT7e4JTpL6bSMD/DgpiTrd+/VKx1R5710Ck0inhxeIasvoofgw+KOqJ9zxPFgcWd+aqWJGLuZvairGXM6IQTq9ZBwYa0k622nbbqunB7n3oNmPkm/c4hwh1Cx6zXI18jxJOQat0LiZHC0ZJgoQukV0VoW/Haz9ZK/uGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rOMx9G86IuJuQe1+WUY5UZ+Xr86tr1BIjgeCm6t9CQU=; b=t+BbdMFrm9+NvaId+QShZlszwh27k7wIxRbUvm79krSBHh7xUpJfNXZQ/stEGi+Uf1yeSgVvBxvdveWH1xdRyMbzDV0IplcNJ8VP7aoyRQeWVpTnf37i4aKxjXIhCVu/LnsWkIQp+OqlOvQIhdz2MlFY+9G9AiTNztftTqwPKcY= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by CH0PR18MB4211.namprd18.prod.outlook.com (2603:10b6:610:be::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Wed, 25 May 2022 06:00:17 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::f154:453d:893:f6ce]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::f154:453d:893:f6ce%7]) with mapi id 15.20.5293.013; Wed, 25 May 2022 06:00:17 +0000 From: Akhil Goyal To: "Kusztal, ArkadiuszX" , "dev@dpdk.org" CC: Anoob Joseph , "Zhang, Roy Fan" Subject: RE: [EXT] [PATCH 21/40] cryptodev: add public key verify option Thread-Topic: [EXT] [PATCH 21/40] cryptodev: add public key verify option Thread-Index: AQHYbBe0q67gnZe620aujYTTDIDlf60t9eMwgAAvvICAAPr20A== Date: Wed, 25 May 2022 06:00:17 +0000 Message-ID: References: <20220520055445.40063-1-arkadiuszx.kusztal@intel.com> <20220520055445.40063-22-arkadiuszx.kusztal@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2b8084f2-7c0f-47f2-2708-08da3e13d808 x-ms-traffictypediagnostic: CH0PR18MB4211:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ec9EhuqAO8/W9zdaMkrkxieG+momdnYY/QiAhB4Cu9j0ThdGZxJOyQEfYIFaEEkYO67O6KNKp4Jr6Hme1jbZvDgO9YmAKK09rvbIy+E7Ezb028HUgZK6RynYPjcZhLoxBxnLVNPkpy9wslgOfuQbgpoEgIaPICcnTdOUvGpsqXORKUbnA52GfO4UqacwBBFlpnBF4mn0cV1pmJ3KBlg8UlP463sJ7OAVUiEFIRzUTFclLkR6yRAla/BVsS2kYOnSUrdoNtWn69crAzjPi/IyuCD/uW9CS2i7+tJPn8K88R8trZ5B+u5tlEfvObTw3wKE5Oqu2LIqBcOdOjuVMapdUSIh1yfwaDG9l4MLj7hO8CyL68OC7EVB4QfS6n+xWEWlQaEHxFpsa/H4ZLC3XmUxR2MzEscrgNLU3G2mjKQQpaz2Tm/at7dlmMb7MTirFS9h3fQdr6sycvPI5TWOHL8aCDL3FDjqfKFUEfTlRRpuF3OeWcbqhbbZVEZTFCGnioLPTVctwze9Msrev4vKXT5SHUubfiamSNu1cvFhq8D7aD0oZaByW/jDyyMLyPzsOhYeNt2IlJurgOBrB65kGLMI75u3TiQA0dNoS98BOrP2cKm+SLJOBPbSVjWk4szZ8ugNupToY+xinHshkC/k8LOn5YKtWM713s/CHSCqYw7slBp2Q0u5x13v7ETXnZogkNRoqF3BDLKezDpQolxlpsjKkA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(316002)(38070700005)(38100700002)(54906003)(110136005)(8676002)(71200400001)(86362001)(9686003)(66946007)(66556008)(66446008)(64756008)(4326008)(122000001)(76116006)(66476007)(8936002)(4744005)(26005)(55016003)(7696005)(83380400001)(33656002)(52536014)(6506007)(508600001)(55236004)(2906002)(5660300002)(186003)(15650500001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?pFaK6zMYE/g+BdrS6Pdn3+sJS31kcdm+n0MkiuYm9fU7AEoa9ukesiLpba0V?= =?us-ascii?Q?TeNDbLQUEAqjWOpwLT8jXG63aqcF/tHIyE4Ti1IhUdxxLW68FgNRIffjmtV9?= =?us-ascii?Q?MoGpgHGcHfh8+BX1KQX+RiirUR8K9+pty8zfM0z3DhGW1u3haDUTWTCIqqXR?= =?us-ascii?Q?dFCvwnu0GVaRLl5F5YxWeJzD2r31p/eZaAI06AW15JbyLprweG9EETAOz5CY?= =?us-ascii?Q?lFxj0FOG9TfD7vmVPyg+zKi4ZcQKlZxqN8XzS/zbm381pajn+XUNWrwnqQR3?= =?us-ascii?Q?te4r5kdI1EW8Hg3m61bokt0u3PjE5vg5eKQEao2xKiedtQCy1Z0pdDbXgAM9?= =?us-ascii?Q?7q0YG6HMy3czk8p5pt8O5lS1ELoQ3PkS9uoUp2SfWdbXrtOd6I6t0lS1mt6W?= =?us-ascii?Q?kA4+p5UJIrrZiVcxpk7cXGE+oJQ7rhbkpv5E4r3WCwpsfXDj4zMOtwiOa5lN?= =?us-ascii?Q?5AHY6eZbOx+bpnfaSwmSfXM2a4MUJMDP+K5VmsGT6Qo/ivvsLcLwjulvNUcr?= =?us-ascii?Q?JI/g8hmYRysp3UPUn7g4YVYDS36wOq3SFFjbd+E97tpNrERYok+YentPzdJX?= =?us-ascii?Q?m+WXPfxvSdhcal9C6Lwf2iFkrc+RMCxYlDpUPP8twETUo8ianAae/mImg7Ri?= =?us-ascii?Q?gsV5NHIajk04vyMpg8O/ZSxfYsvWWMF796+4zcVD0hx0B7cvqhGwTQ/PFMkL?= =?us-ascii?Q?MRPJFYJC3x33JbdnxRPNxi+ixqDMxyutZwajqF3Z6yqemMVQgiVdMXZRVY5n?= =?us-ascii?Q?cn/F8rbKpeLlMcNUEO0hofgZkUA1a9/E+9QltV64GK+mJkP0wWAC0o1VynUN?= =?us-ascii?Q?N5tNFUqIie4+2pKIeciUDdsKWoueVt6Q0nge4F9rbqixNrA9fUm3wgsAbBp1?= =?us-ascii?Q?KgVINL0m7o7qUGaCzUqGIIacK6v19bczaEuEosfEB9yS7Wo0PmEtFOhVqbLQ?= =?us-ascii?Q?IB2mDdD4smljshBOS2s7G3pcNePI4Nel4WLrdLE2+suNywfYwyqfwFj87w69?= =?us-ascii?Q?0XFhUKrrfm4UMw6FkUmuhoLI1iovFAdhoc4wBNrkxya1tkPATuwCfnVI3lia?= =?us-ascii?Q?HUyP2HJqJIMbxz8Q98K5Ghoi5IvMMN8jIwcB7PziJtIa1fqhlvmg8H5p8T2j?= =?us-ascii?Q?h2xU/3ns1WYm+Ih+T54e2pF5qDk1T02kuCqtn7i/lDYTcGIbdAD87lM/1Qev?= =?us-ascii?Q?KH9Wrw5J2/CJc6wl6AQb3BD/IdzpzYbYZa7oSLX7zgfDPjC7GaDGvnq/eEcD?= =?us-ascii?Q?a/wXrKTiV0/xR1fy15hdsBR32HaJupygEGIwQh4hIx6ie3ZyulCYn6ygf2te?= =?us-ascii?Q?Y3xU88k8ccDzBEQ3+5tFGjiI7CUMHK1yAkrLUyHn72xag8lSYvOSCTcII9X+?= =?us-ascii?Q?MUZlOmLGaSUGONgu90kp937ckkebS76b3+YIhjeHyL7mnzLSsLELYg7YF1/D?= =?us-ascii?Q?vCFp/NTSSzvkQ+HKDNuTBO47Je55twGTBOPrwHeDPRDMoyizkNSVSvo1K+ce?= =?us-ascii?Q?Y98kLpa/44OnG2U+Vuf/QxE9JtHPq0RSupcETILTagAH6l6NQyE+1S8zesvp?= =?us-ascii?Q?QO6YANYqPDYXvvnWemHJJem3kqwqinPqyM4XqZyjtW4/3CuVxbbrm6Upz0wm?= =?us-ascii?Q?5vBBLU05hVvQscVT2DERHZZuS8Q5D/lcwuHcIJYB2eETtaPrpwiOhucJTAcT?= =?us-ascii?Q?ixp/X2oztEdPCSExspmvxihI5HQYj/hDxgeeR80iHdhGB/CVlqolu9r7SNov?= =?us-ascii?Q?c/37qemTAw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2b8084f2-7c0f-47f2-2708-08da3e13d808 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 May 2022 06:00:17.5435 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xWndXkrH5R6CzAtbnbmSa7u7TdJ+MFNdD0/MnlPRGwzM6+ZgmhapNfMBaWMWgS+OeOamsY1KW6/BMjpqNedx/w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR18MB4211 X-Proofpoint-GUID: EaqL8wJYDqchSWQi88PUMW_O9VjyqrOw X-Proofpoint-ORIG-GUID: EaqL8wJYDqchSWQi88PUMW_O9VjyqrOw X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-25_02,2022-05-23_01,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > > > > > /** > > > @@ -397,6 +399,10 @@ struct rte_crypto_dh_op_param { > > > * For ECDH it is a point on the curve. > > > * Output for RTE_CRYPTO_ASYM_KE_PUBLIC_KEY_GENERATE > > > * Input for RTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE > > > + * > > > + * VERIFY option can be used only for elliptic curve > > > + * point validation, for FFDH (DH) it is user's reponsibility > > > + * to check the public key accordingly. > > > > What is expected from the user? Please be specific. > [Arek] - Well, this depends on protocol, usually it is size check for FFD= H and zero > check for x25519/448. Not sure how much information should be provided he= re. I can understand we cannot specify everything here. How about adding in documentation a section to give details? > > Add reference to the ke_type for which this comment id valid. >=20 > > > > > */ > > > union { > > > rte_crypto_uint shared_secret; > > > -- > > > 2.13.6