From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BED15A0503; Fri, 20 May 2022 09:21:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7A122427ED; Fri, 20 May 2022 09:21:46 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id CB8B240222 for ; Fri, 20 May 2022 09:21:45 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24K64k5c028859; Fri, 20 May 2022 00:19:39 -0700 Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2177.outbound.protection.outlook.com [104.47.59.177]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3g50as9ba4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 20 May 2022 00:19:39 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JjyL4E8zQXarM1rmJ7HDqPz5jcKiV5JPuaN6lIPqaDCxsrS+J+D4OlosWWk2VdPyfU1w/T+6O1W3IwQ+QCtqlMZjz/qnTCiuEnPQw7u0AsJ2HDEOAgmajxQoMJVDT4iUbcaxOPi5gul4W+lQ2XPIj8NKWZpsKVPapZhXBsITbYeA8OzUVcMptI1PdImMp+cRU6to6qFdqATqjWjjZBp99bP0+gKwVIhguLMfJhOOQPIZh9ZtN7z/rYQprMWbcxqxfosGL8Qr6ED82Y/SkasV4As2UzLyYLFIqd0hynIwRtiYMBdW9IKFDTini8HuXSnr8PW0TRLcTUWEMXNefZxpTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LUmsoZEYX2d4NI+feQjBq+Og5bXWjct1k3U381BObKA=; b=ODP1NeejWoEQ+6WTXEcEZt4cHGpDsK5TgRM/nKCdA+u9hGpm5DyyorpoZBmTEgHXDgthc9K1ORtk5UuDAqHsTstRa7jDLvhbkSVn9JUJpJGtEAlQHWyLsRr9pB9OJvz03e1lFVV7i8M5MnZ2CNmrQAdTB/jKq8rRsdlFic8fDm+b8HlN6di/6F9DBGTp99Q1ONgnjoSkVKmsn8tcTL2QyxuG/FrwWifbWtIg5OHh/nPxp12YNnBPJrMgNrZVNvTkgY/t52uLZE66WgzJA6+01oF46bfbVtc00COocB7u+in7AcY50IGvEe1nj2hGEoZdS8ZJKP5LvWw7HF3Jbj8KJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LUmsoZEYX2d4NI+feQjBq+Og5bXWjct1k3U381BObKA=; b=E4QibQ7hvxlviAca7R1HEdYXfnQe0+OGpEHSquC+bVwIsmwwN2JZMq71vXTP9Jlb2kfzkiPM4+mI8mohchnDHdMs6e57p6PUoGOb+KihWRJOJsmwyH9c3F+HLMZzY8TzQrYoU6OzswpUPHgSUNkozX+Ma8wUDQ2X2ZZeymd42DY= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by CY4PR18MB1223.namprd18.prod.outlook.com (2603:10b6:903:113::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Fri, 20 May 2022 07:19:32 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::1d4a:ca8b:611a:9cf6]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::1d4a:ca8b:611a:9cf6%5]) with mapi id 15.20.5273.018; Fri, 20 May 2022 07:19:32 +0000 From: Akhil Goyal To: Arek Kusztal , "dev@dpdk.org" CC: Anoob Joseph , "roy.fan.zhang@intel.com" , "mdr@ashroe.eu" Subject: RE: [EXT] [PATCH 02/40] cryptodev: remove list end enumerators Thread-Topic: [EXT] [PATCH 02/40] cryptodev: remove list end enumerators Thread-Index: AQHYbBedOVi7sFP6dEq5CrcxaviYOa0nW3Tg Date: Fri, 20 May 2022 07:19:32 +0000 Message-ID: References: <20220520055445.40063-1-arkadiuszx.kusztal@intel.com> <20220520055445.40063-3-arkadiuszx.kusztal@intel.com> In-Reply-To: <20220520055445.40063-3-arkadiuszx.kusztal@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 14843605-2851-4daf-234b-08da3a3115fc x-ms-traffictypediagnostic: CY4PR18MB1223:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: YD2wi8Xo2K6ByEhCIyVav+eoYid39GRUYo+Co23bjds2xzwXhjPawc74l5Hvs6C+bk6ZaybOhXy9wUrAHUQT2t4IZ/bZHIqxT+1hF24nZvpQQa9c6Vhv/6t19CXUug0+VbEWjiTug1eFSgihFgOeayNAHz1zY63UAmgDLB4/xlovgEkoZkIEQIauIcofV7JgQW/bkVvsCqjJ0M8JP+xXQKgiYqJ2APxOQZ6IYCB4qLvg4we4LIAEHXkUdD+u9oVHXXS8FVWe8fLvTr1tt1ThCq3feonkociRBSPxyT1lSS5lJ6LebVh5TCpz/4XXudFVdhPmvWfHePUwXHKi52xDAiXZlO4XihfiHkxTHOvlqwGME9JI92kT3QHcKLfHiylhf9QtfRy8nE6MkRwk3XnYcy1I4+WmB3LmBjrskBO+3XiUoh9sgu00LnZohQ51iubfmjhEqe+3n3ioKY98jqdTZcXP5bxZ2clndNhC65KX32xIgS9kYov8mbdzvgi6SdQfYx+2oN4tL/S5kNzaoNMU+4jBeZ6FkeIJMWzZJcokzykeno9fpuSevtDVhbCCy822oGWPpKjAMl6i3+oGRyPF4IibNLjskBh5qi/mlbQ2t3JmWexxZO+hYa8casBfQS0bby0+qEgUFTC/T/uA1T1HEbv4pg48QxxpfFTUvVKL5qcCh3on+8N6opQlGBoF5N4fQhMjS2b2DQQh42jQMaGTsZMhrklO9Au2hAwkIGHLHXzN+QNTWEl4BPxocil8dI2Tnm7Er9BYjN0e4uyPb0yLRG/5lMLg2IvIHEAixT0K9q0= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(33656002)(8936002)(55016003)(508600001)(52536014)(83380400001)(86362001)(54906003)(71200400001)(186003)(966005)(38070700005)(9686003)(26005)(5660300002)(122000001)(110136005)(38100700002)(316002)(2906002)(55236004)(6506007)(7696005)(66446008)(8676002)(76116006)(4326008)(66556008)(66476007)(64756008)(66946007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?jbDn8+pCzIR7F0YfoWVCg5LqCJLjRa4gp4GLti44YBs0jevG3DEt+oQKJvqp?= =?us-ascii?Q?6tdQ5Vh8/Ipkao9v4/dZjuF/zz4DXaPgIPlblUPsqQ1Z4f6YbhnLSQJyfBXh?= =?us-ascii?Q?Txj0v1bXIwpnq+F1Su1bwpaGY1k4nYL9YIbQF4TRk4+qR+/mzRpS8atEQUSW?= =?us-ascii?Q?LCAzFrGGd4gcI9ac7Iwmxsy9YZEYEVPXSZqQO4DjSdKT1XhzzlcwCXRzxdg2?= =?us-ascii?Q?5O94htlQVqVCu7o3eZ7HqJCIXU7YKD7kd7pe2/7ShalWpq/mh1xnC2HM/iMH?= =?us-ascii?Q?mt7FDaCmjtfEg3upXUoA6KyR8xXCJJcC5O2oHLZmdSr3BO413g5f2OMY4IaG?= =?us-ascii?Q?KXtITX9D+rvmSDg+TVLJhL1CFsCNugnQmrCimZ207Q70YUNrouWrUaV7V3Aa?= =?us-ascii?Q?5CvvNKp9r/STe68O62TwhG0jJ9em7rA7KJSpcELFgbGgWJA6ppu/dXHkcmyA?= =?us-ascii?Q?hQEgryrhRdHG+sMxzPH9xy8pNUvwkh4LjnC2DlThZ7KH5WXOOIMrPkCJiD/C?= =?us-ascii?Q?UAkksto+ljP5e3pcs/uDmwtl8z84GS/t8tj//kAm87d1o6H/2XGYHi9ymcuF?= =?us-ascii?Q?JHpflhIJe3tMpAC+8tZQLSZxa3V2BydQKB8G6h4dwgX8qmQoHjR8v/epjVDH?= =?us-ascii?Q?pIFW0HHWfgsOI03jbHMsYI3nuMzRp5Qh3n5UL+fjuuOlH4zQN6qoyyLbLCQw?= =?us-ascii?Q?f/lf7ZABwkU3Ma8DKYQ/bVYF1j8+DoZc9QbVtsBSryB95hjR4zO66DtdeE3z?= =?us-ascii?Q?FaniMseJnSe5UdNdRsqRMRtiBd7l1ihyqQKj7gNBDcKtBLeYdYCgKscX+Cv7?= =?us-ascii?Q?rclofeTvKnw9cmF53jzZKUwL/AbzCF4dq77o5uHWSrWc7IsaTvVKilWYKCEw?= =?us-ascii?Q?fLtJxTFC6QkhJydsQ+UdNznai3HLp1ppvnkUXqlFjLn+ZXOO29JV4QYLhYaY?= =?us-ascii?Q?1fFY1dP2zCpggKWSbsB12eesLGSGNzXXpw3udYXPt1Vk3k+4tAaK2kSrTk4p?= =?us-ascii?Q?b9ujxvSH/HchKV5gm+FhEbeNgBorcC0Mqma3JiFEVHN2iq9Eib3IwEjKN/vS?= =?us-ascii?Q?goFS/w1+moxwRRy2RFp3jpJHNQMybuDfkcKKpyU+WRbr13tkxhZYU/XIhafc?= =?us-ascii?Q?/N3G31y5fJustTkDb2IbaPBxL1RcjPMPnFMA4MuMzuBVobXy0A9fo5EF8jAj?= =?us-ascii?Q?uqgZZpAFryoBSJZ5QZbIHVhVFDO0ROTNvPhti2Gq7GmZ/cCp7hhVG4BIuovH?= =?us-ascii?Q?OK4ZpO7aILPe+27dMzCXMqafLDq7YaIZZ3z1V0U5SHmPwIdxjZyydBFBazQw?= =?us-ascii?Q?djKOHPuygun1v57X256p3wgnTX4UBJ25QVRZ1fPHZT2WvW5TKRlcR2WS47TE?= =?us-ascii?Q?N8LFtJSHcO5zU3yjZcl08xtr+5ujascPPOQSk4X5lg5Px6qy/8tduwjh0tvL?= =?us-ascii?Q?qlctX7r3EtyLLgmzW/SFDsl8SqqfQtoRCWXJAVWb+d8PEesHvyLdsUAUfgw0?= =?us-ascii?Q?iQmk6zwOa6NmralnfGQAlq40swlqYdyi9k17CFggczkSkbBXyAIKETlN3pTF?= =?us-ascii?Q?+1UkWaK7AcndfnOxB3x//LJUcBakYvKE93ywghqg7mdLsVZMg7f/xMsW92zW?= =?us-ascii?Q?TYw/Ploy1DLYra4cjFyOun1BUjVBlwTXddzKEchKE8ILODkKrrY9PTKPTeKV?= =?us-ascii?Q?IxTFR2VOjsnvENw50p0j1TVAbyZZTOjb9r7AhagqP0t9mXO4IVQ0KgOn9pdN?= =?us-ascii?Q?FnXfR/oFUQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 14843605-2851-4daf-234b-08da3a3115fc X-MS-Exchange-CrossTenant-originalarrivaltime: 20 May 2022 07:19:32.2532 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +H8TRgxz3dPBBST4dxqgy746iNEL4aGqusJVV1FEuSbBnyFv5ddbFMRt/gJbwHUqNR4lxNNOOV/F46617kQ4iA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR18MB1223 X-Proofpoint-ORIG-GUID: ta_4cbjJsge6Jw0sPEl8WzyQRhih7ZDD X-Proofpoint-GUID: ta_4cbjJsge6Jw0sPEl8WzyQRhih7ZDD X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-20_02,2022-05-19_03,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > - Removed LIST_END enumerators from asymmetric crypto API. > Adding new enum entries would require moving > LIST_END down, therefore changing its assigned number. > This would cause problems to ABI stability, so these > enums were removed. >=20 > Cc: mdr@ashroe.eu >=20 > Signed-off-by: Arek Kusztal > --- There was already a patch in patchworks but it need rework. Can you look at this and address the comments=20 http://patches.dpdk.org/project/dpdk/patch/20211008204516.3497060-1-gakhil@= marvell.com/ > devtools/libabigail.abignore | 2 ++ > lib/cryptodev/rte_crypto_asym.h | 10 +++------- > 2 files changed, 5 insertions(+), 7 deletions(-) >=20 > diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore > index 79ff15dc4e..f1945ce3b7 100644 > --- a/devtools/libabigail.abignore > +++ b/devtools/libabigail.abignore > @@ -27,6 +27,8 @@ > ; Ignore changes to rte_crypto_asym_op, asymmetric crypto API is > experimental > [suppress_type] > name =3D rte_crypto_asym_op > +[suppress_type] > + name =3D rte_crypto_asym_xform_type >=20 > ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; > ; Temporary exceptions till next major ABI version ; > diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_a= sym.h > index 7206652458..a474b6acd1 100644 > --- a/lib/cryptodev/rte_crypto_asym.h > +++ b/lib/cryptodev/rte_crypto_asym.h > @@ -95,10 +95,8 @@ enum rte_crypto_asym_xform_type { > /**< Elliptic Curve Digital Signature Algorithm > * Perform Signature Generation and Verification. > */ > - RTE_CRYPTO_ASYM_XFORM_ECPM, > + RTE_CRYPTO_ASYM_XFORM_ECPM > /**< Elliptic Curve Point Multiplication */ > - RTE_CRYPTO_ASYM_XFORM_TYPE_LIST_END > - /**< End of list */ > }; >=20 > /** > @@ -117,9 +115,8 @@ enum rte_crypto_asym_op_type { > /**< DH Private Key generation operation */ > RTE_CRYPTO_ASYM_OP_PUBLIC_KEY_GENERATE, > /**< DH Public Key generation operation */ > - RTE_CRYPTO_ASYM_OP_SHARED_SECRET_COMPUTE, > + RTE_CRYPTO_ASYM_OP_SHARED_SECRET_COMPUTE > /**< DH Shared Secret compute operation */ > - RTE_CRYPTO_ASYM_OP_LIST_END > }; >=20 > /** > @@ -134,9 +131,8 @@ enum rte_crypto_rsa_padding_type { > */ > RTE_CRYPTO_RSA_PADDING_OAEP, > /**< RSA PKCS#1 OAEP padding scheme */ > - RTE_CRYPTO_RSA_PADDING_PSS, > + RTE_CRYPTO_RSA_PADDING_PSS > /**< RSA PKCS#1 PSS padding scheme */ > - RTE_CRYPTO_RSA_PADDING_TYPE_LIST_END > }; >=20 > /** > -- > 2.13.6