From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5FD77A0548; Wed, 25 May 2022 08:10:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 47194400EF; Wed, 25 May 2022 08:10:00 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id CE323400D6 for ; Wed, 25 May 2022 08:09:58 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24P4mRo6019795; Tue, 24 May 2022 23:09:57 -0700 Received: from nam04-bn8-obe.outbound.protection.outlook.com (mail-bn8nam08lp2047.outbound.protection.outlook.com [104.47.74.47]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3g93u2jeu4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 24 May 2022 23:09:57 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AFK8arXEEk2gpP/LNvkgS0MH+9QHU+QAVtrqKqfDoVh5p6FN/RFapH9k04BmB7Mpu2YQrR7rCeTQFPe3gRXzxCqbEVIoibHt6cfFhlt1ZsBEJObJukFWdfLKP+hxYGwz47i/2gNK7yxASrTxj8QpvVXOWULUBNEjvSX/7vUTlzqpN+rG33grAOqgYnB3iapxk2ZZ0cBX/hjRxYodd7UrG5uRPi/6hHNeT/jO/dhlNiSnG+Vp8ABYe6eLxxTvtMGiudBsoBoDa1mHIZjONr29atcGrn1+MkMpDmqcHy67PE4rEjBdIQ/N+N0gONPkPmluJxYdJWhEdVW3bAMUAan/1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=z4dj9qBxf8nd/VyAeSEcYqwDcaSYMDRhHAjJsMB2pmo=; b=b2rwGSkm91ruoDbKyMHeXoJ5Tua+mBFkS/vgrdGJaqfjO166wP86di5ykkLYNi/Nv/7CYSG68baCmAkSOJ5uiLFVIXE+BsJXds2e4YSg6VifDXX1Nq0MQkGrkEmim4EJQ4kRc45F9CAQ4nvttcsROrRatEGYtM2eafnd6H61D9bUtrIdizj1mA+tbw/gkNBU6CSrv5jsL9UmBxiJH4pg1PkRwyZcOf77tBPuEIlah6wfugEdCz+ZrQrhsDenNxnyFLV+0oxQt1Ya6KJpLqL3elE3BtXebG52Ugdf1vCYfX7hdyV6foKs2s6IQURG+7yiemQH+dzQK3sWcabM5aPPUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z4dj9qBxf8nd/VyAeSEcYqwDcaSYMDRhHAjJsMB2pmo=; b=IjHccwQVNNs6FfYhjjYJpt3YPJsvwEOSrsXqr5invkb5yjGtk67YTzo8G9z+ezTkYlPZW+lgu4VZMyvgJvF8TJl6VHIHleECiDiE6xt2KVE4cOhwVGxVRqSH0ab7rqAxJl5R5GoKG67cNa67LOq2r2dP1iq5SFzOcMOhSXpaP8c= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by PH0PR18MB3846.namprd18.prod.outlook.com (2603:10b6:510:49::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Wed, 25 May 2022 06:09:55 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::f154:453d:893:f6ce]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::f154:453d:893:f6ce%7]) with mapi id 15.20.5293.013; Wed, 25 May 2022 06:09:55 +0000 From: Akhil Goyal To: "Kusztal, ArkadiuszX" , "dev@dpdk.org" CC: Anoob Joseph , "Zhang, Roy Fan" Subject: RE: [EXT] [PATCH 38/40] cryptodev: clarify usage of private key in dh Thread-Topic: [EXT] [PATCH 38/40] cryptodev: clarify usage of private key in dh Thread-Index: AQHYbBfOPbpNEKPVEkuERBqXUs7Eg60uAp8wgAAa04CAAQWksA== Date: Wed, 25 May 2022 06:09:54 +0000 Message-ID: References: <20220520055445.40063-1-arkadiuszx.kusztal@intel.com> <20220520055445.40063-39-arkadiuszx.kusztal@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4451e731-85ce-4cca-11f3-08da3e153036 x-ms-traffictypediagnostic: PH0PR18MB3846:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GnOh4giP/hmWsuXNeazB0KbeUI12YIefCh23CQlnRYyME9wiBhPZYBdNMsK1O8cOaXea1VCmum17qmNdqpFFOPVCDw9txWZP2Adv5tqJg11i2RSA/d9JeZAw7zqpltTUv8piG94Q7IgNDC1xXKXHgkaOJ39Kvur/Lb5D23pWwtFXBMACFvuii185+82g9rK/ICV209+tPsStivmJ+MKHqk5TmpnHVy606jCE5PVTPFIMTDKyq/CU8H9PhgMft7bV17QKoPxpYHMSE7YOj1FGBvxhMOCqdymc2nnYcnWyhTz5zLL0OS2Z01vHCrRUfY3e3QIsHxklOqlDVtfGjugOIYBrIGfr2dQMjOre3bB96kv6b6nS1/xXWqzc9IHETBiAEo8okzzWg+UbaOT0whtLwS82v/e8XnnnnxMnQ6uh5oyvA/qNLCDGG6wBv/nQMjGX92RTLphuBu+u0HCZ8L1x5zIDzvLsjjnewsv6uG8lpNUhJUSpQNdvGzO2iGoW6BzdxcvPECq+Zo7ttIL8cuKRPdT9i/hRugZtcU33YYg9dya8TH80ijCLYe80IwEfB1KhrecUg1r+HGOe6qASJTndNzJTIeNn/Q0KPO/qieTvLmzSuYbiZO393p2iIOVB8HSvs4YNOhpZq8OdwWXdndZG1W9hZvHp/sZHQtWxosI2+DK5Pcp/HcZsewPt4fiPLSh1J60NV5vx99cMW9s7XK2Ydw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(66476007)(2906002)(66446008)(38070700005)(186003)(64756008)(66556008)(66946007)(4326008)(76116006)(8936002)(52536014)(122000001)(5660300002)(110136005)(71200400001)(55236004)(7696005)(6506007)(54906003)(316002)(508600001)(26005)(86362001)(55016003)(8676002)(33656002)(38100700002)(9686003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?BinRy1wyb3ezu7jF3aCD/Kz/awGrtIzCL5x9shLEVRbi4sWfpoaxqAs7zox/?= =?us-ascii?Q?qabApSjgOT/Fs7T16rixzYBJ5D/bSycFzxwmf1vLuFxUyBK5J0eimuuwSGWz?= =?us-ascii?Q?+OyfsdBJo3KNgV9k83SA1SlOkwlf7lLJ4Ft4NYL6KHAJnJS5XWr0leTfyslN?= =?us-ascii?Q?8MjjboDEgE1ME9Fcam3xqJqR+nxSkFtRAf+zh2TX75kdtA+qAM41TiEAR0Cw?= =?us-ascii?Q?x4kH1LiCA0x/DC6ZUqM9VCTxdbh9QjkMEu7KKgsASFGD4uwq7elQv8eUxe5c?= =?us-ascii?Q?muK8UeevePNCaSS2ZCag7zH71lO/5PTAJK5gvyA20drfMwu/ZdlP7UKZRmsP?= =?us-ascii?Q?7TFiBcwL2Dks4+qsQvpFvJLxGLuKzNTQicdNeYEoxemihg2eyUKVpYSulPcH?= =?us-ascii?Q?5Q3jPsYTWhfTBZWitv/8cVpnQutLpdAGOUKhp2ab9dvv4XRGtjvClomOpHIO?= =?us-ascii?Q?qih9O5fRI4F8XNY49BLLwz0jlSKn7P/3V//TjydjeVUI+ED6dosy92cbveoA?= =?us-ascii?Q?yWx3cXaoZwVXJjPgABTUw9M7YWL9VdRpNM8o56VBHhbHLhNJpyohK4og0oIP?= =?us-ascii?Q?FIcRBT22lWO9BYe2QMr2hSq2QQnHzf7dy+8WwVsBY0cja6NTGVq8YE04zDED?= =?us-ascii?Q?akbW4Y5DriOJsmKUSo1G+zyK2vtwIXwJEnLwBR37MWZnh6/tx+HIZVj3PLhi?= =?us-ascii?Q?JCdrpazRklCpYByKdJb9A+1F5N6V7eirZ4dGoCJwgLE89lstSBxOvuXalw+V?= =?us-ascii?Q?AHVQSuq8/Bb9GERXLlD+rJL4d5NFcNg0f9nAHZjvVa+GUV7we49/Q/hnInEP?= =?us-ascii?Q?T8pC5RVRybvyRnrWGdQ1xt4w3JjSu5DYAD+oS/0Iy0e5aHvmGStjIgy8IQKg?= =?us-ascii?Q?Yqux/NEhYDoZABmv1DodpxNPzNFgumZ4Jy5A5Fqi5wjGkU6Mogem2tkYZ/MS?= =?us-ascii?Q?VerjtF5QE1PhB75Gd2lpkhB1tLmIvgSTVzR7fwNBVy/Jn6uki0f5XtVh6FTr?= =?us-ascii?Q?ODb2Qz6fm2ru0AcIsidGffeseI2cEDRfhdaZTITjHQsRrof+8uREuuer9KVD?= =?us-ascii?Q?gT4w3DooSkXsmVtl63POziDjEWsGBAU9azK/xU8ozBNqWsTM1QkbognAlbED?= =?us-ascii?Q?zIK1tMw1feKiiOMzfSyN2qW5H9pd6pnPdWiOjniPy8tRkBYI+qvhNXtXLZ6K?= =?us-ascii?Q?cK2WAXlfPL3tgQtcbP1MHdwqPSmI6Wp6uXWh1faGEjwRKe9oZ3IIKG5ipbQQ?= =?us-ascii?Q?NjgP5McoWvr9pCc7qhuS0E1ph5u1g5f8tb7WfrAOXhccKcwcjKstnF91FfJt?= =?us-ascii?Q?fDK13eAX+xLYuo53IGo/2IxYBlKzEorw6g2ipT3Rz8dbeKXMIKFVlfasXwF0?= =?us-ascii?Q?TlbNZD8WBhBgwgxl3MntiT45MHafyKA6atvfKMPInqX/2ae/yY22Q26reqpC?= =?us-ascii?Q?/5lW7k3dAdg+m4wU7LiiCqNwQK5F5LN0e8XECuTK1jUluR0pzizscey4uNK0?= =?us-ascii?Q?2YchnGLHKuGZ3C8OQnaYphSwVSbDR1zZfVIjEThFR3iKj9OMuAAPTYmvEY3e?= =?us-ascii?Q?YHIrGP4Wr8AFGNPxvQHYL+u9Y98NFd+PcAKjxSFmY4uZZl1BNH5QIkOGgjbq?= =?us-ascii?Q?zE7QtaiICiqU1sk/ofTQu7J2t8tWxNnBgVVxEqusVGBV3RyF+PD2W+hMR7h5?= =?us-ascii?Q?TG4eqL/gQzsQgZ0F2alt8N569zttDkmb5vN931cNVb9WkhUWbVWH+9dFnhK6?= =?us-ascii?Q?sJZKdtJEYg=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4451e731-85ce-4cca-11f3-08da3e153036 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 May 2022 06:09:54.9795 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fYCrrrMlJ8XV9OcpCw6pPKJIlANgqIKKOOeYIAlS5iWyLeS0wego4wTZGL+yX7u2rGGFIlacdrnRGKEjpRCo8w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR18MB3846 X-Proofpoint-GUID: BsE-wVquWdaJrgjeg5PW1j-PsOqNiREQ X-Proofpoint-ORIG-GUID: BsE-wVquWdaJrgjeg5PW1j-PsOqNiREQ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-25_02,2022-05-23_01,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > > - clarified usage of private key in Diffie-Hellman. > > > CSRNG capable device should generate private key and then use it for > > > public key generation. > > > > > > Signed-off-by: Arek Kusztal > > > --- > > > lib/cryptodev/rte_crypto_asym.h | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/lib/cryptodev/rte_crypto_asym.h > > > b/lib/cryptodev/rte_crypto_asym.h index 01b1fdd074..a6bb70ca3f 100644 > > > --- a/lib/cryptodev/rte_crypto_asym.h > > > +++ b/lib/cryptodev/rte_crypto_asym.h > > > @@ -459,6 +459,10 @@ struct rte_crypto_dh_op_param { > > > * Output generated private key when op_type is > > > * DH PRIVATE_KEY_GENERATION > > > * Input for RTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE > > > + * In case priv_key.length is 0 and op_type is set with > > > + * RTE_CRYPTO_ASYM_KE_PUBLIC_KEY_GENERATE, CSRNG capable > > > + * device will generate private key and use it for public > > > + * key generation. > > > > What is expected for the device which does not support this? > > How will the application decide? > [Arek] - it is similar issue as in DSA/ECDSA 'k'. Or we will add some PMD= flag to > determine if PMD is CSRNG capable or it will be stated in PMD .rst file. = If device > does not support random, packet will be rejected (send to response queue = with > NOT_PROCESSED). This comment should probably be added. I believe this can be covered in the capability patch that you are working = on.