From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E27F743C0B; Thu, 29 Feb 2024 16:52:29 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ACED9402B4; Thu, 29 Feb 2024 16:52:29 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 4CB0C4025C for ; Thu, 29 Feb 2024 16:52:27 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 41T83HKs022443; Thu, 29 Feb 2024 07:52:26 -0800 Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2100.outbound.protection.outlook.com [104.47.55.100]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3wjp2y9jq1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 29 Feb 2024 07:52:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wv3tMYC+1Ap/44XKbCcm4hhmeuw06FgliIDJYKe5nIxJRr6ypg3w+dbwCeZJKRwrX/QCLEhbYRmQ+owSR9Jn+TS8syLfdS1/pIoXoX801bR8yhYmD4bRY2smHbqnmB+OfvK3QYK43Kx+Czi+YMefg5I/32woV2fQIqOJHTSwLrQ1zLAEK4FT+2CB/br1krVJ5AEBrtGBWQo85U0hwjg69rrQeqwKssXhG2XHEfab55u9p7KdpTjgiVI4lRtpAygUJe4E1mMpq4XMKomqr2PpjgQ2hqYnFuJ2/AVznmeW7oXkR29ODptfvkoUXKJKnQJkWQSEL0I8NRgTTxHvWTfvWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I0tkrphGoWJiW/dhuLd1habscXQZb7NyjMbbOkgSM5g=; b=SdzFhLhfj+dRGV3MJQIQ8W7Te1GhXajxCHMUZDp/5tUmZ3GrIxl3fpPdZE75E0vpwqkclIAUcAmJrEHACTSfoqoTeNGOcFmrQF+XBwmDnG9g4X6HUyQxy6pUFbFlyWZNkyuu3wBru8gMNAII+ZeQNuha3iE+EN99BaELNRdk3obHPyBTsYut7bHUxPdUOOISsiSPescd0PXxoGa4j26gaxHE8raftWo1vZLtzZozKqUYTL4Bb8D9yccYihHg0EIY4avM7FBuOOPO86ptyabwnBCGbZ+R4W8OzV8vUdheHOO/GxiWso31/DbW8jiuRqM+TlBcWRhoxtBh6VhMFRvyxQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I0tkrphGoWJiW/dhuLd1habscXQZb7NyjMbbOkgSM5g=; b=AzFQmnoTFeabqf1HdmTxrugTMe47O7oGxPADCff8ZEIJRb/YL3e/bw8wKEzI0S7pTLJjxx/dJT3eTkJ70RhgLkUU5oVDzaSLvJYYoKjxYxkx/12kTbaIV60OynO/MpXda3gfQOXM+C2XmxUx4F4JkU1NpuNfkXk+A9sjYy8Oabo= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by SJ0PR18MB3801.namprd18.prod.outlook.com (2603:10b6:a03:2c9::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.41; Thu, 29 Feb 2024 15:52:24 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::9345:cddf:24ca:5be9]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::9345:cddf:24ca:5be9%4]) with mapi id 15.20.7316.039; Thu, 29 Feb 2024 15:52:24 +0000 From: Akhil Goyal To: Nishikant Nayak , "dev@dpdk.org" CC: "ciara.power@intel.com" , "kai.ji@intel.com" , "arkadiuszx.kusztal@intel.com" , "rakesh.s.joshi@intel.com" , Fan Zhang Subject: RE: [EXT] [PATCH v6 4/4] test/cryptodev: add tests for GCM with AAD Thread-Topic: [EXT] [PATCH v6 4/4] test/cryptodev: add tests for GCM with AAD Thread-Index: AQHaak6O6uJM/ECSSUmnE8ATvqJT6LEhd8pA Date: Thu, 29 Feb 2024 15:52:24 +0000 Message-ID: References: <20231220132616.318983-1-nishikanta.nayak@intel.com> <20240228140036.1996629-1-nishikanta.nayak@intel.com> <20240228140036.1996629-5-nishikanta.nayak@intel.com> In-Reply-To: <20240228140036.1996629-5-nishikanta.nayak@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR18MB4484:EE_|SJ0PR18MB3801:EE_ x-ms-office365-filtering-correlation-id: f2b0aed8-bb10-43eb-9d58-08dc393e6bf4 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +IAZyA7YHEPn38siRqw2PbOmJLjDXb4V9JRy5YYMNQNARd5D14mMMf8tLV7uxUoqJjQLyS+2nJJ6bJF2dEjlM66dKCnXXq9xMA8pI2OUrE4bNiDY4lVuhsLZiBygtHqqVXYeNlUoFIQ0H2/OeiTy6E1zbkoSoZhZsWMZqtw4MUF6CNG2BZkYL2sj6SUdLiABnJHUIi0IT7NEKvQJbPMOUL6LHGgzqNpeGfLcRMk4cJUUXIsixVwVCVVLI1gS5ShKzzDTOGsX8G78OatOqztIybbmJEyCZmZSKYcr6RqbzJwZz5SDiqB2QaJ7Fx3CybzMGbViQgZhzFqI/YaPQE2NvszJIdCzQPthZ9UFqOPlf71L1yE/Ux0aIhvDPFK3EyWibmLVPlnJZSTmT+oFuoV0tvyEHkoz0YCRqSWIcNsa+NmYbTU7dMfMJ3Ntpabs32Amm/VTblkHCtdS5dpELV28P03fFHd+MBJ2Klcn9f7BCYyLUUPKlQ1BTJ0+DNu7ImJytueJ0ckTWyPYbwn7TC8XDekRznT6LqXexAuWIuScMHAczZiglImVKm4C4fPso0aG/H7USCs5EM8Eow6x80H1HtjsefrrA0fZloVrmKBYMgFNgaj9YhmA+8BmTOkIlzl2LDOCd8v3tz4iucfTQiLLH+g64N69MgbaU1o3EYjdS2Jh/quQK7s41mMSkVNtQfnv+dJo+iTQzx4WEx1E+eHnTQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(38070700009); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?b4PDFfqNOhLCmn9+tMjoe6ufixRTEKVAAyizFOnkjLWivbP2ycSJKq/g450b?= =?us-ascii?Q?NkRGI86IscSFXnp8Oo6wABgpqOM6QB1jTG1rC8rF8fy4Z6PhdLgmf5UfXULk?= =?us-ascii?Q?Dnj/w/k4Amt0N9ZNLNfQuyx7P6ds+e4YQRSf31JN9sJZPh3nl2ulQmDSy31J?= =?us-ascii?Q?JXREIGiAok6NBODD7ATpzzAqR3TNvmvT/NTGcyrtobBaR2O11InNsw/VoTGE?= =?us-ascii?Q?72U65zmiYtcBdaDYXLB4eomIKZ3yjPBPCMcTTHrEP+kQyxASH3Mgae5iRx0Y?= =?us-ascii?Q?JP+KK4S2mM/+9Us1b6eg8nWtv17VEtB9JSf1VAoduo63G6Ho3GAIrMmMaKCW?= =?us-ascii?Q?WoHKpDMKS+lorEidUSFYYmP0D2uWQ0KsIMgGsbRAvwolXL38nqtU0pWloKIn?= =?us-ascii?Q?Uhpohr5Cv1OSjP0hemFWBaxg3lzzkiuMbN2ZznY/CHCOcK54kBZSnjsTSOHN?= =?us-ascii?Q?aLH7UvX753CRbiIC2KS8AnKmcZkRI/IMI1Mjt3KVKq6V5do4k462S2XgQUGT?= =?us-ascii?Q?UgWjEX8Wdm/QYg/BnvN8LkFG80OqNCpUlZC+vQ+g0e+o4PyozevZBpM+Z0/9?= =?us-ascii?Q?MUg7cRtIvYugxIz8fiVKZ4EsZH0CzIUN8B5MkNXOlj6pfBrlBOMp/cfTx9Ys?= =?us-ascii?Q?FcgDRp3ihHMl9otxHe6KE0LWWhfWxYCidSCXqf32uOk4ZIO3jZGTC04XiZNu?= =?us-ascii?Q?qoDtnRkTEdRRuO2iGeYCNVHR0xbXZPvJxOXSnOu6h4QMQn/5JH2MHanXs5Rr?= =?us-ascii?Q?+WMq52Bhepo1cGXwLNn5rbBl58TYzRR768XylBE81uClei/Ak0yO//ik1L9a?= =?us-ascii?Q?N4qhmUhue0Cc7dBBsAfjU0a6rFK06Us4lWitjhGlIG/g12tb7JXUuykP0QVf?= =?us-ascii?Q?eZ1vz5vrb27G4YpcUb8YAxDQkpJhmWf8MnIfhlw6xI2/CU7Y45wa+kK5zqcI?= =?us-ascii?Q?JRHkcGdineawE3mC/OXR8/AX5v5/upauX5Ily686b8mkj1/9y6Tbm+l4xatP?= =?us-ascii?Q?ZgAQYVLf2RJK/S7VSUveUVJwIpNvDYRUtHhQ74uedfMQctsl8KEKJ2O0mthE?= =?us-ascii?Q?MWNyfqx0ywhyMaqisCGE3FJDbSg7xjXw73VY+48DP25L+3pml3506PzVo3X9?= =?us-ascii?Q?lYNvY2X0PLC4eeVGQ0dvkf4+Z1Q8HKHHFJC2Vt9GPIZYxz53WFGG7oa7NjS9?= =?us-ascii?Q?U5icg5F8bdFQaixTYFk6ww4sWDqVTZVMyAPzIeADlrDl8RAfBIdLmdpq4+qd?= =?us-ascii?Q?Qw2U35B8ONbx9HHXg9c+4zmeppI7jzvYu2nWWyOk2SDIO/juquyUZ2DOdPBH?= =?us-ascii?Q?u7IJ9fvBIzABfkZYCPGdA74kYZ1XUYCO5LRwttI89l6wHZe0gPoBbUhXY7xT?= =?us-ascii?Q?mbaFcphr9E5BGMt6OYBP0gJZ+oRJpozpFIBHtViN4bqG+VQS9lVk269iLDon?= =?us-ascii?Q?XfNRtbrueD9dRhL6WZgaeIXTIGA/uzaqvLI/YplIwLUsZSGhno/Hve61YxWC?= =?us-ascii?Q?kaHWDflCn/hXgm3jnuoe0NsiunRe4zy880leEvxanydedhXDc2SoBK80/k4L?= =?us-ascii?Q?sM17pQIZL5RO7rh2muD7UsyulHjRUwUIQPuHyHjG?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f2b0aed8-bb10-43eb-9d58-08dc393e6bf4 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Feb 2024 15:52:24.1656 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PacsOBK8L2f7+g3tWqjWzD+KwlhHRglFkQMdnxk/G9sBhiIlANA819gESpTYuXZLS3C5o4k4ZH66aZcSAsrpLQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR18MB3801 X-Proofpoint-GUID: u9iETxtRoO-1enAMxfUcm5F2DEuZWn9G X-Proofpoint-ORIG-GUID: u9iETxtRoO-1enAMxfUcm5F2DEuZWn9G X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-29_02,2024-02-29_01,2023-05-22_02 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > Adding one new unit test code for validating the features > added as part of GCM with 64 byte AAD. > The new test case adds one new test for GCM algo for both > encrypt and decrypt operations. >=20 > Signed-off-by: Nishikant Nayak > Acked-by: Ciara Power > --- What is the need for this new test vector? How is this case not covered in = existing cases? Can you explain in the patch description? How is it different than gcm_test_case_aad_2 case and other gcm 128 cases? > @@ -12719,16 +12737,22 @@ test_authenticated_decryption_oop(const struct > aead_test_data *tdata) >=20 > /* Verify the capabilities */ > struct rte_cryptodev_sym_capability_idx cap_idx; > + const struct rte_cryptodev_symmetric_capability *capability; > cap_idx.type =3D RTE_CRYPTO_SYM_XFORM_AEAD; > cap_idx.algo.aead =3D tdata->algo; > - if (rte_cryptodev_sym_capability_get(ts_params->valid_devs[0], > - &cap_idx) =3D=3D NULL) > - return TEST_SKIPPED; > + capability =3D rte_cryptodev_sym_capability_get(ts_params- > >valid_devs[0], > + &cap_idx); >=20 > /* not supported with CPU crypto and raw data-path APIs*/ > if (gbl_action_type =3D=3D RTE_SECURITY_ACTION_TYPE_CPU_CRYPTO || > global_api_test_type =3D=3D CRYPTODEV_RAW_API_TEST) > return TEST_SKIPPED; > + if (capability =3D=3D NULL) > + return TEST_SKIPPED; You should check the capability just after it is retrieved. =20