From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3D453A0545; Thu, 26 May 2022 14:04:55 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CD2FE40151; Thu, 26 May 2022 14:04:54 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id B889340150 for ; Thu, 26 May 2022 14:04:52 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24QBjokW026001; Thu, 26 May 2022 05:04:51 -0700 Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2172.outbound.protection.outlook.com [104.47.55.172]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3ga8y0g1yu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 26 May 2022 05:04:51 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nR/l44kFTb+Z+a/kRk8HJ7JiJvDtm4ZOAm9QQhyz3/Wko1DrHxA0Ld7/s/eFv2LCAvE4UKSr0IiGCT1EPdU6tlYeuC0wT2llU2fQ9dFtmdrVAPevOt41zBKgnsl4ggpCOBl+XFg7b5u0kdqAEeYSUAHDnyt0gGYoxmBTJgfcDJVKquQ/phcCXVu8bJO7d+6AaquztFYed4YSHpqj+anUo8Nh7B0kOaEdkG5vO/NqbE6QslepucdwgzPHqJ8ZlefCniXwDj0U+nh+dUpoDIyZ7aiP9XKNVEyi/H+nhPsRyO4m1TCRcWyPNmVN8joAg8ynqOENpkAVMNiS/C2g0b0Wdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yq11O0WJ8kOE37IyJCxebCe7C/3hmPESVundq1ah8MU=; b=XdAy5NpZlJT2YZE8L2LJInLn4eCAOnUGyF/hWSUWeLP38yvfe7GdY8AS7gNo/urQahcODHXSlCILCZsmmByKZUNcWYfA7lr+X4rWIJQonQ3bpsLk1NUFDi1nb6sz83wfUu0anX+Co+/jdZDMawhRvadHXNztZuSTZSz8rOIlKRIgAoytMiwW2f/vFxRj64mfXJCljNIzqYUemlw3/SHj2MtgtH0lZCj1uLnO5zGLAaODIGL1lrJLYbmKxIRIV9yajhys3LT+LYyhboqaa8S3UrwHdEPNkOBAm0ArGUhWW0N7dL2ocARWUTDJ4HpbJ8g6Od4mujHUC2v5H0zUoSiRiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yq11O0WJ8kOE37IyJCxebCe7C/3hmPESVundq1ah8MU=; b=XyJB/cp6TEhRcHCKkirkqYGV8Rv7DsmwquoXZZuyVdbQR5EFqb3qmUCQAD58sBYBHnVpEj2k39SwAgWDO4yfTzIxABHR8pwE3oFYHHydsgQEtKs1Y/WDU77HMIIjqJ3GX5hXEHoN3jaKLSkfhQybNbR8b3NZlMIJC4QF/d1Laew= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by CY4PR18MB1030.namprd18.prod.outlook.com (2603:10b6:903:a6::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Thu, 26 May 2022 12:04:49 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::f154:453d:893:f6ce]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::f154:453d:893:f6ce%7]) with mapi id 15.20.5293.013; Thu, 26 May 2022 12:04:49 +0000 From: Akhil Goyal To: Arek Kusztal , "dev@dpdk.org" CC: "roy.fan.zhang@intel.com" Subject: RE: [EXT] [PATCH v2 11/14] cryptodev: move RSA padding into separate struct Thread-Topic: [EXT] [PATCH v2 11/14] cryptodev: move RSA padding into separate struct Thread-Index: AQHYcFmmv8vFCF6Qz0+PFXv+Hscv4K0xDukQ Date: Thu, 26 May 2022 12:04:48 +0000 Message-ID: References: <20220525155324.9288-1-arkadiuszx.kusztal@intel.com> <20220525155324.9288-12-arkadiuszx.kusztal@intel.com> In-Reply-To: <20220525155324.9288-12-arkadiuszx.kusztal@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 915a9479-18a0-4917-145e-08da3f0feed0 x-ms-traffictypediagnostic: CY4PR18MB1030:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: v1OhdgUIIomfc0mducrRH8ytsWYffQaScbpIkNBo7zc5NIyr1YSja2IF+aQMTp/4EtOCVFFgSqwc5yuCnCu/TYEdZwyn2m+7HV7Z7TohD8kDeI9oBCkLhdWNX5rkJjR3leKIeR3Z1H8hg2yce/htuBv213zLs0KlzuZ+Sj+MN5fubuU3tiwtGgsA6D9/Gu5MlESLM5UjHtJiFFlHgxmetQEjfLKmEbI7ARbHTE+cN6lnE/VjESPW671ExW6TOrh5uwtecBldPpDoAJWoAKIsguI80DcQ19aBufxCflRUqv1lxQDfTRBFf1BiFqxJzvATwBTGlZS0rThK8cKC4q4ak6qfYjNdJbNvNSZt3FAelI3Zr271KynrvwS7g0VC4pNvnGafAYIxg2KCSEkfOrOWRe/wLLXFulcjNmJ8gXgfHQVaFchjOKab4Ak7kD1Ar3EIcMJh1xmFPR+nnTykewuGToqrdSlV0w+V2WLqyUMjuDMep57rR+kGAVWZ28Dj1k0nvYjbjqLx2R4+EUTaQ5NUY/sPvdE9u6lHpgB7lst+mmNqB6eUiO4NAvcnTfILBl6FxvHL7yyko+TqUapxMsyeGUIPxeTN6UaJ7lZDQaGpSYsXJHg7VnUsFAAgh/whpl6WJWVPei/stRMZ9QGnmfasW8SwBlMQL2U2pGL7UYZ/fJzJD0q/wqUxJk8XwzSsWwVoEeEH0+5FAcNlhnCpRTUlrA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(186003)(71200400001)(110136005)(55236004)(38070700005)(55016003)(9686003)(7696005)(6506007)(26005)(122000001)(316002)(508600001)(4326008)(8936002)(64756008)(66446008)(66476007)(66556008)(66946007)(2906002)(5660300002)(52536014)(86362001)(76116006)(33656002)(83380400001)(8676002)(38100700002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Gg81HVJy+BTzwr4AIZcQ6krxJcfgZv2Q6CyB4ZtT7ETo3RDHAR55/xyi1GeY?= =?us-ascii?Q?+f9lqhbC+9sFBqh6jGCcs/OLee2n/kQAnUWLlLJYDakupXIdbd6LYWWtspTS?= =?us-ascii?Q?8NrLdAdBVEZgCTtghXi4fzrlE6AwEzSkThLhp6sdKyU5nCAXfnJQsEx6XW1H?= =?us-ascii?Q?fzvjgMnc5TE3yBrhH3gnjED6GCTeKtQVKYSaY9KEMy7U4Vk3UxS42U2P/KcH?= =?us-ascii?Q?6p668SQbq6w/NQWRUrBFOpQTlC55+tMij/HruIMBFjB+FyTXFwbbmQAuVY35?= =?us-ascii?Q?SKwTgKPBNE8G1mf6CFKa+CM72peOvo7Ieg/shYbBSdfCurI4I5W3Ir3ysW4n?= =?us-ascii?Q?AReuIyXCWPvapl9WSySd9+bQ6uOQQGRbp/j7ZLxoMt6HuPmyB2+b9Y0x+x+L?= =?us-ascii?Q?gA2ty9Cha5QmQm1s2NVHiwslOod2Ouz8vsrLoa9cGAMO4AEHOL1Nyj0eRskt?= =?us-ascii?Q?DanZjjynS+Qc+lxOvV5sDYLA7BqYLAMDswxUSdGDFZfbbKKCo1xxSZaUVhs3?= =?us-ascii?Q?LhGlH5Z9/o36ibuavG4nqu5Tf5hi7rUhxhXwSrtoaDiM5xwvd3yqdPxc30Tv?= =?us-ascii?Q?bsbiPe1Udl2O9r3M0ATtDQY7q3z5DGYrtmgxGOnAAC7D4JBCCZEdCUwOLqXd?= =?us-ascii?Q?gA+iNuHMgyIrmk3coyQNoON91y8mTXj+01k3R8VIK7BF/YyfGrEOftnA/O0w?= =?us-ascii?Q?PyQthX7aas/4TWP8EIRnL6d5IaIeKwXcQ97IBjafSCDscRD4ov9/gtITeKdY?= =?us-ascii?Q?M0A/CSKbgg+UwXKfIWTVGLpK9Ia7G1D7e8YCj+/VdTsYshG/I4ciclB0R03l?= =?us-ascii?Q?IWkt6UYSelOn8QbXWzFjHYaCEp5T2M9PgeFn/oovbnFg64YU8ea0KbMRqjpY?= =?us-ascii?Q?1il1lyihpLLjQvS/T5jC5f1HOqHu4gAWRwRapdSH8mt9fE71uArqx3OHnZQM?= =?us-ascii?Q?91Sksc/PYw7BMm6V5sWUKxxSQJcfHqjbWPY+u432WS307/M5Ji+BmTNXuZpW?= =?us-ascii?Q?vMIYSg3Kb7F0W3wJNpDptm7Ij1oJg+Btahfji58F7vfwiz+Ro51QrOfSHsu8?= =?us-ascii?Q?/u3V/iRmhSpHd2Yt/Eg5vLKlbVXFBBS4IqfZxfAOxv1Uio5zv/po1L07wkQH?= =?us-ascii?Q?ZYHT3+9iK0xJ6Xp2BZhU9OYdrTg1BHZxS+v3RPYx8LvZEF2ue5NkoBq52A37?= =?us-ascii?Q?Nk8/2ubq/h4wyV5uAM207puCfMuVPUqyCx1r53uxc5AHrSp+7RYrz5o2DbpI?= =?us-ascii?Q?YNgj9Bex7YR9BPfpBSHPsIod1QAHnXYEeQDbuW9j4rpxRtb6cGzomrMe8yR9?= =?us-ascii?Q?Dad9juaThMiGYiz2l9CIlwYgSpQ81Feoi97G/B6b+IfdjIilQHiNAi7cByQc?= =?us-ascii?Q?xFOfqPN+qLDEWPGt3ugF1b0d/krZ87RJVuzSieZbhC9P9Jp55fN8L6B0038Z?= =?us-ascii?Q?mbI9t4JO9H0I2Sy1CuNbQ6RXSGJ6hm/yquvg5i7BaQ+Zogfqc0kigkXtFUPD?= =?us-ascii?Q?DPIPIt6v1738pGVedLBD5xlz76Q+bbzvdDqwoH0hyjV9/AI+JIW66u2vJRVd?= =?us-ascii?Q?16ju9S10NUBpeOXssl7eHzTCXkx9yDy8jOtzdbM6oa7K1zg7WlAMtptqhaQp?= =?us-ascii?Q?7bwagKDx7A2vT/bMn3GUXWffkZadeYBGkhhszqron+WwAwG3LshBpjuvykOp?= =?us-ascii?Q?21y3JMzaLpgtpTudAWOw9o26he/Axy7YrGqteW2mI++6RUrNf7o3lWADuDVM?= =?us-ascii?Q?gurkhBaDHw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 915a9479-18a0-4917-145e-08da3f0feed0 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 May 2022 12:04:48.9395 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Ha9QK7wcPNOUxLvVF1vWxbJrrllyiGuUNJcNYbb86rES8grzG28coB1D/t4+LofmDE2VT3gIoroctRpYRjZAWA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR18MB1030 X-Proofpoint-GUID: ZaQIOZYvRYIirn6DJaOMmu6cUqmJQETm X-Proofpoint-ORIG-GUID: ZaQIOZYvRYIirn6DJaOMmu6cUqmJQETm X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-26_07,2022-05-25_02,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > /** > + * RSA padding type > + */ > +struct rte_crypto_rsa_padding { > + enum rte_crypto_rsa_padding_type type; > + /**< RSA padding scheme to be used for transform */ > + enum rte_crypto_auth_algorithm md; > + /**< > + * RSA padding hash function > + * > + * When a specific padding type is selected, the following rule apply: > + * - RTE_CRYPTO_RSA_PADDING_NONE: > + * This field is ignored by the PMD > + * > + * - RTE_CRYPTO_RSA_PADDING_PKCS1_5: > + * When signing operation this field is used to determine value > + * of the DigestInfo structure, therefore specifying which algorithm > + * was used to create the message digest. > + * When doing encryption/decryption this field is ignored for this > + * padding type. > + * > + * - RTE_CRYPTO_RSA_PADDING_OAEP > + * This field shall be set with the hash algorithm used > + * in the padding scheme > + * > + * - RTE_CRYPTO_RSA_PADDING_PSS > + * This field shall be set with the hash algorithm used > + * in the padding scheme (and to create the input message digest) > + */ Forgot to comment on previous patch about the valid algos for this. They are removed in previous patch, but it should not be removed. Right?