From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BA942A00C5; Thu, 15 Sep 2022 09:08:05 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AA8564021D; Thu, 15 Sep 2022 09:08:05 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 7E6BF40156 for ; Thu, 15 Sep 2022 09:08:04 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 28F0IXOw007132; Thu, 15 Sep 2022 00:07:56 -0700 Received: from nam04-bn8-obe.outbound.protection.outlook.com (mail-bn8nam04lp2042.outbound.protection.outlook.com [104.47.74.42]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3jk6995jjr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 Sep 2022 00:07:56 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=avntBCuxBy+Kk6uCYpec6XQ4B6gWlj6VD53/q9s13RvHMkCaOAJjBn7bJLiBmbMs7V08yb6mAqa6NgCs/6MQfu2nVciHfM6NmMc85R1A3I/AyqjGA3iB2HG216eo+SNEKNA4hT2OJs+aCrfLNJalgrJ8lVituN1nw3tttQi94le8ERlINArEmgTFOec+c9rNAX82jv3Z3a+iiuSsOC4DDmQqmiEGQYACT4CxEtSoOcFWPz+V8Fm0Z0HgvIoImMOFF0X3sR40eVsxSUrbbZjCUzPQbo8chacN3QZsQonJfGR4+GherYfcCAhU7Cs4DUjGoe5TVl84K2Sf3MRyk1Q7ZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DZrIwEYkZDe9y33xEkmiSjd5DB3icmnx6IYcb8bpq6g=; b=i+yjVABLoOP6W91gveryOYgJF9hUIYvgMQzETz9ixkaK1aCnEBN56AFGUNGZI36OF4dYaXZqPydyVybFYmq8BeFYNqyRXFVEkoKzbh5iwj2MPEcrudl9PLJg3H5YsyVmli8J+R7ADR/RAgpadeWIlpBi1FiX4A+5/MDjB5VI+ccu3DxO93bUaJqqLEXnGE84C3+bCR/f1NPM3wUHPFA5ycmDif15jwrb2o0S91MQGI8h+GAnx01jS+tairc2rHtSelWCRg4X5uzXU3LKtymca1F4pQeupt+ukcm9Bj75A76TUV5LiVZJ4AZp2VegQhT3av6Pr/CFdqDT4Lv2ToSsDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DZrIwEYkZDe9y33xEkmiSjd5DB3icmnx6IYcb8bpq6g=; b=BzRNvFPBUcovWGizAtEiw5wHa0lDe7YXeVL5OUCqpyR0RGR+kMJlb9nJPmp4HiM3q6S19t+3/1C4vkRTklqZXoXky2o8yN4BgEhthxfoWqj1KE/PX5lIGfOU7C5voGm18SdP8bD5Cwkbm5OM1zRLsH0DbWyz/vkMEHfXasGw3Zg= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by DM4PR18MB4126.namprd18.prod.outlook.com (2603:10b6:5:39a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22; Thu, 15 Sep 2022 07:07:54 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::6d7f:3f2f:935d:7319]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::6d7f:3f2f:935d:7319%9]) with mapi id 15.20.5632.015; Thu, 15 Sep 2022 07:07:54 +0000 From: Akhil Goyal To: Fan Zhang , "dev@dpdk.org" CC: "maxime.coquelin@redhat.com" , "chandu@amd.com" , "ruifeng.wang@arm.com" , "ajit.khaparde@broadcom.com" , Anoob Joseph , "pablo.de.lara.guarch@intel.com" , "matan@nvidia.com" , "g.singh@nxp.com" , "jianjay.zhou@huawei.com" Subject: RE: [EXT] [PATCH 1/3] cryptodev: rework session framework Thread-Topic: [EXT] [PATCH 1/3] cryptodev: rework session framework Thread-Index: AQHYu8M208HTf52gBUSVhtTZwPxv6a3gK9EQ Date: Thu, 15 Sep 2022 07:07:54 +0000 Message-ID: References: <20220829160645.378406-1-roy.fan.zhang@intel.com> <20220829160645.378406-2-roy.fan.zhang@intel.com> In-Reply-To: <20220829160645.378406-2-roy.fan.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR18MB4484:EE_|DM4PR18MB4126:EE_ x-ms-office365-filtering-correlation-id: 8f1152f0-2301-42c3-ff22-08da96e902bd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2+C25H5/4c6SVDKJxk4f+Gy05clVNjVmqU7085iusZ2kznx5CcgbiM+FzbzYKf329ovezcbGQJWTp60UwSRe8+Uw1LyfIFNxTr/HTYkDgNFPuKy8JqocGzyFvbgF33Ii9nNmIOsN4SqdxHxXWzkOh4m96TsZI08U22OOiRezHgd/39f4QBMfwziw4ekItmQLebu3x8qRPeJJuOQ0EopXkiY44VtlWqPHp4BxknQSnDQ5ecGqTtDWljJ4zPiI22lMshkramcOTxtFz8UpJ5pFfzYnQbpQh+NGeEOsrh50BwZAKu41F21NvdEapWrGvY596frQySLpPRDwCaBI4B9sI7E7rTF4QearhB+qqnzEUq61pJeMV4T2dv1WyqyKjRjz11geUMuwnm0jbLNgzLk4TxK6LRGJGkjPX8VjH2wx3Tm27fbickOQ0l2ySje718Y2gclNoMKbReoIBBk8z+R5zNrpMOkB/erS9kHbLbQSVo0EN0eioRY3eF6Dlx5FpyofrbPtjPsaybeXMm94Fj7PGQ2X6Gys0nS/e/YBh0uW777UBVtpfYxY8lk7H6qjK8gQcZnOlel3SxKuUqj5mt8wwYrVrP1bk7aMG1lghAgDx0LJEpJffFEWfFvl7+M6oSArJf3MSS0tCjH3A/no942yKkDhFzDuVNuBE+XyKMs8HuTFDIJt8Vm5/t8W4HCjgnX7vFEDwf+7jD/RNhhiq8i8WnXGseDPpc9FrB70aYA29123dQwHksk9QmnAuoDKcXPlD0rM6gk45UhxLDge7l0ZoA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(366004)(376002)(346002)(396003)(39860400002)(136003)(451199015)(7696005)(38070700005)(55236004)(66476007)(33656002)(4326008)(52536014)(76116006)(66946007)(41300700001)(26005)(2906002)(8936002)(316002)(110136005)(55016003)(71200400001)(54906003)(86362001)(478600001)(5660300002)(38100700002)(122000001)(9686003)(186003)(66556008)(6506007)(66446008)(7416002)(64756008)(8676002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?DZ9TVqSJsFBHDWWhjnNFBYNoF0ApDRyGI/pGr1Akve688LFCx+K2ym28apsJ?= =?us-ascii?Q?t0CfJr9qJ3YNzZBkUTAjXGR+tb+syDEpUYABrgUxxnx7T4JY2+ZVgwKWsBVc?= =?us-ascii?Q?IokuVo1m4tMcZ4jsPqg7HmH3ul1p9oInpqPQB9mHTOrJdjKBQzYvrnbf/FTd?= =?us-ascii?Q?nGbOZmctaPYi5GFdlIxmWARhSG1DlVN0F2KzsB29sj9d/4fWylyq4j1xYGhc?= =?us-ascii?Q?npwSB/d4Q+vyYSftkgTzkgr29W59hrZOGVflQXrCUAgBE1p/YB8Wq6y6fInS?= =?us-ascii?Q?BOhnB+JrHpKh2gsSAIhjr0lMuBQH3InUd6A/tp9HUJTZBg8x4xAiypyhQnzy?= =?us-ascii?Q?eI0flVw0DrOutSFvlibfApAfdqH1/xHgjvdywh9fOqbprQzS2b2oxS+PhFmA?= =?us-ascii?Q?lDMrMy+36MlanoLLE7ISFS8UAmIIjWfUpOOeJgurPGbC+g/pGgjW5QrDGy0O?= =?us-ascii?Q?+dYtoiCVwK6TGg6le2pYSwXYhwcj0L24bZA6asFQCmfgkxy7IweCekdy2rDH?= =?us-ascii?Q?Sfj53NTuBU78TN+As++rVo9XjvUxK/4lKsS7GFUcgkNex/058XCahmUBw3C1?= =?us-ascii?Q?6f/8HZXixXROHjvWodH+M+ViXCoLC//X5+c1TI6TeIyrwDdZadLz7xndXBkS?= =?us-ascii?Q?TGZJP+xt805eVbr+j+TJ9OSnhkX2zBq843S5w0q+54k8eEbFBBb0KnSVX4uN?= =?us-ascii?Q?T/9Yh0DDL/0LNgcRZXZBGyN9vypMy9SCyJ9PC2U7C6ptaVrQ0phrQByFF1DI?= =?us-ascii?Q?kkaxxVAtUi/pdWvFjgoR0Acj4mXYMELgkZjfGibkr1LqWUtph5vIUkq8E+OE?= =?us-ascii?Q?lF59ezj/yS80miEg46MKI5QlOe+jaKuLbUCxd9mtM9db/9HSrv5fixqBHQqP?= =?us-ascii?Q?QhxP1nLcGMGF2Un7Nh4nEvTWZue3bb2/UwmSsiviCb29cBHnv+NkjE+0fdPz?= =?us-ascii?Q?fNYOomg4ICnaYD8zlMj+XtlnknZDCYUaje2spDpOxct02lyu2SR0DIzs5Skg?= =?us-ascii?Q?uBEb0qMIfMOmunx/ycEFwdiZomr5/vFEjMJe7cpLc/a7Nf9OUkiseVx0L00H?= =?us-ascii?Q?PYR5BO5jHWyJPSVcgx31iHw8yHke9IVez9V4NnEcXuhb7rcEHf1ISN/o60dQ?= =?us-ascii?Q?9WgDVsi/KAB5GvpEckT7PKW1pJawfHce1yZbynlBWs58YjMd6HYPxUtSsvhQ?= =?us-ascii?Q?dbKM9o6A60Is0ZFeSKv6XTH6IYXVWPnPICRhfgKHXU0hrTY4EAc3gTB+u9aP?= =?us-ascii?Q?adsqmCcC/Wq6BZWbIfOpI5B0AzaUu+dyqHsgOnv1r80Q6q2mWXCF705MVriG?= =?us-ascii?Q?50gCrwr+lVc8j+L9amDIHNO4alnoBt0A64Ee/2izFjy6b7rvIPYDW8hgyZXK?= =?us-ascii?Q?DIdqJ92pHMgm4yHrBt+Ia414oFH8sKQacWFAWU+a1a3G5gjGzFVW7rFTAkCE?= =?us-ascii?Q?/1PtLETq53Oi2QURqu20Qg7cqPNOxd0vGVoVhVhUbDWEm34QflF+KTZCgHBe?= =?us-ascii?Q?dhp2IjPdN+v9KeEGaCj1VGea3CnveWteDqArMY4n2o5wXaLSm+pbTaEO7l3Z?= =?us-ascii?Q?RNQqi+V/7wWTXPnPVWEwGdKHHp9zv29OMPF5Sj0p?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8f1152f0-2301-42c3-ff22-08da96e902bd X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Sep 2022 07:07:54.3586 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tJ5L1xrLwpJRI7bMuBacE5Bmu69scYG2dXcU68X08NfApcB3L/PIuo9DYBdAtP07WuKBgwLnK9bO/BwIdRNTHg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR18MB4126 X-Proofpoint-ORIG-GUID: 75vXfR6woj3GGkhkA7WjAqGW0c7_gEKq X-Proofpoint-GUID: 75vXfR6woj3GGkhkA7WjAqGW0c7_gEKq X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-09-15_04,2022-09-14_04,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > As per current design, rte_cryptodev_sym_session_create() and > rte_cryptodev_sym_session_init() use separate mempool objects > for a single session. > And structure rte_cryptodev_sym_session is not directly used > by the application, it may cause ABI breakage if the structure > is modified in future. >=20 > To address these two issues, the rte_cryptodev_sym_session_create > will take one mempool object that the session and session private > data are virtually/physically contiguous, and initializes both > fields. The API rte_cryptodev_sym_session_init is removed. >=20 > rte_cryptodev_sym_session_create will now return an opaque session > pointer which will be used by the app and other APIs. >=20 > In data path, opaque session pointer is attached to rte_crypto_op > and the PMD can call an internal library API to get the session > private data pointer based on the driver id. >=20 > Note: currently single session may be used by different device > drivers, given it is initialized by them. After the change the > session created by one device driver cannot be used or > reinitialized by another driver. >=20 > Signed-off-by: Fan Zhang > Signed-off-by: Akhil Goyal Please fix compilation for unused function ipsec_mb_fill_error_code