From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C0A09A0C43; Wed, 20 Oct 2021 18:41:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8440140150; Wed, 20 Oct 2021 18:41:49 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 66DB340142 for ; Wed, 20 Oct 2021 18:41:48 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19KEOHFv011586; Wed, 20 Oct 2021 09:41:40 -0700 Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2107.outbound.protection.outlook.com [104.47.70.107]) by mx0a-0016f401.pphosted.com with ESMTP id 3btmukgsa9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 20 Oct 2021 09:41:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K7ko8SwBaqOW6KKCvX83cDf5RZJMjXmSnr26nz29vK9rE5bpwQawwoXS+650FMkU6ZdE4hWVpxXnedTVGLNDiipE8MrckceXbEf3iMSyKWQGZOJwheyiNcyLTycXKOjeAIhzLwzCpG2+MH9KSH3U4eaJUJDdh6B3btUhhDoePgxTNgg/F8lIu+TFE8Oo3n+PfHPX8OLX9YsSt7BFP6xRP4jVOtaU5F3BkM4/UdQcnqMedMY7AsRuktz1PycKpu0PVbavibMe+sqRYkvsNRrRwdrMD6hbI5CFaLn3iQpq6clj+IDYgTgIaUNlzqmEOLF0xfn1Dtv9fhQNKmCAvD65Vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Vz1vfpv4sttb9mN8Xm2LUKcmj718tCYp7bMLjqkS3hQ=; b=RGUJh+7Thm2W1It65ff31xVvlAei1Jp7ADxJL/Xe+qNf/ksMgvduRn6vh+EjVFCEUIXrkRN71uKq4uE85LFCGxpE3QxzNqi3pt5XDa+2O2dzOeVZ5IM95Lyb6Myf8WV74gJrMGQh+u/njuH0ExytrYYLSa+bK9ukA71peTTWbiwLcWQVy0+C4MVF8xE5dLctRBYN7zX2kg8J1gnPLzmu1g/YMA+TPL4CDsPFDc3/3MvTQ2Vi6pc6AETLY5Q/x0UcmNDf2lc8gzGz/lkSoTLrv8jVnSwG1YZfH5uAORUBHLEbTtNdVF0QuVzf+oH6E3bl4+o/vpAQN7xzw4eLoachOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vz1vfpv4sttb9mN8Xm2LUKcmj718tCYp7bMLjqkS3hQ=; b=LlKyN8QpGVj4lezdF+KMsajb0GjqWXpvg/VxwNaLPzEQsJsK6fG+w0erARGqXCLA5AThaJ0N0G1q8f/kKWNcdQSF5HZkKbKoR5E6j6AhOShHNHrPWoTGlkPmYmbh2tpTmjIvWU2xOtDTkKwUCZQ3jPKtpSHctZ1Uzj2zkO2bCrw= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by CO1PR18MB4635.namprd18.prod.outlook.com (2603:10b6:303:e2::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Wed, 20 Oct 2021 16:41:36 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::c41e:707:3f91:71b8]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::c41e:707:3f91:71b8%8]) with mapi id 15.20.4608.019; Wed, 20 Oct 2021 16:41:36 +0000 From: Akhil Goyal To: "Power, Ciara" , "dev@dpdk.org" , "Ananyev, Konstantin" , "thomas@monjalon.net" , "roy.fan.zhang@intel.com" , "pablo.de.lara.guarch@intel.com" CC: "david.marchand@redhat.com" , "hemant.agrawal@nxp.com" , Anoob Joseph , "Trahe, Fiona" , "Doherty, Declan" , "matan@nvidia.com" , "g.singh@nxp.com" , "jianjay.zhou@huawei.com" , "asomalap@amd.com" , "ruifeng.wang@arm.com" , "Nicolau, Radu" , "ajit.khaparde@broadcom.com" , Nagadheeraj Rottela , Ankur Dwivedi , "Wang, Haiyue" , "jiawenwu@trustnetic.com" , "jianwang@trustnetic.com" , Jerin Jacob Kollanukkaran , Nithin Kumar Dabilpuram Thread-Topic: [PATCH v3 0/8] crypto/security session framework rework Thread-Index: AQHXxGgHgrreuE8Noky70dvpBQ6UMavcClQAgAALT4A= Date: Wed, 20 Oct 2021 16:41:35 +0000 Message-ID: References: <20211013192222.1582631-2-gakhil@marvell.com> <20211018213452.2734720-1-gakhil@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9fac5037-1cef-4960-e119-08d993e87b76 x-ms-traffictypediagnostic: CO1PR18MB4635: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /uMp99QBO0tW+1hg+ijAsPjW2/+njVr10u1R8C3YhFKd564DqxZ2y2Z9nH3k9x1IVxRLZkzkB5v8Uxsf0+uOleZg04Zk2XXUtFd0y6k6Pk/zHAXbb+uIXCOYmkhdnYLpK4GurooIWQm6vbqK5heqFrKGJ/hfGwkwfbsHpMjO1raqLoEpQtTSNu2wLgDhyw90NrD6PWLKAl557AvFoh5kn3avVJoo430sZA+6R/bDTODDTpgPzet4rEk+lHY0g2uZgk4s/HUd0gEIj1htVh3lCE4p33wb80WCnj78hQrSfGzi9L4kB78R3EkbTpiyHaOLGC6VThvmUMaZ5BnX0Qw+G9/lgt/KI1cTAo16eUWwpzjEeoep8fqJ4vUI3VR2Xp6uvouWSC6lwcpXWmlJwGHxwOxnRlfni44q8V6SlQMmHhEyM2j2svi6t2ypv35FFWvJWbSlihwYSGWQy35c3hi157Pa2dqjnhM72AVOhvdh9JVKwQMTb90rke/cylTbFj4W2GJ0HvSMU9WK28rm2ZHS41W32eVkTeqEx43k7imOFMK3pN6ZE1T56DMSTtD2z7Rg/eOSpP/lGPgwOX0Lyhyoo+xMadN46FztccvCp7Dbpcmc3wripTD9ph3cVV/eM+NU5EX7PxEXHDs50uVCm0O6gRpPDadDhqGwX87urRl1v8Ec2wfWdSoTHDZGCzjw66o/dc1gePsooZUWC0BNciU1hQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(8936002)(55236004)(9686003)(2906002)(122000001)(508600001)(7416002)(26005)(15650500001)(6506007)(316002)(52536014)(66476007)(64756008)(110136005)(55016002)(83380400001)(4326008)(186003)(71200400001)(76116006)(107886003)(38100700002)(66946007)(54906003)(66446008)(33656002)(66556008)(86362001)(7696005)(8676002)(5660300002)(38070700005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ubIN9D+ldG6rK4ojUtBux3V4thbLmloFAl1Eupy4wELqoQ/uq+OLReaPf/96?= =?us-ascii?Q?/+oWkNewDLOlxBe0eKeLwZ+akZ3jLOhNkMqHGH9smeQ/w0M/ed+0lDwIC0Rs?= =?us-ascii?Q?OLA0e8Pt6GjvGlEbuFhQGy3JmLib2LF14Wgci0JhT2C2MAycU25scUXQihi6?= =?us-ascii?Q?EknjQAcOdg6ttQZADpLYol5v/kZPs7fSRP7qFkFKYAAmcICQQr4bzA8squKp?= =?us-ascii?Q?LxLCOG1WnijFUBHgIud26XABIKmBnnwZ5nJPAVZiT754LThCBa+cGAK3W7/l?= =?us-ascii?Q?sdic2xkmKZRcjKAOCLsvWe91VTT4iio2pBgEThZ8ZwUnSWCeWFlpmmYHiRps?= =?us-ascii?Q?n0qGnZA3B/hb79HlPL+QtNMAjh24HWfU/HLYx7CFE7unLB03aUcA1CN8SRCO?= =?us-ascii?Q?8NlpYDv0wpCl6UAsjYTZDR5t8lbDz5bTb4V1nwPByEXeZfr8FQq9AOsL9xD5?= =?us-ascii?Q?Xu82kx8nb6R5lKbwr+Zsw8VPzxAAHwylVRk7N8febij3I6Oizb4NAJmYWcrD?= =?us-ascii?Q?kDA+c+nabAZnd249PfgbegILFfTUqBVUk+WfrKr2H99zQ5xS1yRzzao5k7r3?= =?us-ascii?Q?JCuxmukiqgfzMn5a4DellzRcHc/kNL7DQi1zcy5y/pFFABF636LsbNnBI9PP?= =?us-ascii?Q?viy1NagzhxnQmJirjBc14iZP3mKf4W5F6thQ0laDn+IvtNP77K80O9E/1asJ?= =?us-ascii?Q?MReMY2fPTqS8n9ZgeGov1oFA4FU8xPuRhpwG8PMumvblY27KP9zY1FL4UzcO?= =?us-ascii?Q?GEcdMvnT0gM7bAgKYeqNewF2iV00S+jP0NG3kwZGEI67Fh9QAqrHM3QT9mj8?= =?us-ascii?Q?wbIsm/oXDRI5y/miDo8dHGRXRmdqphL8X4GhLR+oZxcL3xx2KSoyWJJbo4Fl?= =?us-ascii?Q?mFRH/Zn0buTSyft/nbpQzz7Krmc94/r12zavWjugNBlsOP83u0K5RQL02BQg?= =?us-ascii?Q?O1ZBWao+PRuo1WmtixfUwLwuCwQ5QtbLnGDTfIcewOI1WjFOXbtFgJvziseU?= =?us-ascii?Q?Ru1rOxfjq14PAG4kSZsj+f51ti+SRJc+N/UiHSohoY7VPwyKIyqIcotAyjw8?= =?us-ascii?Q?BLTh1VQ4o79IEO07GQwJEQUzV8tIrH/Jfad4ykGM0d1NEiatyqCIQllOv7QX?= =?us-ascii?Q?SOqbFNwPIfUbBrHh7gv84SzNSHoaH1fKf7Ya5VOCJP919k+imjIxZFipY1Mx?= =?us-ascii?Q?2VRP1YdCABynUtyYZiBHBXbsG9S6zgOoaFZl6u0AzBoEp5e7kXWFtVqBNGui?= =?us-ascii?Q?QX0gd/6hOP7PcpMA7lBW7lNWC3GL5DyKJYGRT7lb4QcCZSgzxVFRce+/89+8?= =?us-ascii?Q?MCpMJtHM2Wu0AYpq5pj/a4t6?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9fac5037-1cef-4960-e119-08d993e87b76 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Oct 2021 16:41:36.0101 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rdMuVHP7F5/5d+tZt53SB+eB7b/XwmloCXwpcKNab/SyZvhzJ+lzeKnILPIoFAIfcdJOMWlqAVXMfy7hxnvSBQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR18MB4635 X-Proofpoint-ORIG-GUID: GRf-ueLJfOGOWflvgcUTBYJl9arL9SA0 X-Proofpoint-GUID: GRf-ueLJfOGOWflvgcUTBYJl9arL9SA0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-10-20_05,2021-10-20_02,2020-04-07_01 Subject: Re: [dpdk-dev] [PATCH v3 0/8] crypto/security session framework rework X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Hi Akhil, >=20 > >Subject: [PATCH v3 0/8] crypto/security session framework rework > > > >As discussed in last release deprecation notice, crypto and security ses= sion > >framework are reworked to reduce the need of two mempool objects and > >remove the requirement to expose the rte_security_session and > >rte_cryptodev_sym_session structures. > >Design methodology is explained in the patch description. > > > >Similar work will need to be done for asymmetric sessions as well. > Asymmetric > >session need another rework and is postponed to next release. Since it i= s > still > >in experimental stage, we can modify the APIs in next release as well. > > > >The patches are compilable with all affected PMDs and tested with dpdk- > test > >and test-crypto-perf app on CN9k platform. > >=20 > I am seeing test failures for cryptodev_scheduler_autotest: > + Tests Total : 638 > + Tests Skipped : 280 > + Tests Executed : 638 > + Tests Unsupported: 0 > + Tests Passed : 18 > + Tests Failed : 340 >=20 > The error showing for each testcase: > scheduler_pmd_sym_session_configure() line 487: unable to config sym > session > CRYPTODEV: rte_cryptodev_sym_session_init() line 1743: dev_id 2 failed to > configure session details >=20 > I believe the problem happens in scheduler_pmd_sym_session_configure. > The full sess object is no longer accessible in here, but it is required = to be > passed to rte_cryptodev_sym_session_init. > The init function expects access to sess rather than the private data, an= d now > fails as a result. >=20 > static int > scheduler_pmd_sym_session_configure(struct rte_cryptodev *dev, > struct rte_crypto_sym_xform *xform, void *sess, > rte_iova_t sess_iova __rte_unused) > { > struct scheduler_ctx *sched_ctx =3D dev->data->dev_private; > uint32_t i; > int ret; > for (i =3D 0; i < sched_ctx->nb_workers; i++) { > struct scheduler_worker *worker =3D &sched_ctx->workers[i= ]; > ret =3D rte_cryptodev_sym_session_init(worker->dev_id, se= ss, > xform); > if (ret < 0) { > CR_SCHED_LOG(ERR, "unable to config sym session")= ; > return ret; > } > } > return 0; > } >=20 It looks like scheduler PMD is managing the stuff on its own for other PMDs= . The APIs are designed such that the app can call session_init multiple time= s With different dev_id on same sess. But here scheduler PMD internally want to configure other PMDs sess_priv By calling session_init. I wonder, why we have this 2 step session_create and session_init? Why can't we have it similar to security session create and let the schedul= er PMD have its big session private data which can hold priv_data of as many P= MDs as it want to schedule. Konstantin/Fan/Pablo what are your thoughts on this issue? Can we resolve this issue at priority in RC1(or probably RC2) for this rele= ase or else we defer it for next ABI break release? Thomas, Can we defer this for RC2? It does not seem to be fixed in 1 day.