From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2BF5AA0545; Thu, 26 May 2022 13:46:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1D17E42B74; Thu, 26 May 2022 13:46:27 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 6773542B73 for ; Thu, 26 May 2022 13:46:25 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24Q9BMMP025529; Thu, 26 May 2022 04:46:22 -0700 Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2176.outbound.protection.outlook.com [104.47.57.176]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3g93ty8hx7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 26 May 2022 04:46:22 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Bl0JiMVgT0sOpyTQ4VdnGnquBEYTVA9T7rxotPcGKXOl7+JBmSZ3TNQn1hKIwktMSMprUQPhQt7UJqjkycLIxzXoDUvuhuATzCfQYt0ngcI2UWBKH1PmpuI6t+emzMXZRblhUI5ku/AbY38MmlrZOBS5A1Ii414mZNp2aYA5czTXNhCDhmC1sGV7nmv5MhkaaBDZg1s8okVIGtIjhMNl6h8TLvGlJuBar2/Ybt0TS1kdu7NtXagQWUTQhNXwF7yTa9csUcwSO2OCI9oLvmTsazRBkCz1ZpnCSTXbMemZEsy4bqPbx6FUwEGBBaPNP6YQ8m+M8Gmq39qicsupXxl1mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XXUQR8JR2VhfuDNTEMHcM7Xard139L/8vmpoDcNdSSE=; b=d2gAurCiN2SZu6z+ZM1CZyodyROuR0K/fx0DKLhWG74xz7MDY2qL4Phdv1nckhvw6A+WjTDsNi9HogCDHaCbZCL9HHIAahAj/AiioWW9/zXEx37n+iI3QX87VWUDabuzgtRFf2CjuK/4BG5cGU1hbiPwBQ3qJSSVxXmlLA8rCwLGrkGCq+Af3KgvVt7wJ87a1JpNDkh0nyciEN62BryjFrxw3sdmPRAaI/g3N96Gyy51jsTWoWX688NXt6O77nsCwqDpXfDhab6zY7LJPIuDUw3e+qRsjGL98UmJ9a+JiPta4jj0fCC70jPzWQN00pBnGdk8kgTF3paZem7OB+s7dg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XXUQR8JR2VhfuDNTEMHcM7Xard139L/8vmpoDcNdSSE=; b=TA6ylJ5AHEH6TvaNjU5aFCH5ZUHgcO1YLTZ8KWCNBpV47b1InBUbMinWOlzvO+Dzczj7NqqvhY8hY+lyGkLEXQMeF4jw7mkFMf5T0LaIh8Skzmdl+LHvbWiNyBbasYv3x0MlUBv/jpBSNgyPhIChqmxylIZwq0LOkzASgAu511o= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by DM5PR18MB1404.namprd18.prod.outlook.com (2603:10b6:3:bd::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Thu, 26 May 2022 11:46:19 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::f154:453d:893:f6ce]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::f154:453d:893:f6ce%7]) with mapi id 15.20.5293.013; Thu, 26 May 2022 11:46:19 +0000 From: Akhil Goyal To: Arek Kusztal , "dev@dpdk.org" CC: "roy.fan.zhang@intel.com" Subject: RE: [EXT] [PATCH v2 09/14] cryptodev: add asym op flags Thread-Topic: [EXT] [PATCH v2 09/14] cryptodev: add asym op flags Thread-Index: AQHYcFmZewUdLGwexEWEeSfNTfR8fa0xCGsw Date: Thu, 26 May 2022 11:46:19 +0000 Message-ID: References: <20220525155324.9288-1-arkadiuszx.kusztal@intel.com> <20220525155324.9288-10-arkadiuszx.kusztal@intel.com> In-Reply-To: <20220525155324.9288-10-arkadiuszx.kusztal@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 73e43ed1-f3e1-4781-2626-08da3f0d5974 x-ms-traffictypediagnostic: DM5PR18MB1404:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SoVfpV45Mtdxk6+D/4Fxa0ywjiksI+QsHlRJjp3gk+u83USEEQO4rsjTBriHJoKtj3Jy+s5IX+fIKcQV1G7za4N6tHliyQFftVBtRXZtSLLSTtAgGyVOW7a6UlRhSmadt+TdA+Y8Di9+c83sMgcR9NNvl4DHMrtxDu6igmQ9U6RQpYOu8AnIBB0Y2EgUXLKRJtoxBj63aDyfPgLvtRJS0CWyzkWnd7Dp4la8OYS2XVX6iOTvgijAO71IiepCyKTpJ73YrL5RqrGJAyqnXxwlpcEP5H06FPfrUm4O3RIqxnqGuFJkxQQo5e2hT5c2HaVrdjDKUM3/fhcP3hA/gYNWaBQ2iaT8EMJNpad3RFFtUoSuhoSfWpGgSnM4b6ome22Cgp+X1q74KUpVo+zc4REtHRzaA94mwuAeecYJ/wdfuLfKe1LO1jVSpRO15G5cEryCxhzUq7hV/iDBJrQzDGqyStGVPsMq+UbZhLY158vQUPmYZUe4djBJmN7+P5uW57TLaYUmesSHVs5XnTR79jAHPR3Wj3H/FBcYCw4Ah9TrIjt4sn+3THeC4VnK418aoVGfMmFkSs6lk8bTvOSdVhKRRby0x6i/5p4rvWUqjDxRb2GceLNh9nZOWUo+HAdCHJ1W+26Z1ocd++fBqscwbWCEDCDSLotxZuxOk3u6yXkM3aWK7ZjQ2iBewIqGaVhbvFcpgcYKG4rAOeEMYAvROnE1CQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(5660300002)(52536014)(76116006)(66476007)(4326008)(64756008)(66556008)(8676002)(66446008)(8936002)(66946007)(316002)(110136005)(2906002)(86362001)(71200400001)(38070700005)(508600001)(122000001)(186003)(38100700002)(7696005)(55236004)(6506007)(9686003)(26005)(55016003)(33656002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?hdqsMmW7fR4HfYylKZr2f7UBXF/FaRiHYqmvgGNkGrG26EFUro0TvODsuAwV?= =?us-ascii?Q?uHJ10DQsTOCSZD4JLQakTNUTDhfwv+HZxgz/+FqpgZWh94/nmWMzlbTm0QPk?= =?us-ascii?Q?Xl7Ej1Ky8OMwOFAruGGbvcKJSUvzJtu2kfXhN6L3ZbDatM/NX/w8L8bJb4h+?= =?us-ascii?Q?gbqMjMLHm4o2T0GLtyzZX5FIiKoDSyV2CKuyZwQhgIDnX3+3MaZBsL52Kzg+?= =?us-ascii?Q?LihmiqsO2xy9xhYCWL8KX6gZgycHrOhCv+O8US+PhuuO+ovS1OD44xTuO4ZF?= =?us-ascii?Q?Jh3WdhHc0Jl+m+4eQVLfM3rfYANAjy5tZ0BkSVP5xjsjTGmI8LpESgwpf4BK?= =?us-ascii?Q?E2jJaLh25kdjCir1tR2CZFUbwqCw+ERvoynWPGyfVGxaKM5CVOvzZDcU3DE9?= =?us-ascii?Q?f8T+44kpLphB5AR0uBUY72u9T12TZpQwA+BDA2qOBSVqOQ1ITHaw73hcNWN1?= =?us-ascii?Q?W6PWp8E3PkpJny01kdNSssyk7lsZUX02WevuAdiueOAR0U7JUSB31AdBODty?= =?us-ascii?Q?dLDP+czMWmxbuMvan5pI9GvItIkaeIYssVXznWNR5Khzwq+8PnrSjeSS87Oe?= =?us-ascii?Q?a8IgjqIjWHJj/JCub4SrEuXtASoi5uL6kI6UAZ9ME5w+CcmwzfkChsS1ytA0?= =?us-ascii?Q?Km7YR90G40AvQrgTEaHJTF9CHbQooLV0OGZ2pziqXpS4mrQ3ZOsR5qnWiXEz?= =?us-ascii?Q?UpjWyfHpzalGk5CThBTQS2sfft+vzVeGyQXA4zDR9mmL6uq58hPDNBZhLjKq?= =?us-ascii?Q?iOK8sZ33RG4YHcKZ0IqUEBjzWjlwHiNWtQzH+dXmGQgGUE6JDoWurl8C620K?= =?us-ascii?Q?0WlytNKX4+KAqCWrT8mZZOZTSqm6Df/G/bU0srAWEpBoG7ot+8we+MfgW+WY?= =?us-ascii?Q?vOBCFZIvoa42Cnsr4i2Q6Xl9ACi3ufFJL5pIEiAMbm0P/MSdbQHDpXtqGdYx?= =?us-ascii?Q?B4fVcB91+pQrUktRr/nVNj+xnZNFslHfsLnhNRSkrz6hyMA9f8LipkdL7AFa?= =?us-ascii?Q?qP4TJ/1/DASKFHQ6dk/nAW/NfcckStTHDYJhmV78NStCPF7+zbnCzzP60IoU?= =?us-ascii?Q?43pyXSaJy9L+x71XCMpMscm3vr7RrB19ronNppkMwa30BHuQwObNHueX+neV?= =?us-ascii?Q?wjAebFHrFWEwdxm4MRtSgGnfnrQpeYTT4YV4PofV35pTU5lYV15Ji6yFzvE6?= =?us-ascii?Q?Xcb7DBPGhlDOpn/J5mPe8KcQqMo0OWU1RFUwFaLiiyiwu6/fwr4GdSoPi3Gw?= =?us-ascii?Q?KDVm6jjJqSD7CA0IYqvd7uYzCO8vTFPGVkbFYcoF701c4/tJCmTE1KuI64Uj?= =?us-ascii?Q?iEP7CyKJMPPBwkhXSQbBU1mCTy1AJqoD3ipI2piCZsFtkb4jyL6R03KQftzt?= =?us-ascii?Q?rIKcx7/5Qd4NvdVecJAd/8B4j1BCvrN2Aaq7CZ7XcwXTkI2SKpVrETFvS98V?= =?us-ascii?Q?4FBYM1zKEpwUXFGStAn+BZKhVmSsHp6Pw5RVvXQYa40EZP9DYXCTyzKevJUh?= =?us-ascii?Q?J26DSc60mP53CZ/Xz+FWQImkUrZQK15iDKlNnYZavvHQuvwJ6A9YsMRgINYa?= =?us-ascii?Q?peFebytz2VHN5EFn3b8zdl47wCOTuWLE43dBTfLLediGMsem3cjL+WVZeF3g?= =?us-ascii?Q?b3L2252pat32ieKitPFhxeeZ4w3iux+Nkfg90P08kbjaicTUD2ugyNeHMjEb?= =?us-ascii?Q?2z1HU6r8KF3C7El38INdXhi7E5iUX/1nqtArSW9jLGUfK+6AQFuFuGZ/aN3k?= =?us-ascii?Q?EA1qhoI7iw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 73e43ed1-f3e1-4781-2626-08da3f0d5974 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 May 2022 11:46:19.4099 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HxdyDv+/ErFcBNrZpxdFqyVsIYUg27wk09IEQtrjtMl5DEKMt0qCtGBoLVlGDpp+hYwGiBKxNvIMJFbDkuQZbg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR18MB1404 X-Proofpoint-GUID: iacpV0_fYbQnSeqzZ6FG5IlCoVONFDlY X-Proofpoint-ORIG-GUID: iacpV0_fYbQnSeqzZ6FG5IlCoVONFDlY X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-26_06,2022-05-25_02,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > - Added flags to rte_crypto_asym_op struct. > It may be shared between different algorithms. > - Added Diffie-Hellman padding flags. > Diffie-Hellman padding is used in certain protocols, > in others, leading zero bytes need to be stripped. > Even same protocol may use a different approach - most > glaring example is TLS1.2 - TLS1.3. > For ease of use, and to avoid additional copy > on certain occasions, driver should be able to return both. >=20 > Signed-off-by: Arek Kusztal > --- > lib/cryptodev/rte_crypto_asym.h | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) >=20 > diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_a= sym.h > index 3eafaecbbe..1a57c0c532 100644 > --- a/lib/cryptodev/rte_crypto_asym.h > +++ b/lib/cryptodev/rte_crypto_asym.h > @@ -75,6 +75,19 @@ struct rte_crypto_ec_point { > /**< Y coordinate */ > }; >=20 > +#define RTE_CRYPTO_ASYM_FLAG_PUB_KEY_NO_PADDING > RTE_BIT32(0) > +/**< > + * If set to 1 - public key will be returned > + * without leading zero bytes, otherwise it will be > + * padded to the left with zero bytes (default) > + */ I think this comment need to be re-written something like /* Flag to denote public key will be returned without leading zero bytes * and if the flag is not set, public key will be padded to the left with = zeros(default) */ > +#define RTE_CRYPTO_ASYM_FLAG_SHARED_KEY_NO_PADDING RTE_BIT32(1) > +/**< > + * If set to 1 - shared key will be returned > + * without leading zero bytes, otherwise it will be > + * padded to the left with zero bytes (default) > + */ Similar comment for this one also. > + > /** > * List of elliptic curves. This enum aligns with > * TLS "Supported Groups" registry (previously known as > @@ -589,6 +602,8 @@ struct rte_crypto_asym_op { > struct rte_crypto_ecdsa_op_param ecdsa; > struct rte_crypto_ecpm_op_param ecpm; > }; > + uint16_t flags; > + /**< Asymmetric crypto operation flags */ Give reference to flags RTE_CRYPTO_ASYM_FLAG_* > }; >=20 > #ifdef __cplusplus > -- > 2.13.6