From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9DF8EA034C; Mon, 8 Aug 2022 09:43:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4BCF0427F9; Mon, 8 Aug 2022 09:43:26 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 79E2D4014F for ; Mon, 8 Aug 2022 09:43:25 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 277NVRs1029871; Mon, 8 Aug 2022 00:43:18 -0700 Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2168.outbound.protection.outlook.com [104.47.56.168]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3hsnnqnd43-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 08 Aug 2022 00:43:18 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gXsF0zDCgrSYgwoKsH6jEOz+ZW2SBr1esb1a+1k7PLEbh9U5V5VSwpLKM68akCHBNzLDumiZhYKGc2h0D9Qcp73Wc6eghDDjLeJuJVTPNUNBel66MyxWB05sQIjt2bi57Uo+a4nBfKEymryBzDZtZTR9H5wJBuynH9W0INrwP2cuQDlieRoaXPlszwW4qFiLlHAnBIkMtXhBo1Gmwwp2Hup2lnQPxH0oeql1ZVS2nSLsron+M+LOrT6V1KIkS0Fe972WCxBMOt1ijVq8WU2L5D/5pEszfOy7YEx0OP4C3GaIYCYO2mpmFxBfxCdY3GXRKhoXi/RxW9qtGr2nivKmQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=874uTR/x3kas6m4Ev7x/v61xc+7DLOV+vhEUqGXQfcA=; b=i14SiroaKnE2uFZCYS0B85nEI8IJprDjcqVGzIjNbhknUD5gq/+BD/fy2HrZNXtx0zuvlv4PNmfWfnLk9+1M5gN988ri+xKRpQPl49wMRf3mBDWcmOpioNAzucYVuhmQj8Yu7mXM7zZZnzpaEcyuWWhGbhZhBVvoBNW1zwMNXWImuOjORmlmOH/jtWfZpN+4dLGYhFrmF5P9WJuh2nmSPlIRAf9BnxShH5KQ1k2VA9TjYVoGYCnVj5wXHHfB9THlwzYrkyKYz8+QR9SqfUinEjKMtr4VMYoQimaMhoeidWM/Wm/mqFsG9ShTn6I0uVbX70nCl1/9QXiQc4Lei2mzeQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=874uTR/x3kas6m4Ev7x/v61xc+7DLOV+vhEUqGXQfcA=; b=i1TsZjL6Y2bwH2YC/C7UR4/TcuqGrlPxANipRgKZfbvo7CfZ7GLXL6uNYq/6vMaWHLP5X/Ze1sCGeAZpJNqPE6VYmagreOz+URG5qVPXPzOTO0l/18ly0977e0E96KSWrefT+NCr8zeksh0tLi3va41rRgpWS36RBvxkU+7CpcY= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by CY4PR18MB1077.namprd18.prod.outlook.com (2603:10b6:903:aa::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.20; Mon, 8 Aug 2022 07:43:15 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::7df4:c139:2719:5d5d]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::7df4:c139:2719:5d5d%8]) with mapi id 15.20.5504.020; Mon, 8 Aug 2022 07:43:14 +0000 From: Akhil Goyal To: "Zhang, Roy Fan" , "Ji, Kai" , "dev@dpdk.org" CC: Anoob Joseph , "hemant.agrawal@nxp.com" , Chandubabu Namburu , Ruifeng Wang , "ajit.khaparde@broadcom.com" , Michael Shamis , Nagadheeraj Rottela , "matan@nvidia.com" , Jay Zhou Subject: RE: [EXT] [dpdk-dev v1] lib/cryptodev: multi-process IPC request handler Thread-Topic: [EXT] [dpdk-dev v1] lib/cryptodev: multi-process IPC request handler Thread-Index: AQHYoUSUm03CEnbBzEOYSpZ7tshzPq2RnMNAgA5x7wCABJ8ywA== Date: Mon, 8 Aug 2022 07:43:14 +0000 Message-ID: References: <20220726230804.90036-1-kai.ji@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6e6d8570-9c5f-4741-70cf-08da7911a6f7 x-ms-traffictypediagnostic: CY4PR18MB1077:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: t3MAhOA+Jqh1dQvfs3n2cpkhsAtWzijCfqt6ZTKkwHp1n0IxbJjIUVxTL9MfzVV3hboEYpFcIQDySuPOUBT6okmF/xcqPLDzhqMP0M0et/DOqDWvHVzRSzpZeKSDyOFT7pjhLvJ8wTTZ3RuYGUZKRmiOm4BHBCuo4R1wvbiTOvtR4NoTV4mfgWwP5U8m4y355fbbIJjTbY4Ns58981WXfto3QJ8K19srIQcYgFHpCck9cU85bHyHsb/dR4VP0jZBzMVLPf39Lv0LbQ0WkcxWNg4DmkA1yEPgxErytdx/v5Sfe5o0OZ+jqorxt1vDYd7TlHDwiYmGpfOGmMNvpbYH/KxP4OKWh1rot14YHUlEPopnLwam2sEUkp6jY81hiFExjU9gnr7Ilq0lildCYECC9pg97bEceOPvZGvQs9Q+dh2Iq/ODi4O6f8z4MWoTQ8xnO/YZ2jZ+ZJ1SJTad2qIz4F1AxgHg+7WSIAlYjA7X1Re/Dqpwq2b/AZ5+kE4iABShMzHO11t/+RJPYAB4CPwguDGzbjERygUSJOVHbeckKXKMspC0Ej0Ct45M7uon7IXDcCWrMOmThOVyNCTZJ5R21rPcInMKfkN7uGPQbsuvIJpjbnnnpYZFU6t0kGrjHa8fPq8Pg2F6nMu+TqEFsRcdbtQSYVYQXnSvA0d/W6ua98RW+c5vgLW/wVp0qCBFI4XWuDRyWhGy8H7HOEqLODhvk0uvpyhl9XnDo1hTcjgTbxrXD0/8b61VL6bh6D83LN7ZPGIc8JPU65kKZksAT9xqAZqTYhI9Vp/nl6aggvp6zOy6jSiLH0CFgluiX3j1VFxA x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(39850400004)(136003)(346002)(366004)(376002)(396003)(5660300002)(41300700001)(86362001)(478600001)(2906002)(8936002)(52536014)(66946007)(4326008)(66556008)(66446008)(66476007)(64756008)(38100700002)(38070700005)(8676002)(76116006)(316002)(6506007)(7696005)(9686003)(55236004)(54906003)(110136005)(122000001)(33656002)(55016003)(71200400001)(83380400001)(26005)(186003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?b8qW51yM8Hco//Yj4JXLusWy1OdU80jWngs8c/Srx+WDiVprUQG0TleKKECB?= =?us-ascii?Q?eIsFLbWIa9sy2+deXO1ZRoVc0XrcLe0P2cO6+JWIgBO1wj43wOev6QDq22nU?= =?us-ascii?Q?+VZi8lBbpc90x0OOOwORgwcz1f3G2B2lKo5CWF8h4kmMUmwJ+NWVgTGLlkAY?= =?us-ascii?Q?9/6jBkWJEX+3WIeM0zrIBzLgsTj0MYo6PToURfOph8ER9V6A5sjBYPXgC4pg?= =?us-ascii?Q?k3lSfb9fnXHEalPZDvsmqNCn75JTg7QVwJVACONTYhW9FmANtx6O6YwTz2bD?= =?us-ascii?Q?uTwOn82owWCOpwZN5MLAdi9iGVQLczgZuu+URq0C6pYo8l3MG4nRHVXW6Aoy?= =?us-ascii?Q?GT4RQwNrNpV3/qxOhVPVhnZxOB1OYCu9ykaziPKcdWCcByg8fmY1EpQbwHQi?= =?us-ascii?Q?RqaaTVev3FGvDbC1+Fj8W6sAjGmEbTCjHChuLv2cAv6RLjYLIEmvBSYfYpQz?= =?us-ascii?Q?PnKATx7y9ELbnC5OQ9KI0TwdmAOME52DIFnuqaizFnr0v9bQ5R/CW+QmUDFp?= =?us-ascii?Q?HJn3mAlVjrV7wrOCiM3riLw8X/7bhdAAlxccIdMlQfeYM9AdZATO23frC71e?= =?us-ascii?Q?99uD55BISBqZ1vot35Oz9Iw3exDDLe1/XCojIEPJnQx63Dk/cml6UBFCipmx?= =?us-ascii?Q?mCA8UCLNQ3tvfAyZ3BdxW+r8xPH6OGkeHUCdmNnRpOMocTwfAd7sBPLygvV1?= =?us-ascii?Q?3FCwmOrD1OzgpI8Qo9/w5Kul8qKUJUQGJgjqW3LitoatxvszaxvlmVgfSwMK?= =?us-ascii?Q?5wtjcsMq/8onmGIUglaAzaysFv3HtTKAvcUOj45D1fx6+0NIcYEG4TIbi2jD?= =?us-ascii?Q?CQ9B2yhpRBzxjZl0btP/ZUosEnLk/A5Sw0Nr8LOl0CHcbnz1+uVn44Td7Mc4?= =?us-ascii?Q?LsnsG/Hka4F2C2Q2+GlKRCq0n1xnofiwXNpFB6/J0j7Ft317fw/8H+dKCLp/?= =?us-ascii?Q?4cwaaLMlUk7SiRMe0avcANRhH54ahnvv+3zP2ZDHroVuGv5URxfRG+uYTZve?= =?us-ascii?Q?xdtsNGYOF1hFyBNnhTwAbv90yJoDkOGt8GoIprf6nq0xJkA/QOl0Ips9PjxY?= =?us-ascii?Q?kgUove+F2PMmR+bd+fU9FafIo76N9d0RRq90kJ7DbMrtNUO7MnGydESoiTYE?= =?us-ascii?Q?u1TVNuvb7dzxNqJbj9ACyHnQFtLKQYRBSvs9Gu3gQCpQYioJg02w+5ZnIoRa?= =?us-ascii?Q?RLrPaTck2M3SZejL39pad/my0Yo/Ni8GxFbtjg7tg+TQ2LAaz6ko7jdjQpor?= =?us-ascii?Q?wTaQszjXkLZHsGqhzzH1hhv0Vfmfh1X4XbR++LVEXi6+GAvQkjrvfBfSU//o?= =?us-ascii?Q?XjetGOjJBOnVMxjnHjqb3ZbwAbimxHG/pXkABHrCDQ+5MQa1MCOWUUO208Cd?= =?us-ascii?Q?IIhXKUbgQClAHlFxDwQm45pXu75mHP8hvKDJxU3pRdiHLR9585WHmcmywGEH?= =?us-ascii?Q?9k6jXXzZvs5xcVfmPx4l44vEubVkS+MmzH0A1llh72/ZsPpNXlMzntOscr9n?= =?us-ascii?Q?qT9TuZXKN0kcNTiPw+6AQeHJp6Mrdsgl3mBD3EGsykCSCapkTTkTjzLGv4zj?= =?us-ascii?Q?m3fySUqlA5n2xJz6VNh6HKgAx3JoAF5Ej2Mxqn2z?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6e6d8570-9c5f-4741-70cf-08da7911a6f7 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Aug 2022 07:43:14.8828 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +WZy9geAPCeBa1wd69fqCx4RLtgSAC7uSQBEIs+4bFSpazprxfjOU6j2ImtikzTf66OwU/m5lGQiHwo1V+kDcQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR18MB1077 X-Proofpoint-ORIG-GUID: _kpzHqawvxKq_utzkO8uq-2vQ-O0DkfD X-Proofpoint-GUID: _kpzHqawvxKq_utzkO8uq-2vQ-O0DkfD X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-08-08_05,2022-08-05_01,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Fan, > Hi Akhil, >=20 > > This is a library change you should cc all PMD owners while sending pat= ch. > Kai is in holiday at the moment and will be back in a week. I will sync w= ith him > then. > > > > > This patch add in multi-process IPC request handler function in rte > > > cryptodev. This function intend to support a queue-pair configuration > > > request to allow the secondary process to reconfigure the queue-pair > > > setup'ed by the primary process. > > > > Who will release the queue pair already setup by primary in the first p= lace? >=20 > Fan: If the queue pair already setup by primary the secondary shall not r= ecreate > it > but use it instead. OK but the description says secondary would reconfigure the qp setup by pri= mary. >=20 > > Currently, all queues are setup by primary and secondary uses them. > > So if a queue is re-initialized by secondary, and if it is being used i= n primary > > process, > > Wont that drop packets abruptly if the queue is re-initialized? >=20 > You are right. What about creating a variable in the queue pair with eith= er PID > or thread id who own the queue pair? I believe we should not expose the PID/thread id via queue to the user appl= ication. This may be security issue. Instead an "in_use" parameter can be added which can tell if sone other pro= cess is using it or not. And this in_use param also need not be exposed to user. It can be completel= y hidden in the PMD. User will get an error number(probably -EUSERS) indicating the queue pair i= s already in use. Regards, Akhil