From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5F8C5A0553; Thu, 26 May 2022 14:07:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 294B140151; Thu, 26 May 2022 14:07:00 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 67D3140150 for ; Thu, 26 May 2022 14:06:58 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24Q9AdNQ023817; Thu, 26 May 2022 05:06:57 -0700 Received: from nam02-bn1-obe.outbound.protection.outlook.com (mail-bn1nam07lp2049.outbound.protection.outlook.com [104.47.51.49]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3g93ty8m1f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 26 May 2022 05:06:57 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fzLh1+3Sw2c8FyG0wPYEZaSJTspwHHA8MnNCK+WaengFDcTexf59merhhEfIcw25kcvJK8uvcrC5wXGN8uhQ/rJtsxaxUefgtmWkrMFoRYgzNMC8ixzlxydiUTvzN1eEAAxE7hPbdlevPL3JfiSX/dVun61qRkFkDDBYNfoIIZR9YHqF+M6OyRv8WwHyYuI9SN/VfuTtdykbGWhoHTatb9YQRtyKKUQjQhBpsLOFDlkFPfVLAi+QnzUF0ULY87WE484FaikkU38l9tSAdZV86fZYLjLqDGOOYLEq70rsYSVvWYtrWn+JrixhDrfTeAxgguNDrGGexRbp/T5v5HHoNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QC1hEWoNF+HzbGJX3djJZAaY3+EUsw7TG7Rd36SX0PE=; b=JUHtrMVXDezCv1JglyRapLluKlHVUKfbYj34RMEr/FxTBkq2pNAqp37J2zUGW8YACOjM5G2zLCiZTg0L39MEDso7G67p7sBaY814oYTdWnRAEKo2siF7Z1HyYvrgroQaSM7gxreYMg7ekWMJqlxkWDf/mU/CYChyt2J6ZuDW22MxKI62KiuwahTjMMLdTH8ykq0tug3uKx4jQqLhdVIjE6BaGgxUM9T5+oxM7ytlxefGw6jhrUZcC3Dm8jyTara/wzPVQ6voEtlmnoo2GE7y0Fcwr7LbtU/0IPeBe8dWWcJaKOWkSQqx/7Z4ixKFPO55MAIJGjb7r0KGKAG5HA+m8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QC1hEWoNF+HzbGJX3djJZAaY3+EUsw7TG7Rd36SX0PE=; b=FuK++If8Zpw6EW+dY4+SSYPdugzBJSpDVOOgRIKg2gFEVhXYRLe/rEJvH4VKglQnxwo+kfnPFwy+C2fpUqGaJaV6Lcr2rkPCNhhU3ksQadJv1DCGNyVCZmucb5keabeGLlPZ/rg/iz3MPZLWK8/nGu5RQVttgMYCn2wx7CyMF4U= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by CY4PR18MB1030.namprd18.prod.outlook.com (2603:10b6:903:a6::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Thu, 26 May 2022 12:06:55 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::f154:453d:893:f6ce]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::f154:453d:893:f6ce%7]) with mapi id 15.20.5293.013; Thu, 26 May 2022 12:06:55 +0000 From: Akhil Goyal To: Arek Kusztal , "dev@dpdk.org" CC: "roy.fan.zhang@intel.com" Subject: RE: [EXT] [PATCH v2 12/14] cryptodev: clarify rsa verify with none padding Thread-Topic: [EXT] [PATCH v2 12/14] cryptodev: clarify rsa verify with none padding Thread-Index: AQHYcFmskRDdXriMGk2enITC3B/zta0xETeA Date: Thu, 26 May 2022 12:06:55 +0000 Message-ID: References: <20220525155324.9288-1-arkadiuszx.kusztal@intel.com> <20220525155324.9288-13-arkadiuszx.kusztal@intel.com> In-Reply-To: <20220525155324.9288-13-arkadiuszx.kusztal@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fd182357-d682-468d-a2f4-08da3f103a25 x-ms-traffictypediagnostic: CY4PR18MB1030:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: c7lLk5GqXGE3IYLoTX+Q6c4K8R9sJ0ivVm2LWHjnnNNOmHMDqm3MXopkOY6bHdKbnK8BFRpCJ0pFyekEM/J+ZTAAqBNVzVQOU4Cc48HMNZUEpNLVkMaZ8s21Kdn5ykjlNYQsXOtdhwKC1rraDt1ki1xYa5xRjHoUZ8JGfNVq+zBSGSy3/ixSf+GEXv3B34EqPZLRIbwQw2YJ5hWE1zdtn5/LtAE+A0rCLI8U9XrZXGouj2m9jFei10x+lOTvDF5kOMgmib7Yr4MXrwPlK/RDbmxCv/mk8cOfOolNU/cIr14aDGiYRJcnXVKlNxDnAjxujmKXVGrCFFPVmqIoqVGKIR47ueXhUWUWOQy4arF0cxO5aLLoylCPNN5Kccg+DfpplE7p4l95Ya4yLk5mcW9SWNqV5Io4YzNeunC5qtjdByWJI5E2Tmmt5YkZ2pm0sWhhFFGJvmJ3helEz78gH6V3IR7DhHuQY0o7u/10RiTTqU7mglNDMrKRIFh/Z4hhZZ/MyDFw2ZnZ1tjixLbkHJSRTdG/FjYgBsAGTGtOjI6w8NTfE1RDu+qZQ1yAz4hMcPtDa14Xv1cr8vhfB7Ub2Tt81eX71+nRi3UrpVpEiym/PZ820PSuC15O+t0NweZEspI4LmIyK3jc8KMIViU10ehTSn63WCP/CSAdKwpuPJy4nkwwNjPXA1KqWSGUptiZdM+SuRJy3C04DxSPFGFm9bi2qQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(186003)(71200400001)(110136005)(55236004)(38070700005)(55016003)(9686003)(7696005)(6506007)(26005)(122000001)(316002)(508600001)(4326008)(8936002)(64756008)(66446008)(66476007)(66556008)(66946007)(2906002)(15650500001)(5660300002)(52536014)(86362001)(76116006)(33656002)(83380400001)(8676002)(38100700002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vCtVe3xCyJgLamj4hvK+E70jv7S+mC2VgySrZ7WoXvGDDVhbxhUTowRfvzMj?= =?us-ascii?Q?4pJ6+GzLcAjXuFBFiH+OBmJe1FUvYBZPUHYX4SNhu4OvEhpebOUpbnqX096b?= =?us-ascii?Q?0mxCNCTCaHehM9hZB4PCf4kYqjdNoDaR0SnRtRU/nhi6WVWBP+PgLyY4ADRt?= =?us-ascii?Q?KM2WqtaUDlWycq7zDseGXBh33Q7X07evjw07x7OUva/oq9fATWdbA9t23lJ8?= =?us-ascii?Q?QC7f/4FxssgkFhqQekuOtTesVQXJ+z5B4tPTJQQuADaN/il2Xj/bVWoHQTk8?= =?us-ascii?Q?+WFvYodDdbcmQ18hN6PzXxVOjtPTgdRu4HmQIZtz4pYU0Y8bhmSXn3CltvDR?= =?us-ascii?Q?lEIGmqsZj803xXkGl2T1J4zhRE+SdA4SICTxO4EiSp/3QYAa/GvtEPvX8sMD?= =?us-ascii?Q?PjpOl7VxHzCvDvAF2z1ltiHEU4iCDNjdmflAHWo5qc1PLjKgcQza6PqLzsck?= =?us-ascii?Q?qN99KBmBFzu+yHZVGDGDviHBixZArm3cu8tyNPtb7YEkCW8VWsBfs0N9HaQT?= =?us-ascii?Q?WvLeSxQu19AWlqrxVRvqJWSkbuhKm5flv/V2w33U7Va/iAzEwnOwMmhFJVmB?= =?us-ascii?Q?Q/MMgrbKtqqpvprs+N8dvm0JI9P1lqRQrd4dWc84GsAaohr43cNO3/fSh4/2?= =?us-ascii?Q?eh365W60KT9OA3g6XW+ebf8UHQUUJYHumBrJfm3jdBPG8d9z/NHjbB1lTFkG?= =?us-ascii?Q?xI6k936h66kN+kOIfyiY8DtQ1qfSBaiMxo10eTPqqZMp2OlMN8HWapznxmbS?= =?us-ascii?Q?h0/2J/AMfvVQrI/PENGPyZmQk20urNiZ9d+DINkkSgBpspetTtqcQd8ztLV6?= =?us-ascii?Q?BnuOc0/D7+MapGFSlBcqLpZeqCRPLB+SLg58ibzrIXZTITnmdhaWcejL0SZl?= =?us-ascii?Q?JBTaKzRzYdVfvXKXbmQ+ub6IZgeQo9KkF4Q+3E9tq9N3Vf8ZzZ0SdLcdPUlE?= =?us-ascii?Q?wKHxOeY63U2AIkFUQjZ1Zbske9PsDxUQvCmfowoClNW+Rnf9CWJ/c+gQO5nb?= =?us-ascii?Q?L3riCQ36peNle+A0aVKf562PVRrJ3t8Z04A62HmVmno+fe0Mse3ioHXdKeuT?= =?us-ascii?Q?2Q+i787+EWg9VXs1Sdh6Pt4KVO3m0ePBV66mjftKLbj7rE/jmD3zCxdRoqwu?= =?us-ascii?Q?HPVw/AP5ksLUw4QvKeMY429ne08COlIGyiNLSW0/ikJ7TBF33VFr0NDYFsC8?= =?us-ascii?Q?XnkrfZEaFUS9/yxWo96wL+PM2K5KOi/PCJhDGXtDTfOiLO7EFsBZdCIdasIo?= =?us-ascii?Q?MRRUPGIFwar/O4MXzEvI+4Qa/7eq74mrzrAn/AJOK5TL2g6bjvvZ3OFl+PqM?= =?us-ascii?Q?Rj3miAEeZ1g6GZeMkpe8ymeTxMbUa11+1DiV/5YCFUVhmooebFd+kcnec6Wm?= =?us-ascii?Q?P1UXLA7kLtcCMJxR/y+qfHjgFn8gk+qc0VR8SxTNraKIdEwU19uAeWF79eyU?= =?us-ascii?Q?487pbM7EnD2gSi4ICWkb7VCiYKMF3EmJt58mbRz+lphiZSEZUvlYpdBOYhKw?= =?us-ascii?Q?30IOk1K4+OODRh72Atfy23ST5Fle3tneu6czA5lV9k5c/HnBgA7yO5o0Lief?= =?us-ascii?Q?feSwysbGzpnG6+g1OVao48r0AKnMRg+OwmTx80bLnTUx42POTm2S+OP5Zd51?= =?us-ascii?Q?05lldTL4WHFTFdSLQ5NElVjnx8VgMR/VSoxTN53vhLREtyATkNreTyehhYlW?= =?us-ascii?Q?IekeyVPEkUIjNqXYAzengudv+rf4z9ku6FkWbYcUZEXEp3gp7WyyHFj0qQvO?= =?us-ascii?Q?UW3JD/frUA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fd182357-d682-468d-a2f4-08da3f103a25 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 May 2022 12:06:55.3450 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4b0mrlhUsJf4MrTXfBqpTFma4DPbm9zdk/Ou1e2pIKxw5Pcb4NvVwxC/VXlb4wNMAtAAHgmuzoF0Ri6SWiplEQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR18MB1030 X-Proofpoint-GUID: VV77Kx2hIBZkH9-KwZOAomPJnIz1ZztU X-Proofpoint-ORIG-GUID: VV77Kx2hIBZkH9-KwZOAomPJnIz1ZztU X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-26_07,2022-05-25_02,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > - Clarified where should output be stored of signature > decryption with padding none. > PMD is not able to know what padding algorithm was used, > therefore decrypted signature should be returned to the user. >=20 > Signed-off-by: Arek Kusztal > --- > lib/cryptodev/rte_crypto_asym.h | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) >=20 > diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_a= sym.h > index ee0988d3cf..9f7fba3758 100644 > --- a/lib/cryptodev/rte_crypto_asym.h > +++ b/lib/cryptodev/rte_crypto_asym.h > @@ -372,8 +372,6 @@ struct rte_crypto_rsa_op_param { > * (i.e. must be at least RSA key size). The message.length > * field should be 0 and will be overwritten by the PMD > * with the decrypted length. > - * > - * All data is in Octet-string network byte order format. > */ Patch description and title does not match with this change. >=20 > rte_crypto_param cipher; > @@ -388,7 +386,8 @@ struct rte_crypto_rsa_op_param { > * at least RSA key size). The cipher.length field should > * be 0 and will be overwritten by the PMD with the encrypted length. > * > - * All data is in Octet-string network byte order format. > + * When RTE_CRYPTO_RSA_PADDING_NONE and > RTE_CRYPTO_ASYM_OP_VERIFY > + * selected, this is an output of decrypted signature. > */ >=20 > rte_crypto_param sign; > @@ -402,8 +401,6 @@ struct rte_crypto_rsa_op_param { > * with enough memory to hold signature output (i.e. must be > * at least RSA key size). The sign.length field should > * be 0 and will be overwritten by the PMD with the signature length. > - * > - * All data is in Octet-string network byte order format. > */ >=20 > struct rte_crypto_rsa_padding padding; > -- > 2.13.6