DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] doc: announce change to cryptodev cb function prototype
@ 2022-06-24 13:45 Srujana Challa
  2022-06-24 18:09 ` Akhil Goyal
                   ` (3 more replies)
  0 siblings, 4 replies; 7+ messages in thread
From: Srujana Challa @ 2022-06-24 13:45 UTC (permalink / raw)
  To: gakhil, roy.fan.zhang; +Cc: dev, jerinj, ndabilpuram, anoobj

Function rte_cryptodev_cb_fn prototype will be extended to
add new parameter qp_id, to return queue pair ID, which got
error interrupt to the application, so that application can
reset that particular queue pair.

https://mails.dpdk.org/archives/dev/2022-June/245428.html

Signed-off-by: Srujana Challa <schalla@marvell.com>
---
 doc/guides/rel_notes/deprecation.rst | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 4e5b23c53d..d6c94f8ac8 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -112,6 +112,11 @@ Deprecation Notices
   session and the private data of session. An opaque pointer can be exposed
   directly to application which can be attached to the ``rte_crypto_op``.
 
+* cryptodev: The function pointer ``rte_cryptodev_cb_fn`` will be updated to
+  have another parameter ``qp_id`` to return the queue_pair ID which got error
+  interrupt to the application so that application can reset that particular
+  queue pair.
+
 * security: Hide structure ``rte_security_session`` and expose an opaque
   pointer for the private data to the application which can be attached
   to the packet while enqueuing.
-- 
2.25.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* RE: [PATCH] doc: announce change to cryptodev cb function prototype
  2022-06-24 13:45 [PATCH] doc: announce change to cryptodev cb function prototype Srujana Challa
@ 2022-06-24 18:09 ` Akhil Goyal
  2022-07-12 11:57   ` Hemant Agrawal
  2022-07-06  9:11 ` Zhang, Roy Fan
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 7+ messages in thread
From: Akhil Goyal @ 2022-06-24 18:09 UTC (permalink / raw)
  To: Srujana Challa, roy.fan.zhang
  Cc: dev, Jerin Jacob Kollanukkaran, Nithin Kumar Dabilpuram,
	Anoob Joseph, hemant.agrawal, rasland, thomas

> Subject: [PATCH] doc: announce change to cryptodev cb function prototype
> 
> Function rte_cryptodev_cb_fn prototype will be extended to
> add new parameter qp_id, to return queue pair ID, which got
> error interrupt to the application, so that application can
> reset that particular queue pair.
> 
> https://mails.dpdk.org/archives/dev/2022-June/245428.html
> 
> Signed-off-by: Srujana Challa <schalla@marvell.com>
Acked-by: Akhil Goyal <gakhil@marvell.com>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* RE: [PATCH] doc: announce change to cryptodev cb function prototype
  2022-06-24 13:45 [PATCH] doc: announce change to cryptodev cb function prototype Srujana Challa
  2022-06-24 18:09 ` Akhil Goyal
@ 2022-07-06  9:11 ` Zhang, Roy Fan
  2022-07-11 14:52   ` Jerin Jacob
  2022-07-12 11:55 ` Akhil Goyal
  2022-07-17 10:37 ` Thomas Monjalon
  3 siblings, 1 reply; 7+ messages in thread
From: Zhang, Roy Fan @ 2022-07-06  9:11 UTC (permalink / raw)
  To: Srujana Challa, gakhil; +Cc: dev, jerinj, ndabilpuram, anoobj

> -----Original Message-----
> From: Srujana Challa <schalla@marvell.com>
> Sent: Friday, June 24, 2022 2:45 PM
> To: gakhil@marvell.com; Zhang, Roy Fan <roy.fan.zhang@intel.com>
> Cc: dev@dpdk.org; jerinj@marvell.com; ndabilpuram@marvell.com;
> anoobj@marvell.com
> Subject: [PATCH] doc: announce change to cryptodev cb function prototype
> 
> Function rte_cryptodev_cb_fn prototype will be extended to
> add new parameter qp_id, to return queue pair ID, which got
> error interrupt to the application, so that application can
> reset that particular queue pair.
> 
> https://mails.dpdk.org/archives/dev/2022-June/245428.html
> 
> Signed-off-by: Srujana Challa <schalla@marvell.com>
> ---
>  doc/guides/rel_notes/deprecation.rst | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> index 4e5b23c53d..d6c94f8ac8 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -112,6 +112,11 @@ Deprecation Notices
>    session and the private data of session. An opaque pointer can be exposed
>    directly to application which can be attached to the ``rte_crypto_op``.
> 
> +* cryptodev: The function pointer ``rte_cryptodev_cb_fn`` will be updated to
> +  have another parameter ``qp_id`` to return the queue_pair ID which got error
> +  interrupt to the application so that application can reset that particular
> +  queue pair.
> +
>  * security: Hide structure ``rte_security_session`` and expose an opaque
>    pointer for the private data to the application which can be attached
>    to the packet while enqueuing.
> --
> 2.25.1
Acked-by: Fan Zhang <roy.fan.zhang@intel.com>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] doc: announce change to cryptodev cb function prototype
  2022-07-06  9:11 ` Zhang, Roy Fan
@ 2022-07-11 14:52   ` Jerin Jacob
  0 siblings, 0 replies; 7+ messages in thread
From: Jerin Jacob @ 2022-07-11 14:52 UTC (permalink / raw)
  To: Zhang, Roy Fan; +Cc: Srujana Challa, gakhil, dev, jerinj, ndabilpuram, anoobj

On Wed, Jul 6, 2022 at 2:41 PM Zhang, Roy Fan <roy.fan.zhang@intel.com> wrote:
>
> > -----Original Message-----
> > From: Srujana Challa <schalla@marvell.com>
> > Sent: Friday, June 24, 2022 2:45 PM
> > To: gakhil@marvell.com; Zhang, Roy Fan <roy.fan.zhang@intel.com>
> > Cc: dev@dpdk.org; jerinj@marvell.com; ndabilpuram@marvell.com;
> > anoobj@marvell.com
> > Subject: [PATCH] doc: announce change to cryptodev cb function prototype

> > --
> > 2.25.1
> Acked-by: Fan Zhang <roy.fan.zhang@intel.com>


Acked-by: Jerin Jacob <jerinj@marvell.com>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* RE: [PATCH] doc: announce change to cryptodev cb function prototype
  2022-06-24 13:45 [PATCH] doc: announce change to cryptodev cb function prototype Srujana Challa
  2022-06-24 18:09 ` Akhil Goyal
  2022-07-06  9:11 ` Zhang, Roy Fan
@ 2022-07-12 11:55 ` Akhil Goyal
  2022-07-17 10:37 ` Thomas Monjalon
  3 siblings, 0 replies; 7+ messages in thread
From: Akhil Goyal @ 2022-07-12 11:55 UTC (permalink / raw)
  To: hemant.agrawal
  Cc: dev, Jerin Jacob Kollanukkaran, Nithin Kumar Dabilpuram,
	Anoob Joseph, Srujana Challa, roy.fan.zhang

Hi Hemant,

Can you please ack this deprecation notice?

> Subject: [PATCH] doc: announce change to cryptodev cb function prototype
> 
> Function rte_cryptodev_cb_fn prototype will be extended to
> add new parameter qp_id, to return queue pair ID, which got
> error interrupt to the application, so that application can
> reset that particular queue pair.
> 
> https://mails.dpdk.org/archives/dev/2022-June/245428.html
> 
> Signed-off-by: Srujana Challa <schalla@marvell.com>
> ---
>  doc/guides/rel_notes/deprecation.rst | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> index 4e5b23c53d..d6c94f8ac8 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -112,6 +112,11 @@ Deprecation Notices
>    session and the private data of session. An opaque pointer can be exposed
>    directly to application which can be attached to the ``rte_crypto_op``.
> 
> +* cryptodev: The function pointer ``rte_cryptodev_cb_fn`` will be updated to
> +  have another parameter ``qp_id`` to return the queue_pair ID which got error
> +  interrupt to the application so that application can reset that particular
> +  queue pair.
> +
>  * security: Hide structure ``rte_security_session`` and expose an opaque
>    pointer for the private data to the application which can be attached
>    to the packet while enqueuing.
> --
> 2.25.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* RE: [PATCH] doc: announce change to cryptodev cb function prototype
  2022-06-24 18:09 ` Akhil Goyal
@ 2022-07-12 11:57   ` Hemant Agrawal
  0 siblings, 0 replies; 7+ messages in thread
From: Hemant Agrawal @ 2022-07-12 11:57 UTC (permalink / raw)
  To: Akhil Goyal, Srujana Challa, roy.fan.zhang
  Cc: dev, Jerin Jacob Kollanukkaran, Nithin Kumar Dabilpuram,
	Anoob Joseph, rasland, thomas

Acked-by:  Hemant Agrawal <hemant.agrawal@nxp.com>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] doc: announce change to cryptodev cb function prototype
  2022-06-24 13:45 [PATCH] doc: announce change to cryptodev cb function prototype Srujana Challa
                   ` (2 preceding siblings ...)
  2022-07-12 11:55 ` Akhil Goyal
@ 2022-07-17 10:37 ` Thomas Monjalon
  3 siblings, 0 replies; 7+ messages in thread
From: Thomas Monjalon @ 2022-07-17 10:37 UTC (permalink / raw)
  To: gakhil, Srujana Challa; +Cc: roy.fan.zhang, dev, jerinj, ndabilpuram, anoobj

24/06/2022 15:45, Srujana Challa:
> Function rte_cryptodev_cb_fn prototype will be extended to
> add new parameter qp_id, to return queue pair ID, which got
> error interrupt to the application, so that application can
> reset that particular queue pair.
> 
> https://mails.dpdk.org/archives/dev/2022-June/245428.html
> 
> Signed-off-by: Srujana Challa <schalla@marvell.com>
> ---
> +* cryptodev: The function pointer ``rte_cryptodev_cb_fn`` will be updated to
> +  have another parameter ``qp_id`` to return the queue_pair ID which got error
> +  interrupt to the application so that application can reset that particular
> +  queue pair.

I think it is a wrong decision.
Some events may not be related to queues.
You cannot add all events infos in the callback.
In ethdev, we are querying the event infos with additional functions,
specific to the event type.

Applied, but I will try to convince you to not do it.




^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2022-07-17 10:37 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-24 13:45 [PATCH] doc: announce change to cryptodev cb function prototype Srujana Challa
2022-06-24 18:09 ` Akhil Goyal
2022-07-12 11:57   ` Hemant Agrawal
2022-07-06  9:11 ` Zhang, Roy Fan
2022-07-11 14:52   ` Jerin Jacob
2022-07-12 11:55 ` Akhil Goyal
2022-07-17 10:37 ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).