From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 33A14A0503; Fri, 20 May 2022 09:18:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EECA2427ED; Fri, 20 May 2022 09:18:40 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id B6EEB40222 for ; Fri, 20 May 2022 09:18:38 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24JNtIc9018336; Fri, 20 May 2022 00:18:37 -0700 Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2046.outbound.protection.outlook.com [104.47.66.46]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3g6008sehh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 20 May 2022 00:18:37 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EBqioribO0N9DfanIvpWEZD5gO+PyWvHp7RgE59eW64NrvFouCGynuLxipfZIO3ITxivTYfvgPDbKS0ffiggHwitKQ7PhCf2s+6KivV6wNn3ab3Wt9j2oUONbBo16Xa+pUpoc4S83IL7eDNfKgp0aQHW1xvWxVk8QFwEDzHE6ElilzYKDREMLjt+PWB+GoTb1Mf/Ze/K1u/uvnHTw5uoB4lls+3CtLn0u6y/VvSZkCZkz5ytJKxd62vmgnkNvt2oD6m+EBWS7raxBik3KFyg91EjSqJQn3NmRE/7+8R6jgGnSu4+6yO/9l4fjACDxH0+HLnJ3n23xsVF4ZXPIt21pQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BT6jpD4PMo7Wf0/WjodS2QJNAvBFY3opplle6UxNavI=; b=ijCSwWmleqru5mdw3L6mVxSn6X98T7ge4y5eV94c8cs4QBzpr7Sb8l8cBCvJaT/VJlvPCrrgPcaqqakDp88BZoTqsIfgpETYu22PQi7TtyrQAXcNuK5TQY3r7+X9GInnsKKrxPxd4//5PDy/iZfaD1RbdW7IkPKctUxQuf/P7FKqh4jVmsZCid7IsJjnk964olKAZxm7l18xm00oYBqlTXK82BuOmk50w7/+RVyy7SkeqHndTXKQa+pF49mTwFXg3oC+Lv8vrGmu2Il/yueHRv/NoQv/8ypWrp6yZ/RHpod0vC23VxEdpKPTCGlmgTRtKXIqDbgakZ2vLiEGwIcbdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BT6jpD4PMo7Wf0/WjodS2QJNAvBFY3opplle6UxNavI=; b=j/F8JyHh+IbjXmaVVE1o6R1VXXa5zhyRTwokqR1Sm4V1LDWSM1PbLyuB27i0juuEbR2/tfvvxflZz9l8eE1B3/PKXQ+A4cJQcT703dOl5fkQjtE8cm/fcZHB8rSDSJBRmnWm6GwlJnvFWuIPV8ILm0swLht5l41nR9AkUI8lVpg= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by DM5PR18MB1196.namprd18.prod.outlook.com (2603:10b6:3:b9::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.16; Fri, 20 May 2022 07:18:35 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::1d4a:ca8b:611a:9cf6]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::1d4a:ca8b:611a:9cf6%5]) with mapi id 15.20.5273.018; Fri, 20 May 2022 07:18:35 +0000 From: Akhil Goyal To: Arek Kusztal , "dev@dpdk.org" CC: Anoob Joseph , "roy.fan.zhang@intel.com" Subject: RE: [EXT] [PATCH 08/40] test/crypto: separate key exchange operation enum Thread-Topic: [EXT] [PATCH 08/40] test/crypto: separate key exchange operation enum Thread-Index: AQHYbBeh4XeJ2aZ2WUic8rMhAUaZeK0nWhOA Date: Fri, 20 May 2022 07:18:35 +0000 Message-ID: References: <20220520055445.40063-1-arkadiuszx.kusztal@intel.com> <20220520055445.40063-9-arkadiuszx.kusztal@intel.com> In-Reply-To: <20220520055445.40063-9-arkadiuszx.kusztal@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 47b4a288-822b-4b8d-1c07-08da3a30f3e8 x-ms-traffictypediagnostic: DM5PR18MB1196:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xOiLGOTTOmJgHg1y7QHid7R3i7MgSNyBZ0lxPmD3NZhcbrgZVtk9JW8zGh5Ze4+hn8sa78gb6OQmoqjbTxOedPjcjF0kJkZvnANngI6aIfWkoE3mxvE97mya6KLvHezEnBWxm6/InkOQVT8G7TeI6yt5cZvfQgKAo25A3ubRfyk39/8ETl0fq7taD1h1YIbiRvcKOQkW9oLl95635ePP/lEjpNujifxoN96rBFoqJPxlaMz3cvDwYeRFcTmGaY+r6jwhiz4rEZtULQXvWoM6J6n8RsauWJEeo9kQyi/vyvn/MwbPuOj7aBOq8oY4UYNRR1yb14QiR0F8C4aGZRWGQJzPxa2/0l5LlCr9vJBTbPuAFVwTe7PPFIvos5ta/6HG1qYBTSjC7ubpxLK19fsbgJg0uL2Rr+IDy44rGRKDNBEmo+h/B2P0yBqO/7+rjoeqjwIPJBJ971jqwLR1XWhK7ldkGbmc8vt6azSUeuB2KuLkQo4yydCUlzM8nwJcQ2fZh0r7kMmodzJI9CunJqI/wZr59AQridswKcmkkA2tQos/K6C3eVpz1VzmUfAATdC3K7LSxbuuw/wpEN+IhXQQrRylQJu+Ev3eFDIOfgIoEl2B01BjoZotLWgWKgqd7Pgyu0ANawRqJeY+MFvR50npRZcQ4wZCnL82bwYdub3Qp0mvgIjMUBUS0u6UyUKphw2FdwQ0hFkvLG+qcgNCaBpzDA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(54906003)(110136005)(5660300002)(122000001)(508600001)(186003)(38070700005)(71200400001)(316002)(52536014)(8936002)(2906002)(7696005)(55016003)(8676002)(66946007)(76116006)(86362001)(9686003)(26005)(55236004)(66556008)(66476007)(4326008)(66446008)(64756008)(33656002)(38100700002)(6506007)(83380400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?hSeWuWS9a/oW7rZGOc+cTFtpdTp7oroyd4gmk1663dWU0a2nqyncaQu2Yu4j?= =?us-ascii?Q?JirOBSrpSVgJNt8S5dItVZBcS2wMQEJm9OzjKo0O6913JKh+7ee3oLLD9TLN?= =?us-ascii?Q?aLG/3+yYYgYd5T8p11wUOPUs2bbaeysPhuMIlKapYsRjBVMWKSIKAOC1z8zZ?= =?us-ascii?Q?KQj8aeXmBWjwCR2OaCFZrwTgKKtiozngBOCaFmus4XBJqhsgmcUzPAgPjCjD?= =?us-ascii?Q?63k8bg+9SqplW3ZrQvEVY5rdqFDuQCB3j/IrnvenCkWlTiuax3iMdmZVKbnS?= =?us-ascii?Q?jcjpzmxnEmBaqPrfSi4kAIL/vVJ+sV0xj5VAefTqgT3DJkDmLHD6aM7RzMxD?= =?us-ascii?Q?K9kYmD1TGjPIGR0y3XUOxt2KrSiAii7m3NsBbwC0a02uplU09McizPLU83rW?= =?us-ascii?Q?qkiN6A9++ActaS4iiEztgyx2dzG/T2iuz0Nwu5JCpvOqFQdSgZmBM17vSRhW?= =?us-ascii?Q?13bXIdtRpmUvw9z0opM+Gdl54oBhb1YnTBglIsPsfs4w9x5THpdEsZ+GYpBQ?= =?us-ascii?Q?e9rhKBFmBdV/2rrrF3owCenIK4Aztj3httABUd0qCiL5dcwUNeqKgAJhCNVu?= =?us-ascii?Q?FPlIHXaqLewZb5AD1cqwtjsn7HtlYvPIQata06hJzuH2fMndI1fOGElR+h3/?= =?us-ascii?Q?zGMiX0FeUcrE+cnQW6O6X843KMQiUb6XdTHDEJsUbL0y8Pnyo0RDDyzJuKCu?= =?us-ascii?Q?+M65aGrTgZ4GR3kcYX3wRybxfuFjI6YvwWbAtWpFg9Po7aoW0k8yEjVDRCep?= =?us-ascii?Q?r8cu0WFfpeo+uepVx2vZtggqkieFLUCGZ+a/gc23HMBw7szjm2n5rlaKMllK?= =?us-ascii?Q?PbBke085TuCdAYQzNIWP0TpmZLw+qDhXuMlpvZq/SMxH4G6Eu5PAS5msijDT?= =?us-ascii?Q?sla1rNHt1nDq6eT7ODu29WiqTFbHfxySMfM3pP6XjkkG0UO4ZtFmqfXuMV+8?= =?us-ascii?Q?gWuDOshd43MJKha/K0FPh/PRTb1Gix//NdDKzMu0hdMS4ntyzAv7kGVxtST8?= =?us-ascii?Q?lNhXV0cTsgLdmyYiCBGZhpR2jRBOY2CK6Q0/fqmZQu8EDGTBk7cHdz6LT7Gv?= =?us-ascii?Q?ea36Cf8YI/zKS87qNbX1cg4ha80gxj5Gg4VAFHkm5C3cCgDtR4yJ1NS3utpf?= =?us-ascii?Q?eQwhg6Qms0V4Eq90qqyYRqZhkPEm0Br6x2asBnNhbN9/Bk+vjs5/hSEpJ8M1?= =?us-ascii?Q?+NVRYO5SlngU8f7cBetuVFtCFZ2Q1MiUeb9OU6KmzOC3ZCwnSDqC0LSMq1ia?= =?us-ascii?Q?QlKvltY3tBqQtE0NEexcNdQFwUZioDkJck4uocYhw4VdEtsDpxnuxKufN011?= =?us-ascii?Q?yoZtTw6ttP5djzsAe2SyARXeTDb7eQTqmrj4FEmOE+UXhkCd8GD49Qk+rln0?= =?us-ascii?Q?xD1rFq4fpyFeB2LonjNL+aQq2TfOmd5i/jIAaxsOcG/1m6WVPp4UBs4DAVOL?= =?us-ascii?Q?8kRDYo0jUZL1ZXcWkJ954TjuLk0hx96y/fTDAaqmM3nd1EA4ngoTi7EWs5Yd?= =?us-ascii?Q?hanjClcwOHBLmGqFil+iTLzsLAqujOVXulQp8fBZzfXkEvYmaUYdIlNGVNiX?= =?us-ascii?Q?nB/M9qh96bzRHOLIne2MA4xI6KNJSXiIWmQH1NbKyv2prWJSvGUpkp2xrPfa?= =?us-ascii?Q?O9IkV7VTdwcb8/DF9JsGSm3TDY1/NAXY65uNvBSsdUNMSvPuB2scCra4J7jp?= =?us-ascii?Q?bGYCWrOZg40+L/Lfl0UCpn4pxElVMljEEf7wcqY1XiUlo7QXhxsJeBc2R5Wh?= =?us-ascii?Q?fEGPZYVmag=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 47b4a288-822b-4b8d-1c07-08da3a30f3e8 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 May 2022 07:18:35.1106 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VrSsMzwiQFe1aOEMIYDPqSymq/TxwovcNBYsd2ZQ4djjCyR3ywCoFFgAapBcWfRqsbWbuUPgy2m23+JImeTdvA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR18MB1196 X-Proofpoint-GUID: FnPDI1G3rtuqI2wEir0ke9P43ng-P_jC X-Proofpoint-ORIG-GUID: FnPDI1G3rtuqI2wEir0ke9P43ng-P_jC X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-20_02,2022-05-19_03,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > - Key exchange is now separate enum. > This commit reflects changes to the asymmetric crypto API >=20 > Signed-off-by: Arek Kusztal > --- Individual patches must compile. There are multiple patches which needs to be combined. 6,7,8 should be a single patch or else compilation will be broken 2,3 should also be combined. > app/test/test_cryptodev_asym.c | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) >=20 > diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asy= m.c > index 62d710b0a0..0098b6bf65 100644 > --- a/app/test/test_cryptodev_asym.c > +++ b/app/test/test_cryptodev_asym.c > @@ -530,7 +530,7 @@ test_one_case(const void *test_case, int sessionless) > printf(" %u) TestCase %s %s\n", test_index++, > tc.modex.description, test_msg); > } else { > - for (i =3D 0; i <=3D > RTE_CRYPTO_ASYM_OP_SHARED_SECRET_COMPUTE; i++) { > + for (i =3D 0; i <=3D > RTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE; i++) { > if (tc.modex.xform_type =3D=3D > RTE_CRYPTO_ASYM_XFORM_RSA) { > if (tc.rsa_data.op_type_flags & (1 << i)) { > if (tc.rsa_data.key_exp) { > @@ -972,7 +972,7 @@ static inline void print_asym_capa( > rte_crypto_asym_xform_strings[capa->xform_type]); > printf("operation supported -"); >=20 > - for (i =3D 0; i <=3D RTE_CRYPTO_ASYM_OP_SHARED_SECRET_COMPUTE; > i++) { > + for (i =3D 0; i <=3D RTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE; i++) > { > /* check supported operations */ > if (rte_cryptodev_asym_xform_capability_check_optype(capa, > i)) > printf(" %s", > @@ -1062,7 +1062,7 @@ test_dh_gen_shared_sec(struct > rte_crypto_asym_xform *xfrm) > asym_op =3D op->asym; >=20 > /* Setup a xform and op to generate private key only */ > - xform.dh.type =3D RTE_CRYPTO_ASYM_OP_SHARED_SECRET_COMPUTE; > + xform.dh.type =3D RTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE; > xform.next =3D NULL; > asym_op->dh.priv_key.data =3D dh_test_params.priv_key.data; > asym_op->dh.priv_key.length =3D dh_test_params.priv_key.length; > @@ -1144,7 +1144,7 @@ test_dh_gen_priv_key(struct rte_crypto_asym_xform > *xfrm) > asym_op =3D op->asym; >=20 > /* Setup a xform and op to generate private key only */ > - xform.dh.type =3D RTE_CRYPTO_ASYM_OP_PRIVATE_KEY_GENERATE; > + xform.dh.type =3D RTE_CRYPTO_ASYM_KE_PRIVATE_KEY_GENERATE; > xform.next =3D NULL; > asym_op->dh.priv_key.data =3D output; > asym_op->dh.priv_key.length =3D sizeof(output); > @@ -1227,7 +1227,7 @@ test_dh_gen_pub_key(struct rte_crypto_asym_xform > *xfrm) > * using test private key > * > */ > - xform.dh.type =3D RTE_CRYPTO_ASYM_OP_PUBLIC_KEY_GENERATE; > + xform.dh.type =3D RTE_CRYPTO_ASYM_KE_PUBLIC_KEY_GENERATE; > xform.next =3D NULL; >=20 > asym_op->dh.pub_key.data =3D output; > @@ -1317,9 +1317,10 @@ test_dh_gen_kp(struct rte_crypto_asym_xform > *xfrm) > /* Setup a xform chain to generate > * private key first followed by > * public key > - */xform.dh.type =3D RTE_CRYPTO_ASYM_OP_PRIVATE_KEY_GENERATE; > + */ > + xform.dh.type =3D RTE_CRYPTO_ASYM_KE_PRIVATE_KEY_GENERATE; > pub_key_xform.xform_type =3D RTE_CRYPTO_ASYM_XFORM_DH; > - pub_key_xform.dh.type =3D > RTE_CRYPTO_ASYM_OP_PUBLIC_KEY_GENERATE; > + pub_key_xform.dh.type =3D > RTE_CRYPTO_ASYM_KE_PUBLIC_KEY_GENERATE; > xform.next =3D &pub_key_xform; >=20 > asym_op->dh.pub_key.data =3D out_pub_key; > -- > 2.13.6