From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9B56F43CFA; Tue, 19 Mar 2024 10:32:26 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3E59B40A79; Tue, 19 Mar 2024 10:32:26 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 49FF940298 for ; Tue, 19 Mar 2024 10:32:24 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 42J4x9hp023529; Tue, 19 Mar 2024 02:32:23 -0700 Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2169.outbound.protection.outlook.com [104.47.58.169]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3wxk77kwq3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 19 Mar 2024 02:32:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oU0u1SxF7xtQ3me3aaxcV58Dl5VOdChKqYsFUz3NdBDyyjKAXwB5Qxbp9Z2Bm19r+poZmesWYmPSa1MLEcrlMSFHLmyyXPJlQ8VfL8iUKVy/pVKe3fUI/0ad5UGVITLpBFwSOE5kAHthejQBlTf8g9tIlEyLVi2oinmK8V6nhckB4HFEJSbQI3hVaDS+t67jRFTSGsjqCR9b+s6V0Ixuf7zzMghVPAmmVzmR+PePZUATF56vKqEtXnzhOJnVcHBSMn3dBrB31rBaXYgfoUktce6eo+ZPgYDAT9+3htSBzgrcBrJWB0FoVf7zy1B7u6GNiYVWdGnz4ESdBpH/x8gvbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yunsfISg6+j4eXtZaFuBKtsxd0BkUp3TTL1g1gcC6/0=; b=juhoKr2QbmupgAp8+924wHixjJMD6/2ydHbjQmueMLk6wH1088Kmdex2Wz6lGj4mGXHmhyQTDrEMH0/X13C53oth+tfKxXCU6HgmuhMJ/DF8fPp4TsLP/xwnQ1zkzIOnqmKdSoaCkVOrdqzf6uMNPIoOOCJaSuIHakWIBarW7JDznAJiRXffa4gc7mLwBlz1p/0o+znh/ZvYF6V8VytfOzl8gxzXEFvBxqsXJBOOX79/9TlkZ4ewYItIRMSxPPSJocprTwezibMuHJfPwhhpMm7yQLz56RzqT8Od+IONivyeiGIWXI6RyC9PYeIKWVLEigU44NnLeIYjMhC7xby3Sg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yunsfISg6+j4eXtZaFuBKtsxd0BkUp3TTL1g1gcC6/0=; b=EJBrN+XYFvenPvfwSZZ0/1oKK6vmPYRE85dcbyxv2yhVCx2i+Eyx4Q/t9ClJtXOmHKkZflMWr9sjyJ6pcv0YntnP1aeFwuag9UxLajzKeYqfkPcveQPam4Mh9K6v9i+5B/MCtO0e3fNofI9NqtGt+QBvXxStaTlCAXCKFd03uGU= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by DM4PR18MB4366.namprd18.prod.outlook.com (2603:10b6:5:39e::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.27; Tue, 19 Mar 2024 09:32:06 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::4e74:4cf3:63b6:b149]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::4e74:4cf3:63b6:b149%4]) with mapi id 15.20.7386.025; Tue, 19 Mar 2024 09:32:06 +0000 From: Akhil Goyal To: Suanming Mou , Anoob Joseph , "ciara.power@intel.com" CC: "dev@dpdk.org" Subject: RE: [EXT] [PATCH] app/test-crypto-perf: add throughput OOP decryption Thread-Topic: [EXT] [PATCH] app/test-crypto-perf: add throughput OOP decryption Thread-Index: AQHaP742RYhcx/RoTEimHsaTWSKaH7E3+RBQgAbJLACAAGrzwIAADKiAgAAFFHA= Date: Tue, 19 Mar 2024 09:32:06 +0000 Message-ID: References: <20240105100104.908543-1-suanmingm@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR18MB4484:EE_|DM4PR18MB4366:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /umvK3NHQjKGC40wCrrXzJ8s2auK7qMuPc7e465fG8NLR1YIXqn0RNUKB9gw19KmNL2iRCyYzG2vXT9MC4ZLKObo9abmLstwI6fdBDChwEiBCSS5MCdivWu7KTZp+9iBuyc0DrVDMnQ48r7rdHKM3kSeUnDBRcgj+xf5bsO4lCU+OrlDRVNogPDmNhLpUBge39SLnsrifOMSH4gQ130NiM42DBFUjuI4TQXclsvH25jJ602pVPO3Nr8JnD//87ltY4WHYUFZuJVkPl0/SVxU8Y1a+D4fInnjAu8ii9aqp0IwbPgS0iQAJRkw0V1XiIh7R87GN/1eiFwB54Wl+9Wp13RLjbRMB7HGlr/QtGmKFpifzfQnXHGBwgSY9XSLta34hjQHf4n/aPSXFXLP3wWCuN8My+j3PDk64iMrpJUVc5PZr8/BH7ASm19LbiuN4MTMgUEl01wHxAx2yxHHdUeGvO42FfCEhSDjAV3rMU4lwM814nKDhex/NuckX7ZdNdl3KDy1w7T1NWHXHytYeiteNSIa1SdAw9EEvvawwIB1GZNUhSQSsWjDV8NcYFGU8VTrRNnm5lCbcqCGUhLYJ4x3Sm88s8yqkizHnJ9Fb9Hekap50IkQbgNX52wR7cpSfMY7ZMSlRQNhqLZNjTqJHkPX9/WkdU8tqA1smAdq29CwNVo= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366007)(1800799015)(376005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5WUfic1jjDhy5gX/H5oWYq/mC40urjDPf3NNmJgVTFlGufkudQSvyIdhj1sV?= =?us-ascii?Q?1yq3siiEnJAnxiDQd8YjfLaiRl7XzxHbB/Fz4rKmB6se2H1w9DqpzUSq8XnL?= =?us-ascii?Q?ZPDDvQEPppmtOh/yLfKsoMhTb6hh/gssTdR30MOzvF0gFU8Ti2RE6gO02wBP?= =?us-ascii?Q?BVIwSc+BukDsZAeCfrsfUUhU7hQcxnc7BhNHIDPO/DjkuEy+EDnrl39cqUq6?= =?us-ascii?Q?Ek96+lQLbmASu3zwGW/Izve3CxoLOT5ZtBUgzl1kviHUVZMFW94shUPaXWYw?= =?us-ascii?Q?eNCsmSrOkBrQFvjMVDtzca60kEJmXXBIHtukOyurKztDrvVRl7mBeSHv1T5Q?= =?us-ascii?Q?pjklephqjYcyKwkdCdR1PMKYnBM93Mb3AvepxCAWwXVsIfXWXtsMZbSNDk3n?= =?us-ascii?Q?x8Raw08Kn/taddKlF47haGG4veKw3vjzwQGBQLEM+SOrwjuK7BqsjV/rA7JR?= =?us-ascii?Q?XLMTrHujyNreSO4Se+JJI9X3qaNHJ37kdZ+Vgn7GH8uI65hZ4vF2wasphIS7?= =?us-ascii?Q?oGB787ibeIJuKIL8K4Vd+JVrH8NcJenJoWWGeErCym6q9pr7ZMnGE9rCyZOM?= =?us-ascii?Q?G24wi3R4kbV+XxQnoVRKRBqWxQ6kVBQWO7TxL7Ns9lyUwTEHi6bbfagfV0of?= =?us-ascii?Q?KHgezaBXc9Fv4PFLkOndlmzDKB5khh8nkkjcdFtZjdufhKSMtwZfwjviEbdx?= =?us-ascii?Q?SvvLpTrQgU5zCdGW8g3eOmSOs1Vvyit4geAQKUHmSJ6ldfzIGtqwewE9NI/7?= =?us-ascii?Q?1K951ID6PXvVYbEKi8VMHM19Yh2Yr7ktYS+zxrrIT3ujcT6t4YSEqK1StlYJ?= =?us-ascii?Q?4bkd/PMoapdvH4YmdqTxm2olfLZhBXtKn2/A6/WJGlJjIu9NMpwRx8SlhwHl?= =?us-ascii?Q?YggzQ8JuWVORwvmszRU33xjOUsm5Cd0SdCvPqGI1kr3BwUBezpNwmK/6cOJs?= =?us-ascii?Q?Mj/afrWwVhxqHTCqZ5YSN58v4ZOf0p9CRQXwBw0wKyxnRFL3VdQ2bUGkrN5O?= =?us-ascii?Q?bNQav4nNjnTn/jWC39ysHV0UEh5dgQk8dJxtZfxY6WbE0KWUTdt9Zw5PSth4?= =?us-ascii?Q?OVgwUiIx+k7BKpzemH6lO0OBAgUD9bvM5LLJN3vVm6032SYLGljqN86Tw2+I?= =?us-ascii?Q?+nsNAsqER/BYQyfGebJPbzCX0efS9tmJKy/Kvbl95tX8gm9Lyy8W327VLrA1?= =?us-ascii?Q?FCQJBTeYxp5OWxQNWU7akvTZhHWQP31sDgJeJ5CNa8uL9RV3JRCKzmlW0fZ7?= =?us-ascii?Q?DgQRMd4F9HYX/IU4ngJHghOkIzclFlX9DI8OIV4Z+dCZOXippqB97AnhR5ut?= =?us-ascii?Q?bSAwwchhUtFSlpDo5J2ZDOlIdPAxg5ca/9+rET/SdIIPpW9HY6FLCIj7dNvr?= =?us-ascii?Q?TNsoXWWhWKqRcR7pE3DbsDSgiF74gC+VK9jGbDDPCJiV0v+Mu0x7+GdSt9L5?= =?us-ascii?Q?hU+Yrib2XbTMvzkzVtRFUGYwicnoogrM13YvuW9OgwTfy6t/JyyacVirBvqc?= =?us-ascii?Q?5sxYDbuMdjiRQigyTzxffrXfTz0DTDMBcdUAgay+HSRVzV3l1hKLbMOdcKhT?= =?us-ascii?Q?TuTrirypCmMIbmGsDnw=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f7eb6792-bfbb-4e8a-921a-08dc47f77135 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Mar 2024 09:32:06.1327 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WH/fqjZKpuIalUZJYqIQYJz7PY180pjN5pkiKRr7iUGf5hsC8r4FUIKJBKHJK3vlbQcweGbGMh6Jf+v1g5dEKw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR18MB4366 X-Proofpoint-ORIG-GUID: iwDwiBA8KWjt1WR6giHDgpIMs2YpMukn X-Proofpoint-GUID: iwDwiBA8KWjt1WR6giHDgpIMs2YpMukn X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-03-18_12,2024-03-18_03,2023-05-22_02 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > Subject: RE: [EXT] [PATCH] app/test-crypto-perf: add throughput OOP > decryption > > > > > > > + if (options->test =3D=3D CPERF_TEST_TYPE_THROUGHPUT && > > > > > + (options->aead_op =3D=3D RTE_CRYPTO_AEAD_OP_DECRYPT || > > > > > + options->cipher_op =3D=3D RTE_CRYPTO_CIPHER_OP_DECRYPT) > && > > > > > + !options->out_of_place) { > > > > > + RTE_LOG(ERR, USER1, "Only out-of-place is allowed in > > > > > throughput decryption.\n"); > > > > > + return -EINVAL; > > > > > + } > > > > > > > > This check is blocking cipher_only decryption which should pass > > > > irrespective of inplace/oop and Data correct/incorrect. > > > > > > Sorry, in that case I will remove "options->cipher_op =3D=3D > > > RTE_CRYPTO_CIPHER_OP_DECRYPT" and only kept " options->aead_op =3D=3D > > > RTE_CRYPTO_AEAD_OP_DECRYPT ", what do you think? > > > > I would suggest to check for "auth_op =3D=3D RTE_CRYPTO_AUTH_OP_VERIFY" > > Instead of cipher_op. >=20 > I'm not sure. Since in AEAD OP, auth_op will always be > RTE_CRYPTO_AUTH_OP_VERIFY, in that case even in place encrypt will be > rejected. > If the combination here is too complicated, what about just remove that l= imits and > let user to decide? If the input is not correct, PMD will reject it as we= ll. The problematic cases are where auth data (ICV) is not correct. i.e. AEAD, AUTH_ONLY and CIPHER_AUTH. Hence following check should be ok. if (options->test =3D=3D CPERF_TEST_TYPE_THROUGHPUT && (options->aead_op =3D=3D RTE_CRYPTO_AEAD_OP_DECRYPT || options->auth_op =3D=3D RTE_CRYPTO_AUTH_OP_VERIFY) && !options->out_of_place) { Yes PMD will report error if the input data is not correct, but we cannot just fail in that case just because the app is intentionally = not filling the data. It should report unsupported case.=20 >=20 > > > > Ciara, What do you suggest? You were also seeing some issues in this pa= tch.