From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 52149A04FF; Fri, 29 Apr 2022 14:23:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E15B4415D7; Fri, 29 Apr 2022 14:23:19 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id E2B3C410E3 for ; Fri, 29 Apr 2022 14:23:18 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 23TBKLZW010394; Fri, 29 Apr 2022 05:23:18 -0700 Received: from nam02-dm3-obe.outbound.protection.outlook.com (mail-dm3nam07lp2043.outbound.protection.outlook.com [104.47.56.43]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3fr49gtn1a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 29 Apr 2022 05:23:17 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J+1efruoDXda+EUXM1y1Co0EMZkOSeyzOlM/fcxBBbd9ovcuIcyef9zjbf7LzZdcnuFVpNXdg0+UcKXCTIQ8+PDsXt/eXk/IS0/wbWMFg5GFso7xJFMqBWHMRc8kPn6bT+FJOqpO1If5YNt7S0B7FRFP6xPpB3VbyHhGuE4QWilGc9ODFOW3ztr5ke3G1mUTYkjqAM3usaEZLpI4sbXYjcV3E7yfKW35nb6/LN9Y5JZ0FML4Xp6p1/b704DxYcAN0AzXH6QNwMLQSTptBBf7BcsDh+iuKD3pvvwJ56jeDqCRAidIvkm8LkxDgrmsdqNUYAuO/RSlroZcxXWGsss34g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NcfKyV+em0qUU2Wi29yEvPoHCZ3kkvQmHdwh3NrB2FM=; b=D0Iv4j3JCJ6XFtM50/ujRiEaLUCLEmTq99F2SyIUxgYoRF/OE4BpR19TkxRwOeOIfvCSePZOg8+3/Dv7S3CJcg3rTJWtrdYrtBW9ZrQeOyQNShv6P3nliiNDTBqBH7KUQZIk8EKoTzFWyN+EHgMOxe351oOBZbUGLpsvPifInYbiPF0qSWmlF3y1XzjA3Yu6zAoiDE/rvIr0iAzHghu2MB5KRUQbSOYL632+K7D9nk8H4ZHKhLrw4pQ7n45phnNZrtn4ovtpH1LH/KwGpJvIpZtvZ6G6etbPP3g4vmuPNaO1dWAd/MPf2p/L9EyHvDGf6l8Da3AUL7T7rQn+iEivwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NcfKyV+em0qUU2Wi29yEvPoHCZ3kkvQmHdwh3NrB2FM=; b=dm6tuLic7M5XUOMx6fZb1QdlJRPz5qBY/np8AW4pjWw2Gk7aSiq7VKBYd579YHfhWXN5kwFETsj6iKSLlfkqbFbi7gHHLzCo/RVy57MbFMuQRX4NW2ItuTV2b42xzpVCmTFLWbUjzzsIUc6zoJ+AJ2dMdnruaf+c3xSQ3JbcnOs= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by BN6PR18MB1330.namprd18.prod.outlook.com (2603:10b6:404:12a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Fri, 29 Apr 2022 12:23:15 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::a0df:8676:6ad2:4338]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::a0df:8676:6ad2:4338%7]) with mapi id 15.20.5206.014; Fri, 29 Apr 2022 12:23:15 +0000 From: Akhil Goyal To: "Gujjar, Abhinandan S" , "dev@dpdk.org" CC: Anoob Joseph , Jerin Jacob Kollanukkaran , "Jayatheerthan, Jay" , "Vangati, Narender" , Volodymyr Fialko Subject: RE: [PATCH v3 6/7] test/event: add asymmetric cases for crypto adapter Thread-Topic: [PATCH v3 6/7] test/event: add asymmetric cases for crypto adapter Thread-Index: AQHYVY1qVlP+0V1i40KXJY1D6KIuAa0FekqAgAFhiTA= Date: Fri, 29 Apr 2022 12:23:15 +0000 Message-ID: References: <20220418193325.368313-1-gakhil@marvell.com> <20220421143720.1583062-1-gakhil@marvell.com> <20220421143720.1583062-7-gakhil@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 84335819-e746-4630-711b-08da29db094e x-ms-traffictypediagnostic: BN6PR18MB1330:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: f9Mp3g0oNGlXtLKOVhDPfXTNM/9l8kTAy3/RukzsnedUiV8257wJ8+4JGRdfi40+kK3Bi5QXpTnFA/m/DeLNEGVnE5xsRZMit0d1w+5v8wuy0t6odmoXzM+QP4QRkaoTEQ7IJTzpobBsagz3WBUlUCSJC1A5wyUdh/wXdkN3tZqszsFvfb8hFY5v00EAI9yIH+0nfIHcuuvohfk8ugd5H5+uFp1uo0untKKAD9B4bGTXP4PwChvqmExsOIZZq2cSQXSDPCCqcqAZQziFbPL1dY77TNfGmwOmloxJEPMSCDreaRn6mWi+ssUo2BYjTaLHssSQtVo0UIuAv+VW9TJ6HB4MZXwkt9/fcqIbqNaYiDcBgqWorX/IxcG8iUlhQVezmr0WnJqDOBqG2F6RrTtB+VPSxbA/SBKugSE8FfKGz11uTRsAqlRHHapWjTRYx02dk1XW1uikusqSFe9GXrM+xEz+jxoihx7c2yOoRZvezs7A/6chIs6OCDvTV06Sy03vrLz3kEE2yvXw0soyUvmQiIbI5eRgXLOIJVaSSZANTjTXj4nZZPS5I/gv8HH7JqqngDa+u7E0Jr8IZ/jfPrGL6gDdlxFQJI+fJm6nLkFm9LSuk/H+TtOs0u5VGwf2883zgZYK1jYNbLU08NHru+g2anghU6X4CL3GEdkisd2+FQLwb+EHWTqlPWC530OMjdengiDPebg0yaBPgEoCqI+aFA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(186003)(66556008)(7696005)(5660300002)(2906002)(66946007)(76116006)(55016003)(66476007)(316002)(33656002)(52536014)(83380400001)(8676002)(66446008)(64756008)(4326008)(8936002)(110136005)(54906003)(107886003)(71200400001)(508600001)(86362001)(38100700002)(38070700005)(26005)(55236004)(122000001)(9686003)(6506007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?F56M/sXNXu2v1dOhu0i1Zn9GEFfn1OwWyqDJ9G0HsG9NIJbcCYvX+Xx5bjiZ?= =?us-ascii?Q?bQI+nU06LAdKx/lafUiDGlp9opSDhwqA0kp/z2hCiiNNW3l8OOkuCDX6pbut?= =?us-ascii?Q?qOz1qw8jL4JALwLDF2yfZ1VNYli/wr/adI81pfnMrqpf1XTDEP25AJf2i1Wh?= =?us-ascii?Q?VxU1whA/j2g6oxFqCWcf09xApAFonTTQiB501TU7m/3KZnd6H3DT1N19iMiX?= =?us-ascii?Q?v7Ru/ZWQVDRDPefIxwDfLhUR4lZ/LQmyyg88O7MIqsYR6VSTQwX8iljuLLot?= =?us-ascii?Q?kA3NRQuFximQiZd4kft6ihKSym3YA/8ZxzAEbO05582JR8GfPztkuIIbJgIy?= =?us-ascii?Q?sO0N6cxsCb1UmQ3ow9NSkxfPwFGoYFa+lnDjnCN+HC6yH2pZ83JL6RJlE99y?= =?us-ascii?Q?yXzZ5hn1O15s3ORQt9mt93a4tStmazdz0+uHr/xvvTZqkJUeLW4GOpwhJdX+?= =?us-ascii?Q?OpSG5KFl8KNlls9xJ9B/hrB+RVB/wlYKcWO+XxIOqJV20f+ALQTc9eVk7ZPO?= =?us-ascii?Q?qoLsNxFP45+Z2/OyKxiCWUdptOGy+q+eOTCAM4A1/K/qFRnISQxrgPlMYKlw?= =?us-ascii?Q?Y90Dmenn7L6p8/erbQr5jnnaOpFg9Tn1RN2Mc4w7mafADSj26kJfaNXsr5WY?= =?us-ascii?Q?29GbHMOseA8wTv2xQFoUQlgn42vfTzogisC8kUS5AduekXcWLxzql2TqKXBH?= =?us-ascii?Q?divaadjqeWxJwZEUcguTyJJuHRdydW9zZ9AqAgm+qKGda9yf8ARj7WFSegfh?= =?us-ascii?Q?9bVOM6RSJAqZ683gnf2tjHaXo6cmYdNvXDtcZ5y0Cadksb0ZPMg1ssL2uUTp?= =?us-ascii?Q?ksYAP8KaWiUphx5G41ZrdJPOhpTi921XlxxmxfS94sgQJQr5O3+L8rBlKT54?= =?us-ascii?Q?+IFB6utc+t52NAFTlsWD13oWC26LOpLkj4QtRezggnWSiM+JGv2buFXxVknm?= =?us-ascii?Q?/5lT6PTrwZcPk5WnaXAPTtVoWq5Q1RaABTjU0uEkcahDl9NllQWkzH8nbZKA?= =?us-ascii?Q?vHgVSJ9NI9GShvOejTp6S+ehDFc9sUUdYNzmgw050suPA/q7P0knQutK8s7h?= =?us-ascii?Q?ALcG0w5apXB2a2IurHZgEmruur0rSel3wm9/c8oAL0Yvb0cKk6vmnbc2NG28?= =?us-ascii?Q?n1G0ZmArgQbr45AypL0EU5P8SBuhwY9zcEYkFCtGmfTsG9xIIR1alHShfocL?= =?us-ascii?Q?SZiarrZB2XYg8hl25T7gpVwYt1jKf1qPPVwvT/s3ePdQioZymDaQbKdBh4Of?= =?us-ascii?Q?1a9JBBtx8a0UnLY41gS26H7eKXUQQuObhSpFNurqktnJLAlska/PSJba1bZE?= =?us-ascii?Q?Hc3yMWPg+ydKilE3Oqw39PDjpNSfMOAsz2CxUE+Bf2A59OOTOZBNPXazq9vR?= =?us-ascii?Q?7S8aODCoUrcERcWKY1hFQ/tPUg5hx7wDup800hD+anwqtW5N2/CEjfzI2fH8?= =?us-ascii?Q?aQ9qDKmJUACuQaxuORTVfGvTVfahP2p5ivvtaZ3ukBdxWDOU9o0DPuzdyI69?= =?us-ascii?Q?ClhX8KJk+uoZy2EggnPO7XD+vdEJDRN0H4MX/5jFoIC9zb1YjIznYmFhHAq/?= =?us-ascii?Q?8f8DsuLrfVkLLiOrMF9AYAG1o8fBcDJjI/jVDPMOKivcJ2Mw1QK8CYJJKpck?= =?us-ascii?Q?CyadsNaJ4ikOGHqEn+Anngya+6TYGfZ32a93EJerD7PGjGdtVWJhU75tYML2?= =?us-ascii?Q?odh3TFz5sopZfgpPl3nnJm2Rv4UOWY+Gs158oHWjqCHU/4NSI+dQaZFrRD7Q?= =?us-ascii?Q?3+iTGF4nRA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 84335819-e746-4630-711b-08da29db094e X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Apr 2022 12:23:15.6433 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: UVo7LSsosKIWBdvVhZavz6r+aaD9SYgFCpCQb+luz6qzs1QTfoKTubq/gIS8aI//xCkEOAKZw5hThlZtDwefLg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR18MB1330 X-Proofpoint-ORIG-GUID: ex2pEi8gypmvcpyHG89VsSG40gbuo1se X-Proofpoint-GUID: ex2pEi8gypmvcpyHG89VsSG40gbuo1se X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-04-29_06,2022-04-28_01,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Abhinandan, > This is failing with asym changes. Please look into this. Thanks for pointing this out. It is failing as null crypto does not support= asym And asym_session_create would need an op from driver which is NULL for null= crypto Please check if below change is working for you. diff --git a/app/test/test_event_crypto_adapter.c b/app/test/test_event_cry= pto_adapter.c index eecfc22057..2ecc7e2cea 100644 --- a/app/test/test_event_crypto_adapter.c +++ b/app/test/test_event_crypto_adapter.c @@ -934,13 +934,16 @@ test_asym_session_with_op_new_mode(void) static int configure_cryptodev(void) { + const struct rte_cryptodev_capabilities *capability; struct rte_cryptodev_qp_conf qp_conf; struct rte_cryptodev_config conf; struct rte_cryptodev_info info; unsigned int session_size; + unsigned int i =3D 0; uint8_t nb_devs; int ret; + params.mbuf_pool =3D rte_pktmbuf_pool_create( "CRYPTO_ADAPTER_MBUFPOOL", NUM_MBUFS, MBUF_CACHE_SIZE, 0, MBUF_SIZE, @@ -963,19 +966,6 @@ configure_cryptodev(void) RTE_LOG(ERR, USER1, "Can't create CRYPTO_OP_POOL\n"); return TEST_FAILED; } - params.asym_op_mpool =3D rte_crypto_op_pool_create( - "EVENT_CRYPTO_ASYM_OP_POOL", - RTE_CRYPTO_OP_TYPE_ASYMMETRIC, - NUM_MBUFS, MBUF_CACHE_SIZE, - (DEFAULT_NUM_XFORMS * - sizeof(struct rte_crypto_asym_xform)) + - sizeof(union rte_event_crypto_metadata), - rte_socket_id()); - if (params.asym_op_mpool =3D=3D NULL) { - RTE_LOG(ERR, USER1, "Can't create CRYPTO_ASYM_OP_POOL\n"); - return TEST_FAILED; - } - /* Create a NULL crypto device */ nb_devs =3D rte_cryptodev_device_count_by_driver( @@ -1020,16 +1010,34 @@ configure_cryptodev(void) TEST_ASSERT_NOT_NULL(params.session_priv_mpool, "session mempool allocation failed\n"); - params.asym_sess_mpool =3D rte_cryptodev_asym_session_pool_create( - "CRYPTO_AD_ASYM_SESS_MP", - MAX_NB_SESSIONS, 0, - sizeof(union rte_event_crypto_metadata), - SOCKET_ID_ANY); - TEST_ASSERT_NOT_NULL(params.asym_sess_mpool, - "asym session mempool allocation failed\n"); - - rte_cryptodev_info_get(TEST_CDEV_ID, &info); + + while ((capability =3D &info.capabilities[i++])->op !=3D + RTE_CRYPTO_OP_TYPE_UNDEFINED) { + if (capability->op =3D=3D RTE_CRYPTO_OP_TYPE_ASYMMETRIC) { + params.asym_op_mpool =3D rte_crypto_op_pool_create( + "EVENT_CRYPTO_ASYM_OP_POOL", + RTE_CRYPTO_OP_TYPE_ASYMMETRIC, + NUM_MBUFS, MBUF_CACHE_SIZE, + (DEFAULT_NUM_XFORMS * + sizeof(struct rte_crypto_asym_xform)) + + sizeof(union rte_event_crypto_metadata), + rte_socket_id()); + TEST_ASSERT_NOT_NULL(params.asym_op_mpool, + "Can't create CRYPTO_ASYM_OP_POOL\n= "); + + params.asym_sess_mpool =3D + rte_cryptodev_asym_session_pool_create( + "CRYPTO_AD_ASYM_SESS_MP", + MAX_NB_SESSIONS, 0, + sizeof(union rte_event_crypto_metad= ata), + SOCKET_ID_ANY); + TEST_ASSERT_NOT_NULL(params.asym_sess_mpool, + "asym session mempool allocation failed\n")= ; + break; + } + } + conf.nb_queue_pairs =3D info.max_nb_queue_pairs; conf.socket_id =3D SOCKET_ID_ANY; conf.ff_disable =3D RTE_CRYPTODEV_FF_SECURITY; >=20 > root@xdp-dev:/home/intel/abhi/dpdk-next-eventdev/abhi# ./app/test/dpdk- > test > EAL: Detected CPU lcores: 96 > EAL: Detected NUMA nodes: 2 > EAL: Detected static linkage of DPDK > EAL: Multi-process socket /var/run/dpdk/rte/mp_socket > EAL: Selected IOVA mode 'PA' > EAL: VFIO support initialized > EAL: Probe PCI driver: net_ice (8086:1593) device: 0000:18:00.0 (socket 0= ) > ice_load_pkg_type(): Active package is: 1.3.26.0, ICE OS Default Package = (single > VLAN mode) > EAL: Probe PCI driver: net_ice (8086:1593) device: 0000:18:00.1 (socket 0= ) > ice_load_pkg_type(): Active package is: 1.3.26.0, ICE OS Default Package = (single > VLAN mode) > TELEMETRY: No legacy callbacks, legacy socket not created > APP: HPET is not enabled, using TSC as default timer > RTE>>event_crypto_adapter_autotest > + ------------------------------------------------------- + > + Test Suite : Event crypto adapter test suite > CRYPTODEV: Creating cryptodev crypto_null >=20 > CRYPTODEV: Initialisation parameters - name: crypto_null,socket id: 0, ma= x > queue pairs: 8 > CRYPTODEV: elt_size 0 is expanded to 208 >=20 > CRYPTODEV: Could not set max private session size >=20 > EAL: Test assert configure_cryptodev line 1028 failed: asym session mempo= ol > allocation failed >=20 > EAL: Test assert testsuite_setup line 1361 failed: cryptodev initializati= on failed >=20 > + ------------------------------------------------------- + > + Test Suite Summary : Event crypto adapter test suite > + ------------------------------------------------------- + > + Tests Total : 11 > + Tests Skipped : 0 > + Tests Executed : 0 > + Tests Unsupported: 0 > + Tests Passed : 0 > + Tests Failed : 11 > + ------------------------------------------------------- + > Test Failed