From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 64E8DA0C49; Tue, 20 Jul 2021 11:51:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DE58F40689; Tue, 20 Jul 2021 11:51:02 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 7411D40140 for ; Tue, 20 Jul 2021 11:51:01 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 16K9jqgJ010269; Tue, 20 Jul 2021 02:51:00 -0700 Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2177.outbound.protection.outlook.com [104.47.57.177]) by mx0b-0016f401.pphosted.com with ESMTP id 39vytqdqbu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 20 Jul 2021 02:51:00 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MNPeKYCdLd+zWj8exdjY1pZPp7WclHHi/VXZ07Ct4+y6/9RgQ3MUfQq3VBeN2eMxH7oxBH4A67Pw3qkSskYMrK+WYi6AuAhnqlxMbdh4XtyCZnTqh1wyazuZS+mf3sujmSGw1CXxwkTx8qLnU4osRmwq9IinN50mUCAHRp8br2Uc/cgQohD4Q1duJZrR1tXz1YIl3y3TS7xtXYNs+Gf7nhFGa/YHmAYsn3Q5TV0KxzXycsDik5t5r2a4GhKCpjx7icTWO+BtbfMPh3vCDvBxP3ib286G4T/f9MRJ4mMCxueKv2oujkvrG8jSbvq1eIGPzDgD7/+O5pbs37yZ3nfKGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SrSAUrUCIRGtwkRUhjwlP3Y03RLasFLbBkPoaj3vZFw=; b=i3+ZzaMz1Hh3ocJIZMuyagfQYJk/2etJyrzk3e6DClyoar0oKrO+F/rcVBsxhuj6Kgb3FcUlFcVnsfrysBS/km1iQU4faER7QS8nHGZzq0/Zw4jNfX2v6RLglVLLlzILi3shnY9Kd7l0lO/4J43Wry20NUd95aePK8AShLjmb83DZp87faOsOy4IYLmXGzOcy+LMHgwdWkSiMrtkIl6ZOKfl55QTnZSkrwUbaoHbN5iwv3Rep52wNN1cTctUX66Ea4n9MniRUB5y8zqcV30h8uIIAGFqCLIvqkAQyjFsvRV2NEAW5JioVLgmB7TdWLU15am6OKm7xPfyTq7ni2n3tQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SrSAUrUCIRGtwkRUhjwlP3Y03RLasFLbBkPoaj3vZFw=; b=fTTG261H+v8NJcfd1W73oFC7o0VXOytwqhpbZzrKbLcxGXpGrlpuPV+6N1oyM3wtCvYDbP0mkm8kANmVvlgcRVGUpI+vup8Kxi0zSejc5QFaU/XKkOP0+DgUOOqCQ1gNeR1Vfj6H+mtvRk6oGxPUDoLv9dLv/Ei3seYeFCEBvUU= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by CO6PR18MB4468.namprd18.prod.outlook.com (2603:10b6:303:13a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.23; Tue, 20 Jul 2021 09:50:57 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::1455:9a67:a6e7:e557]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::1455:9a67:a6e7:e557%6]) with mapi id 15.20.4331.034; Tue, 20 Jul 2021 09:50:57 +0000 From: Akhil Goyal To: Suanming Mou , Shiri Kuzin , "dev@dpdk.org" CC: Matan Azrad , "david.marchand@redhat.com" , "roy.fan.zhang@intel.com" , "g.singh@nxp.com" , Anoob Joseph Thread-Topic: [EXT] [PATCH v8 15/16] test/crypto: add data-unit and wrapped vectors Thread-Index: AQHXeZhqLfWQX1VchUCEk922b2VvU6tGBmwwgAWYewCAAAZvUA== Date: Tue, 20 Jul 2021 09:50:57 +0000 Message-ID: References: <20210715150817.51485-1-shirik@nvidia.com> <20210715164126.54073-1-shirik@nvidia.com> <20210715164126.54073-16-shirik@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=marvell.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fd46735e-bf7e-40cf-3d1d-08d94b63dfb2 x-ms-traffictypediagnostic: CO6PR18MB4468: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BkNdy5HvDcCKptSZByJBs6TubdYS+AErEYdvQlBbFunwexO3tclrEUBbv8edVXbcq1sMXnobfcsn+AGvxotQR4ncoATEzYAY5YSm4/X6laxAI8kr1YAwyQYC+1IFW/64tH914OYeWif0QxRQnCsuFPECvts/Iws0a1On/U26QOs9JcCdCC+ZIPiZprR+zRxMExC0CVJKzbxd8+rFGENaEO+yJb7b32waY17jR2jM9GNSesuQ1Y4ysZWvy0oNshBFtX6JAk4NCkW/K2Lf0VrJADDapKwne6rirD9RirqLm6iZtZqBQAZV3hrN8Ix8TWFAFySD3t1Uc+7Y89EEFEOC9i5ZEov36uBV2SECdHTdpfOQXf9BI10hnFhbDV7TVm532VL9nee5mttKvkg67T1q39/g0fhvMZG5nu7i+S7dLQKU5jJA2Vrh1gnBpJgWNak9XhSg+MaMX6IwRisyHKu/49ogHgTe/JY/3dZRgxDiYrVn//UwxMauXQ2Id0ae5la+xAuFpvnA29+20Iw8p0HiGRZl0uxpNsKT+RW4JhzZQL07qHmrzY0sTqcKno1inWaxfLkKL9Vo1Fe+nqo5WtKpkVo4cW+4IgMTrolrkdRjdfs/L0yA9zuDta8FZxJM+qTPMGArcKsVMDVvgZLu2v+xbt6MJ6Qnf+rPJgPD8druGhoytFxq3vRxb0VMKvFleduQD+e86paGEpL8Whm4fcxrkQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(396003)(39860400002)(346002)(376002)(366004)(8936002)(186003)(316002)(38100700002)(83380400001)(71200400001)(33656002)(8676002)(86362001)(122000001)(2906002)(55236004)(52536014)(107886003)(110136005)(54906003)(26005)(66946007)(5660300002)(7696005)(64756008)(66446008)(55016002)(4326008)(76116006)(66476007)(66556008)(478600001)(6506007)(9686003)(38070700004); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?HwpVmT6Z705L3LtGPQ0hn4e0rN9XOJKFQUVH7vRZtp9AH2Hc9SMqNvla9De+?= =?us-ascii?Q?KNzjULrsRWKI+wZxXvSioE0v79kKya3bOb105mjVHq5i+6b7nRd6a51OMQKS?= =?us-ascii?Q?hXghjDdkRIGbe5+8wALjL8ApProDl3cnPy/kqVNpsnwYPRXBJCshKWiFweXN?= =?us-ascii?Q?YjnxPzGGNmcXS5o55RbZE2d9Pe2u6rnMty41Mq2FEHt9FtpGuhwxGilBTFkZ?= =?us-ascii?Q?/O5v/SMEXcoQAzhvWl7tkEq5Cjq5V6LOv0gOSIFAWiUZhnr1uou776cpXl6N?= =?us-ascii?Q?Hft9kHghmp5qEthAtowoOIb7lFOXuEqDEqEqkYtihWB085c0SVKCuOaWXkfC?= =?us-ascii?Q?GtLLGDVt9zFJDY41UqXrVJ6NbmtOq1L1AWokYUfgkpLoiCNb+jr3CvJviKfZ?= =?us-ascii?Q?Augr2v5rT1xKORd8Qe5z5TzcMGjErhtj5JR10LcnnoD55khml2fsnI7Hk+I7?= =?us-ascii?Q?Uu1e9FHfc5aFak6LlYxtARi3/jRBnZPr7T5eG0hu+376oE9Rmz6Wata5WZLC?= =?us-ascii?Q?hBTw3A2vLbs98DtyJZEflGftN+o4yApcFKD6T/WhNQiiXY7woxQn7AOWaODk?= =?us-ascii?Q?jl0cf5UMZe4URdo1nuZ9jDKtvNAWXJFkRkpIRuw+AJipe4+GvyMHpSSxQd+2?= =?us-ascii?Q?UUZv0RPfYMLSC1Kq7mBhqlAIZwBkyZzcLuUbJgp+PMFk9ug8WYJ/GTokkKXV?= =?us-ascii?Q?nD8ISRyspng4l5wfghOimVZcljx59CZkaaTC8GjAzkMFUAeJ4VqHvDlj0puF?= =?us-ascii?Q?XvNpik90y2osjinCASiyaybeulkNtTyiNjfVV00dYHPwnIoIBVZh176BBU9z?= =?us-ascii?Q?Hq96yPa+U1c5TEY6bTCAhFny5lpVcxy0lVcDL5y6kbC+mV3TDC3Pkq9mH9i1?= =?us-ascii?Q?lmJ/doT3HBgbW2rImL4IYQt27UeJ3d8AO9S/D6c2DqtUyUobqwb93BD+X6wh?= =?us-ascii?Q?x3R6BvHIiCDrCF7iF6pHTqhxdMy1Oz9tdMuqrsV++aq7taeV5Wtv4pLjxsnE?= =?us-ascii?Q?6Xnkhby5JvCXgDwKJTAeENZgTUJKgwokqwU/zgM3uVDG2XTKd4ejZJek9usP?= =?us-ascii?Q?zQgDbwtkXkokbhgYv6Ek0d/2HfGImA9Sszrmhk8luilFPHa7WssFlBsuiMDQ?= =?us-ascii?Q?M2sYaKhpYXV2PXXBEjbIVR8kMoR5T3AeCQJgvyDglo5XbuCIRs1KsGtgr80C?= =?us-ascii?Q?HCgkx8Bo2b9EP48CqMKTvWMO2G+C0OYL4ieJ66jrKkLDrx9qrKX17WnDaEfl?= =?us-ascii?Q?sWolzrZJHUXJEIefdz0z9RTWwevQajouayZoGr43H4rHJ81qE4PaPf08DoSZ?= =?us-ascii?Q?4GXnR8pCIBsm3hcCKwGMY3DW?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fd46735e-bf7e-40cf-3d1d-08d94b63dfb2 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jul 2021 09:50:57.5555 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jN140Gf4xO9TQ3l9X/MmDTeUSOSUu2PYa2vfTGaSijZl+L/FPULf3hHVRQPOU5N7g7AMcN/DuEKWticftZW4kw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR18MB4468 X-Proofpoint-ORIG-GUID: FypnUAva0D2o2IHprMtStDEFQTBMCnSd X-Proofpoint-GUID: FypnUAva0D2o2IHprMtStDEFQTBMCnSd X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-07-20_04:2021-07-19, 2021-07-20 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH v8 15/16] test/crypto: add data-unit and wrapped vectors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > > > The AES-XTS algorithm supports using a wrapped key. > > > In AES-XTS the data-unit defines the data block size to be > > > encrypted\decrypted. > > > > > > Add AES-XTS vectors with a wrapped key. > > > Add a variable stating whether the key is wrapped or not. > > > Add the AES-XTS data-unit. > > > > > > Signed-off-by: Shiri Kuzin > > > Acked-by: Matan Azrad > > > --- > > > app/test/test_cryptodev.h | 2 +- > > > app/test/test_cryptodev_aes_test_vectors.h | 1340 > ++++++++++++++++++++ > > > app/test/test_cryptodev_blockcipher.c | 10 +- > > > app/test/test_cryptodev_blockcipher.h | 2 + > > > 4 files changed, 1352 insertions(+), 2 deletions(-) > > > > > > diff --git a/app/test/test_cryptodev.h b/app/test/test_cryptodev.h > > > index 262e545ee6..f35dba6837 100644 > > > --- a/app/test/test_cryptodev.h > > > +++ b/app/test/test_cryptodev.h > > > @@ -19,7 +19,7 @@ > > > #define DEFAULT_NUM_XFORMS (2) > > > #define NUM_MBUFS (8191) > > > #define MBUF_CACHE_SIZE (256) > > > -#define MBUF_DATAPAYLOAD_SIZE (2048 + > > > DIGEST_BYTE_LENGTH_SHA512) > > > +#define MBUF_DATAPAYLOAD_SIZE (4096 + > > > DIGEST_BYTE_LENGTH_SHA512) > > > > Any specific reason this size is increased. It may negatively impact on= other > > platforms Which have lesser memory available. > > We need a reason to change the existing MACROS which affect all drivers= . >=20 > The reason here is that mlx device can support up to 4K data payload size= , I > assume even we haven't changed it, there will still be other vendor can > support more big value later. > After the rebase today, please try the patches on other platforms in case > everything is still good. >=20 Can you make this particular change as a separate patch outside your series= ? This would need ack from other PMD owners as well.