From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6A054A0C4B; Mon, 4 Oct 2021 10:02:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E5479412D7; Mon, 4 Oct 2021 10:02:48 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 6ABFF412CA for ; Mon, 4 Oct 2021 10:02:47 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 194194T1032640; Mon, 4 Oct 2021 01:02:46 -0700 Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2168.outbound.protection.outlook.com [104.47.55.168]) by mx0a-0016f401.pphosted.com with ESMTP id 3bfqptrtqe-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 04 Oct 2021 01:02:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BHkMv3e4EQrTnjyQVdwq1mM883zwDEBGTmlIIMCAZC4OJmEmeAV7Uc+usGTps9aoDG62Kb/cNW+nUawgHlRCPt0XDGzBiL7HtmZf41Unb7On+ADVgPT9bcMaRM9Adtsdk8ABeqTpF1QfP8Vplqhdo/2cALeCXdci7Z4vgDB0FSyalkz2F01Fh17kGakt81CvT1TN5I5JuPzs2WEiRIhhKtxZkG5noTY2jaEv3nNRtOETbLApKbaOAWYmVuiX+pUMmqyLLFEOG0tGuB9clFf5kuqC6vJ42xcCyfrFsZzDhe8tTFHlHq3CNjgwUHQDyUXNxEfxuBpB76UlRfcr1DYJpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2j9xH//b5MO/JYq5SxCu4tZiSBxQ0eUNbZepsL/VQqw=; b=NHh36Bzgs0ELDc/lRjVDJ+Lr2hNMx39LSEUiS32sQJmFuIQfnHJ61JxBWdCeiAFxniWgvXjWoG7aGSdu//5zzyLUGRFzr9cEc15AVXTk8w+fjWCVuzoENIJBiTJnaFKm7ZW+CNbfbACfea8MXBqmzneE7GVQ+hZfGbf9a7KeiTTpaJEz58IygxaR31ijagi3uxZujbQZSIxlm2xw6EnHmmz+FshVWi7zNjyH3Xb3zKemJ3tX4kDShXP9ICcgRlfm+o8Qy9DkT7i7DQVFuy8hzl6agrddXWZUH4xEWmfdmtDpKqOlEpNdigyfSOxT/v1D+mJDXk/x65sp/S9DXvhvNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2j9xH//b5MO/JYq5SxCu4tZiSBxQ0eUNbZepsL/VQqw=; b=I509ukb1g/v9ZC1gkdJHhSQ/X1bz6ooBNi3fdPd2v+rzRm1G8Sg5h7/aN6rxMd/qECq7YKnCRivJvxJChnqCSTGZSDDnKK3nSiapCRnrQyjDcJ9mYbxV0UjoArSxoJTq+cbEBqOBx/O+yDkEeqIyHp0U/N3kiy+05J9y+ZvD+F8= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by CO1PR18MB4684.namprd18.prod.outlook.com (2603:10b6:303:e7::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14; Mon, 4 Oct 2021 08:02:44 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::c41e:707:3f91:71b8]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::c41e:707:3f91:71b8%6]) with mapi id 15.20.4566.022; Mon, 4 Oct 2021 08:02:44 +0000 From: Akhil Goyal To: "Zhang, Roy Fan" , "Luse, Paul E" , "dev@dpdk.org" CC: "matan@nvidia.com" , "hemant.agrawal@nxp.com" Thread-Topic: Recent change to make rte_cryptodev_pmd.h internal prevents some important functionality Thread-Index: AQHXtJGSITZW7noKIU2lsGWVggeKQ6vAQ7DHgAInpCCAAA/LQIAABtyw Date: Mon, 4 Oct 2021 08:02:44 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 10e95378-26bf-4975-fbd6-08d9870d58c5 x-ms-traffictypediagnostic: CO1PR18MB4684: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Rs6s04bDQldrokUEpYj7ckgXhYBdvrASYhqB6d0NJValQspnZylqQd796s6hvLDF7LoYhu76czYzTM6u+WjWLynKhAD5+3Wlrnpi94V5zRiSaiwuyzjZa0cm8ei+ZC4RVM2iq1Prnq//rpfnHiC8rCM+mOvNZMLvQw3PYoPxoNiSPnp1ZbX1Nkr8uyE1B35u9yZkzqXrGfGeDaEUTZbujVz8TfeInsZx+JHswoZgv25KaPIzMhATaSuGTbprU6tdkGf9qEfzC+towMZBfyJ1lr+xFahHvyt1PtBktZ51g9WMu0tOUEAzQnfDpzH3J7P8XE+fDo3KsylBuJlOktJGe6MGE6WvLlIU1Luj74jYWru3hH4mugI19Nx48RYA1bzqD8AfDYamejEQ5ncM4E8y+a88rgHx+x4AlsMmk6S4uQdBAKrJss/fWXx4oBL+o7+MVKCFvKOhMPvyLn4bYkSldhZVhIR6lbvApbgm8PtQGzbL852o6gOKtCFWIQ3u67oo8F/R5HWUdTsazcDeR4wbxPFyvGchrLIU0/hjDBoQj3lGOH+pT/dzvWJsIoi5dYE9ISfqB3E7KraM7hqVtqrImBGvRP3+miedF5V3aD2LVHR/nsQx1z2oSvlbo+Yo8EsJk8ORg8/rySxN5s/2zEH58B4Od7ccs4nIqlI0hpW1Z7iLs7MDcr53sCHkvE0ZJ3s23ux7oxlwLijWIoEhXFgbIdiB37U/8VwrGVXRJigRmR8mJiEEbHvljGrYlw5V8tPjepR5j6OUsZhrt20M/n99ANfqXIbZLIsBpB9qY7lx21sUI8S8OWjJAyQbCo6nNXkr32y8tkD6wLI1z6/66aXZSg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(166002)(6506007)(186003)(33656002)(5660300002)(122000001)(54906003)(110136005)(8936002)(9686003)(38100700002)(71200400001)(53546011)(86362001)(55236004)(83380400001)(508600001)(76116006)(66556008)(64756008)(66446008)(7696005)(66946007)(66476007)(2906002)(52536014)(316002)(966005)(4326008)(26005)(38070700005)(55016002)(8676002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ZSQFe42ASe9KtJGQNWG831kjnt6qW/ACm88EF+yUD7dltnIu+m4TgqypfGyp?= =?us-ascii?Q?jFtutsza4OH53ufNBhDZwqJY+ln3rbKZah4UfoTgGsVxPa/QFziFvGSxPDFK?= =?us-ascii?Q?P+3AqbssVhpL17Ggy4oLQLOLUy/2ONGAPJBr885Q+YRpi/yfJIRrHirn8iLM?= =?us-ascii?Q?00bkRN4PtLXeMyHJ3mH0lJwmJQcCm4eyhD+V71xsQmO04uzadlgmv4IyxDgT?= =?us-ascii?Q?Dp658RBxvf/lh8+gbFqk9la7SyrsuJFauGbpWS7Q3r+0ZuavAI9SjJmK8PCq?= =?us-ascii?Q?UuRnaNoCOdnbbobcRarHlOpIp0Ov1Q7zDF+rA1aEt0CzSXlWdC6RYV164zCw?= =?us-ascii?Q?3H6ON7DYlJhm0s20Vii23RFRUPsmSJ3V2slxOKUAQSy+BkgAZkIam4V1vuEi?= =?us-ascii?Q?qM7RpKzVn2dgG+rl8CH0YCZn7DCQJHiCCLi8AdkM3Av9aLjnZ4FBNVhCo4za?= =?us-ascii?Q?t1/tbDdBfWTypQKkoVC/xd/fEvAz6PVi0KQXEywXLlvjwJMlhfvLIX94FbmY?= =?us-ascii?Q?Zg09lPk9+ADSSMevLYDFD2RZe1teBzUcOdZHlASkJiIA6xOVh08IYe8bS+VQ?= =?us-ascii?Q?/biSD+jPwOgY+6N5pwoV80eBKOrFTtSPaz1JlDUtszO8Vkq1KDRTEgGcXx0/?= =?us-ascii?Q?ivi+Xovuib47C1uIzHxgsH9FlJ+OegRCGrck5WlCnq4HYmFIQkKUYxrE0l/p?= =?us-ascii?Q?uZrgLJa5xj2/gYNCUs+DnSRKwdtC7XZOvLFMM6WQ6h3CRvs3qh+QTzSXQ4Wg?= =?us-ascii?Q?70HllMedovuRTf+Az7bjd3Tp15dUQz3Y52fwC1o68tA9+GqcisXtS7YGBY9A?= =?us-ascii?Q?5QZ10umXQCXn1lA6aUrkyULGq7Lj3YYzcafy/lK2ZLGh3kDMAYLxq9MXmqTw?= =?us-ascii?Q?KfFruEHZ3hMeHfznEgMbFnZiM4e/pOoh58gM7dxwpMiSrsPr7iDzBbLOjsx1?= =?us-ascii?Q?4Rnk2YfAj+Awn+dJVoihsFBmEQd0DGd83pA2y4WlfB6sJzjlsMtjP+Gfya5N?= =?us-ascii?Q?tfPcQt0iQj1IUVrp81ZHsU5DykUmJ2H+YpfMMy6xnOleNwxd2w3USqjdgSk4?= =?us-ascii?Q?BEyNftNEEWJsXMKutYv7CmTLlYbG3jNht7yhkalfGTavrNvvO8UAAOL51TiK?= =?us-ascii?Q?R1emG2paLSV3CD3X7qoVHH5shz0HwVIacVXwLCtNm3jDVu8/4nmW5wE5vz4x?= =?us-ascii?Q?vpuHa0TrpTrSNcZoGc2hluc3xVXOoH+Y5qppPZXnoCWftH2tluuGkpL2e0vU?= =?us-ascii?Q?wciabgnx9w4PvV/ptclwg4snHWT4bPv/u4uh2js+yZPNXL94341r+oCjHKOH?= =?us-ascii?Q?MHKBCZrV5Y+24K3190YQtxD4?= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 10e95378-26bf-4975-fbd6-08d9870d58c5 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Oct 2021 08:02:44.2404 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ES8XEmBc37zl6wj/1fHycwxPLW90KjjbjJ41MhNmiGjkF+XHHGMt95/bbkZwBkmuBztGySLGsp84/LbIaVdMEw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR18MB4684 X-Proofpoint-GUID: a8Tpe6oyOygORNifkNhxjLFQ3cXRDes- X-Proofpoint-ORIG-GUID: a8Tpe6oyOygORNifkNhxjLFQ3cXRDes- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-10-04_02,2021-10-01_02,2020-04-07_01 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] Recent change to make rte_cryptodev_pmd.h internal prevents some important functionality X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Ahh, yes!!! queue_pair_release is not a public API it was mentioned in the rte_cryptode= v_pmd.h, and it was mentioned on top of the file NOT to use it directly in = the application. Could you please mention the use case for which this memory need to be clea= red before the stop or close of the device. Or you can send the patch to in= troduce it and explain the requirement of the use case in patch description= . Regards, Akhil From: Zhang, Roy Fan Sent: Monday, October 4, 2021 1:14 PM To: Akhil Goyal ; Luse, Paul E ;= dev@dpdk.org Cc: matan@nvidia.com; hemant.agrawal@nxp.com Subject: [EXT] RE: Recent change to make rte_cryptodev_pmd.h internal preve= nts some important functionality External Email ________________________________ Hi Akhil, This isn't what our concern was - our concern was rte_cryptodev_close() may= not remove the memory complete as rte_cryptodev_pmd_destroy() did. Our research result towards this was if the PMD could act more throughout t= o make rte_cryptodev_close() working same as rte_cryptodev_pmd_destroy(). What Paul's concern is valid: We DO NOT have a way to release a queue pair = manually anymore, and releasing queue pair to me should not be blocked from= public API access. To resolve this problem we should have a public queue_pair_release() functi= on in the cryptodev. If you are ok I can send a patch for 21.11 right away. Regards, Fan From: Akhil Goyal > Sent: Monday, October 4, 2021 7:45 AM To: Luse, Paul E >; dev= @dpdk.org; Zhang, Roy Fan > Cc: matan@nvidia.com; hemant.agrawal@nxp.com Subject: RE: Recent change to make rte_cryptodev_pmd.h internal prevents so= me important functionality Hi Paul, Similar comment was discussed in ML for fips_validation app. https://mails.dpdk.org/archives/dev/2021-August/217781.html I believe Fan is working on it to fix the issue. Fan, Could you please share the update. Regards, Akhil Note: Please CC maintainers for a prompt response, or else mails can be ski= pped. From: Luse, Paul E > Sent: Sunday, October 3, 2021 3:14 AM To: dev@dpdk.org Cc: Akhil Goyal >; matan@nvid= ia.com; Zhang, Roy Fan >; hemant.agrawal@nxp.com Subject: [EXT] Recent change to make rte_cryptodev_pmd.h internal prevents = some important functionality External Email ________________________________ Hi Everyone, I sent this last week and haven't heard back - apologize if I missed the re= sponse but if not here it is again... We use cryptodev in SPDK and included rte_cryptodev_pmd.h so that we may re= lease qpair memory that was allocated when we called rte_cryptodev_queue_pa= ir_setup(). We'd do so by calling the function pointer queue_pair_release(= ) which I believe is the prescribed way to do this. The DPDK change in question is here: https://github.com/DPDK/dpdk/commit/af= 668035f7f492424b2e199f155690815944a8ca Question: Is there another way for us to release this memory? I've looked t= hrough the public API and nothing stands out. Thanks Paul