From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A753FA0C55; Wed, 13 Oct 2021 20:36:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 573CF4111B; Wed, 13 Oct 2021 20:36:04 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 2028640E64 for ; Wed, 13 Oct 2021 20:36:02 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19DEtCZ6013514; Wed, 13 Oct 2021 11:36:01 -0700 Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2102.outbound.protection.outlook.com [104.47.70.102]) by mx0b-0016f401.pphosted.com with ESMTP id 3bp0h3sd8a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 13 Oct 2021 11:36:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CuX5BY/zcAR6jlUZu8j+C4Fd6LjSNn5BRtA1rv9OXXrCLbiUp2qTHodLne2C45l4+Fvti88otbKkK2Kyf2O4Dvmp1ck/FWdboJPvPqDOyVD6JXYyQdR1GKUDL+iqyo4Wt9rf16tRhKMxx3SBSBmGM5uhG5OpN36aeLu7mfhaW08n/hdlvXFJZCuzit5jG1+1rNgqNR0PWw4wU7hUe+6p0ZLI0PlmvZVjv7P5WCh4uNKqMUEXF10GGgXu/BQgZSMHYbRilAwmuKDfnbg2tB4KMJleKPtr51by/H95GvmJk/A+woZimAEx4s4lFVzcl0A93L6GZtAflfeIw5YW4mL/8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DIrq+llwQpYMki64ZHnIDvPMpTcNTi/YUFoibCHQzPA=; b=BvOoNaUNGdLtJ9JwWBTXS4ZR7ula882GD+P1MyLjuDIqZkQfY/5A1qhNNZeXdXz8wmsdCOI3Y5u4K43cANT/aEscmuMe/wWutfSVmvSIvAF3f9XsZnaTh1TO1NqJUMJorDw8c6IWLC2FwldTk6l3c9Y67zkFvIJIf3pHK5N4v/gX0JpQynYtiHmtYzxnhkYmiWnVomsp5QbBIBHZRKD8DeRfnMnhVWZFsQeKkiWGm5dzZdQugR1GkHiHwSTPj29HI2mAe/jOWKtOVLQMexriPh4lc4TNkmbcKQRC9FJoYQJfWNSbc/NjNDLij3tL0WdxaPnBtlsd6Gk9MmH6mW2tQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DIrq+llwQpYMki64ZHnIDvPMpTcNTi/YUFoibCHQzPA=; b=ux88Iti0hK76zQh9I9TvpsCtYXrt+28qhxEgqN0G/WOcEZdnreYpbquch+eIS6a+mvF+Y8DE0CF8Xvxj26e7rzG+YnYMc3s2r/QTh3AFwimQGB1VlE3V8unuLBUDQyd7mYUsJRk03YCEe2B0Y8PporVHrKd61IEDl93A2FvzKlQ= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by CO1PR18MB4601.namprd18.prod.outlook.com (2603:10b6:303:e0::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Wed, 13 Oct 2021 18:35:59 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::c41e:707:3f91:71b8]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::c41e:707:3f91:71b8%8]) with mapi id 15.20.4608.016; Wed, 13 Oct 2021 18:35:58 +0000 From: Akhil Goyal To: Hemant Agrawal , "dev@dpdk.org" CC: "roy.fan.zhang@intel.com" , "konstantin.ananyev@intel.com" , Gagandeep Singh Thread-Topic: [EXT] [PATCH v3 02/15] crypto: add total raw buffer length Thread-Index: AQHXwGCaJYk+FlfZXkGz2YRb1v8P2avRQVQA Date: Wed, 13 Oct 2021 18:35:58 +0000 Message-ID: References: <20211013182720.32486-1-hemant.agrawal@nxp.com> <20211013182720.32486-3-hemant.agrawal@nxp.com> In-Reply-To: <20211013182720.32486-3-hemant.agrawal@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1803683c-b2df-4415-eea1-08d98e784d03 x-ms-traffictypediagnostic: CO1PR18MB4601: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: bw080PME2uangbTdtx2JDi1npeU2MYCZ254Qby83pymYenq/uy3WVdsLner0IsD9zbxwYSFaPSRXSoTUtLRD4AT2uK69RT5Js8Dbob2fuXE9WwJuty/Zd1If5pfWtMCVBQS2Du08xjJxtU8gA3nLyeWdT1NV5eMbQEHk1veAx/bgo7HD6hEg/4S86L2AAX332uRUThhSc9GY0GyZfE6R1cvxQ4riN2ol1tEC2hTa2e8BphI/hfIYEkJzPIqwPrgWIgyHWzvgBwO6DOrY32m7JduHUmJyzMOGuZW4xuY7TF8jtFT2BOKNbvueitmov882hxwr0Jgsyig2JtdvIjPp3Lki/Pf59ph/vFoDdhkOmNViiHse+BW0Gl54FCFFaTrKCs4ZBE7erTLXhDfZuXvFSrxpTADJzkNxjdyh0rta8+9kBKyDefKVOY3wTvTB0VlSWrHeLWDXsrQ3+fgq3hlhpwKaQsZJBjUVNDW9xucbw+YZdjCAsCL8gkeBDiGvZmhi4DJqB4Jf+oqM28gsgkYBhxywWhgGtaZ1ePVqRhi6djol//4p2QiBbDcbmnfBXScNKxW2V/JmYdRfV7UzOIJYxO4j6KWR8/iSFTSCErbxecKf34IacMmSkOThWOnCny1BhljqbfSzw1qtFkU7ftdo2x/Tl/fm8XUiJ0RwromJdAGMcnsVcMknVyOd3Hpe7zIFS1ZZ0kIdXUeSd9mztah57Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(66476007)(5660300002)(71200400001)(66556008)(66946007)(8936002)(66446008)(54906003)(4326008)(76116006)(7696005)(64756008)(316002)(86362001)(33656002)(6506007)(110136005)(508600001)(55236004)(8676002)(38100700002)(26005)(52536014)(55016002)(2906002)(38070700005)(9686003)(122000001)(186003)(83380400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?VWO5ggsyOKI1Z2sDl2Up282whGzq0Qmy43sYoBJ9mSetb/3mlz//dnqWr5JD?= =?us-ascii?Q?rP770mo7/AHdFF9RlsUi16xA6qZzf0w9XDTcSRUa0Hi/BK6Kr8HDN+XCt3Dj?= =?us-ascii?Q?npC6/yOXY1GRjQwVEim2KFYxFfnZEV2wI0fpIDmSi++4t0gT1A3EMK0NcXlx?= =?us-ascii?Q?PJAoCVIOgqVH5DnBN2eYrLBVWMu+UE+wc02ped7fwBofASk1iVvGU9w7niKF?= =?us-ascii?Q?yCQ4TegNxpk8P6rgPU5JlfR/WuU7NrWTSmlYa60tcL78MzZbq7cM0YlC2sGK?= =?us-ascii?Q?IYoAY95edHwgVomartNG9kTV6QVXV0aTAltx4d7jafu5j950ZjspV3alDSTj?= =?us-ascii?Q?R2Z8YNIqsJOAUJxJ6EVTwABdAUBMahc06IdviCHBJmZZqAs/biLpnfqajezz?= =?us-ascii?Q?cgNeYORhQuQFFONqiZfy21j/pPyh64o4UAxHdqN551+k3wc8a6uN06IHc1H2?= =?us-ascii?Q?rPPAVoSWY5N96ekM6He09IS2WCXB0WrDdr/RJzjAPhD75YKMz4LHmIX2/Jqj?= =?us-ascii?Q?YCmUPO8fOguLR82uuUSH8xZ3Jci+YwB4wjhLfZEPkGcw4zv4sCu/BeCLhGLT?= =?us-ascii?Q?ISiAU4VlhG/XwiA2dokLmN4I3syx5wV58jHlUSyB9F0LLWmTzIqC1EgGHnof?= =?us-ascii?Q?O1j2uMbFzg37fq9f0BmWniQQ0PhrQpk6+qg59M264SqmM4QRfIX6DRXa4y7C?= =?us-ascii?Q?pp8xASENvrjeyPSTdfdRHfzEAQ3Sgo9wApwAx90UYOblK8sgMtZiWK7ooyQc?= =?us-ascii?Q?5+HwuQfRrkoo9wsFjyPGuOGVWEoqCVVCyBji73UsehOAcESJRWUrTblwR65n?= =?us-ascii?Q?XIX86/6B6QW3rCac6L4s4zXXoEKiL9c/GH2WYpxd65sMZRmWq28aGZNycGUT?= =?us-ascii?Q?YdnNaAvktjX5tzDQOPGHska3Av6D9Wmw1K8VMI/gFwXz7oggsN6WbbGey0sl?= =?us-ascii?Q?SBXH4nnQslujCatKQYAZiU62MVeNzJlL6AAgfk/O4EEXBL4rvQ3AUL9o+Qp9?= =?us-ascii?Q?O3PPfecsXEVojHWnIvB3YERRSF6GorcpSrgN9Dah07qk0Cz83Yc83KwzuRRZ?= =?us-ascii?Q?kJUfJXNmCyfVGokAK6fvvPSbQdOHR2FEfUmPiJP+Hu13Dpbzq6020eTAPl1s?= =?us-ascii?Q?y+3yuD5oaei9xl/aG8zTGmJ129u8fMAMaZrmFQX+MOvOR3ZM78lxVYLz0fAA?= =?us-ascii?Q?DbLgHGUx4KELKoRJalOvu18aZmwBsdBVPzcZS+QrRufVOOPkRISUigk8/IGs?= =?us-ascii?Q?a6UL9X5PUEyXP9wm4YXwi6u7UhQDfuyp8r1uuNnDOdtv1I6/kvGenqx74qtU?= =?us-ascii?Q?/iiJupRJ97rpvfhUk8EmqV1J?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1803683c-b2df-4415-eea1-08d98e784d03 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Oct 2021 18:35:58.7973 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: iZ5LH1cd93BQcErcfgca1xJqtPUE4RKoorw3pbcFNlDsR9tR39I6G+lqwoWiCPFAwCRZqddw61tlPTVpTbuk1Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR18MB4601 X-Proofpoint-GUID: qKkyjDY3xvh4hGc3gewo9foRQ4Qrn4OM X-Proofpoint-ORIG-GUID: qKkyjDY3xvh4hGc3gewo9foRQ4Qrn4OM X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-10-13_06,2021-10-13_02,2020-04-07_01 Subject: Re: [dpdk-dev] [EXT] [PATCH v3 02/15] crypto: add total raw buffer length X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > From: Gagandeep Singh >=20 > The current crypto raw data vectors is extended to support > rte_security usecases, where we need total data length to know > how much additional memory space is available in buffer other > than data length so that driver/HW can write expanded size > data after encryption. >=20 > Signed-off-by: Gagandeep Singh > Acked-by: Akhil Goyal > --- > doc/guides/rel_notes/deprecation.rst | 7 ------- > lib/cryptodev/rte_crypto_sym.h | 6 ++++++ > 2 files changed, 6 insertions(+), 7 deletions(-) >=20 > diff --git a/doc/guides/rel_notes/deprecation.rst > b/doc/guides/rel_notes/deprecation.rst > index f3c998a655..4b26ef6747 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -211,13 +211,6 @@ Deprecation Notices > This field will be null for inplace processing. > This change is targeted for DPDK 21.11. >=20 > -* cryptodev: The structure ``rte_crypto_vec`` would be updated to add > - ``tot_len`` to support total buffer length. > - This is required for security cases like IPsec and PDCP encryption off= load > - to know how much additional memory space is available in buffer other > than > - data length so that driver/HW can write expanded size data after > encryption. > - This change is targeted for DPDK 21.11. > - > * cryptodev: Hide structures ``rte_cryptodev_sym_session`` and > ``rte_cryptodev_asym_session`` to remove unnecessary indirection > between > session and the private data of session. An opaque pointer can be expo= sed > diff --git a/lib/cryptodev/rte_crypto_sym.h > b/lib/cryptodev/rte_crypto_sym.h > index dcc0bd5933..e5cef1fb72 100644 > --- a/lib/cryptodev/rte_crypto_sym.h > +++ b/lib/cryptodev/rte_crypto_sym.h > @@ -37,6 +37,8 @@ struct rte_crypto_vec { > rte_iova_t iova; > /** length of the data buffer */ > uint32_t len; > + /** total buffer length*/ > + uint32_t tot_len; > }; >=20 > /** > @@ -980,12 +982,14 @@ rte_crypto_mbuf_to_vec(const struct rte_mbuf > *mb, uint32_t ofs, uint32_t len, > seglen =3D mb->data_len - ofs; > if (len <=3D seglen) { > vec[0].len =3D len; > + vec[0].tot_len =3D mb->buf_len; > return 1; > } >=20 > /* data spread across segments */ > vec[0].len =3D seglen; > left =3D len - seglen; > + vec[0].tot_len =3D mb->buf_len; I think you missed to update the tot_len as per Konstantin's suggestion.