From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 125CDA034F; Wed, 11 Aug 2021 10:19:45 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9979240042; Wed, 11 Aug 2021 10:19:44 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 9697E40040 for ; Wed, 11 Aug 2021 10:19:42 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 17B8Aerh002480; Wed, 11 Aug 2021 01:19:36 -0700 Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2104.outbound.protection.outlook.com [104.47.58.104]) by mx0a-0016f401.pphosted.com with ESMTP id 3ac6qtgta7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 11 Aug 2021 01:19:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z9t0pP0esUB067qj5Miznzk8O3lWySVAYMnul76HVYSxnKHYY+2pJO1r0Qd7qXG9eKEPp5NqKfhJDJPI1BI3syWp4Xm/M+2JPMO1yhXj6bIF9LeVrNFiIh+ZPVI7fZDnjuCAl3IRu8U8WiTlLnf8rnqw5fEJZK+l9bHIw0iJmitJwVUNKzO7UPJ1nUDpsh1rTiOPY59JoWGh9oBBSbX8DnY9fzQF4B9nYNcYg+aXucIPrdwvxuPOIm57OFxq6G9kqglSewt5m6M7H26GL6bB/aY13va09VPQyKUZnAQUhdC4dVGaZ9QWCAABTXvyuiPTMWFeM9nV9qOn608uSjZeNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tFeg0UU9l4qvxEhLsGqg18mCHieYdhmm9Nkj9Qz6chI=; b=PYe/NNJ3/v81H0b6h622hSLiu57f4EuZiODjZaZL5oSuil5TB+spsHBrIWN5FlfApfgSG5Z8jAxe6wUogWYoDja6nrvoSO7WvyAUJ1iugJmTrqoVBMKuss0jCmEi6DR87xWzc/lNQd+Z9hmda1r/lUXHeKyclymRY8g6xyiy7zexnAmk6nJeR6wKtuT2eER7lNT3Prb7CC+PozUWC/C2wvPdtI1220bdINQkyZBK1jMvtYM1n25J1ZRmEf68LIAwimJbB5Gn1SQfDvlU+YT7Bm9ylx8twh695B8OMN421Na8HSlUAN7SmsgTAFOMywxfwrbBQTkQX4dLgoCiIdTruw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tFeg0UU9l4qvxEhLsGqg18mCHieYdhmm9Nkj9Qz6chI=; b=c2I6XTkQc20+hDLxQfUxv9bCehRBI14ZpRsvvF4OnV9j8fEU4OTt7+nTyxF+YkSTwJoiuUDtemmDxRLLbset4SpZs6yeWiaomYFprtWYylJVTQcKT7JxH4Rk0/AhoOs8r6knD2GX8lNqXAD3mdDDuEUVt1bWAxXhOK2JXyQGehM= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by CO1PR18MB4569.namprd18.prod.outlook.com (2603:10b6:303:fc::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.14; Wed, 11 Aug 2021 08:19:32 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::1455:9a67:a6e7:e557]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::1455:9a67:a6e7:e557%6]) with mapi id 15.20.4415.016; Wed, 11 Aug 2021 08:19:32 +0000 From: Akhil Goyal To: Matan Azrad , "dev@dpdk.org" CC: Anoob Joseph , "radu.nicolau@intel.com" , "declan.doherty@intel.com" , "hemant.agrawal@nxp.com" , "konstantin.ananyev@intel.com" , NBU-Contact-Thomas Monjalon , "roy.fan.zhang@intel.com" , "asomalap@amd.com" , "ruifeng.wang@arm.com" , "ajit.khaparde@broadcom.com" , "pablo.de.lara.guarch@intel.com" , "fiona.trahe@intel.com" , Ankur Dwivedi , Michael Shamis , Nagadheeraj Rottela , "jianjay.zhou@huawei.com" Thread-Topic: [PATCH v2 3/4] examples/fips_validation: remove illegal usage of APIs Thread-Index: AQHXjiEPBnxbhBM+ukePEjdPj9/KUatt3+AAgAAVOGA= Date: Wed, 11 Aug 2021 08:19:32 +0000 Message-ID: References: <20210805200236.1180289-1-gakhil@marvell.com> <20210810195020.1423013-1-gakhil@marvell.com> <20210810195020.1423013-4-gakhil@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=marvell.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6a0d9587-d2f4-4393-6a38-08d95ca0bf6c x-ms-traffictypediagnostic: CO1PR18MB4569: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1013; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: R7fR6QiFL9SjdOFnZQJbNQtWqsVhvQkkoRRQBXVGAvdCQzCPzOs2VHdvVMfbdCmrlw37RuOqN3qHd6zicmbWDgE5Nh4JQPe52uqeJcdMiIGXA+/GWLb143qhgQHmDuEbaRuhVX5pDvRlxyutlT7IxVpYZJjCsUWXIIp8s1dXdNN3u+2R+z/Me999LEmZiSzLwfVpjGPgibnH0RnrM+ID4tEnUSnnafKKjLjDpDroENfWrsSEIL530s+WbHfJSOcKDZayxd43fqI9J49nDHe04rs2Bmh9TcEXovhb4rDWT2pXK+QOwKOSqqqHw6MqiShhCEp52zth6bONnuYY6SGXuVDk2Kbv4W924dwKLsXx3fxeCKhPdpHWyDoq0SostIier0FLj809qqAadd3EiHGHsBE02/l9thAgvMj/wwQBCxy+Ux1maUmjybA2bIqkKvT95s0b7oaLXOEpZ2gOv29LgaO3UINxbpDviAuVp7C9IHFyim2fTJwdkN9bWpmR1x+YeWVsCBdz6DHjdnv0xN9gBrPmKtMNlvmNBZ0jPNOBzIEzSPdZGSOmp58dW1glImI2Jq03m5hYPmi/U1nmKrLoLqHozs4rBX1kBgaFkBKPWjY2YJ1PSY0m1PF5UP3S1J3QS7/qT6xRSqmMJQo312RweIva+93Ypg27+o/pZXmwRS6Nw9CGxCo3iep8G8jE+m8NUu6lrKyRI3WUmvkk9UdmUg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(346002)(396003)(376002)(39860400002)(366004)(76116006)(55236004)(71200400001)(4326008)(6506007)(186003)(38070700005)(26005)(7696005)(478600001)(8936002)(122000001)(110136005)(8676002)(2906002)(54906003)(33656002)(86362001)(9686003)(52536014)(38100700002)(66556008)(55016002)(64756008)(66476007)(5660300002)(66446008)(4744005)(316002)(7416002)(83380400001)(66946007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+YLyiVxC9ur5/AK2S5P95Tg6nFc1tXnxTEOi6UsazN3Wz9QXKz/Fe5n7GCo6?= =?us-ascii?Q?BXg/Hs9fGRBhnQSqXZOvr2HPN37B+QsTeZORUdbPxEda8sKn3w5nOfBNAkHt?= =?us-ascii?Q?brEJ9jGugqjhVoRRyoqNygMRpeCw+oOhLDDuc6tzIdLhsN1lDhUZBflx4ufl?= =?us-ascii?Q?Fyjh6SO99a5n3nM7XinJQFRfKpjLjuzULGc05XKwv6SyJ5oifS1Tuvu211Bo?= =?us-ascii?Q?EG90SrMpW4wEkgcSO3zgVTG05U+MOelfAT7r+y+Y8cx4Nw8s/jLTwa3i39l5?= =?us-ascii?Q?JuZQhOWiNx19QQj4fYv0MjjPrpUn9wUZ75rRxgv3XdOrB070mD70znHkEUfH?= =?us-ascii?Q?aqPFjGDtXZQZFdC5lyylqrlDvXhCfHCmlhNTdsBV+AjIELVbQ2dztczD+ecM?= =?us-ascii?Q?ij4SKqNkns7kjC9UlaHTzaLqeFtmc8842j4eeL2UGs5P+0UrDVgJwJsFkAaa?= =?us-ascii?Q?ZPuCYKrZ0Cc0fMEs6wG13zAYOLEeYwhtY0eTHmPdjhDo8UZwJMEUMQFPCjh4?= =?us-ascii?Q?ckJ4m2Eb3vy4xcpNVn57DH74y2nW+A5cYtZ42W78tuO+OsnQHmhJIuIRoktK?= =?us-ascii?Q?6liIfRZrYwkQD0a4tstaCZ6zR5Bdbjg3pIS4W8kTZ1E2z68cq1T3iy2hLDW8?= =?us-ascii?Q?/9tWkC+DWV79Y/CPKTrQkFF1TqH07hFHv1XHonuMK/aU+2LABgtaDXZpytdt?= =?us-ascii?Q?R1bqWL7cBcMP7myYVKk/uEDIUmAYQAnvbxzvkV9m6ClXLOpYDh0FXVxE/KSt?= =?us-ascii?Q?2QQ0Vs7Gkhz9VZfK40tO99UUmviZZwxu/OaySbLryAsmytypXhWIo7ujJq7c?= =?us-ascii?Q?pH31aQrfkdhhuyBBLieX27Dzzn+4B/0ofALC2P7ZydCH/8Byb4d2q5AEmoGo?= =?us-ascii?Q?Fb8FBvM27ITsXlZqME6y9Q5QsQjlhUiwH9xc1dr1KbCzWnj7ai5WkhMu86yu?= =?us-ascii?Q?EGIc/U9pMC0HY7mKHU1Ksc0djNZzK10WSvEjzPWrntBieD+mBphYOBU0PGz7?= =?us-ascii?Q?vR+juGXYRNAOErVJN8XFtuzoBvrzJRfFDN0gKobvkuxmsBbqLrgzhmK6x0rE?= =?us-ascii?Q?fihO40db+zSop/QTRZnHiMhG75D13tbmCfspxnh+yjG6+5Jq/Rg+VS/QtJm+?= =?us-ascii?Q?7p//OQNJyTvf5eAeyFsUj7CzlemTdb4D708wQFRmKIi0bFP70Q4CwPoCgTQ0?= =?us-ascii?Q?v+ZuoX+eZTrxS14CeHODEOEvLpwkj9MFAXMB5Juwwu1Pqh+NUaCrwmHv0Vea?= =?us-ascii?Q?CbqZAK3bg2PeviIybhRk+4pmA/O/q9i9IR6ESoKThXjc1c+l6pcU7EzweQsg?= =?us-ascii?Q?53iBYjTJRt1lEy62qwd8lt3O?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6a0d9587-d2f4-4393-6a38-08d95ca0bf6c X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Aug 2021 08:19:32.3660 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qiEqt5K8yUkTvsjGykSntZ/nTp71AGUXeLYKcefzmFOQbuzWE/Y0CFyzCu5qCgvpobjDKDQ0MbKrsl5fegy9tA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR18MB4569 X-Proofpoint-ORIG-GUID: BnOXkZDRODjDJoVQpRET3Yrlr2CZcaOQ X-Proofpoint-GUID: BnOXkZDRODjDJoVQpRET3Yrlr2CZcaOQ X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-08-11_02:2021-08-10, 2021-08-11 signatures=0 Subject: Re: [dpdk-dev] [PATCH v2 3/4] examples/fips_validation: remove illegal usage of APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > From: Akhil Goyal > > Some of the cryptodev APIs are not allowed to be used by application > > directly. Hence removing the usage of 1. queue_pair_release: it is not > > required, as configure > > of queue pair release the previous queue pairs and the > > dev is not directly exposed to application, hence cannot > > use its ops from app. > > 2. rte_cryptodev_stop: it can be used directly without > > checking if the device is started or not. > > 3. rte_cryptodev_pmd_destroy: application should use > > rte_cryptodev_close instead. > > > > Signed-off-by: Akhil Goyal >=20 > Look's like it should be backported to stable releases with a Fixes refer= ence. > What do you think? >=20 > Besides, > Acked-by: Matan Azrad >=20 Yes, Agreed. I wanted to get opinion from the Maintainer of fips app first if the change= s are=20 Correct or not.