From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5643FA0C43; Tue, 16 Nov 2021 11:42:12 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D0FB84114D; Tue, 16 Nov 2021 11:42:11 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id B7858410EA for ; Tue, 16 Nov 2021 11:42:09 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1AG3tBDN004135; Tue, 16 Nov 2021 02:42:08 -0800 Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2104.outbound.protection.outlook.com [104.47.58.104]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3cc55n1e0y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 16 Nov 2021 02:42:08 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kRQ6HM2cktfdIhZZCAreKztDv3r2Di2ngjcvkXV+06s1+1tY4BTrMS3JqeQ/LysREQDUZbZlAGC69MeAxXfqEqH8W9rue1LmYVvNryFRve8YVtS2/PIRFmDFlHRvrIRoY8P9vJxFPriB6nm7leIFjrQFwTzOhPsSzn5c/WwEdXWoUy+b+61xHvJX8hoGsUrrwzN0aRcla29PbPSfE7h6OzL+/7BKjbA91o4Pr44rBYSY1NceBYWM/4Mw3x357RW20KAwQCyNS2DQOTa8sjpiNVwLNvFolkE+vdHHQ/S/WXC0XKt7BFQTUuM97msz6Jd/k+/Xpi9vpKdaoDcTE0penA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TU2nquyxp92xXmSuHDKeyifB8h91+pIUK5/QjTtJ4Hc=; b=LQv8rGSte8jxgmlKmFweANFIsuQsRxkRke4VWF+RGvjwefYZELcxoEerMV5adQul43YeqbLBSeZyy4megqZjMJtU85jTsdwOhh6xQQz7CJvgwuhzPQYdm8xdqEXqsn0pTXhb+Bb/FGj1hfWydSrVIk21JkafDPC2Mm5Vil84mX9mRbDoI7dmis+lZ/3M73RehpOliIe74Vej2Eaxg/HBN8GICwXqb0H2RSQ+qEBGVme2+XuuwGBd28KBEb2qClgLuNizyyTfwo2ZIGs/6wQGkr/UpXT1dTMqkEpd3vOR/uV5ANUOkHyzI7r/2FYnLTQ8R58XCkb8yJ0NeeFZl+9tbw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TU2nquyxp92xXmSuHDKeyifB8h91+pIUK5/QjTtJ4Hc=; b=R0fDv6zqyYJ0iB3gstccVyL9aKbaEpJqmoikZkOAtNKbPHouMZix1Ka54b6VQad+KXukWaZwrWESkTPWS2MdXOHBsSXhUYdxWYi9pgb0SVNJi0L828/79F9YlAHo4uEzaa9P6b94s/xtEWu+U2UVYHT+V1G7aSWuOSKQ48KNUWw= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by CO3PR18MB4928.namprd18.prod.outlook.com (2603:10b6:303:164::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.16; Tue, 16 Nov 2021 10:42:06 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::1d9c:3cdc:3142:5095]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::1d9c:3cdc:3142:5095%7]) with mapi id 15.20.4713.019; Tue, 16 Nov 2021 10:42:06 +0000 From: Akhil Goyal To: Gagandeep Singh , "dev@dpdk.org" Subject: RE: [EXT] [PATCH v2] app/test-crypto-perf: fix segment size for IPsec operation Thread-Topic: [EXT] [PATCH v2] app/test-crypto-perf: fix segment size for IPsec operation Thread-Index: AQHX2tX4ssSGjIcEHUCaanuOYoBic6wF9rlA Date: Tue, 16 Nov 2021 10:42:06 +0000 Message-ID: References: <20211116102301.2142361-1-g.singh@nxp.com> <20211116103714.2148007-1-g.singh@nxp.com> In-Reply-To: <20211116103714.2148007-1-g.singh@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 048d8c22-eb30-4de0-56de-08d9a8edbc12 x-ms-traffictypediagnostic: CO3PR18MB4928: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1443; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jBYyh7lXxdM8neCG4NTuCbrfjnfykTBCvLPAiqf7IfE1Q8tCPVLzdDiL7jHMsi+6bnFZlQWeUj2fRKZwtrx69bNfAibdnKle/BhZ4GB2vfTwY45wt3ulOrsVBxrfYeAzIGgOXFSMD2z+aXpH7D7mtogWzBNH9IqhweQZi2dOzNAXDF6d9t3tDnWjiHJBaEgP2RgeGceI9f+9t5ghwoxxxSU/nNnqso60nTztjnSnq+5t3DO8fiUsqlXO8SazGMN/2z5xqNxnbairDZ2t1HSGHEiEf+NJZK3SLSfj5gatsaov/8G7P6LCc49uuV05moGmIHfeKieh1qNf6vwDpBGUUVe36d43cIOYVx4eaagVZWD6IKydlYqvhNcdYs5VuI3AtY/YCUBuvEzGOpeofQOkRZ1N/sHlg5HXBnBVi4m5maeIX2vHsRFMZL+8SbX7e80GxpAwlm1Lf9s1EinMs/BIVg3Db5/csWIAfaovH7cyt/zopNSKLFNEM1aIVV0FBgXl/L6lkGTq4KaqBSUk8cvOA2NIgfr0yN15DzZgxisJ/JcUonydJhgZCdiv+mDhFeBN+Sz8KXolQcIgCLIEvfam9CWUOa9ZAE4yGAXmxpp7Gv9CcYe8M9S7J1FmbBHOf/vvZav1w0HKveU3M3sgKP0zgJoi6VZMk/QNn3x5rUbUAjIJXBR7FQJtiSy81yceUj8jAWdEram00/xNIegRq8PZ1g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(186003)(6506007)(110136005)(26005)(7696005)(55236004)(38070700005)(33656002)(5660300002)(52536014)(2906002)(38100700002)(8676002)(316002)(8936002)(122000001)(66446008)(9686003)(66556008)(508600001)(86362001)(64756008)(66476007)(76116006)(66946007)(71200400001)(55016002)(83380400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?F5Milpcl9xj0R51ccdx+GbRSchdNPCq4blP9pwxL88PAsgnOQTSVu8M1I46p?= =?us-ascii?Q?qwMIbyPycLvt8xJIb+tttcfZECgjzGHdc4DNS564oXLO6EidGOf+1/e3ZuEL?= =?us-ascii?Q?rqTvT6C7C67b7wQTzPP/Pey2Xw0vCfdshlGhWS/5NJOeJPjzoqfXzondm/Yy?= =?us-ascii?Q?Dg0vRVB358cv958qMop3GooVG0IiQ6XHI+aVA9GNFVgIJDefjjYVYzNtAkzU?= =?us-ascii?Q?l73EmwoHRzsDv1+E2ikroUfEOljnxjd4kpnPThWq28eyjWpEpOsIYQMAjCQY?= =?us-ascii?Q?3yQgkzBHLMWVW3btnBlDGCkNjotpvGtpW99UxJc9PGzHtVGvhp4kGpv3TCU5?= =?us-ascii?Q?6r6FnMBb1LfhzTZpUgU5lQQ1ZVaE32EEJ0jMhWT/YnITbPuKC6f9qhmv+sMM?= =?us-ascii?Q?O2TeR+xm8enENVBWJgdJ23FFhfzj3mwvrIuucU7atGv4aO0+Tn1klgo4TEww?= =?us-ascii?Q?Aorss+mZWhw6x3FkLr7CZBH/2uuuGiR8h7+awA+2FUDAUzWdjV4lLcI+f6t4?= =?us-ascii?Q?kUCX7HCa6fdWtsOygLV72k2uBe7F64ogG2/xWhEZ70OddS5e6S2rb3LtLT6H?= =?us-ascii?Q?hmZ2KPg24gZ2PUnGOJvUM/s0QSg7MLI5bh4WTuLCM0JwPI3uM4poRki1Lncg?= =?us-ascii?Q?3ftaQZy1J0c2W3ZoO1D6i9Pv2jndqiQqGIdvgjo5941bAUtKXPwD4ebJ4T4L?= =?us-ascii?Q?Moc76MHN1C4Ca58vEtat5x8TI633yitLUkUmz7capvruyz8tky87M7ZzEe1c?= =?us-ascii?Q?LSb+fjptxMgD31AqX9+T/5vqTjFNHRU5mVbfGUXRNsPUgu59KFaN7dYwMzOn?= =?us-ascii?Q?J1TGwwhopGQfs5uQaFl28hXgQEkFES0b+w6cX0QmJKLsn6dj+4qTjgEgF5+t?= =?us-ascii?Q?El8rWBK51BghaBOvrEkRtoesrHjO0afz3xG/O6h8GBXdGwjGWwpOS09Mf+m6?= =?us-ascii?Q?KkxVe1NQ1kIYlX9tb9FiTjDOzkzDtut+CZh/ccO/OketMRsi6vTe6zwEEzGa?= =?us-ascii?Q?o5I+aCnjhIkN0zKB39WEoDy1N+ysq1atS57wlVvm7GvIMD0LKkNTfYhY+o0O?= =?us-ascii?Q?xKLCmT1V0vRYoW65d3hbOJNZCVscLzXtRBdOL4H8pkLo6Z6NwmkImwKwHaJO?= =?us-ascii?Q?v3jZEhjxiw7wGPBICxgkaQsQpCj5sxUKfmdRgSnAnkAXq92AshHuTywEwOWR?= =?us-ascii?Q?CxaQpKHCFqnDryQWNSjRNvUDQiWY51qQyh7t8Cre0Ck5KaithavaHFo1wi1O?= =?us-ascii?Q?V0dttaEVn2lw/run6aPZ85UgvMaqSomvJDtVOkcyiEXU04SPSQfJqqMGUCe2?= =?us-ascii?Q?v32drNVb/zG/VvJm87dyddiR6wZdd33jRAHclK5fKK/hzFWDPhO5VgIYHIZA?= =?us-ascii?Q?RMrD3thfQL5hDksHVYfE1KRL5wbsiEDUQz0JGxOfSajjDp0b6IlWaOYGPhSm?= =?us-ascii?Q?fU20hToabUthiac62vJrgf8D64ahX/n0AqP2NMQHNCogHYFVjlmebx26t94+?= =?us-ascii?Q?yto1vdjGWm7GnsCJBg0jQSOWRw7bQsmVUFjAv0D/47TvMEP61aTc/BZV5e3N?= =?us-ascii?Q?+a3RsgHjgpA0aSpMj2fg4yvwdMaWH6/zMAAdxYambBNJtOgoUAz5g0bsBHib?= =?us-ascii?Q?5yAHJrR6lvPp/GuJeyYzyYg=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 048d8c22-eb30-4de0-56de-08d9a8edbc12 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Nov 2021 10:42:06.4186 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: aJVbLJViZNf8vlorcYiiW+nP7cLldcZzmOTpzigJyhguPxT7mNTSDX6L+Vaa0AqInohDZryPCUn3l1NktfFkew== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO3PR18MB4928 X-Proofpoint-GUID: _sz_dh49nNKF4NZFzH79auaJIiHQyFAd X-Proofpoint-ORIG-GUID: _sz_dh49nNKF4NZFzH79auaJIiHQyFAd X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-11-15_16,2021-11-16_01,2020-04-07_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > Application calculates segment size based on buffer size plus > digest size only, But if the operation mode is IPsec then > packet length can be increased up to 73 bytes due to IPsec > overhead. >=20 Can you explain the calculation for 73 bytes in the code? Will it be sufficient for IPv6? > In this patch, adding the IPsec overhead length in segment size > when there is no user given segment size. >=20 > Fixes: 28dde5da503e ("app/crypto-perf: support lookaside IPsec") >=20 > Signed-off-by: Gagandeep Singh > --- > v2-change-log: > Update commit message with fixline. >=20 > app/test-crypto-perf/cperf_options.h | 1 + > app/test-crypto-perf/cperf_options_parsing.c | 5 ++++- > 2 files changed, 5 insertions(+), 1 deletion(-) >=20 > diff --git a/app/test-crypto-perf/cperf_options.h b/app/test-crypto- > perf/cperf_options.h > index 031b238b20..cdbc027b89 100644 > --- a/app/test-crypto-perf/cperf_options.h > +++ b/app/test-crypto-perf/cperf_options.h > @@ -61,6 +61,7 @@ > #define CPERF_PMDCC_DELAY_MS ("pmd-cyclecount-delay-ms") >=20 > #define MAX_LIST 32 > +#define CPERF_IPSEC_OVERHEAD 73 >=20 > enum cperf_perf_test_type { > CPERF_TEST_TYPE_THROUGHPUT, > diff --git a/app/test-crypto-perf/cperf_options_parsing.c b/app/test-cryp= to- > perf/cperf_options_parsing.c > index c244f81bbf..268f544936 100644 > --- a/app/test-crypto-perf/cperf_options_parsing.c > +++ b/app/test-crypto-perf/cperf_options_parsing.c > @@ -1132,9 +1132,12 @@ cperf_options_check(struct cperf_options > *options) > * If segment size is not set, assume only one segment, > * big enough to contain the largest buffer and the digest > */ > - if (options->segment_sz =3D=3D 0) > + if (options->segment_sz =3D=3D 0) { > options->segment_sz =3D options->max_buffer_size + > options->digest_sz; > + if (options->op_type =3D=3D CPERF_IPSEC) > + options->segment_sz +=3D CPERF_IPSEC_OVERHEAD; > + } >=20 > if (options->segment_sz < options->digest_sz) { > RTE_LOG(ERR, USER1, > -- > 2.25.1