From: Akhil Goyal <gakhil@marvell.com>
To: Vidya Sagar Velumuri <vvelumuri@marvell.com>,
Fan Zhang <fanzhang.oss@gmail.com>
Cc: Jerin Jacob <jerinj@marvell.com>,
Anoob Joseph <anoobj@marvell.com>,
Vidya Sagar Velumuri <vvelumuri@marvell.com>,
Aakash Sasidharan <asasidharan@marvell.com>,
Tejasree Kondoj <ktejasree@marvell.com>,
Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [PATCH v1 1/3] cryptodev: add queue pair reset API
Date: Wed, 9 Oct 2024 14:29:44 +0000 [thread overview]
Message-ID: <CO6PR18MB448452DAD389D0F65EE29DBAD87F2@CO6PR18MB4484.namprd18.prod.outlook.com> (raw)
In-Reply-To: <CO6PR18MB44847753C82BB1A3968D925AD8622@CO6PR18MB4484.namprd18.prod.outlook.com>
> > Subject: [PATCH v1 1/3] cryptodev: add queue pair reset API
> >
> > The API will reset the specific queue pair of a cryptodev.
> > The current API, cryptodev_queue_pair_setup(), requires the cryptodev
> > to be stopped before reconfiguring any queue pair. Stopping the
> > cryptodev in one thread can result in a segmentation fault when
> > multiple queues are used for enqueue and dequeue operations.
> >
> > On supported PMDs, the cryptodev_queue_pair_reset() will
> > reconfigure/reset the queue pair without affecting other queues or
> > the cryptodev state.
> >
> > The caller should ensure that there are no enqueue or dequeue operations
> > ongoing on that queue and that there are no inflight packets before
> > calling this API.
> >
> > Signed-off-by: Vidya Sagar Velumuri <vvelumuri@marvell.com>
>
> Acked-by: Akhil Goyal <gakhil@marvell.com>
>
> Please update release notes.
> > diff --git a/lib/cryptodev/version.map b/lib/cryptodev/version.map
> > index fdac0d876e..eec06d9939 100644
> > --- a/lib/cryptodev/version.map
> > +++ b/lib/cryptodev/version.map
> > @@ -87,6 +87,9 @@ EXPERIMENTAL {
> >
> > # added in 24.03
> > __rte_cryptodev_trace_qp_depth_used;
> > +
> > + # added in 24.07
Changed this to 24.11
Added release note updated for new API.
Applied to dpdk-next-crypto
Thanks.
> > + rte_cryptodev_queue_pair_reset;
> > };
prev parent reply other threads:[~2024-10-09 14:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-22 10:28 Vidya Sagar Velumuri
2024-08-22 10:28 ` [PATCH v1 2/3] crypto/cnxk: add queue pair reset support Vidya Sagar Velumuri
2024-09-18 5:40 ` Akhil Goyal
2024-08-22 10:28 ` [PATCH v1 3/3] test/crypto: add support for error recovery Vidya Sagar Velumuri
2024-09-18 5:42 ` Akhil Goyal
2024-09-18 5:40 ` [PATCH v1 1/3] cryptodev: add queue pair reset API Akhil Goyal
2024-10-09 14:29 ` Akhil Goyal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO6PR18MB448452DAD389D0F65EE29DBAD87F2@CO6PR18MB4484.namprd18.prod.outlook.com \
--to=gakhil@marvell.com \
--cc=anoobj@marvell.com \
--cc=asasidharan@marvell.com \
--cc=dev@dpdk.org \
--cc=fanzhang.oss@gmail.com \
--cc=gmuthukrishn@marvell.com \
--cc=jerinj@marvell.com \
--cc=ktejasree@marvell.com \
--cc=vvelumuri@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).