From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 197DDA034E; Thu, 20 Jan 2022 18:11:19 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C7E4442717; Thu, 20 Jan 2022 18:11:18 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id B94BC40042 for ; Thu, 20 Jan 2022 18:11:17 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 20KCOasT015679; Thu, 20 Jan 2022 09:11:16 -0800 Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2175.outbound.protection.outlook.com [104.47.57.175]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3dpybrtsw5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 20 Jan 2022 09:11:16 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VM8LhlvZJ2IaMDlqXmJme5Yoh2B4zy2h3yJqOHrXaYQ2zAd1YEYysh/y9hw5qyS1v+5hmP+8Ub9XFM/nc2NJPdzWxahRMjP6a9CB6ZCg7zXnTWF0Wq8FmpAqqTV2rxa48VffRN/upQgPnd/BtGgXnrBk8H5ivrKaP3sQJpQhBrrSMKf6Vhjk6zz74l2nzxkjPT9YBVLLuSBU9uTKjNYCN05nkRa0AZOaheXIJ5VK5ipt1eZzYk78AOWpKdL2LUJWEZeV681toDcMxspjQyMTjID7G5jrXfxmprAs3KLu1umL6wf8tOf58vpMIeRWbI8hSMfozwwBtFkNoHol1sWLPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Pq/d52gjnxMG9XVNbW2r1RdFS5JBGSCe1mDiIHY24SA=; b=hH92e84c3WbbkY+pBStdQKDCl4sI84YPkbVFaILFH0xgkwmnR9FNU3RWSxr7lgP8u69XRce9WTYjG2CSRxbICvrXqeh5qHAl2ceh9ikseSHifkoFrZN+wwo2RXbiMLSTMzzcrpP0tbHqV42LsnRVdx26BsVY3K7B5ePipbamaa/qLPGw2XB54a8m0G5XvdmYBoGzGkwSm4ALtXMVl8RT7y/u9txVbXHc0MsMKVfeLsU5CfinAlDepHv8Wpr+pQelWeq+qit1HD8DseJHALjwZwUi3QaJDTsoxvMFR5UJ00FyHXp384SoAP9D639yq6QXk7elNcr0IoUEFl48w6lARg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Pq/d52gjnxMG9XVNbW2r1RdFS5JBGSCe1mDiIHY24SA=; b=G5snV7cgyskdRfMtVe3CUn4OGAS4hUZOAQqdYLTzRZx9+rHM2aeRW0Ki09FWuyeYLpq1myz14gqDFd8BhxVgswY6LHrcQ0RPf5eQ5lgdDdCI1UUWeLR0iAJ6ejedYEZO2sgjPdEgcdwHuYt8QeHleMMxIdZxzsTrnGvMRHiIwgU= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by CO1PR18MB4681.namprd18.prod.outlook.com (2603:10b6:303:e4::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.8; Thu, 20 Jan 2022 17:11:13 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::ecd1:2b8:57bd:7780]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::ecd1:2b8:57bd:7780%8]) with mapi id 15.20.4909.008; Thu, 20 Jan 2022 17:11:13 +0000 From: Akhil Goyal To: Stephen Hemminger CC: "dev@dpdk.org" , Anoob Joseph , "radu.nicolau@intel.com" , "declan.doherty@intel.com" , "hemant.agrawal@nxp.com" , "matan@nvidia.com" , "konstantin.ananyev@intel.com" , "thomas@monjalon.net" , "ferruh.yigit@intel.com" , "andrew.rybchenko@oktetlabs.ru" , "olivier.matz@6wind.com" , "rosen.xu@intel.com" , Jerin Jacob Kollanukkaran Subject: RE: [EXT] Re: [PATCH v2 1/4] ethdev: introduce IP reassembly offload Thread-Topic: [EXT] Re: [PATCH v2 1/4] ethdev: introduce IP reassembly offload Thread-Index: AQHYDhqGsk7JZEaeNkGacIa+1HuM0axsHe4AgAAHBnA= Date: Thu, 20 Jan 2022 17:11:13 +0000 Message-ID: References: <20220103150813.1694888-1-gakhil@marvell.com> <20220120162627.4155695-1-gakhil@marvell.com> <20220120162627.4155695-2-gakhil@marvell.com> <20220120084502.7e5eb2c5@hermes.local> In-Reply-To: <20220120084502.7e5eb2c5@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: baa3be71-7be7-435b-9c3c-08d9dc37dcd1 x-ms-traffictypediagnostic: CO1PR18MB4681:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: bAwpjD6IPTYwSBvqeUzAN5CkbmlXzdycy/G5CoYsoaZ7pxZcM8mLG8VrQ1kH6it0UgRDHuR1pQiYWQA6CdNmkZ0n4ELwMB7lRuIkXzZ5Os9qKMkLM7Z8woK7Xd7jh/Sceg6kxUY27jPXKTUYc4tgxN3qScU82Xv8Ii/cN4WBHJB9KZMqqSjzGOQYlYkdGOhY9NPC1bz1l+6Dy5nWKtUNrG9G/Z1NFRRUoNdGmdxMN9V1aXfxDlQW5C+uicDpFuquOLSJV9oMubyaC7cw1ndFcb6yLHb4Euu810J29oefLqNLtpJaL47olJHMvcp7WAeiog7D77tL29Q22IJHjIXHmG+nWm5ZDQQNLT7j66eHEkCKSB/AFJiyGoay7va8qxDRxsw7eyno6Reb1H1JN2vUIvlcWocSY/AUTdi1K/pbcKWVxV6Ifx6yCXTYcQameEKSXfNsZgMvtJCSgHPsRKyHMLABw3RUONu+4JVNAGLSTFEu8R8rioXLPjZUnZYDSikMKfw3m+D15MUeis3bi3TOWx4LLPG2lC054div/dFWm2DF8xvn0D5RCrIBvrvLphPpukZyj+abE+tncJ0QZOt52m1BgH+J6a4ID24UbXlJRfSM2Ao9vHyH+OCrBiT7hHbNnT1trw+0xOSeCZ8HuD64IdBrg9ZC7VHaA71Kq67d1dzb5IT0VYKMi6Pgkg7Mb5dmLKYml+HvNb/lX8ChADTLhR2552uFfGGVMow1Ss+lVVE= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(316002)(66476007)(6916009)(66556008)(107886003)(54906003)(9686003)(7696005)(64756008)(5660300002)(52536014)(7416002)(6506007)(4326008)(83380400001)(55236004)(66446008)(33656002)(2906002)(38100700002)(122000001)(55016003)(86362001)(38070700005)(8936002)(508600001)(76116006)(71200400001)(26005)(8676002)(66946007)(186003)(21314003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?tG4o3h/vVeopaiNAxV4mFJC/CY6PhtsJ/DKd2CW0Jn1CwAW3zxIQbMvvBDpo?= =?us-ascii?Q?x9IeCY2r8uS0jXeAqkfJIJZgU95dtuvfqSymC+SUwojkfa6isftZHMNxscBg?= =?us-ascii?Q?aZ9RTLrJXJH0VN6ddEarSgUE/WdCJlY8aklRXOJpFa0xO2Ctg+KNmXZMjOUz?= =?us-ascii?Q?hBGYMOI2vsMS8Ldx5jNwmT9Vblt2lvd3jJEvFhyPNDwDlMY5DCcvFz0t2pKu?= =?us-ascii?Q?HDC2vQ2dgdioNhT7pWwm/3uoF0OY3A7RlGO/uChCEiodbO57h+ZlnBI1h2CQ?= =?us-ascii?Q?P2qmuHq3BI/wp6R1vxdzz2QBiIupk6HAeuXUL5rTan992mD7qPGr389UCddK?= =?us-ascii?Q?gGS0HyWxjVfiiZpWcrXZhDOFpWbsJivTnImYqWOY3Xi3xNzwB4s59XiV4mFV?= =?us-ascii?Q?mGnDx35xHow6UtHGjOWbWJjw8ZyGb7EfFfbmDSbV9MN9macE/S7Qxu4Q3Wib?= =?us-ascii?Q?n+UNVX76E+Fg9DlpF1el+nYJiffO/T5Vhicfoa0vU2Gw/FK2gDtv8SVhGyY8?= =?us-ascii?Q?8UQhV4v2YIdn6eJm5wW1CPq+yGbHnPRmg6Bng3JcXO7NxdWwusuU+Hd9lzSB?= =?us-ascii?Q?dk1KDy1ROxqS33FU/KAL+Y6y75xnLD6c+n3cwhCMF4c/LCVBB9fkUaIGAq/h?= =?us-ascii?Q?sldlsNre9U+W8y73H1qUpO1JiYv9nxp3XAlPAwB7gNXpb9MWYUzvroUtKGPi?= =?us-ascii?Q?QJTlIrzSWZWS7fouJIu25Ub8Qr6rEF0pTNG2D1bUKlmClOkoE3RZJEKkj+Vg?= =?us-ascii?Q?llJC6e2xcMnNOD+CvlBodR0ye9wAPZR3WSR8ndM+qxz+hZ6JauFmfo0QCfvK?= =?us-ascii?Q?2ZhtIfLUKJyrgi6I+qoH6ys7zDpbi9Zs1l5SdNjxMLAKT5KF4t2f/ktcDU6l?= =?us-ascii?Q?j/ScTNyrrDRg7BPHMUx+Wx6cKVgnUubj+6hePNZ6aeGPkpOOn3cFSO2p+3wN?= =?us-ascii?Q?CkxJTVNpUCxWoLswgYACEahGJSp8t8QyrU7iPS4OwwLFae0S/wDtgWIfv1P3?= =?us-ascii?Q?qKZcG73pv6++KGfEi1Mek3W7rElRVmNWN1CYYYs2tkW/AHPVHD3+UK51e0Pr?= =?us-ascii?Q?+nd9o0NEuRXE1IDYiTwPJv8WR2c22JhVpaGUx958y4/O8z2R8g4klgpb4hSI?= =?us-ascii?Q?LBWSpQOoe4imxrwJV+XPDEaXcIWK3e/1ctKupb/PM2qwfVm4RDYUvQr1MNcj?= =?us-ascii?Q?eerAAIkxecrzPtn0rJC1abGAB9i8fe+paDMBJm7rfsNXMbP1TyXDuuhXvdP5?= =?us-ascii?Q?XLYPIV/r8e4GFqSui6kG74lXO0F8MWwZPJUXyFYnmLNbOuWDSsba1N+rcIBR?= =?us-ascii?Q?mxo147oWC08Fv/NSG6/WZn4bhpwojCydfh+Y/oBzaIDiHrPn3V69A0TAJ/uJ?= =?us-ascii?Q?epHvJo6Hzhef5KnF2GXKexDUuflvBiy7w1p1LGw0LCKo9ag0wlHBzJfjGnRF?= =?us-ascii?Q?4Eei7qMLsEv4QbO4LSAZZinRUvsALn3Q17k+Gf8uxNrno0rveTsoT0DXvoLk?= =?us-ascii?Q?/dfM+MckthHeTeWMgycBAUKnolmqHDhqoBvrbHHn+HQm2NSJ4TEtiw/puDRI?= =?us-ascii?Q?N2c2HrFJVevuaP9B4ulh+6YEYsNr2Ec+wgaaqhvthC7lWlUE3c4umMpKED7J?= =?us-ascii?Q?CA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: baa3be71-7be7-435b-9c3c-08d9dc37dcd1 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jan 2022 17:11:13.4422 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: K+BeiV06e0AcrepAl0Y2IxcQsOlCatYNdu489527QWIIxmtRA68Lad3kgQho6QH9tos0inBLtCYE7laCDbW5Ug== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR18MB4681 X-Proofpoint-ORIG-GUID: 5zBz8Kj_8ODD2bNNMHCge8rtoDiOY6jv X-Proofpoint-GUID: 5zBz8Kj_8ODD2bNNMHCge8rtoDiOY6jv X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-01-20_06,2022-01-20_01,2021-12-02_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > On Thu, 20 Jan 2022 21:56:24 +0530 > Akhil Goyal wrote: >=20 > > +/** > > + * @warning > > + * @b EXPERIMENTAL: this structure may change without prior notice. > > + * > > + * A structure used to set IP reassembly configuration. > > + * > > + * If RTE_ETH_RX_OFFLOAD_IP_REASSEMBLY flag is set in offloads field, > > + * the PMD will attempt IP reassembly for the received packets as per > > + * properties defined in this structure: > > + * > > + */ > > +struct rte_eth_ip_reass_params { > > + /** Maximum time in ms which PMD can wait for other fragments. */ > > + uint32_t reass_timeout; > > + /** Maximum number of fragments that can be reassembled. */ > > + uint16_t max_frags; > > + /** > > + * Flags to enable reassembly of packet types - > > + * RTE_ETH_DEV_REASSEMBLY_F_xxx. > > + */ > > + uint16_t flags; > > +}; > > + >=20 > Actually, this is not experimental. You are embedding this in dev_info > and dev_info is not experimental; therefore the reassembly parameters > can never change without breaking ABI of dev_info. Agreed, will remove the experimental tag from this struct.