From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0936FA054A; Tue, 25 Oct 2022 16:20:17 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D931742BF6; Tue, 25 Oct 2022 16:20:16 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 1125542BF6 for ; Tue, 25 Oct 2022 16:20:14 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29P9EKtH029862; Tue, 25 Oct 2022 07:18:06 -0700 Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2102.outbound.protection.outlook.com [104.47.58.102]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3kcg1mudn5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 25 Oct 2022 07:18:05 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O7+yrDt5dWv1jz02W7GVPrBInC/mEcT+1SxbDN4wKbGy14+6CRvO8DU3g0Gdgo9WSj3+nCYKhFKU8pY1tZ7ELUh8vVfrjR421q7OIVcspzuuJWKgB2peyTUCkx0wrZIL/Q75szjdnP6jDlFesZeh3DKzmoeWdTskCxK1WWGav7/xv7aVDB2kWpDPrVK3RS+H2+R+ooP9voyjuEjpws1ffchgbNOv2aDCp80BFkltWEYCJYv3CmBbQKv1aU/a7cgCx9YedJBKt1z+QXXWFmw9gy9i6AamIDd7/wSqGgmLemAxGndYi2gwBsTHhdEQJM09boguTtu9XMMmdlSP+BpECw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uNTdiY65+PY5X3LP8bXsi/3cJXNVsB0CRiogS5VXVwA=; b=ADqMtFQe4fR9oH5wq7IsovhUtaAo6uGEHi+mgC9qENe1ewgbLDuUeazq87iqLG8T9/ePBKSFOYsqdHmqYXhBBN/DYbp4dlIOn6ez3m+FnNmgwnZhXNbVcRte3VU6iOtjY/I5SczBl6yZ3e1qmKIzBJqInCO1TwlHqNpZUvPpUEfo0YHy0YFZMBqcXu5fTgbsZwIX6Amd/33nNZa9PMdE399968SiHtUbs8eBIUub+Fwtp1FsvTodznKNS6W63il1ll/9qI8cmN7H8IsHsljykbjY8VWpRm24emc4uTy1wwe3DgbiNyQFcjLS1j2SSenUSbEgFwq2Kze0WApZ5wJcAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uNTdiY65+PY5X3LP8bXsi/3cJXNVsB0CRiogS5VXVwA=; b=IuJyQ2WXXW8dkJfMkVhG2ufRDFy9mo44XXMI6HmG7NiBJLJLosxOPcrfhc7nOUZIEVaETJXbP0W0ltbNr8d+PldBR/Qg2C2H7/1+SvVPLVx4ms6YTrZWgwrOkuo0EDl+aOyi9srn/qnzoxR8fz8ZCPqHKSxOClYee9GM2IxmXX8= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by SA0PR18MB3599.namprd18.prod.outlook.com (2603:10b6:806:94::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Tue, 25 Oct 2022 14:18:02 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::8c4f:e24e:332d:dc6d]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::8c4f:e24e:332d:dc6d%3]) with mapi id 15.20.5746.021; Tue, 25 Oct 2022 14:18:02 +0000 From: Akhil Goyal To: Zhangfei Gao , Declan Doherty , Fan Zhang , Ashish Gupta , Ray Kinsella , "thomas@monjalon.net" CC: "dev@dpdk.org" , "acc@openeuler.org" Subject: RE: [EXT] [PATCH resend v5 2/6] crypto/uadk: support basic operations Thread-Topic: [EXT] [PATCH resend v5 2/6] crypto/uadk: support basic operations Thread-Index: AQHY56/sI4zp0vAIYk6jME+qM71MgK4fJ1Gw Date: Tue, 25 Oct 2022 14:18:02 +0000 Message-ID: References: <20221024134409.1896776-1-zhangfei.gao@linaro.org> <20221024134409.1896776-3-zhangfei.gao@linaro.org> In-Reply-To: <20221024134409.1896776-3-zhangfei.gao@linaro.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR18MB4484:EE_|SA0PR18MB3599:EE_ x-ms-office365-filtering-correlation-id: 2cc529c2-f723-4eb2-092d-08dab693ba1d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4K4tPgheAiK7xUKIf5ktF4lf9F6Nx72viQSMZQWyN5jNJmAEMZjLnqlxWk26W7Um6Hp+wv1iomQuHidVEUqALG8yVwY4Yi+nSdlc4swSmSsYyqlKvVNDhpSXd6G/lR6KOJl1XhyuACtrekMlOdYovymN/+Bf9hi+QRF9090a9tjs/XA5dwOH4x1hU2r8yoT/uoBMTVWPE6yyMcAqPaTp/P0m52DJjFuYKEpVTCuhzz0/1KV6DUPcUIL6CKPnTPyUkbRQpiI9J8SGF2zLNKoD+PmrcB9pUp0MGrRbtur+niW1uzt5NPpS/G3gvNyoXyD1/0PgxBVXmCCRyTeZBg3oDQ23bZfl2+Iuj2b+A7QHnW6uHx2gulzF0B2ynSUK/qZVMwftcHFknl//Cmch/EqGlf+d/lteeC/EqdXWBeHHND5qRnwG7F4K6e/7ow1uSgG0o/nWqU9Hgt2XoXgAm6ictv9+9MtG74HnJhOyJc8EmTRlQ92cDi/ULLRy/FOBMCoqLANzGPwxGj+u1+iUrtsmi0h+ZjghaZYv7vHjaEJ2uEDPWgJjVQs3XDgUHrmd/q93UXU2hJBM2YlO/pe8FT0Iiv0JOwCmM1mK7B6kKeXD6cTDoBKAxqXp2HY1LPXqUTy+cVWpVnNTyWVU28djGPVHASCDVZNz7SbZNiGt0znsMwH96WyJWc0cKnKsq5uSW02ezeiVDYHomdlv8zh6IvqiolcL40QAw0pT9GazSPshdHM2bfYkX0hKMeMYovqwxDaWGgj92Tv7VQtPips6i8qDzw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(396003)(136003)(376002)(366004)(346002)(451199015)(316002)(33656002)(4744005)(83380400001)(38100700002)(38070700005)(52536014)(66556008)(66476007)(8676002)(64756008)(66446008)(76116006)(66946007)(54906003)(55016003)(110136005)(5660300002)(2906002)(41300700001)(71200400001)(8936002)(4326008)(9686003)(186003)(478600001)(122000001)(86362001)(6506007)(26005)(7696005)(55236004); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wrovqsgc3XYZTZenPgzcTLvBee7bGfufQD0ej0ekW9saTYZE1lOu79SlaV7K?= =?us-ascii?Q?VZ3+loCUEQQQuRlDlVYV0wNXdQEXjF+ZOp8p9bAf7owPUIIVt0b6WiZ6HXf6?= =?us-ascii?Q?ZxssO9n3LWdjJSNVRPCZZjbKTl0HKBQF7dYVavRQZ6PsHdkpgyrSmve/qUY3?= =?us-ascii?Q?biIicqoMciB0nm3B6jUVQRwn8PsiaoALxNL7S6N5WXsSdJnfIN3dtUXW4z6V?= =?us-ascii?Q?oD+nyibD4H2+kN3Uvx5XdFteSD3Yn3l+awbSsOUCGQ9O3SJufMIp5J48ARWN?= =?us-ascii?Q?uHveDJojjekiTMdzjCyH6Rke4wlI213YFK+dJD+qeN1/AEFN+8cxT6F8/DNK?= =?us-ascii?Q?caJL62MH/CckeFbTNpEp++YMX/bx2UFWV/mTZQe2W+H4v98pjDVHFp/mrLPJ?= =?us-ascii?Q?hvfeBiNQ2XcKUuac9kxddLula3IsnJpsE+Ub6NsZKneO9UPWssJHRAY2wQ1L?= =?us-ascii?Q?BlgT9RzaYNEKTM5TkOssd8MovHspHvxtcqAejDnsGAyTXJObPZiu+Xg+I5oB?= =?us-ascii?Q?tIC9h3PLFsVJbYHo0zAe0hs+KXuQG/Typxptzuo+vscxuXc9iWsLB7bkFn9b?= =?us-ascii?Q?KqeHMfmNog4ma9kj1dm/+xekz3T8NldTYbg9A7XzOIAGvuMSovQtDtqYDybw?= =?us-ascii?Q?PR0ggd4KU4TH/3+eM1eABZs9BCiBeSzT7F3Ot7c/yQRPOar37fLUxolUWDk3?= =?us-ascii?Q?Vy1wlGY7moF8cftau+vyQvpcs7FvcBAdm6CV8mQoOy3C/T0GGmh+7xT11eBn?= =?us-ascii?Q?zxoas3ZF6uUbj+ht8PvpVIvgh5O6Z0LFfGQZoBdOtt4fylVrj+6smWRAGLaW?= =?us-ascii?Q?PV7VzISMS6XVNm87pT8QPAleEnZ6uz3Y6idI6wPNn6ixwErpaZsAktgY04SY?= =?us-ascii?Q?VMG/zM752iu2UjxeEKd6/UJ/KChJJY20HQbfvxAI5jM4XFHyUMsjK0Ka7oyz?= =?us-ascii?Q?w6oobnkcCQ+5A5pg2JFxt/4gPAM9RKCPd+f7MUSFYpaTO70ZnOr1vnfFnqov?= =?us-ascii?Q?DBbvQ/iIb4FZ3Fecm8rqvAoPPOmas1BGcYBIp++w0wKsrQNAyF+sIYanKEJx?= =?us-ascii?Q?MRAORvxmnKVnzbFGv5N4nAjAxwQJc5hi5Oc1yXgE9Gmi25ij+FzBrKFcpS2k?= =?us-ascii?Q?uRgvOhzOAixJmBndp1o9BRntCE+9nP5jWDx66HsbeiuSv4P/boEOVrH7RUaB?= =?us-ascii?Q?XlebgGGRS5QdHPBqu0B4Df/cy9uoTwEF7yoyxXrDLh19BrgIufPc7LlyTrpu?= =?us-ascii?Q?JCXxvRq8ApLtR7cgaQUQdtxzp5h6sWZRFzirH5D8R61He+ylUYAOLAZRRhlT?= =?us-ascii?Q?sMC161op6FEu3931a1SYysQR12PVSb+zlEwgiW0SFsrOL9Afp523/rBLd5lF?= =?us-ascii?Q?IN5+dm3aju7IwekoTv2q+jPYf+lhAl4l7hI7pyONgplqe2iiRoMbkYVpIzYp?= =?us-ascii?Q?M2F9bj4/KRhSEZ2UbYS0BLchgdN3WJHQrbwCHCz9ob6tPMA+Ji5bffpZKiQk?= =?us-ascii?Q?KwsLLXkmFt2nuCxwRr6p4THfwtu+bDXWqoKEuHJrzGJsyURiTUZXIrlAXBd2?= =?us-ascii?Q?UzLMff39H5qkIpcrWRhRjz9O/J9wOIjL0hqZ+SN4?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2cc529c2-f723-4eb2-092d-08dab693ba1d X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Oct 2022 14:18:02.5090 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kDTTfRMD+FE1tQnFxi1FG3wybref1pAvo1GLXtlxIWk4VyYAcLMyWaQmm1VVajjhwR6nd0xegV97Fvozbe8n9w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR18MB3599 X-Proofpoint-ORIG-GUID: P8tkcBCeljMBoWS6qqwTTXPOk6mM0X9i X-Proofpoint-GUID: P8tkcBCeljMBoWS6qqwTTXPOk6mM0X9i X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-10-25_06,2022-10-25_01,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > +/* Maximum length for digest (SHA-512 needs 64 bytes) */ > +#define DIGEST_LENGTH_MAX 64 > + > +struct uadk_qp { > + /* Ring for placing process packets */ > + struct rte_ring *processed_pkts; > + /* Queue pair statistics */ > + struct rte_cryptodev_stats qp_stats; > + /* Queue Pair Identifier */ > + uint16_t id; > + /* Unique Queue Pair Name */ > + char name[RTE_CRYPTODEV_NAME_MAX_LEN]; > + /* Buffer used to store the digest generated > + * by the driver when verifying a digest provided > + * by the user (using authentication verify operation) > + */ > + uint8_t temp_digest[DIGEST_LENGTH_MAX]; > +} __rte_cache_aligned; > + Same comment as on 1/6. It is better to move the structure definitions in header file.