From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0699BA00BE; Thu, 10 Feb 2022 22:08:08 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CF42E410E5; Thu, 10 Feb 2022 22:08:07 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 98D954013F for <dev@dpdk.org>; Thu, 10 Feb 2022 22:08:06 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21AKAGKZ023570; Thu, 10 Feb 2022 13:08:05 -0800 Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2177.outbound.protection.outlook.com [104.47.59.177]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3e5134akhc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 10 Feb 2022 13:08:05 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a8J75VQ/s96noKoMHzkbGzryuIA9TTC0tX56BXbRfdl7QxVAkinVI1z/HXd+U1BZF4WYQuOjnAuwbI0F2/s9B5S7g6nSYB/CYPswyfOcOHLi3U0i8EEtzew6+YtTudjvFHO7TQpSaLxlz6O7xWvPxPQTfpMBH99ufQ3D+81kKQebHQRe512KeWywWsWK7hV8z1bZbXc34IPb7VQdYnCfdPVCnJESdqHPfCg48Tw7QP3zNf4s+pp+LwOeMsGtH+beC0nNsvMSu30z3o0LngyBaNOEWr0qbkAfSAiXzRAp18to/B5M6jC/LpRrru9M3SeQYZPw2YG6DC1nYyBXnyu5eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p9K2UNo9DVb0vaPgCivGn6CabW4sZLvoZfXRu+S8fq0=; b=FKnkR6FwLThkUS7JJRpkkBxJF+BWcRQXo6h/qIQMQgmDlfI22askrKvROipISGMey20bsN9YOlAq0gIrmYpaNXceosQazKEMNJzxgJ0imQ57bUfIgEVSlNU0sBx0fXZh+V1Eh6HHbpKY0EQsgFOiwI5qTQSU4uRtVyMmgVip9/MAof5jEeosnUDzMW+4P3XKe92ZcGTbxaZVicZZeJGF2NnAtEAX+1M+wP1Zx8oPEA41dz5Kotj+gXCp3wZtCYpWi7c8XKvMr3tAXmqMP06IRGfCwC4GoYQYJyWQKajEvorhTLZlfOe7z4/Btb31ss3g+cEtC7mXKCSzZL8pAAKNpg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p9K2UNo9DVb0vaPgCivGn6CabW4sZLvoZfXRu+S8fq0=; b=dbchc+8gfIKcYE0TMHd9N6C964gZ8yOGUQ+Y8aoTDUoaTgCzId8p/BW5BHwdHSRLFR32vMoR0aPnvjpAOs3HhJC49E1EW/jrGMC2953w4J8RmG4RbVtQLiJcRfIg5RAJETrP1Gm0NEcWA5LyOys796R0Y4yvxFPYcu41ng2bWdQ= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by DM5PR18MB1641.namprd18.prod.outlook.com (2603:10b6:3:14f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Thu, 10 Feb 2022 21:08:04 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::d4c9:8800:1431:88e1]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::d4c9:8800:1431:88e1%5]) with mapi id 15.20.4975.014; Thu, 10 Feb 2022 21:08:03 +0000 From: Akhil Goyal <gakhil@marvell.com> To: "Zhang, Roy Fan" <roy.fan.zhang@intel.com>, "Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, David Marchand <david.marchand@redhat.com>, "ray.kinsella@intel.com" <ray.kinsella@intel.com> CC: Ramkumar Balu <rbalu@marvell.com> Subject: RE: [EXT] [PATCH v2 4/4] crypto: reorganize endianness comments, add crypto uint Thread-Topic: [EXT] [PATCH v2 4/4] crypto: reorganize endianness comments, add crypto uint Thread-Index: AQHYHBbsEgri2dygZk6R9ftKhzRk4qyMlkDAgABq9gCAADdJoA== Date: Thu, 10 Feb 2022 21:08:03 +0000 Message-ID: <CO6PR18MB44845FC6456E8B7DB7A8BF90D82F9@CO6PR18MB4484.namprd18.prod.outlook.com> References: <20220207113555.8431-1-arkadiuszx.kusztal@intel.com> <20220207113555.8431-5-arkadiuszx.kusztal@intel.com> <PH0PR18MB4491A357D10D5F85079DE975D82F9@PH0PR18MB4491.namprd18.prod.outlook.com> <MW5PR11MB580948BC5358937320A337B1B82F9@MW5PR11MB5809.namprd11.prod.outlook.com> In-Reply-To: <MW5PR11MB580948BC5358937320A337B1B82F9@MW5PR11MB5809.namprd11.prod.outlook.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 05d1bc64-02d0-45f5-358f-08d9ecd96d7e x-ms-traffictypediagnostic: DM5PR18MB1641:EE_ x-microsoft-antispam-prvs: <DM5PR18MB1641579FAD86FA89EF70FFF7D82F9@DM5PR18MB1641.namprd18.prod.outlook.com> x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: l/o+cTvi+sA/T057tuzt3ivgCJpyT3jycxiWk25Dq0Q21U8BWnf/mDwcTPYbY9b+9VduKn/BWGhK8OyPs5n8TmZ69CpDKGHm2Ttdi7lZ0ps9FNM+5sPDvLKRSMCYFMcsHmBbM4KIdnTQLmCITh2POvRT+ZoCuTTfFtkCTNlGzSa2lDRP9gX1a5ib+8iTo5IexCSYh4eGmWkwaetTA3m8Fx3swdiYoUQ6bCWGBoUJ0s/zM1ucaAzRxCHZzpWyOIuRGUKZ6Z0KhSC6d2U3c5IrAQ7oSBmZvYOW+t8KGtYKNqmblOqWY/MJXdKyBNWUi47ParhgoD8ZGGjOSkVqu5QsTFeAHl6m7lU9/TSmR2t/tjmEd7ixVSqgcRCyBVsZdvIpb6fhGlhcnpzArve0e/9zNeZpMYxZlbFTNiNCk/NeIt2hxA5yH5umGaWPKade66x287iTdWkAEpBvDCgjJM3BWQfAQQ9eKxs6KxwwaRkFFKnHdaYQeNSaE2Itvn5ZnZABOik/5EDlxgh2h/bH0hrhRImBLkhXhKOl3wGSdKWzcGIJKGm3zLVFJVwKx7GxOpPbjppMA3gNWC+lMMHl2zOboN4fCYiYMqgbtVdZL2Zp1FbJazpjV9iIPTgsxcf9pKinpAOZvqBt4NXxrxO219U7Ap1zLH7Xu75+QRKUkWlSymDwyfCCWrmbwNjgXO5Ga6T+LSQ6/9lnoFhEHGtwJMPsKB0EC8oL5df6gqluM4f9PaMiSXthHclj2SraI1QVhHzw4f3akpwjdLYU1kul7J0QDmN3z5FoNQREo1Q0amacFe4= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(33656002)(76116006)(64756008)(110136005)(52536014)(4326008)(8676002)(122000001)(38100700002)(5660300002)(8936002)(66946007)(55016003)(38070700005)(66556008)(316002)(66476007)(66446008)(2906002)(6506007)(9686003)(55236004)(7696005)(186003)(26005)(508600001)(83380400001)(71200400001)(966005)(86362001)(107886003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?GJZRnowJM7rAha3NMwrEqzZ/FAGKeQq6DLqlyjwMAozBjdsPisSe0hPfY8aZ?= =?us-ascii?Q?u7ElFq/kXvYq75hZxCpnb5+ZtEdzPCTYTp1iqoSxe2Q+APVSAn2ZQbJfjBhp?= =?us-ascii?Q?vi0yXgJZMedM+uAKFm6ntP0S4Iozwt/YwqyooFFBz2YXebEEF1VlGfmZglBA?= =?us-ascii?Q?8IUFIUwAMfFuBUfSI1WiBt8xo1TTNaRyJ1qgqH95+xpmDg0503S/l88bLTqx?= =?us-ascii?Q?ZiZmRuQP7kvEFGr2bghH2HsPLOuiiNcvx2Bdqc2uq5pWgGloWlD6YGcPtX7p?= =?us-ascii?Q?AVnCuuc7l7r1qfsBm89LtCZoSls5Wq+BHw+WD2lDLF2oSZdIzqvU6/wM9eVh?= =?us-ascii?Q?dNJWYLFEU5FaOEKmky4GRRXZJ53fxlCCYfrR061nDgyZWFuLA/+N1aejqdtg?= =?us-ascii?Q?dmyHnon4C1+VccL291dv/ov47zqkRPwNoQWFBKDdwC3K97bEYpIXMeK+OvVK?= =?us-ascii?Q?0dXP0X+l067KkaDxkn8PlbQlGIyy5HTVRgOta1QG85XMW2+TCl3ZrL01i/7g?= =?us-ascii?Q?dacIpLYw6YrfgasEabi03mXE8yRcGgLUecNNsn7j+8F5LptJbGmkTCET8Qfz?= =?us-ascii?Q?D5PvS6VEXoI2RNAjzjy1/f5rLGiXk2UdP++Zk6ZiUsxbB0gMRix3pljnIT5y?= =?us-ascii?Q?0Jct8rnZmSPm8SLwjK5erwvh+b2vdEKx8DlaeLePwnjNa0B+12vQFR0MA6WM?= =?us-ascii?Q?HOqQKLXAJUMKuGy6BwYJ+6TRm8p68Xy/AcPprGkOtSuQaPpYqoXkH1imntaY?= =?us-ascii?Q?LDPOpZHQmpwwI2u8L96s3D5O6Iz66dmPO9KcNP1Pgi+5a0HnfFT/aJ1bL1XR?= =?us-ascii?Q?5X1pbRRGRdDtHtsOiTGms9cIQfud6PmPatwAJRjDegaY/n6cyzxBL6Txf2ni?= =?us-ascii?Q?Nena+kvvXgRPKWAt4AuDEVQgXYaHOEJWCyl9gS2qbPQSPg/AYBv9XWhjcToS?= =?us-ascii?Q?Pnz/SEZ2AdZ2YlgWQUtM4WeHV+SBOJ6wQgndTrAQC7X3an34UKGLueSpl9QU?= =?us-ascii?Q?r0nesTl33d/brm3E3pdPfE43YqgHEE9HVxRMbBJCw7O3qETHd9ZGuslWD20i?= =?us-ascii?Q?a/rbEjnzsIMI/d2bZepRpd7wf/e2/h0Mj/4IbJyxXQDpocPCkaAXAcALITbj?= =?us-ascii?Q?ivW3up5iQV+4JgdiXiyYJibxope2hWjLDjtN5c2I8sorWDuD9T4iMMqw3LQB?= =?us-ascii?Q?he7T9PpbqcpmrzRj8drmIrV0eGofTw6wKB9krm8jxCjsfDr3l6BqzrVsPsQ6?= =?us-ascii?Q?F3wf8EMhB33m3JEiLf4kFRwxTMIjB1S5M8o7Z3Q26gQw0fVWoWkDZontA5x6?= =?us-ascii?Q?T8ubXjqExmuELLuqZ3syx1ozfY+OmlPXwHsYGxlTLDEuyo0QNCCzg+xvZsAu?= =?us-ascii?Q?kAvo0K/1txi99U035XxKnZMK2ICtxrIMNY7gd6RpSisKEQgYCriLs4bKdHtA?= =?us-ascii?Q?ZsVjRmFRcaKBefRTFNgpLte5pMsqRfq0LSdnTHZrnP/e+24Ii11VTUKuWA3O?= =?us-ascii?Q?YJiUQ992gByhEQO/4jhdS2KHXUYq/K9padNK0OqAfirOmMqnUN75cGryFKYX?= =?us-ascii?Q?UlgWgeBhw4vhmP+rH01m1FDXmFgJu1GeU3gQxMSf2Bzc2x/OJZFfKba9h12m?= =?us-ascii?Q?T1d8ppGHJz4H4Oie9bA6zR4=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 05d1bc64-02d0-45f5-358f-08d9ecd96d7e X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Feb 2022 21:08:03.7432 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: q6IZe5zq33USXiJRrIplcF3O5GC6eEcDT3bQ1s4b1zc+2Cqvksar4DbBDzjNmOiFQX9fubQLInvZ3MQZRAn0iA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR18MB1641 X-Proofpoint-GUID: wGitLrLcgoZMbIu9elQGqKc8raAT3u4f X-Proofpoint-ORIG-GUID: wGitLrLcgoZMbIu9elQGqKc8raAT3u4f X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-02-10_10,2022-02-09_01,2021-12-02_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Hi Fan, > Hi Akhil, >=20 > I assume everything in asym crypto is under experimental tag at the momen= t > right? > The goal is to have them updated and fixed before DPDK 22.11 so the > experimental tag can be removed. >=20 Asymmetric crypto APIs are marked as experimental, but the structures are n= ot explicitly marked experimental. rte_crypto_asym_op is part of union in rte_crypto_op which is definitely n= ot experimental. So a change in asym_op will result in ABI issues in rte_crypto_op. David/Ray: Can you review the patch 1/4 of this series from ABI compatibili= ty point of view. http://patches.dpdk.org/project/dpdk/patch/20220207113555.8431-2-arkadiuszx= .kusztal@intel.com/ IMO, as per current experimental tags, we cannot change parameters inside r= te_crypto_asym_op and subsequently in struct rte_crypto_dsa_op_param. What do you suggest? However, I remember, some exception was added to ignore ABI issues related = to asymmetric crypto. Could you please check why that exception is not working in this ca= se? Regards, Akhil