From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 648FA440A7; Thu, 23 May 2024 17:38:13 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2E9B0402B3; Thu, 23 May 2024 17:38:13 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id DF3724026C for ; Thu, 23 May 2024 17:38:11 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 44N4e465004520; Thu, 23 May 2024 08:38:11 -0700 Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2168.outbound.protection.outlook.com [104.47.56.168]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3y9xy7t4pe-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 23 May 2024 08:38:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UDfAn6Cgw1HcDEkum2bJIiKvK2+Dxu6YpQSV5ISwwxxjtMMowSAhMrFQdn8B0xXRPIeeNCPuSsB5ScI1AWjcW2qr+i059hYLcvmHEYN5eA9MSTGejVMEy6SHTYniV7Ufsc8x0KMbQ5aS/kOXYMi2gvAOb+2/JeOqTmpAPq5Ie8J4dURqks9bjl+7qMKBsVl30SBQYtAFcB8QnenUJpcgrypRLeoyma5eZxX+mQukmrNA26Rfaihc516ZLAd4v5VLrJmPdcxnPBP51AIPTKd4PCaWXZn+rMGw2GvTSUCxuqRTztSq6worcT0AT7GqmGH8rk/l3Rnq9B6Z9OZohw4r2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CsqwEZ+rQaP8e6iM3SSFZL/15cSGCHxiOcTIOYj6KQQ=; b=bWdi96JPYVLTM7RuM8+CiS08tpv3ZcMTTEcDU0cD3Nyz+PZ56yUmsCpuywITVkqAKUzfzEt67lEaAwLE9OBU/zFAnw1KnwF2cr01qZXg79lqZE0Djn+umV1WdYEcLzf9l3i9dEWVTKxqJ7s88Ab7adXSxEPY7anMb7DBishgFeWRDZXb/atZ5N6Kdlm6TpQjQk7TzPutndZyj80eea3d5j3B6FnY/Wq0oT5q42nZBOMhOO+2y8Afu2OBJFkr5YF5Z22y/8NMgp6FW5+haj1ooOFH5t690X9X9ZyocuOjHbsInisIXU2qD7C//smUdztjVVZ6VT9TdHHPSSHn+8wTzw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CsqwEZ+rQaP8e6iM3SSFZL/15cSGCHxiOcTIOYj6KQQ=; b=hheSRnW7b5XD/ku2U0UQMEJaUtW8FuU+oqVmMl46mitx/miPi/mCOxuplW2nooMyinZKJeNNtQEQquzyG4wUKLaK5nkhXAChwrzBcmlbVmS802ufGWUKQZ9A/5t3T4G4Yf25AosQCrvtvvOtJVCPHX9JlfDOhTiLsECvBHavDoI= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by DS0PR18MB5454.namprd18.prod.outlook.com (2603:10b6:8:15b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7611.19; Thu, 23 May 2024 15:38:06 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::3c98:dd36:4897:a51d]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::3c98:dd36:4897:a51d%4]) with mapi id 15.20.7611.016; Thu, 23 May 2024 15:38:06 +0000 From: Akhil Goyal To: Zhangfei Gao , Fan Zhang , Ashish Gupta CC: "dev@dpdk.org" Subject: RE: [EXTERNAL] [PATCH 2/3] compress/uadk: support basic operations Thread-Topic: [EXTERNAL] [PATCH 2/3] compress/uadk: support basic operations Thread-Index: AQHalMHJAMbAkJIq90Wu4R3lZxh9brGlIgag Date: Thu, 23 May 2024 15:38:06 +0000 Message-ID: References: <20240422143102.251-1-zhangfei.gao@linaro.org> <20240422143102.251-3-zhangfei.gao@linaro.org> In-Reply-To: <20240422143102.251-3-zhangfei.gao@linaro.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR18MB4484:EE_|DS0PR18MB5454:EE_ x-ms-office365-filtering-correlation-id: 1264ea4d-f0ee-442c-1056-08dc7b3e5780 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230031|376005|366007|1800799015|38070700009; x-microsoft-antispam-message-info: =?us-ascii?Q?e4NKN4cDV+jhyV5hXgmInkb/xXX+LEOGYedd1OMouwA79i7ZqlJLBevjeIRN?= =?us-ascii?Q?167UUIFl/NNL6LDaMs2+qBX4Sv+bT3ruD75zy+l32NTlsTd0FzSN9BDjtL/x?= =?us-ascii?Q?ZOj4XzUZeFJJ+0hxdlEuaqWAOrK+QD38q3ToizwuG5dYUjJL8PiVHgOVPOc3?= =?us-ascii?Q?rR5u3uz4cKYIsNrT0cyabqA+jwKx7UJfVlLuRY1ktNIknUJ3EyRqQs2dIPX8?= =?us-ascii?Q?oUhNKe/+92ZMG3nv69h/6G3lFAuFJkxxJqYIPpLiou6auFVr6qSEYOOH3gyB?= =?us-ascii?Q?bpv9TD95pQlLYXThwc8z3CMqw6tV7w+5APUuvmdNfUDdCo08dSmZLVOtVpiQ?= =?us-ascii?Q?c9K4VrDgfc+9lPTCOYi1lmGJf/TgjLfddOdth3G4cwob/cm98nxnZbzZHslL?= =?us-ascii?Q?Nx8XHRtTa3XSDBZxki8yym7b1jpXlqXJjZQhfo9yvhMLU5T9YIA8C3au2XLc?= =?us-ascii?Q?6OPbsbWz5rrtpqCT5Dz14LYtFsgDhizPgzKrdqnCG1QU+c2FZCqOkC1FMK45?= =?us-ascii?Q?ikzIQ/LjSkFeyN6NszUg9Sti6+icYdfI1pWOiJowq/8UTOi4Ag/ELDbC4DUJ?= =?us-ascii?Q?5I2XLNumtRXPPLVUG7PbrcqsSLpNvwyNjslxO6ngpEihAcXgM0mhF7dF85tk?= =?us-ascii?Q?Ue4pa+mxP+LDhOSsSMTv7rufWayTXFPiuwGy//yVPuSE2z+hjzRCOMY9CDVP?= =?us-ascii?Q?+vMOjxLOM+hfukLMR9MwtPWpdIQ0CL4pup7ZVtssjHrhvOfRl82KCcsnADcG?= =?us-ascii?Q?PRxEIr66aXm4lqNHNgSVVQGxWClmXvnR5019op8oGa1JixBUGDRtZVDQ8c4l?= =?us-ascii?Q?mVMSiNYDHJAfyVHk+9WwBQl+AGE/gEZT9iuQDoSHDZjBHq9WlE2Z9etK+58A?= =?us-ascii?Q?GiAkzydHcrjT7sFwJHVYJCZqBFMtXiDRwE1o+UVmyiDgOh1gDe4it0J2BdcQ?= =?us-ascii?Q?WP/wg8iV6NWPULyo+onVJ96L/aIkDpyrFIWY1ruXP7AT3x0kQzYaWIcRMRzj?= =?us-ascii?Q?C1F7DC9wnT3ePO7YXXGY3W6PVMMYpGFBfesOisL9EpCD5tA9hK4MVId7T6ue?= =?us-ascii?Q?NLwd1M3eNuAI954u0OtkzDeoo3FDHGGixe3Xp4d1OtAvl8Rxgq9vGQ+SYfjb?= =?us-ascii?Q?Wkah+Tk9QAS/0I4oyAhLbQIBLNcZf26cBn85daXAsfXKYk7IGzdNRjVjWu6z?= =?us-ascii?Q?+GihKe7kRPT+rRNDkiF4F25+A03xFgmUOyoW+qTsZKOqC2y3N4bE2sKasIw1?= =?us-ascii?Q?8WRyVtLZKQzzt+KawFgtLUkogfNeI2nQ14fY3tWg5v/Yo12dgWBU8K6A+Zr/?= =?us-ascii?Q?rZ/HkNjogCBjTpC2m/5ledcAV1/3x/S+ork+HAd3ngLMAQ=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(366007)(1800799015)(38070700009); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?BaodwZGWJx2NVJBeOAlEp1h//xddlVEJO73ifiM6fyaLx9E9rwDYEWzQm6pI?= =?us-ascii?Q?p8HBgEJRw1r0Lq9oHbxdlydja4rv2XRn0UZ/uagK9h9zFlhTUdMwdA+nMOcD?= =?us-ascii?Q?RVUyQpB5PE/1iuzovFA2wrtGhmZb59neHT0PSEcnietLv7PRYkTyTMt+AZov?= =?us-ascii?Q?jJqG0i8E94QW7evr0bydm1OkjHuC1ahe5Ts/6HrU7hyJuK3niLUkHEMW/zAo?= =?us-ascii?Q?YFYjj2e0m+2EHi0tCJrNEe6j8YCVuHrLu1wHNraq54jF8GjXv10Z0TJpQrHJ?= =?us-ascii?Q?BCHLtmBRsvO81/s+MPsz5RZAcIGSPBXIJY/nN8Mq6Km6dBmwcJ9y74w5AH32?= =?us-ascii?Q?YkX/h6wJuyfJiVTBNsQL//hKPZ7EdTttMQQ3ZHtzeGQG3aVCoYXBrxfIc5Nv?= =?us-ascii?Q?+aIoodQ4+8BZ6Fom1meFSoHkwlpSWQMgFGcNJYFhM7JL7cNnbrfkQp/NMUdz?= =?us-ascii?Q?i3kvBxj4Vfq4KkOi56aiy2jS5cAaB/rJCGuVDn1RQo0g+AS8sh/zKPpn1Zix?= =?us-ascii?Q?55Owo4fEANAoO79ToVtNC0jpVJiCiP6RIpklHBGBm37UTlPZyJ81CLHM/cCy?= =?us-ascii?Q?B0U4KtHCOSnl4qrZLsP8fTWw9XDrhBJBqbCrka9PQRvcpm5vsc76Zu7TIHq7?= =?us-ascii?Q?KicVDVCdExm9MB26n7f0e4Je044v0mMXSeaxKuNTRshYm9c3cM6yx7gZLOrp?= =?us-ascii?Q?qzksFa6zzAO/oYpssoHVAel4H1YEfYs/NrTTNqBcgLkoIRrxl5iZeE0Tt33c?= =?us-ascii?Q?SWh83iYNnkjphyj21lhchPSlsVpeVdxPHJsdCPxASIdvftE+UT4XkdrenEMK?= =?us-ascii?Q?H8X42tWkV9ZIWurwRpQPGwDmFusya0hzSXAhItaaFGrRVrUGoW2+iwtNi/T+?= =?us-ascii?Q?2iO/6OdyZoxbSn2uKbgxG/ukQ4NOiZ3rF0wzdSKLD/j3CtU7kucHmRCfVTs5?= =?us-ascii?Q?D3NzopduRta7rnu4htoKwAYU0q6HEkU+VIILq4xQnNoSkUhQ0x1+yQelGKEu?= =?us-ascii?Q?5MrKVQre9w/PAP37dT6UIo+DUOe4M0+jcnInlVNWVdjIgOvR8RLbu9C6dYfx?= =?us-ascii?Q?LBaaz0SfUR8hrPILLI5EpopAILPj2splT7r8g+2b8/oK0x83zcj4jsdY2m+G?= =?us-ascii?Q?eQDgFRoEEowB9Pmg7N1HW5sUngoSbTn9bjEOn4+0RajmHLt/inv4wFf2rlw1?= =?us-ascii?Q?3yqmA+1Rj+g/BBWL3lEns7uEmupKN+MZ54258V4IU/KXfTrb7cYcczx/3ZlR?= =?us-ascii?Q?kg6Yo8fyEXaKO2wH11faY88ut/5rdI+u45NkrUg+iBB4D6Pf74Fg7dKx0DWL?= =?us-ascii?Q?i54z9WuE5/nJwk96Dg6NUhVAL+EaMFbXSlGV1WNeNRXPhnvmjvUtYP0sq6p3?= =?us-ascii?Q?GKzk8ShhW76AGVlCpy+20/pzL88WT0xGGDoJ6pI4oSZTHoofBkNurGfIDJR8?= =?us-ascii?Q?ezH5uY5y7kyJ9kpecfX17t1pJG9bynmlq9KE5gLe+f5BIOfuXjywu+q8ekaE?= =?us-ascii?Q?aH+2mSn75tUh2R2XliIhDUfp/VY684N6vhY0nyijO1vllPbO3+aO+8U8lOEu?= =?us-ascii?Q?EYG5b/2Bm33J5VssrbtSI8GRI0tIHzLeDCLXG0Jy?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1264ea4d-f0ee-442c-1056-08dc7b3e5780 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 May 2024 15:38:06.5844 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ILg0IGxe3us679MsJV8lT2m86dzzf9ZI33aC/pbLbrNhIjDI0rF/UdjraGPr5O+bd8W0e1rS59GfC5TIpmUWqw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR18MB5454 X-Proofpoint-ORIG-GUID: r9xyV_oX54z2d2GSQGpNsg38UgIdUF-o X-Proofpoint-GUID: r9xyV_oX54z2d2GSQGpNsg38UgIdUF-o X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.12.28.16 definitions=2024-05-23_09,2024-05-23_01,2024-05-17_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Zhangfei, Overall, a well written driver. Please see below comment. > +static int > +uadk_compress_pmd_config(struct rte_compressdev *dev, > + struct rte_compressdev_config *config) > +{ > + char mp_name[RTE_MEMPOOL_NAMESIZE]; > + struct uadk_compress_priv *priv; > + struct rte_mempool *mp; > + int ret; > + > + if (dev =3D=3D NULL || config =3D=3D NULL) > + return -EINVAL; > + > + snprintf(mp_name, RTE_MEMPOOL_NAMESIZE, > + "stream_mp_%u", dev->data->dev_id); > + priv =3D dev->data->dev_private; > + > + /* alloc resources */ > + ret =3D wd_comp_env_init(NULL); > + if (ret < 0) > + return -EINVAL; > + > + mp =3D priv->mp; > + if (mp =3D=3D NULL) { > + mp =3D rte_mempool_create(mp_name, > + config->max_nb_priv_xforms + > + config->max_nb_streams, > + sizeof(struct uadk_stream), > + 0, 0, NULL, NULL, NULL, > + NULL, config->socket_id, 0); > + if (mp =3D=3D NULL) { > + UADK_LOG(ERR, "Cannot create private xform pool on > socket %d\n", > + config->socket_id); > + ret =3D -ENOMEM; > + goto err_mempool; > + } > + priv->mp =3D mp; > + } Do you really need a mempool here? It is for uadk_stream which is just stru= ct of pointer and an enum. It can simply be rte_malloc.=20 And even you do not need uadk_compress_priv. This can be simplified. Right? Also remove the execution part of documentation from 1/3 and add it in 3/3 Since the PMD is complete in 3/3, release notes and execution part of docum= entation should be in last patch.