From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BB0CCA0542; Tue, 31 May 2022 13:47:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6FFCA400EF; Tue, 31 May 2022 13:47:08 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 29E37400D6 for ; Tue, 31 May 2022 13:47:07 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24VBDsJV014522; Tue, 31 May 2022 04:47:06 -0700 Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2177.outbound.protection.outlook.com [104.47.55.177]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3gbk8n91nk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 31 May 2022 04:47:06 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E27XP+o+jmKeMbaKhzylCBVCG/8piku6y7iwnIfTHWq4Veeqr3NemmpYztAkiChmS0Y7wGNj/QEz4QQcnm8TUDcgDmxziHwnkXG+XyIdfkUzKgWhQqBjo0BR4RQJPiF9hh2ZjLOz9UsVk1J0ao8EvhkvXv4q58G3aR2MpkRc9ZWb3a4H9YvYkAlyxDDcUrB7/cuKaUhK666ENFcqs9I9OEp5t0hnMLDASCSfF12q/STOVilH1Q74RjP22TMcAsk4T470e5Sy0nCP3Pro2HAO4P3he2Xv6RmZn9wbqM9D8B8SZfPYLrzEQOxtWhJdL5j6D9ihZXjlMO5/c0R0Jf9K0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s7DS/4qPosnmMG1e5tCOWK7kLAWy+TR7MXLxU0ICcNc=; b=RIcAeqw2dtMIPg6jraOo2bwMAI4cMh4TGukKgrxmTovoZm/bX+JSH0Tz5gFq5cuHpd2CzLTmNkTGXeg1pt1mKUyKIygiKwKffZCPW26xSOkKJ/8Y3VDutJG8Pdie2aLHRlIqfcXBD2FPdDlsqhQFNyjwtnfVdqJQqJrQpmIrVOKjZZfg4Cfzlvof4QnP64LhdRqIlhna3nRNBG7vX9/8WZanNk3LvYFZg9YcsEpTjdSP4zYFTJOIEjsCix6+/X1EDP8d8kXiRhEtXDsdV93Xbm6eiiO84wSbjA2Amd1V4yKbMg5OeH6O6apxHAUp4tr/U299tWGB+G+E4SXf0tfz9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s7DS/4qPosnmMG1e5tCOWK7kLAWy+TR7MXLxU0ICcNc=; b=GNKN5DQUR6C8a84cjGz3nefsQ1ej+oJbK1un2YMvUuOr09A7PWweiNfvdC+dTYMKyvnKSTRiA4QChrhmzjiIthXBHD2TP2yjUbAumxGRA+8PPns1xmfuLITJ29iBdDeK6QOO/BB/XfiiWBfnyAHsCRhkjSmFBBu6bkjKGHUr42Q= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by PH0PR18MB4428.namprd18.prod.outlook.com (2603:10b6:510:e1::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.12; Tue, 31 May 2022 11:47:03 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::f154:453d:893:f6ce]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::f154:453d:893:f6ce%9]) with mapi id 15.20.5314.012; Tue, 31 May 2022 11:47:03 +0000 From: Akhil Goyal To: Arek Kusztal , "dev@dpdk.org" CC: "roy.fan.zhang@intel.com" Subject: RE: [EXT] [PATCH v4 02/12] cryptodev: separate key exchange operation enum Thread-Topic: [EXT] [PATCH v4 02/12] cryptodev: separate key exchange operation enum Thread-Index: AQHYdK0O9KfTG1pWHka/BweqAhldwK043moQ Date: Tue, 31 May 2022 11:47:03 +0000 Message-ID: References: <20220531040439.15862-1-arkadiuszx.kusztal@intel.com> <20220531040439.15862-3-arkadiuszx.kusztal@intel.com> In-Reply-To: <20220531040439.15862-3-arkadiuszx.kusztal@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cf537763-e47f-4047-f796-08da42fb47bf x-ms-traffictypediagnostic: PH0PR18MB4428:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Q0aLs04RkT8OdpEv8BRdVcTaxn1AD0b5ulyHAkolKONivILQ1j3810KXTQjFGvhSTFoJvty0IgmmlgmksU8vHNOXAL1/73S7kr0FJIhQmVnGJfCmOKn1zSmvu9PQ7aScDPpMPM37RnOZddovRqaAW8QCkQGYSSbKKC8K9pqdoGKpf+wf8Q9mD0RBIiw3bE1ksBKlnWBEXg4uW9e5Sdyhq/Z5gYjMN3y8KzHCsHIiKls1F4V5EdNJqN+99w01EFBJ5RAfhCbAaekv4rJNAQ8LM29sGxDXIDMBNOMDRiNqOcHoN+7/wkb2nIMPWYh0WiXH3jM2H24Vvy39RzAHOPIxs5FgyOk7u2DTWN0QswWyLL90gaM53O415NHbuH9a4XDXtNmEJDKYzSYq03Qwrbs+K92mLlRalB331T2WeVJ3Uk0I2lNWfZ5ChOai42wIYkYvkldkk6cmWMSwjBQda0pdfXVbXaQYax4lys4bzoDzUeT7xXPDBEAQopDlVViFvJhE68RHEk39lAoXMOcMQ59EWTndehWOPSDPXqXASDMw+iPoVIjBhQZlL6DCfy/pnSEuA2dPWqzQNOlF1BYfbA27GH5JYT6gvKD7NTla9cZx8+B5Xv4ES92jCVWHFn0ilcv3DZEhjvAKqoaFbi9e4d9yVG7x38TlmzWIyd7GMZ3LKJb9CztGcojSS5cTuy5yGc6phxgs526/El3pYYAa3y6K3g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(55236004)(8936002)(52536014)(66476007)(66556008)(66946007)(76116006)(2906002)(110136005)(316002)(33656002)(64756008)(71200400001)(7696005)(5660300002)(8676002)(4326008)(66446008)(508600001)(6506007)(55016003)(26005)(122000001)(38070700005)(9686003)(38100700002)(86362001)(186003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ZEQR86/3zA9wSa/FhUHGI/dPvIy/vl5FOwmJgBGnvhYJm86iCY67j4QXpWb0?= =?us-ascii?Q?JdmB6O6KT++GxtcL1jqLvUzPDzRkyK5Vnk2bFB/SvrCSrumXqY3JO3lYVgjF?= =?us-ascii?Q?18ak+rrFN/2Ait46PYcPSbmmnPPcrjg2a5i2tRtisf6t24FerzhtU5dqDgi5?= =?us-ascii?Q?E600LKmkMfEpD5aUzdUa2VK+gz1Nm3f8yBfW5nAjBrgcgdeman529xmBsB0O?= =?us-ascii?Q?cLam4FSN3sb4yL+INAPzVTZvXXRwHzL86YdH0TiM5C0fOA6RWQAUcd6zT/GI?= =?us-ascii?Q?CHRTqn7suko1OvzfVQkdcUx8EHe7rrPAACHXK/5L6lFM+DPdZvIVKnM4nimr?= =?us-ascii?Q?Ti5kPDzfyykHs1oZvPC7qIP0bUwNnCdGPimnEfkrbKuzTPB5YbMgfuC8DNOj?= =?us-ascii?Q?ub3AxE+UsLZtJzYcXHj/nExfibr+AiWdZxlb7Q4RcD/RQUxlT+8PBGtnHX7R?= =?us-ascii?Q?dB3zv0I3jni2zczVX7cglm51tuNtWXowK/fZgnazsXVoM5nrZEJ8fV9PVE89?= =?us-ascii?Q?eUPUEKEw7pYUU8ZqkjyyH+0YDP0R26oPdPR/8lOIchzqx6oqKzSIncDSAHDt?= =?us-ascii?Q?sQOHFXfxNBHoIh6w24ZN79wIB4e1rZcLzEv6njEvPYVbrNgB+9Wg3nhuEHxs?= =?us-ascii?Q?7jirdEFhx6Br/Pu7hNetg2iGZxdegekFKk3j470AZ2nFeP8dA4ScIP2fXvQN?= =?us-ascii?Q?lZ+Lf+fSmwarCCyBl+w7+ARqXWfE48/VYeBZm1HwDco3UCcGkb13nfngwH8i?= =?us-ascii?Q?YZHxq/0g4vBi6r+5Wbg61xQBFVJmlY4OUxIds2gl+fypp/I9cbgdrz9D4p2V?= =?us-ascii?Q?JAcdRjB/DI6/7ZxmAIBmjuTch54fSPCUYlemWDHRzLacBVSHOMkBaTjmVimh?= =?us-ascii?Q?jrTj0LwVHXJOKwOOO/0f9Hr1/efjqADDXbgvUCmCwUdcO27LqjoOc6pzEQAf?= =?us-ascii?Q?gLRUHOc7F71gm/VWFkGTYHIO15dG7+xC4rgjVutYwdIGap5ZrRwt4M33TSNz?= =?us-ascii?Q?BKHO1ty6tYwIP677+haRt6bw4YVTIZI9BQTds5oPXbrAwA8CON01D6Yfti2L?= =?us-ascii?Q?eYey6jSW3VpS9We6X1ncHUYiRnx2Oe/5HjKtizk2nPmx6YrAUYZK7vM0KLgb?= =?us-ascii?Q?839WrVUXXquRH8LkeghJf/3LQFhz8gk2wmNUJlNmAhAuVxJCvXQwGGYApAyT?= =?us-ascii?Q?KHyYrFVkluzHWkK6X1jyPlmm4K0joliPB/a4n9sc550bLWTg0lKRGeuYV8vB?= =?us-ascii?Q?s57HfVA9b8M7hzQNg2y5INde9BHMwqg3vFJI5B5oOTDiUngE8aUO7IWQ4qVQ?= =?us-ascii?Q?jFp9RcYV+MrG6g+HwQNEKQvtS71MA0qrKK9zPXQfJ5a0yhtEnGPf6+s4Wiv1?= =?us-ascii?Q?8kOTL1HJPISs4tCgE5YV9+sNMJBeFcHGxBASz17KBRTsO2V7k8edJH5oF/1Y?= =?us-ascii?Q?unwZalNiybINKKw4cAdepjworP5AJmB3JT1+eM7QFyjmkwibhYsRS1QH2SAY?= =?us-ascii?Q?Rxaz8h/ND/Hdoti6Wb/BgK9piQaKnvAt4zZngXrHitfZke4VXn9w/ot4tYzA?= =?us-ascii?Q?0TopEZmhgvslpdbGorOGdE7Ehs4OSrwJElzLdUW5MNoKr67ri03KIeR9C5tO?= =?us-ascii?Q?VpaT+tGS/HqIN3I7MXyJvUNGgaTwFX7lytY9rB67JSnsSDQKvJKIpy++ILJs?= =?us-ascii?Q?mHFC+N/PlONDCFhjcB2JjktPlGjgn416gvkQXFOAn5qGJoNN07uaDMdKfDg7?= =?us-ascii?Q?WIxPtlZHzw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cf537763-e47f-4047-f796-08da42fb47bf X-MS-Exchange-CrossTenant-originalarrivaltime: 31 May 2022 11:47:03.3709 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: srwASTwjNvCgLcBmXAmCE86DoPGuOJmfg7ypi0dXIiG2cw2g0Oeh7fi0/ZbOaaHZT4PlkR3MEDW0klnhorbDFg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR18MB4428 X-Proofpoint-ORIG-GUID: yIUHkuq0ok63FAIHiuL7FxhUarkEogzW X-Proofpoint-GUID: yIUHkuq0ok63FAIHiuL7FxhUarkEogzW X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.517,FMLib:17.11.64.514 definitions=2022-05-31_04,2022-05-30_03,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > /** > diff --git a/lib/cryptodev/rte_cryptodev.h b/lib/cryptodev/rte_cryptodev.= h > index 2c2c2edeb7..7d683fd728 100644 > --- a/lib/cryptodev/rte_cryptodev.h > +++ b/lib/cryptodev/rte_cryptodev.h > @@ -168,7 +168,9 @@ struct rte_cryptodev_asymmetric_xform_capability { > /**< Transform type: RSA/MODEXP/DH/DSA/MODINV */ >=20 > uint32_t op_types; > - /**< bitmask for supported rte_crypto_asym_op_type */ > + /**< bitmask for supported rte_crypto_asym_op_type or > + * rte_crypto_asym_ke_type > + */ How is this supposed to work? Ke_type and op_type are 2 separate enums which can have same value. How will the user identify which one to use? Shouldn't we split this too? >=20 > __extension__ > union { > diff --git a/lib/cryptodev/version.map b/lib/cryptodev/version.map > index f0abfaa47d..dbf1f62199 100644 > --- a/lib/cryptodev/version.map > +++ b/lib/cryptodev/version.map > @@ -108,6 +108,7 @@ EXPERIMENTAL { >=20 > #added in 22.07 > rte_cryptodev_session_event_mdata_set; > + rte_crypto_asym_ke_strings; > }; >=20 > INTERNAL { > -- > 2.13.6