From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 84E70A0548; Wed, 25 May 2022 07:44:37 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 14E35400EF; Wed, 25 May 2022 07:44:36 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id A9819400D6 for ; Wed, 25 May 2022 07:44:34 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24OK8PuP020616; Tue, 24 May 2022 22:44:33 -0700 Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2170.outbound.protection.outlook.com [104.47.57.170]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3g93ty2axf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 24 May 2022 22:44:33 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B4+dnp85pW08ceSWpxtr5xg5dkhMmGaobxD/GV8QeKgkwP48ye2UTm0ax5DogOTM6HWUeWt7na8s8bBa0ZNa/r2koOH+AugDUwSQ5w+hsX/jjsQWZ8Jdy/FBNUNRADP7m4AL4MlzyCp4hAMrZCuMWT0pBLROyxYjBrU/rgN4w0rY1KCfUQlYVA5FDA2E59QOjpdGU9AOKWzUTG/o9Lybzq5TuCVSiM/iwyN1zeFveXeKTdqdgU8wD4TQbldW68xhV/WgnsdDwTWQzb3yLMe2iNUp8XBXX2SNge3eRRDMPyHidWq/yB+umhRx4xGRAefPi9P95PDisSDA7BecF1VKPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZopaFktwL5xLCKQ6uEbI5wX6LQ5/citBOmFr7c+lHuI=; b=X5ibcpPao9sdwLffOLILJEnG3NeSSd+XgzOC90IAUuNSO7u7AY7xO/QIVGBgAf8MTRG3oREEQTBzCBEzAnmfwHlnf/74EBGjwZMfkuLNG5w1wZSEqbSjLJ7Lzez2+KKrkEyMsGtfnA12mi0f9l5s47b1gwtv7M/azo31maKXsDjwVPzlcs6okidqi82CnNaFd6zQqMuft/tQ5gfLbQfQ27AQwOTLtsTIH56uh85kMTd/i6T5c9a26YCVbFE1i/4hB8DTMDAITzaFSYTxGQE6zprxJ4i8uzNgraIN5dsK3Xw0Sps8wtwfeWriYQf9aCnvm6+mCwiNuqqC0oK1h42zQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZopaFktwL5xLCKQ6uEbI5wX6LQ5/citBOmFr7c+lHuI=; b=MPIze4/0ovYQmbFPql+0YH2n036gMHeHLilUXJu0wRi0pJED7eMVVpYYFwpLKFfSLhhTXMxa3XVpnEQebcmycap/P0yWDFPx+hXnh+D0ed2L1Jysac4uaRzD+U3hw78nVCcMv4k++orD7gJV0xPIxKiftQkKZl45Yfug6L2zfuY= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by CY4PR18MB1399.namprd18.prod.outlook.com (2603:10b6:903:109::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Wed, 25 May 2022 05:44:31 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::f154:453d:893:f6ce]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::f154:453d:893:f6ce%7]) with mapi id 15.20.5293.013; Wed, 25 May 2022 05:44:31 +0000 From: Akhil Goyal To: "Kusztal, ArkadiuszX" , "dev@dpdk.org" CC: Anoob Joseph , "Zhang, Roy Fan" Subject: RE: [EXT] [PATCH 04/40] cryptodev: reduce number of comments in asym xform Thread-Topic: [EXT] [PATCH 04/40] cryptodev: reduce number of comments in asym xform Thread-Index: AQHYbBedXEj7gm1AOEag2xuKTQZQZq0t3BZQgAB1uQCAAMn44A== Date: Wed, 25 May 2022 05:44:31 +0000 Message-ID: References: <20220520055445.40063-1-arkadiuszx.kusztal@intel.com> <20220520055445.40063-5-arkadiuszx.kusztal@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8011f2ac-7562-4e5e-27b5-08da3e11a411 x-ms-traffictypediagnostic: CY4PR18MB1399:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rR4MrE+IvqldE656sk0wKfqpX00BwakwV51hWEx8fivy4LhwoE/xj3cEw8Laa7Rn27NNM0gXqn/dJ9GCeMEobZDRVe58PjxhHCsoPJ+GwFPVqiCh6pRfpr0OGoEQRXADmVnnNpQfmKj7wbmF6LsUoTLU5RCqC2y1oUb80fBdZ3OnRIGxJAgneTGwNxq7CUsMXtJPgWoCFWAbRCpqg2AfsE9jdvsZAdedwm9SXIRJgx0xmIVxtTi7P+ftYS2Cdw3nHWtEGwzf+45YrVzi61pr4OuuBHEaR0dqBZqGjjNDGxinpA7icGtcOSPrVgVjf4QPAKEksoDRw59B+bOP1ApcTeKhoj5mTyr3Wxyqn8Ug5Jh5sypaetFZ4lWE0mnDEppuRQEcxc9RAzUwvUz3UFPDQjvJpNtBXWH22DouI1qAiA4WlSjtuWVoY2DJ23NGpkqp/2TE3IytQXzottHqlnCxm+W76NS64Xq9pTS2EObOyjORjVmi84qNW5tmKZ8qT0ZMzwcsNfMb29EfAFHf9pLm0QNRE/4id3D2DlqWIMi0bUMspkWF6DEzoe8ZoOUBDNHxv+w/E+ZOF4gZnOYD+TbySJfGtBjtfOnFAquEN+xz6BDLK84+9vMjMZrrQ4zWNAJRq5v6O+0vkYQDjvja6UemT9eR3ILFpimJzbvdTEm+Jqt3Y5LjO4+SUyKjS3Wy/BWTbW87ds01epa71/zQsxVb/g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(54906003)(110136005)(186003)(2906002)(33656002)(7696005)(8936002)(55016003)(316002)(38100700002)(83380400001)(66946007)(26005)(66446008)(66556008)(66476007)(9686003)(71200400001)(4326008)(76116006)(5660300002)(64756008)(8676002)(38070700005)(55236004)(6506007)(122000001)(86362001)(52536014)(508600001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bYN99dT6oICG61qRmBhHYjp62c9gnCXBNPtKr5DfqxKAABeBe0V1SdLBSX/V?= =?us-ascii?Q?nHSwjukiehvm/GUyONzFFH97Kd/1DrkV/bqnP5Vu7v8VxGC+zKM72+dM6pHE?= =?us-ascii?Q?Lg+EZRkJm4ruDrGPq7vgTgOQl9OZhTtr7QSit9MFBOuKNxFwzALQMFJRi/21?= =?us-ascii?Q?dhIGasu1Hg2Tc/dvace0xuA4s+9pLI2f0LTmnKTXVR55PQx4URYlMdWWY1Pw?= =?us-ascii?Q?pt0I04N1pbsnQRk3gQQ5ZKihEj+OYAAtQYWD7KzLAj/jkVw28HDWCN7anetd?= =?us-ascii?Q?hmTG/SiqJMqPwygtA2xD7DCe7HICXa0QglrCXQJeEvkNXB81M0v+Gx/drT2X?= =?us-ascii?Q?m23gVTti3rkc8uzj6a14zTsB1X9mKXI5gc9EDAWEfqmmQvdbJgZO3ZXkbBJi?= =?us-ascii?Q?LWk3oAXn5eAWu1/tfvo25OhgpvEOiPWbOeZHW80xed82tp1jnHusKmG//F40?= =?us-ascii?Q?dKtiOb2yFQZsHT58nh/DlNZIXQlfPGitWQ+C5HaTYtVIjwL+I+SWCGoMzs7h?= =?us-ascii?Q?jjQo40WI6CDuJ4zcyO/X8OWBBnxJOtmPNdLE3TevZYt79Zp0chi/mX/3wNRI?= =?us-ascii?Q?eRJtAjqaF8ebyEf1kDgyqTlc7mUzJB85AOR5gq1MaG4bffP9bAgYkxDcxleD?= =?us-ascii?Q?XEQ7/QMd8kHoOyhc0kgJlEuQQFL6GRNa9OmGXIZ8RTWcdOoIGzw5hcW0YDF5?= =?us-ascii?Q?VTkohYzLlLrex8xCfYG5zh6NBlH9T8YYzmCiH1NHE7uzcKkqJj3zDnmMxSTt?= =?us-ascii?Q?cCgNeSO2sgC/6Be4hshInfn4XFJYS2W4kaG5lpJcOjUB39Axmbh8YMwTr1tm?= =?us-ascii?Q?isJV7f6+bcZsX6CMLf437pv6TIMUXSyD+xaTssTAEyz1fy8y/Zhps0S8f1iT?= =?us-ascii?Q?jc4XgeKhV24gJfLCvZXhGkHLVLtyBFjbcheBSkMzgQNNzaCr9Xg1pA37ucZT?= =?us-ascii?Q?nqCUq9IqrVsWCeQKQWHsAjG7z2ntPt7BeyPXT9Ppkfc3tcibwTeBEAIPXZtK?= =?us-ascii?Q?V2jKlImVydAe26rNbyMizydmE9fljVvaBrsKilKOwdOsW3OXRwyFpn0Cl3eg?= =?us-ascii?Q?qULZTEvxtfBsYVE9POYEd0GPnsd80F7+enlSlGHwRKbH0n1VlVKN191CgSav?= =?us-ascii?Q?sh+pqrIm78f0vno6dwiCtyAcn8Q+Bk6AtoNxmM7w1hgVRdZbtFEJbY5MOrek?= =?us-ascii?Q?ePm5PNDcAI53gHqT5zyKWJ5G4UJg5fSGFlS9lWR+kK5MufXWGvuxYC5WvjFc?= =?us-ascii?Q?NRDXjuFj0u0BiVCjzwzRymP/RFwAOLwlKcTJYegeB/whwTDMPK8Hd/dnw42x?= =?us-ascii?Q?70Ed6EysswzWXvxMxHrQa1Jr7tnVtEWUKrVJC1yuaZMJ1dE3kQ4DBkx/841o?= =?us-ascii?Q?lkFMcQ9Pn6iOKPjPG0NCpLRYSj54GY4Tx+0pa5OPooKolnY+XfFLE/bZnwaZ?= =?us-ascii?Q?NxHbo258VKEtIce028iiITM+N410sOkit13D5PTm8ZDkV5P9bhzrSveJA10F?= =?us-ascii?Q?pC8d4FwLknE+FP1auyT7LiXR4hWaJNI8asnoQ3Miu5tEt2Ltd2pbiTO8mkCM?= =?us-ascii?Q?nVYd45VLVwu2Bo3CUbg2MyPbsKLRv8ibkDRouJmrqN3L43K0d86GD1TPkSGI?= =?us-ascii?Q?qQBT9ZodqDRPMohfifUbg1XOuHHAJNYyByRub7463Fecki7CAaip0yNOSU/1?= =?us-ascii?Q?T1XC/egvtiAjD9H1b9BpBG41gCP9hqtWyAdpSf80sAHKt69fqFBDxEVyHA28?= =?us-ascii?Q?NgDIc0RnhA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8011f2ac-7562-4e5e-27b5-08da3e11a411 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 May 2022 05:44:31.3831 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4mTYmSU3bAC4HMgMBRlr3+N5oZqdRvEBb22wIu5NrP6+mWzRN8fufYUuoudaOuTV3asgMgsbSuMA2Ox4uNn0fQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR18MB1399 X-Proofpoint-GUID: 40yS5pqAoViien6rg7SPdHEgM7R286ag X-Proofpoint-ORIG-GUID: 40yS5pqAoViien6rg7SPdHEgM7R286ag X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-25_01,2022-05-23_01,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > > - Reduced number of comments in asymmetric xform. > > > Information describing basic functionality of well known algorithms > > > are unnecessary. > > > - Added information about data memory lifetime. > > > It was specified how user should work with private data, and it is > > > user's responsability to clear it. > > > - Removed NONE asymetric xform. > > > > > > Signed-off-by: Arek Kusztal > > > --- > > > lib/cryptodev/rte_crypto_asym.h | 45 +++++++++++++------------------= -------- > -- > > > lib/cryptodev/rte_cryptodev.c | 1 - > > > 2 files changed, 14 insertions(+), 32 deletions(-) > > > > > > diff --git a/lib/cryptodev/rte_crypto_asym.h > > > b/lib/cryptodev/rte_crypto_asym.h index a474b6acd1..0251e8caae 100644 > > > --- a/lib/cryptodev/rte_crypto_asym.h > > > +++ b/lib/cryptodev/rte_crypto_asym.h > > > @@ -55,46 +55,29 @@ enum rte_crypto_curve_id { }; > > > > > > /** > > > - * Asymmetric crypto transformation types. > > > - * Each xform type maps to one asymmetric algorithm > > > - * performing specific operation > > > - * > > > + * Asymmetric crypto algorithm static data. > > > + * Data that may be used more than once (e.g. RSA private key). > > > + * It is the USER responsibility to keep track of private data memor= y > > > + * lifetime and security of the this data in xform. The same way > > > + * it is the USER responsibility to call cryptodev session_clear() > > > + * function if a session was created. If session-less not used > > > + * xform data should be cleared after successful session creation. > > > */ > > > enum rte_crypto_asym_xform_type { > > > - RTE_CRYPTO_ASYM_XFORM_UNSPECIFIED =3D 0, > > > + RTE_CRYPTO_ASYM_XFORM_UNSPECIFIED, > > > /**< Invalid xform. */ > > > - RTE_CRYPTO_ASYM_XFORM_NONE, > > > - /**< Xform type None. > > > - * May be supported by PMD to support > > > - * passthrough op for debugging purpose. > > > - * if xform_type none , op_type is disregarded. > > > - */ > > I believe removing this is not a good idea. As stated, it will help in = Debugging. > > > > > RTE_CRYPTO_ASYM_XFORM_RSA, > > > - /**< RSA. Performs Encrypt, Decrypt, Sign and Verify. > > > - * Refer to rte_crypto_asym_op_type > > > - */ > > > + /**< RSA */ > > > RTE_CRYPTO_ASYM_XFORM_DH, > > > - /**< Diffie-Hellman. > > > - * Performs Key Generate and Shared Secret Compute. > > > - * Refer to rte_crypto_asym_op_type > > > - */ > > > + /**< Diffie-Hellman */ > > > RTE_CRYPTO_ASYM_XFORM_DSA, > > > - /**< Digital Signature Algorithm > > > - * Performs Signature Generation and Verification. > > > - * Refer to rte_crypto_asym_op_type > > > - */ > > > + /**< Digital Signature Algorithm */ > > > RTE_CRYPTO_ASYM_XFORM_MODINV, > > > - /**< Modular Multiplicative Inverse > > > - * Perform Modular Multiplicative Inverse b^(-1) mod n > > > - */ > > > + /**< Modular Multiplicative Inverse */ > > > RTE_CRYPTO_ASYM_XFORM_MODEX, > > > - /**< Modular Exponentiation > > > - * Perform Modular Exponentiation b^e mod n > > > - */ > > > + /**< Modular Exponentiation */ > > > RTE_CRYPTO_ASYM_XFORM_ECDSA, > > > - /**< Elliptic Curve Digital Signature Algorithm > > > - * Perform Signature Generation and Verification. > > > - */ > > > + /**< Elliptic Curve Digital Signature Algorithm */ > > > RTE_CRYPTO_ASYM_XFORM_ECPM > [Arek] - maybe this is not that important but could not we have asym_algo= rithm > instead of xform_type? There is not ECDSA/ECPM xform at all. Converting everything to asym algo may not be good. As they have different = xforms And different type of operations. May be we could split into xform type and algo similar to symmetric crypto? > > > /**< Elliptic Curve Point Multiplication */ }; diff --git > > > a/lib/cryptodev/rte_cryptodev.c b/lib/cryptodev/rte_cryptodev.c index > > > e16e6802aa..691625bd04 100644 > > > --- a/lib/cryptodev/rte_cryptodev.c > > > +++ b/lib/cryptodev/rte_cryptodev.c > > > @@ -160,7 +160,6 @@ rte_crypto_aead_operation_strings[] =3D { > > > * Asymmetric crypto transform operation strings identifiers. > > > */ > > > const char *rte_crypto_asym_xform_strings[] =3D { > > > - [RTE_CRYPTO_ASYM_XFORM_NONE] =3D "none", > > > [RTE_CRYPTO_ASYM_XFORM_RSA] =3D "rsa", > > > [RTE_CRYPTO_ASYM_XFORM_MODEX] =3D "modexp", > > > [RTE_CRYPTO_ASYM_XFORM_MODINV] =3D "modinv", > > > -- > > > 2.13.6