From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D073DA0C55; Mon, 6 Sep 2021 20:29:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 98FD9410EF; Mon, 6 Sep 2021 20:29:12 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 10572410ED for ; Mon, 6 Sep 2021 20:29:10 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 186E6MIw022984; Mon, 6 Sep 2021 11:29:04 -0700 Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2100.outbound.protection.outlook.com [104.47.58.100]) by mx0a-0016f401.pphosted.com with ESMTP id 3aw9d2twqs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Sep 2021 11:29:04 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cMgtAQY7QSYTkHNxsxCxethKG8JbDYOA6gwH3TcpfujDZvIqMxVjbm5HQ9ZMKEH6x4/q0gWfksEtAdt4SNyyc+fNWXEI2lVPSsLjr3mPFTVajdXtOSEZbtUyN4camhFYfID5ZxHWgdlUmZNW6S4BlbezTa3UvOdfVi6hFYXrENHdgZk/51uPVh5MGO4OerVAZal7ppBO9CAO72zS6H25IjAwYon/icyTdFu0Vzsd715NIkONOuo4ktWI9kvWAYLs0H2ImG70m1SZe/BdlVwOW+DRMXRc+qwN7DU4c1IowS29yOGrJ+XGX/UbDNLjTtXdHLbqvH7+A86VKOUWxY8+uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=fu+41dokJmW6tGeioRbZ6ybUW9K1OFmisu9SHUYl3eE=; b=S674MjBGSAniJreXGJ0T23bDstpdofP4cov8Ar0RM6WEK6Y1f5Gjn0qwqObMS5EbF1uri5836D3I5cI7TZajFRiZRmUQob0DMYn8MqaqwIXGzsatj+ednNCtzmMw3LGhNNrp6ptIUBT73fTE+LplVUbU+KQWlouO7tM9rVx0cVWakM9SMTdD4Df2Y4JyCZTc1XsjemxOH58QQ/U86acZwr6NM+MU5I9eASGvUjoSFZk1oWAC9AcsR+tKnvnS1uVSWeNdVcf0/obb1RwkYWGaB3ehZvqpgmI+IdRIO5ldz3T+k7f/h3uBOoNcgL1zZyXYrTM5v0vTGaZuLbNnxQOfeg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fu+41dokJmW6tGeioRbZ6ybUW9K1OFmisu9SHUYl3eE=; b=hZNoLD1RZXPm9o1EhXMFluX34CQBPNsEzWwFiiqfON/iV4pGfzHXs7O7sI7unQbK7zrLTBAK/YiTIf/6h+HS8DsibLUa1xa7EJ+Yht5SwXZzH81T7joUfw1qBcVKb1AUIcC+TpMk42X7OcStRUKebM4g/lBlZ42sJ3JC2DpwDUQ= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by CO1PR18MB4633.namprd18.prod.outlook.com (2603:10b6:303:e0::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Mon, 6 Sep 2021 18:29:01 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::411f:5b87:321e:de29]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::411f:5b87:321e:de29%3]) with mapi id 15.20.4478.025; Mon, 6 Sep 2021 18:29:01 +0000 From: Akhil Goyal To: "dev@dpdk.org" , "roy.fan.zhang@intel.com" , "hemant.agrawal@nxp.com" , "konstantin.ananyev@intel.com" , "ruifeng.wang@arm.com" , "matan@nvidia.com" , "pablo.de.lara.guarch@intel.com" CC: Anoob Joseph , "radu.nicolau@intel.com" , "declan.doherty@intel.com" , "thomas@monjalon.net" , "asomalap@amd.com" , "ajit.khaparde@broadcom.com" , "fiona.trahe@intel.com" , Ankur Dwivedi , Michael Shamis , Nagadheeraj Rottela , "jianjay.zhou@huawei.com" , Jerin Jacob Kollanukkaran , Akhil Goyal Thread-Topic: [PATCH 0/8] cryptodev: hide internal strutures Thread-Index: AQHXnNSjcZo5epTmRkGIS+5bWZX+cKuXX3ng Date: Mon, 6 Sep 2021 18:29:01 +0000 Message-ID: References: <20210829125139.2173235-1-gakhil@marvell.com> In-Reply-To: <20210829125139.2173235-1-gakhil@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=marvell.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 60fe5b56-fa19-4f5f-0435-08d9716432cf x-ms-traffictypediagnostic: CO1PR18MB4633: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: XEYc1Z0kVZapH2giueEYQs3dWNB0y1+/cBFGnWqKL81xhXY2wpNDhC/853UA7wwN2dzDAwfPZb4IuALXTtrMjChPhfp+8sHGPwsD+xwDQMY7r7XCm3KFij5m8cked/NvOR7tyUhQFwbaDJ89ShoP59CQRPpQY9F/R0Dl+/jxCSlrK6QUCcVF2XLihMEvQ6qphLa+2iQA0OjjSB7YVyxMOuP8gGEVm1p5nyR7eOa+/YGcAzqjz5oLAWxbN5fnQvpoNnCCLQlw6Zy/GFTwC+nypoWyWncD5o2pdMQwDYeWMyzawYjr2KaDGAfhuNXpSUBQXCleNNrN3knDvd3OEZ+xhUkW7HV1GxyIM/lrK9jX7dQcDO6/4TG+VTkwtkCdAByb3sWIwQtmzGtjKba/l138nzkASvIjsdoeEjt/13tEiyi1MLC0nxnm+zKjT9nRQy46Rr41eOegpE4aOYo6nFAhxgCkOuCa3K7l5jyEgx7DqoCAUqOCDT4/bfT+M7N7hZxKkXYmq3Ybn8jm3RL/bXxcCrvTBZ4bZs7ibUFDMa4GWyvKuMaIRcxTtlN0ZM4ZX03E2DkAXI7ZxejmUvmipR4IEShRdUR29g+zCocr4OYeK3E08PAZWtwQrmuaQLksOnLHZImJEGiejXCvv2iUscbdlIYEuIL5lb0YWmKRfrSOYXbfnejhtlHJY/z3TvG/bPsx+sN8u37duySJUipWSRlfG4NZBl76nGfNhtYRNTOBUCFmjkLR/EPy3cc3yV7edhvyHqLtXaiXvvDqyZ9oWZfCR9zm5ljXxSZnwu6hLLEni8eCAsbgg13k96US5FMq6w38OwqL/ZW6W1aH2APRaVIMoQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(366004)(39860400002)(376002)(136003)(396003)(38070700005)(33656002)(966005)(83380400001)(316002)(71200400001)(54906003)(55016002)(7416002)(55236004)(478600001)(9686003)(8936002)(8676002)(4326008)(110136005)(122000001)(38100700002)(107886003)(66556008)(66476007)(64756008)(66446008)(86362001)(2906002)(66946007)(76116006)(52536014)(5660300002)(186003)(26005)(7696005)(53546011)(6506007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?IflSGZgMduouqyXf2QcUwSjB1JG6uBSILjuMEXMbiT2OnWsgyIR0aQWfeHfn?= =?us-ascii?Q?P4S5dyHqOZ9OtGHnsklF4Oos0xzhHmHFsHv3Ss4XmJ4v8wmxk0ap4j8qZd7D?= =?us-ascii?Q?ae+cOVqTx4T73VPqanV2Oj4wMCWQHr2DK8M0FE14QYiWJedtC3Eif6yVsxRI?= =?us-ascii?Q?siHeEFbw9/HYhCewKDvTET8DwApCD6wi7oLq6y7sHoR4ti/JQnYfWw1V1cpR?= =?us-ascii?Q?9WDNNbOIcDFF0P267cCm2BerdmdyI1JBybFy0jC4z1YKYY6pGFJ0r5hoBj4R?= =?us-ascii?Q?pN2qBGakVkte0hUr/EzHQ5YUYoLpIc6HJkxvNlnXddiic1tR+VyZ1uWE3nUc?= =?us-ascii?Q?4pwF4PE3A3MkUY5L/379cf9B8OHmN3TwZjO7UvQUTqq4Sv+Rk3ENcCAeok+y?= =?us-ascii?Q?k0/Bcr7aqZwFo8w69NXlXnW8Vn4oJnC66DETtpy+H/4Whm9uu9hpDCPEfpqX?= =?us-ascii?Q?TyHqVEtHK3Ey5i8GtrIlDCZBW9dnMbikZVpe/20O3UteaXMul8InTQcp1n0B?= =?us-ascii?Q?2rzq75nu703k1f/nGOFurKX2Te3cmCTKG7RgE8PkcmqZxVfXv+yYYOB8ZoUS?= =?us-ascii?Q?b4OvU3PsoA80o+drwAwdYNVhTi5bgYF+spmPk258SGwLELQCmUAVb9xMjbei?= =?us-ascii?Q?Dx/+IrDxLMX+YfuH7QSdOjykVbBw468LHY0jqo/hM9U66bMIwzfhh3SSSbaJ?= =?us-ascii?Q?hj7Gm2nNq7HCtpNdEzvLNpcGyl5GEdZajQ9ZBnz2SFE14rBNzU7zxVp7rYw8?= =?us-ascii?Q?DFDsOW6KrUtfXpq74EIMWcZS7BTanRwj6fbTusWJ6YEJL+ohIh48faEjGZpl?= =?us-ascii?Q?WwykfKsYB4SP1qh9pvpf87z/nzkRQgnHXCwxn0WyGReHvm5Sh38jxoZPId8/?= =?us-ascii?Q?GExgKZaG300FYqV4RgjKsi4sMRv9TmfEdWx7zDEsZ3P9OOPbQa9g7s9kD4zA?= =?us-ascii?Q?LLmLmCDuImvGrpB/fFbWyzbHWi1a3CzgpJuzOLZXC5qTETx9qCUL5bV0LO83?= =?us-ascii?Q?iZtfNI4XIA4pZIKnIrrnBdWImLKIkkLoTkqepr60x9OEzgGQcByIYFwEDcL2?= =?us-ascii?Q?PFXS8Nxw0LwGq0dawMDUuCZDnfEHDyu8hErvyhSoBQ/eJWiI8iwn3izXgc+L?= =?us-ascii?Q?JmFxyvDNlzs5B42SWpKII3kx8yTa8xnMeheTHczOxIeauBtC5UcYkKkgNlQB?= =?us-ascii?Q?+eWSwMFoGigROmiY9fYDktzxo3x38zTArMLcer7J4XqjyKuk2YEvRsQsgagO?= =?us-ascii?Q?34GQHGFupqZKltfEQ/BKcKMnAWTESk/SQ7hAPdGok7A6CumRu4n3YFlLl6lt?= =?us-ascii?Q?JhfAGX9de7qMr5WmRp1A8hqc?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 60fe5b56-fa19-4f5f-0435-08d9716432cf X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Sep 2021 18:29:01.0880 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HKNqqC5GJzvsnFbzQ38yF9ByxO9yzxn4SuzNn73nS3tm0zh42rRXrLB3OFY9bg2BuJY75Uc3artFB0NwpJSJzQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR18MB4633 X-Proofpoint-GUID: VA3SlKwMwKUb_NpyVf6q_bMzFleFMiOp X-Proofpoint-ORIG-GUID: VA3SlKwMwKUb_NpyVf6q_bMzFleFMiOp X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-09-06_08,2021-09-03_01,2020-04-07_01 Subject: Re: [dpdk-dev] [PATCH 0/8] cryptodev: hide internal strutures X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi All, Please review this series as soon as possible. Would like to merge this series as early as possible so that we have Lesser conflicts for other series. Thanks and Regards, Akhil > -----Original Message----- > From: Akhil Goyal > Sent: Sunday, August 29, 2021 6:22 PM > To: dev@dpdk.org > Cc: Anoob Joseph ; radu.nicolau@intel.com; > declan.doherty@intel.com; hemant.agrawal@nxp.com; matan@nvidia.com; > konstantin.ananyev@intel.com; thomas@monjalon.net; > roy.fan.zhang@intel.com; asomalap@amd.com; ruifeng.wang@arm.com; > ajit.khaparde@broadcom.com; pablo.de.lara.guarch@intel.com; > fiona.trahe@intel.com; Ankur Dwivedi ; Michael > Shamis ; Nagadheeraj Rottela > ; jianjay.zhou@huawei.com; Jerin Jacob > Kollanukkaran ; Akhil Goyal > Subject: [PATCH 0/8] cryptodev: hide internal strutures >=20 > Structures rte_cryptodev and rte_cryptodev_data are not > supposed to be directly used by the application. These > are made public as they are used by inline datapath > public APIs. > This patchset, creates a new rte_cryptodev_core.h file > which helps in defining a data structure to hold datapath > APIs in a flat array based on the device identifier which > is filled by the PMD. > The patchset updates all crypto PMDs to use the new > framework and hence the internal structs are made hidden. >=20 > Similar series for ethdev and eventdev are also floated on ML. > http://patches.dpdk.org/project/dpdk/list/?series=3D18382 > http://patches.dpdk.org/project/dpdk/list/?series=3D18422 >=20 >=20 > Akhil Goyal (8): > cryptodev: separate out internal structures > cryptodev: move inline APIs into separate structure > cryptodev: add helper functions for new datapath interface > cryptodev: use new API for datapath functions > drivers/crypto: use new framework for datapath > crypto/scheduler: rename enq-deq functions > crypto/scheduler: update for new datapath framework > cryptodev: move device specific structures >=20 > drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 10 +- > drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 11 +- > drivers/crypto/armv8/rte_armv8_pmd.c | 11 +- > drivers/crypto/bcmfs/bcmfs_sym_pmd.c | 11 +- > drivers/crypto/caam_jr/caam_jr.c | 11 +- > drivers/crypto/ccp/ccp_dev.c | 1 + > drivers/crypto/ccp/rte_ccp_pmd.c | 11 +- > drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 8 +- > drivers/crypto/cnxk/cn10k_cryptodev_ops.h | 3 + > drivers/crypto/cnxk/cn10k_ipsec.c | 1 + > drivers/crypto/cnxk/cn9k_cryptodev_ops.c | 9 +- > drivers/crypto/cnxk/cn9k_cryptodev_ops.h | 3 + > .../crypto/cnxk/cnxk_cryptodev_capabilities.c | 1 + > drivers/crypto/cnxk/cnxk_cryptodev_sec.c | 1 + > drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 12 +- > drivers/crypto/dpaa_sec/dpaa_sec.c | 11 +- > drivers/crypto/kasumi/rte_kasumi_pmd.c | 11 +- > drivers/crypto/mlx5/mlx5_crypto.c | 11 +- > drivers/crypto/mvsam/rte_mrvl_pmd.c | 11 +- > drivers/crypto/nitrox/nitrox_sym.c | 11 +- > drivers/crypto/nitrox/nitrox_sym_reqmgr.c | 1 + > drivers/crypto/null/null_crypto_pmd.c | 11 +- > .../crypto/octeontx/otx_cryptodev_hw_access.c | 1 + > drivers/crypto/octeontx/otx_cryptodev_ops.c | 16 +- > drivers/crypto/octeontx/otx_cryptodev_ops.h | 5 + > .../crypto/octeontx2/otx2_cryptodev_mbox.c | 1 + > drivers/crypto/octeontx2/otx2_cryptodev_ops.c | 11 +- > drivers/crypto/openssl/rte_openssl_pmd.c | 11 +- > drivers/crypto/qat/qat_asym_pmd.c | 11 +- > drivers/crypto/qat/qat_sym_pmd.c | 10 +- > drivers/crypto/scheduler/scheduler_failover.c | 35 +- > .../crypto/scheduler/scheduler_multicore.c | 32 +- > .../scheduler/scheduler_pkt_size_distr.c | 34 +- > .../crypto/scheduler/scheduler_roundrobin.c | 34 +- > drivers/crypto/snow3g/rte_snow3g_pmd.c | 11 +- > drivers/crypto/virtio/virtio_cryptodev.c | 10 +- > drivers/crypto/virtio/virtio_cryptodev.h | 2 + > drivers/crypto/virtio/virtio_rxtx.c | 2 + > drivers/crypto/zuc/rte_zuc_pmd.c | 11 +- > lib/cryptodev/cryptodev_pmd.c | 33 ++ > lib/cryptodev/cryptodev_pmd.h | 323 +++++++++++++++++- > lib/cryptodev/meson.build | 4 +- > lib/cryptodev/rte_cryptodev.c | 43 ++- > lib/cryptodev/rte_cryptodev.h | 308 +++++------------ > lib/cryptodev/rte_cryptodev_core.h | 43 +++ > lib/cryptodev/version.map | 8 + > 46 files changed, 854 insertions(+), 316 deletions(-) > create mode 100644 lib/cryptodev/rte_cryptodev_core.h >=20 > -- > 2.25.1